woocommerce/woocommerce-android / .agents/skills/review
review
VerifiedReview code changes against project architecture, style, and conventions
Review Changes
Review the current changes against the project's conventions and architecture rules.
Load the appropriate docs based on which code area is being reviewed:
- Store code:
@docs/store-compose.md,@docs/store-viewmodel-patterns.md,@docs/store-tracking-events.md,@docs/store-testing.md - POS code:
@docs/pos-architecture.md,@docs/pos-tracking-events.md,@docs/pos-testing.md - Shared:
@docs/coding-style.md
Steps
-
Determine the diff to review. First check
git diff trunk...HEADfor branch changes (most common: pre-PR review). If empty, fall back togit diff --cachedfor staged changes, thengit difffor unstaged changes. -
Determine if the code is POS or store. POS:
ui/woopos/,WooPos*prefix. Everything else: store management. Read the relevant docs above. -
Read the changed files in full to understand context, not just the diff hunks.
-
Check against each category below. Only report actual issues found — do not report categories with no issues.
Architecture
- POS: ViewModels extend
ViewModel(), use parent-child SharedFlow event bus, pure Compose, Compose Navigation - Store: ViewModels extend
ScopedViewModel, usetriggerEvent()/MultiLiveEvent, Compose inside Fragments, XML nav graphs - Both:
@HiltViewModel+@Inject constructor, data flows through repositories, ViewModels never access Room/network directly
Kotlin Style
- Max 120 character line length (test names excepted)
- No wildcard imports, no
FIXME(useTODO), no!!force unwraps - Constants:
UPPER_SNAKE_CASE, companion objects at bottom
Jetpack Compose
- Check against patterns in
docs/store-compose.md(store) ordocs/pos-architecture.md(POS)
Testing
- Store:
BaseUnitTest,testBlocking,captureValues, AssertJ - POS:
WooPosCoroutineTestRule,runTest,advanceUntilIdle, AssertJ
Analytics
- Store:
AnalyticsEventenum,AnalyticsTrackerWrapper - POS:
WooPosAnalyticsEventsealed class,WooPosAnalyticsTracker
Output Format
## Blockers
- [file:line] Description of blocking issue
## Suggestions
- [file:line] Description of improvement suggestion
## Positives
- Description of what was done well
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |