Skip to content

supercheck-io/supercheck / .agents/skills/code-review

supercheck-code-review

Verified

Review Supercheck staged, unstaged, commit, branch, or pull-request changes for correctness, regressions, security, tenancy, architecture, tests, docs, licensing, and commit/merge/release readiness.

Supercheck code review

Use every domain skill touched by the diff. Review is read-only unless the user also asks to fix findings.

Establish scope

  • Identify repositories, branch/base, commits, staged/unstaged/untracked files, submodules, generated outputs, and existing unrelated changes.
  • Review the effective combined change, not only staged or unstaged fragments when both exist.
  • Classify each file as architecture/data, auth/security, API/action, UI/hooks, execution/worker, monitoring, storage, SRE, deployment, testing/docs, CLI, recorder, billing, or another integration.

Trace behavior

For each changed contract, follow:

flowchart LR
  CALLER[Caller/user input] --> TRUST[Auth and validation]
  TRUST --> LOGIC[Business logic]
  LOGIC --> STATE[DB, cache, queue, object, provider]
  STATE --> CONSUMER[Worker/UI/CLI/integration]
  CONSUMER --> TEST[Tests and docs]
  • A diff that looks correct locally can still break a caller, worker, old deployment, CLI, extension, migration, or retry path.
  • Treat reported findings as hypotheses. Confirm through current source, call paths, tests, and runtime contracts before recommending changes.
  • Do not convert intentional hardening into a finding merely because it is stricter than generic guidance.

Critical review areas

  • Authentication mechanism and exact RBAC resource/action for cookie, bearer, trigger, admin, and public routes.
  • Organization/project ownership on reads, writes, joins, cache keys, streams, objects, queue jobs, and provider identities.
  • Zod/input bounds, uploads, HTML/browser messages, SSRF/redirect/DNS behavior, webhook signatures, and output allowlists.
  • Secret encryption/redaction and absence from client data, config, queues, logs, errors, model prompts, and artifacts.
  • Migration existing-data safety, constraints/indexes, lock duration, destructive operations, rollback/recovery, and version skew.
  • Queue payload parity, atomic capacity, retries/idempotency, duplicate delivery, cancellation, terminal cleanup, and worker loss.
  • React server/client boundary, query-key/invalidation parity, stale data, accessibility, error/loading/empty behavior.
  • Visual design against DESIGN.md: raw palette, hex or hsl(...) colours outside the central maps, a recoloured or non-black primary button, a status colour without text or an icon, copied toolbar/pagination components, and missing light/dark or 390px checks.
  • External effects: timeout, retry safety, idempotency, cancellation, billing/usage exactly-once behavior, and provider reconciliation.
  • Deployment: immutable versions, secret handling, gVisor/network/namespace isolation, resource ceilings, autoscaling, health, and destructive blast radius.
  • CLI/recorder public compatibility and AGPL versus Apache/third-party NOTICE obligations.

Findings format

  • Order by severity: critical/security/data loss, functional regression, reliability/performance, maintainability, suggestion.
  • Give exact file/line, concrete failure scenario, affected users/system, and smallest safe correction.
  • Avoid style-only noise unless repository tooling enforces it or it materially obscures correctness.
  • Record important investigated claims that are not defects so reviewers understand intentional behavior.

Verification and decision

flowchart TD
  REVIEW[Source/call paths reviewed] --> CHECK{Relevant checks pass?}
  CHECK -->|no| BLOCK[Not commit-ready]
  CHECK -->|yes| CLEAN{State and docs clean?}
  CLEAN -->|no| BLOCK
  CLEAN -->|yes| COMMIT[Commit-ready]
  COMMIT --> CI[Required CI and human review]
  CI --> ACCEPT[Browser/provider/deployment acceptance]
  ACCEPT --> RELEASE[Release-ready]
  • Run proportionate focused checks and broaden for shared/high-risk contracts (commands in supercheck-testing-qa).
  • CI coverage gaps to account for: *.db.spec.ts suites run only under npm run test:db, not npm test; the PR E2E job only typechecks and lists specs (playwright test --list), and the browser suite runs in e2e-full.yml. A green PR does not prove either.
  • Confirm whitespace/diff checks, package contents, ignored/generated files, migrations, and docs/skills parity.
  • Separate commit readiness from merge and release readiness.
  • An unavailable browser/provider/production check is a disclosed acceptance boundary, never a pass.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 466kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 466kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 466kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 192kUpdated Claude CodeCodexVerifiedInstall