Skip to content

rowdybard/whetstorm-art / .agents/skills/woc-review-pr

woc-review-pr

Verified

Review a World of ClaudeCraft pull request against its actual diff, canonical architecture, tests, and domain risks. Use when asked to inspect, review, assess, or prepare feedback for a pull request. Reading and drafting are allowed by default, but posting GitHub feedback requires explicit authorization.

Whetstorm fork guard (read first). This skill was written for the upstream project. Never run gh against rowdybard/whetstorm: the CLI on this machine is signed in to the Whetstorm owner's account, so anything posted there goes out under their name. This fork's own repo is rowdybard/whetstorm: target it instead, and check that every gh command names it explicitly with --repo rowdybard/whetstorm.

Review Pull Request

Perform a read-only, evidence-backed review of the requested pull request.

Hold the authorization boundary

A request to review, inspect, check, or assess authorizes reading and drafting only. Do not run gh pr review, post a comment, approve, request changes, push, edit the branch, or otherwise write to GitHub unless the user explicitly asks to submit the review.

Establish scope

  1. Read the root CLAUDE.md in full.
  2. Identify the pull request, repository, head, base, and merge base.
  3. Read local CLAUDE.md files for touched directories.
  4. Inspect the actual diff, surrounding production code, and linked acceptance criteria.
  5. Run git status --short and avoid disturbing unrelated work.

Use read-only Git and GitHub inspection as needed. Do not rely on the PR description.

Review and verify

Check correctness, edge cases, canonical architecture, determinism, parity, persistence, security, authorization, localization, generated artifacts, decisive tests, and updated operator documentation wherever those domains apply.

The coordinating agent runs targeted commands once. Specialist reviewers inspect the diff and shared results without duplicating the full test or build run.

Invoke woc_database_performance when the diff changes SQL, a database call site, schema or indexes, query frequency/cardinality, pool or lock behavior, timeout policy, background database work, database driver/dependency versions, PostgreSQL engine/resource/configuration/topology, or stored-data growth. Pair it with persistence or security review when those concerns also apply.

Invoke woc_server_hot_path when the diff adds or changes server work that runs per tick, per request, per broadcast, per session, or on a recurring main-thread job: a shared read or cache, a growing table or in-memory collection, a snapshot or event payload, a selfWireJson key or the src/sim/ read it calls, an autosave, sweep, or self-clocked job, or a world_state blob write. It owns the non-SQL server budget; pair it with woc_database_performance when SQL cost is also in play.

For every candidate finding:

  1. Trace the execution path.
  2. Confirm the PR introduces or exposes it.
  3. Check existing tests and guards.
  4. Identify concrete impact.
  5. Cite the narrowest useful file and line.
  6. Remove speculative, duplicate, inherited, and style-only noise.

Classify findings as blocking, should fix, or suggestion. Deliver confirmed findings first, followed by test gaps and residual risk.

If posting was explicitly authorized, show the final review text before the write when practical and submit only the requested action. Otherwise return the draft and state that nothing was posted.

finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the workStars: 322kUpdated Claude CodeCodexVerifiedInstall
systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixesStars: 322kUpdated Claude CodeCodexVerifiedInstall
test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation codeStars: 322kUpdated Claude CodeCodexVerifiedInstall
skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy.Stars: 198kUpdated Claude CodeCodexVerifiedInstall