njdaniel/conch / .claude/skills/principal-review
principal-review
VerifiedThe recurring ownership loop — review merged PRs since the last review, check invariant drift, groom the backlog, and write a report for Nick. Run weekly or per-milestone.
principal-review
This loop is what "Fable owns the project" means operationally (ADR-000 §6). Output is a dated report in docs/reports/.
Procedure
- Establish the window. Find the last report in
docs/reports/; review everything merged since (gh pr list --state merged), plus open PRs and CI status on main. - Review merged work. For each merged PR: does it match its issue's acceptance criteria? Any scope creep? Approval-path PRs — was the E2E test present and was it merged by Nick?
- Check invariant drift against the golden rules:
- Single-binary:
deps-allowlist.txtvsgo.mod; any new required external process? - Schema-first: grep for hand-rolled JSON shapes outside
pkg/schema. - Parity: any CLI/TUI or MCP capability without a REST/WS equivalent?
- Audit chain: do approval-path tests still cover request → notify → resolve → audit?
- Single-binary:
- Groom the backlog. Close stale issues, write the next tranche of issues to the template standard (Context/Files/Acceptance/Tests/Blocked-by), promote P2/P3 stubs to full issues only when their milestone is next, re-order blocked-by chains if reality changed.
- Write the report to
docs/reports/YYYY-MM-DD-principal-review.md:- Merged work summary (one line per PR).
- Invariant status (per rule: OK or drift found + issue filed).
- Backlog delta (issues written/closed/re-scoped).
- Decisions needed from Nick — proposed ADRs, dependency requests, release readiness (assessed against the
releaseskill's preconditions). Explicit list, even if empty.
- Post a summary into Conch itself (the build org is tenant #2), once the report is on a branch with a PR open:
ops/principal-review.sh post docs/reports/YYYY-MM-DD-principal-review.md <pr-url>. It sends the report's title, one line per##section with its item count, the## Decisions needed from Nicksection in full and the PR link, as plain text, to the channel named byCONCH_REVIEW_CHANNEL(defaultprincipal-review), withconch send, as whoeverconch loginstored. The decisions section is found by that heading, so keep it. If Conch is unreachable, there is no login, or the channel refuses the post, the script says which in one line and exits 3; the report and its PR stand and nothing is retried. Release readiness stays an item in the decisions list: nothing here raises a Conch approval object.
Cadence
Weekly, or at each milestone boundary — whichever comes first. If two loops in a row have nothing to review, say so in the report rather than skipping it.
The weekly run is a systemd user timer, and optional: ops/principal-review.sh install enables conch-principal-review.timer (Mondays 07:00, Persistent=true), which runs ops/principal-review.sh run. That starts a headless session to do steps 1–5 in its own worktree on a branch principal-review/YYYY-MM-DD; the script then commits the report, pushes the branch, opens a PR (Refs #26) and does step 6. It never commits to main and never merges, it holds conch-agent's lock while it works, and it does nothing if the day's report is already on main or on that branch. ops/principal-review.sh status shows the timer and the last log. A milestone-boundary review is the same run by hand, or this skill in a session followed by post.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 321k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 321k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 321k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 321k | Updated | Claude CodeCodex | Verified | Install |