Skip to content

moonlight-lupin/agent-skills / plugins/dev-pipeline/skills/review-lessons

review-lessons

Verified

Library of lessons from past build-review loops — not a stage. Use when a review or fix round hits a specific case: a reviewer BLOCKING that contradicts the brief, a test that passes but checks nothing, a feature dead in production, SQLite/WAL migrations, MCP tool surfaces, REST API authz, app ↔ external-source sync, Android/APK verification, fill-template extraction, CLI/git mechanics, reviewer outages. Load the one file the case needs; never load the whole library.

FileKindSize
SKILL.mdexecutableskill md5.5 KB
references/architecture-refactor-test-updates.mdexecutablescript2.9 KB
references/beta-gate-release-hardening.mdexecutablescript3.3 KB
references/ci-and-repo-hygiene.mdexecutablescript3.7 KB
references/confirm-loop-lessons.mdexecutablescript24.2 KB
references/cross-model-parallel-review.mdexecutablescript4.8 KB
references/data-integrity-principles.mdexecutablescript7.3 KB
references/delegate-skills-adaptation.mdexecutablescript2.1 KB
references/evidence-pairs.mdexecutablescript2.5 KB
references/extraction-from-filled-docs.mdexecutablescript6.1 KB
references/field-briefing-integration.mdexecutablescript5.2 KB
references/full-module-replacement-scoping.mdexecutablescript6.3 KB
references/generated-frontmatter-and-reviewer-outages.mdexecutablescript3.0 KB
references/loop-pitfalls.mdexecutablescript27.9 KB
references/mcp-category-tool-implementation.mdexecutablescript5.3 KB
references/mcp-design-review-patterns.mdexecutablescript5.7 KB
references/minified-bundle-selector-research.mdexecutablescript4.4 KB
references/mobile-app-verification.mdexecutablescript4.8 KB
references/multi-batch-sequencing.mdexecutablescript5.7 KB
references/parallel-dual-review.mdexecutablescript10.8 KB
references/pitfalls-dispatch-semantics.mdexecutablescript6.3 KB
references/pitfalls-fix-round-verification.mdexecutablescript6.6 KB
references/planning-with-files-adaptation.mdexecutablescript2.6 KB
references/plugin-gates-and-fix-rounds.mdexecutablescript8.2 KB
references/production-reachability-review.mdexecutablescript5.0 KB
references/reconciliation-review-findings.mdexecutablescript3.1 KB
references/rest-api-review-checklist.mdexecutablescript13.0 KB
references/review-findings-adjudication.mdexecutablescript34.4 KB
references/scope-test-in-process-execution.mdexecutablescript4.2 KB
references/security-property-tests.mdexecutablescript14.2 KB
references/sqlite-migration-pitfalls.mdexecutablescript4.1 KB
references/sqlite-wal-review-findings.mdexecutablescript5.0 KB
references/sync-pipeline-review-patterns.mdexecutablescript13.2 KB
references/tool-mechanics-pitfalls.mdexecutablescript44.1 KB
references/upgrade-path-test-pattern.mdexecutablescript3.0 KB

references/planning-with-files-adaptation.md

View on GitHub
# Adaptation Reference: planning-with-files Port (2026-09-12)

Source: https://github.com/OthmanAdi/planning-with-files (OthmanAdi, MIT,
26.8k stars, v3.17.2; reviewed Sep 2026). Verdict on the repo: Watch —
strong engineering (706 tests, honest evals, real security-incident
disclosure), and it ships a NATIVE Hermes plugin (verified against Hermes
0.19.1, skills-guard SAFE). Decision (user, Sep 2026): option C — port the
concepts into this skill dependency-free; do NOT install the plugin.

## Ported

1. **3-file persistent loop state** — their `task_plan.md` / `findings.md`
   / `progress.md` pattern, adapted: renamed to `loop-plan.md` /
   `loop-findings.md` / `loop-progress.md` (distinct from repo docs),
   gitignored working state per this skill's release-hygiene rules,
   promoted into the repo at delivery. `review-commit/references/persistent-loop-plan.md`.
2. **Phase-status + completion gate** — their `**Status:**` grammar and
   gated-stop concept, implemented as `review-commit/scripts/loop_plan_check.py` with a
   `--gate` exit code instead of a `pre_verify` hook. Runs at session
   resume (resume pointer) and before loop completion.
3. **SHA-256 attestation** — their plan-tamper detection, applied to
   builder briefs and Hermes-written test/plan files:
   `scripts/attest_file.py attest|verify`. Turns pitfall #20's ad-hoc
   diff-reading into a mechanical check.

## Explicitly NOT adopted

- **The native Hermes plugin** — per-turn `pre_llm_call` injection,
  write reminders, `pre_verify` gate, `/pwf` commands. Standing ~1k
  token/turn cost on EVERY session to defend against context rot we only
  incur inside long loops; our loops read state on resume instead.
- **Injection-time attestation enforcement** — their hooks refuse to
  inject a tampered plan. We attest on demand (attest/verify around
  dispatches); no hook chain to enforce at.
- **Parallel-session write guard** — detects completed phases going DOWN
  between turns from concurrent sessions. Our loops are
  single-orchestrator; parallel BUILDERS never touch loop files.
- **PWF env knobs / .planning/<slug> isolation / .active_plan pointers** —
  multi-plan fleet machinery for multi-project agent seats; overkill here.
- **KV-cache-stable injection formatting** — no injection, so moot.

## Revisit trigger

If a real loop shows context rot despite this pattern (orchestrator
resumes wrong, loses a review verdict, or re-derives settled decisions),
re-evaluate installing the plugin (option A):
`hermes skills install OthmanAdi/planning-with-files/.hermes/skills/planning-with-files --yes`
then the plugin route per their docs/hermes.md. Verify with `/plan-doctor`.
finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the workStars: 323kUpdated Claude CodeCodexVerifiedInstall
systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixesStars: 323kUpdated Claude CodeCodexVerifiedInstall
test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation codeStars: 323kUpdated Claude CodeCodexVerifiedInstall
skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy.Stars: 198kUpdated Claude CodeCodexVerifiedInstall