Skip to content

moonlight-lupin/agent-skills / plugins/dev-pipeline/skills/review-lessons

review-lessons

Verified

Library of lessons from past build-review loops — not a stage. Use when a review or fix round hits a specific case: a reviewer BLOCKING that contradicts the brief, a test that passes but checks nothing, a feature dead in production, SQLite/WAL migrations, MCP tool surfaces, REST API authz, app ↔ external-source sync, Android/APK verification, fill-template extraction, CLI/git mechanics, reviewer outages. Load the one file the case needs; never load the whole library.

Review Lessons

What past loops taught, filed by case. The dev-pipeline's PROCESS lives in the stage skills — round budgets, severity floor and stop conditions in review-commit/references/confirm-round-protocol.md, model names in orchestrator/references/lanes.md. Where a lesson here disagrees with those files, they win: lessons are dated evidence, the protocol is the current rule.

How to use: find the case below, read that one file, apply it to the finding in front of you. Don't preload — most of these are project-specific.

Old names: these files predate v0.2. "build-review-loop", "codex-confirm-loop" and "subagent-driven-development" in them mean today's review-commit and build stages; model names in them are what ran at the time, not current pins. Numbered references ("pitfall #N", "rule #N") point at the retired v0.1 stage SKILL.md numbering, which no longer exists — treat them as historical context, not as pointers to read.

By case

Adjudicating findings and fix rounds

CaseFile
Reviewer BLOCKING contradicts the dispatch spec or a contract test; deferred findings as design questionsreferences/review-findings-adjudication.md
Fix at the wrong layer, red-test triage, two-sided fixes, live verificationreferences/pitfalls-fix-round-verification.md
Builder self-report, regressions from fixes, mid-build user steers, brief racesreferences/loop-pitfalls.md
Confirm-loop probes: exact repro shapes, vacuous tests, mutation-testing a fix, race probes, kernel statereferences/confirm-loop-lessons.md
Two reviewers in parallel, synthesizing their findingsreferences/parallel-dual-review.md, references/cross-model-parallel-review.md
A reviewer lane is down; YAML frontmatter generated by f-stringsreferences/generated-frontmatter-and-reviewer-outages.md
Plugin ship gates and fix-round contractsreferences/plugin-gates-and-fix-rounds.md

Test quality

CaseFile
Property tests for isolation / scope / role surfaces; inert tests; exempt pathsreferences/security-property-tests.md
In-process scope property testsreferences/scope-test-in-process-execution.md
Feature has tests but no production callerreferences/production-reachability-review.md
Tests to update when the architecture shifts mid-loopreferences/architecture-refactor-test-updates.md
Upgrade-path testsreferences/upgrade-path-test-pattern.md
Before/after evidence pairs for deliveryreferences/evidence-pairs.md

Data and storage

CaseFile
Invariants, foreign keys, idempotency, money as TEXT/Decimal, migration fixturesreferences/data-integrity-principles.md
SQLite table-rebuild migrationsreferences/sqlite-migration-pitfalls.md
SQLite WAL migration review findingsreferences/sqlite-wal-review-findings.md
Replacing N modules with one (caller inventory)references/full-module-replacement-scoping.md
Reconciliation logicreferences/reconciliation-review-findings.md

Surfaces and domains

CaseFile
REST API: routers, authz, SQL patternsreferences/rest-api-review-checklist.md
MCP tool surfaces and design reviewreferences/mcp-category-tool-implementation.md, references/mcp-design-review-patterns.md
App ↔ external source-of-truth sync (Sheets, SaaS mirrors)references/sync-pipeline-review-patterns.md
Android APK / WebView verificationreferences/mobile-app-verification.md
Fill-template document extractionreferences/extraction-from-filled-docs.md
Styling against a shipped minified bundlereferences/minified-bundle-selector-research.md

Mechanics and process history

CaseFile
CLI flags, git mechanics, contract-test mechanics, push hygienereferences/tool-mechanics-pitfalls.md
Dispatch, polling, parallel builds, brief racesreferences/pitfalls-dispatch-semantics.md
CI and repo hygienereferences/ci-and-repo-hygiene.md
Batching a phase by dependency and riskreferences/multi-batch-sequencing.md
Release-hardening-shaped cyclereferences/beta-gate-release-hardening.md
Integrating an operator's field briefingreferences/field-briefing-integration.md
Port notes: delegate-skills, planning-with-filesreferences/delegate-skills-adaptation.md, references/planning-with-files-adaptation.md

Adding a lesson

Add a lesson only when a loop taught something a future loop would get wrong without it. One file per case; put the date and project type in the title; add a row above. If the lesson changes how the loop runs (a cap, a stop rule, who reviews), change confirm-round-protocol.md instead — a rule filed as a lesson becomes a second, contradicting copy.

finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the workStars: 322kUpdated Claude CodeCodexVerifiedInstall
systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixesStars: 322kUpdated Claude CodeCodexVerifiedInstall
test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation codeStars: 322kUpdated Claude CodeCodexVerifiedInstall
skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy.Stars: 198kUpdated Claude CodeCodexVerifiedInstall