Skip to content

moonlight-lupin/agent-skills / plugins/dev-pipeline/skills/review-lessons

review-lessons

Verified

Library of lessons from past build-review loops — not a stage. Use when a review or fix round hits a specific case: a reviewer BLOCKING that contradicts the brief, a test that passes but checks nothing, a feature dead in production, SQLite/WAL migrations, MCP tool surfaces, REST API authz, app ↔ external-source sync, Android/APK verification, fill-template extraction, CLI/git mechanics, reviewer outages. Load the one file the case needs; never load the whole library.

FileKindSize
SKILL.mdexecutableskill md5.5 KB
references/architecture-refactor-test-updates.mdexecutablescript2.9 KB
references/beta-gate-release-hardening.mdexecutablescript3.3 KB
references/ci-and-repo-hygiene.mdexecutablescript3.7 KB
references/confirm-loop-lessons.mdexecutablescript24.2 KB
references/cross-model-parallel-review.mdexecutablescript4.8 KB
references/data-integrity-principles.mdexecutablescript7.3 KB
references/delegate-skills-adaptation.mdexecutablescript2.1 KB
references/evidence-pairs.mdexecutablescript2.5 KB
references/extraction-from-filled-docs.mdexecutablescript6.1 KB
references/field-briefing-integration.mdexecutablescript5.2 KB
references/full-module-replacement-scoping.mdexecutablescript6.3 KB
references/generated-frontmatter-and-reviewer-outages.mdexecutablescript3.0 KB
references/loop-pitfalls.mdexecutablescript27.9 KB
references/mcp-category-tool-implementation.mdexecutablescript5.3 KB
references/mcp-design-review-patterns.mdexecutablescript5.7 KB
references/minified-bundle-selector-research.mdexecutablescript4.4 KB
references/mobile-app-verification.mdexecutablescript4.8 KB
references/multi-batch-sequencing.mdexecutablescript5.7 KB
references/parallel-dual-review.mdexecutablescript10.8 KB
references/pitfalls-dispatch-semantics.mdexecutablescript6.3 KB
references/pitfalls-fix-round-verification.mdexecutablescript6.6 KB
references/planning-with-files-adaptation.mdexecutablescript2.6 KB
references/plugin-gates-and-fix-rounds.mdexecutablescript8.2 KB
references/production-reachability-review.mdexecutablescript5.0 KB
references/reconciliation-review-findings.mdexecutablescript3.1 KB
references/rest-api-review-checklist.mdexecutablescript13.0 KB
references/review-findings-adjudication.mdexecutablescript34.4 KB
references/scope-test-in-process-execution.mdexecutablescript4.2 KB
references/security-property-tests.mdexecutablescript14.2 KB
references/sqlite-migration-pitfalls.mdexecutablescript4.1 KB
references/sqlite-wal-review-findings.mdexecutablescript5.0 KB
references/sync-pipeline-review-patterns.mdexecutablescript13.2 KB
references/tool-mechanics-pitfalls.mdexecutablescript44.1 KB
references/upgrade-path-test-pattern.mdexecutablescript3.0 KB

references/evidence-pairs.md

View on GitHub
# Evidence Pairs

Every delivered batch carries an **evidence pair**: the state before the
change and the state after, captured the same way. The pair is embedded in
the delivery — PR body, commit message thread, or final report — not stored
beside it. A claim about the change without its pair is unverified prose.

Ported concept (Sep 2026) from michaelshimeles/skills "prove" beat
(evidence-driven-testing). See *Adaptation* below for what was NOT taken.

## Capture rules

- Capture the **before** while reproducing the issue — before the fix, when
  it is cheapest. A before captured after the fix is a reconstruction, not
  evidence.
- Capture **after** with the same method as the before. A screenshot vs a
  screenshot; a measured number vs the same measurement re-run. Method
  change = invalid pair.
- No visual surface? Use **measured numbers or output pairs** instead:
  the failing check output vs the passing one, the slow timing vs the fast
  one, the wrong total vs the right one.
- Keep pairs **local** (workspace, `/tmp`, repo `docs/` when meant to
  ship). Never upload to public hosts — screenshots of customer or
  internal surfaces are sensitive.

## Where the pair lives

| Delivery | How the pair is embedded |
|---|---|
| PR | Markdown table `\| Before \| After \|` in the body; images via repo-relative paths or uploaded assets |
| Delivery message | Before/after blocks side by side |
| Commit for a small fix | Before/after output pasted in the message body |

The loop's dual review (Codex + Opus) judges the diff; the pair is for the
human — it answers "does the change do what it claims" in one look.

## Completion criterion

A batch's delivery step is done only when every user-visible claim in it
has a pair beside it. `--gate` open + attestation verified + evidence pairs
embedded = deliverable.

## Adaptation (source: michaelshimeles/skills)

Ported: the before/after pair as a delivery requirement, and the
"capture before while reproducing" timing rule.

NOT adopted: their `@vercel/before-and-after` CLI (uploads to a public
host by default — 0x0.st; unacceptable for production/customer surfaces),
`greploop` (needs Greptile; our Codex+Opus dual review is stricter),
`unslop` (controlled-English is our writing standard), `new-feature`
worktree flow (our parallel dispatches use disjoint brief ownership,
pitfall (parallel dispatches); worktree isolation remains an option for true conflicts),
`code-structure` service-layer skill (already covered by our
architecture review checklist).
finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the workStars: 323kUpdated Claude CodeCodexVerifiedInstall
systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixesStars: 323kUpdated Claude CodeCodexVerifiedInstall
test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation codeStars: 323kUpdated Claude CodeCodexVerifiedInstall
skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy.Stars: 198kUpdated Claude CodeCodexVerifiedInstall