Skip to content

moonlight-lupin/agent-skills / plugins/dev-pipeline/skills/review-lessons

review-lessons

Verified

Library of lessons from past build-review loops — not a stage. Use when a review or fix round hits a specific case: a reviewer BLOCKING that contradicts the brief, a test that passes but checks nothing, a feature dead in production, SQLite/WAL migrations, MCP tool surfaces, REST API authz, app ↔ external-source sync, Android/APK verification, fill-template extraction, CLI/git mechanics, reviewer outages. Load the one file the case needs; never load the whole library.

FileKindSize
SKILL.mdexecutableskill md5.5 KB
references/architecture-refactor-test-updates.mdexecutablescript2.9 KB
references/beta-gate-release-hardening.mdexecutablescript3.3 KB
references/ci-and-repo-hygiene.mdexecutablescript3.7 KB
references/confirm-loop-lessons.mdexecutablescript24.2 KB
references/cross-model-parallel-review.mdexecutablescript4.8 KB
references/data-integrity-principles.mdexecutablescript7.3 KB
references/delegate-skills-adaptation.mdexecutablescript2.1 KB
references/evidence-pairs.mdexecutablescript2.5 KB
references/extraction-from-filled-docs.mdexecutablescript6.1 KB
references/field-briefing-integration.mdexecutablescript5.2 KB
references/full-module-replacement-scoping.mdexecutablescript6.3 KB
references/generated-frontmatter-and-reviewer-outages.mdexecutablescript3.0 KB
references/loop-pitfalls.mdexecutablescript27.9 KB
references/mcp-category-tool-implementation.mdexecutablescript5.3 KB
references/mcp-design-review-patterns.mdexecutablescript5.7 KB
references/minified-bundle-selector-research.mdexecutablescript4.4 KB
references/mobile-app-verification.mdexecutablescript4.8 KB
references/multi-batch-sequencing.mdexecutablescript5.7 KB
references/parallel-dual-review.mdexecutablescript10.8 KB
references/pitfalls-dispatch-semantics.mdexecutablescript6.3 KB
references/pitfalls-fix-round-verification.mdexecutablescript6.6 KB
references/planning-with-files-adaptation.mdexecutablescript2.6 KB
references/plugin-gates-and-fix-rounds.mdexecutablescript8.2 KB
references/production-reachability-review.mdexecutablescript5.0 KB
references/reconciliation-review-findings.mdexecutablescript3.1 KB
references/rest-api-review-checklist.mdexecutablescript13.0 KB
references/review-findings-adjudication.mdexecutablescript34.4 KB
references/scope-test-in-process-execution.mdexecutablescript4.2 KB
references/security-property-tests.mdexecutablescript14.2 KB
references/sqlite-migration-pitfalls.mdexecutablescript4.1 KB
references/sqlite-wal-review-findings.mdexecutablescript5.0 KB
references/sync-pipeline-review-patterns.mdexecutablescript13.2 KB
references/tool-mechanics-pitfalls.mdexecutablescript44.1 KB
references/upgrade-path-test-pattern.mdexecutablescript3.0 KB

references/delegate-skills-adaptation.md

View on GitHub
# Adaptation Reference: delegate-skills Port (2026-09-12)

Source: https://github.com/amElnagdy/delegate-skills (amElnagdy, MIT,
reviewed Sep 2026). Verdict on the repo itself: Watch — it targets other
orchestrators (Claude Code/opencode via `npx skills`), and its relays
duplicate dispatch mechanics this skill already hardens. Concept port, not
adoption.

## Ported

1. **Dispatch result contract (`delegate-result.v1`)** — from their
   `delegate-relay.result.v1`. One machine-readable result file per
   dispatch: status, exitCode, model-that-actually-ran, touchedFiles,
   report path. Implemented as `review-commit/scripts/capture_dispatch_result.py` +
   `review-commit/references/dispatch-result-contract.md`. Their relay writes it
   automatically; we capture after exit because our CLIs run raw in
   background terminals.
2. **The reviewer commits** — from their core invariant "the relay never
   commits — committing belongs to the reviewer" and their commit-boundary
   discipline (working tree is evidence between dispatch and commit; no
   reflexive `git checkout`/`clean` before inspection). Encoded as
   Pitfall #32 in SKILL.md.

## Explicitly NOT adopted

- **Their relay scripts (`relay.mjs`)** — per-CLI wrappers for other
  orchestrators' headless modes. Our dispatches (Cursor CLI `agent`, Codex
  `exec`, Claude Code) already run with verified flags and pitfall
  handling; a wrapper would add a layer without removing any known
  failure mode.
- **Fleet lanes / `delegate-fleet.v1` config** — persistent lane maps with
  approval-hash binding. Designed for multi-CLI fleets and multiple
  orchestrator seats; this workspace runs a fixed builder/reviewer pair
  with Bot Mode. Model routing lives in the brief, not in config.
- **`delegate-setup` discovery/interview flow** — multi-CLI discovery and
  burn/spare economics; no fit for a 1-operator setup.

## Validation

- Script exercised 2026-09-12 on a scratch git repo: clean tree →
  `touchedFiles: []`; post-edit → exact porcelain lines; non-repo dir →
  `null`; exit-code mapping verified for 0/124/127/1.
finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the workStars: 323kUpdated Claude CodeCodexVerifiedInstall
systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixesStars: 323kUpdated Claude CodeCodexVerifiedInstall
test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation codeStars: 323kUpdated Claude CodeCodexVerifiedInstall
skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy.Stars: 198kUpdated Claude CodeCodexVerifiedInstall