Skip to content

moonlight-lupin/agent-skills / plugins/dev-pipeline/skills/review-lessons

review-lessons

Verified

Library of lessons from past build-review loops — not a stage. Use when a review or fix round hits a specific case: a reviewer BLOCKING that contradicts the brief, a test that passes but checks nothing, a feature dead in production, SQLite/WAL migrations, MCP tool surfaces, REST API authz, app ↔ external-source sync, Android/APK verification, fill-template extraction, CLI/git mechanics, reviewer outages. Load the one file the case needs; never load the whole library.

FileKindSize
SKILL.mdexecutableskill md5.5 KB
references/architecture-refactor-test-updates.mdexecutablescript2.9 KB
references/beta-gate-release-hardening.mdexecutablescript3.3 KB
references/ci-and-repo-hygiene.mdexecutablescript3.7 KB
references/confirm-loop-lessons.mdexecutablescript24.2 KB
references/cross-model-parallel-review.mdexecutablescript4.8 KB
references/data-integrity-principles.mdexecutablescript7.3 KB
references/delegate-skills-adaptation.mdexecutablescript2.1 KB
references/evidence-pairs.mdexecutablescript2.5 KB
references/extraction-from-filled-docs.mdexecutablescript6.1 KB
references/field-briefing-integration.mdexecutablescript5.2 KB
references/full-module-replacement-scoping.mdexecutablescript6.3 KB
references/generated-frontmatter-and-reviewer-outages.mdexecutablescript3.0 KB
references/loop-pitfalls.mdexecutablescript27.9 KB
references/mcp-category-tool-implementation.mdexecutablescript5.3 KB
references/mcp-design-review-patterns.mdexecutablescript5.7 KB
references/minified-bundle-selector-research.mdexecutablescript4.4 KB
references/mobile-app-verification.mdexecutablescript4.8 KB
references/multi-batch-sequencing.mdexecutablescript5.7 KB
references/parallel-dual-review.mdexecutablescript10.8 KB
references/pitfalls-dispatch-semantics.mdexecutablescript6.3 KB
references/pitfalls-fix-round-verification.mdexecutablescript6.6 KB
references/planning-with-files-adaptation.mdexecutablescript2.6 KB
references/plugin-gates-and-fix-rounds.mdexecutablescript8.2 KB
references/production-reachability-review.mdexecutablescript5.0 KB
references/reconciliation-review-findings.mdexecutablescript3.1 KB
references/rest-api-review-checklist.mdexecutablescript13.0 KB
references/review-findings-adjudication.mdexecutablescript34.4 KB
references/scope-test-in-process-execution.mdexecutablescript4.2 KB
references/security-property-tests.mdexecutablescript14.2 KB
references/sqlite-migration-pitfalls.mdexecutablescript4.1 KB
references/sqlite-wal-review-findings.mdexecutablescript5.0 KB
references/sync-pipeline-review-patterns.mdexecutablescript13.2 KB
references/tool-mechanics-pitfalls.mdexecutablescript44.1 KB
references/upgrade-path-test-pattern.mdexecutablescript3.0 KB

references/beta-gate-release-hardening.md

View on GitHub
# Beta Gate Release-Hardening Cycle (Aug 2026)

Session record of the 0.1.0-beta.1 Beta Gate: five hardening items run as
orchestrated build-review batches. Complements the multi-batch-sequencing
reference with a release-hardening-shaped batch plan.

## Batch plan (execution order, not brief order)

| Batch | Item | Class | Build model | Test author |
|---|---|---|---|---|
| 1 | G2 CSRF protection | security code | grok-4.6-high | Hermes (red contract tests first) |
| 2 | G1 backup archive format | money-adjacent code | grok-4.6-high (parallel) | Hermes (red contract tests first) |
| 2 | G3+G4 docs + runbook | docs-only | composer-2.5 (parallel) | N/A |
| 2 | G5 constraints file | release engineering | composer-2.5 (parallel) | builder (guard test) |
| 3 | Codex+Opus dual review | review | — | — |

Highest-risk/highest-leverage first: CSRF is the smallest security gap and
unblocks docs (security.md references it). Docs and constraints are disjoint
from code files → safe to run in parallel with the code build (SKILL.md
pitfall #69).

## Contract-test pattern that worked

For each code item, Hermes wrote red tests BEFORE dispatching, encoding the
acceptance criterion as behavior:

- CSRF (`tests/test_csrf.py`): module contract (create/verify roundtrip,
  wrong-user rejection, garbage input → False never raise), template embeds
  `name="csrf_token"`, mutating routes 403 without/with-forged/with-foreign
  token, happy path extracts the embedded token and succeeds.
- Backup (`tests/test_backup_archive.py`): tarball contains manifest.json +
  master.db + entity DBs; manifest fields (format_version, app_version,
  created_at, entries[path, sha256, bytes]); checksum verification;
  `backup verify` detects tampered member / missing member / corrupt
  manifest; restore roundtrip reproduces trial balance + hash chain;
  refuse-without-force preserved; single-entity archive excludes others.

Before running red: probe the CLI's real contract once (`_error()` → stderr +
nonzero; success → stdout JSON) and fix wrong command names in the tests —
harness failures are not honest RED (SKILL.md pitfall #64/#47).

## Session-specific findings

- **Claim-vs-repo delta first**: a strategy brief said backup/restore was
  "missing"; the repo already had `ledger backup/restore/vacuum` +
  `tests/test_backup_restore.py`. The actual gap was narrower (archive
  format, verify, PG path, CI recovery test). Verify each brief claim with
  grep before scoping the build — this halved G1's scope.
- **Clean reference venv** (`/tmp/<proj>-venv`, SKILL.md pitfall #68) — host
  venv had a stale `mcp` package producing unrelated ImportErrors; the clean
  venv turned those into honest RED. Its `pip freeze` then became the G5
  constraints file directly.
- **Builder deviation caught at verification** (SKILL.md pitfall #50): the
  G1 builder added a global `tarfile.TarFile.addfile` monkeypatch in the
  package `__init__.py` that nothing needed — flagged for removal at review
  instead of being committed silently.

## Outcomes (test-level, before dual review)

- G2: 11 contract tests + 108 related tests green.
- G1: 11 contract tests green; 32 combined Beta-Gate tests green.
- G3/04: README reconciled (bootstrap-mode API-key drift fixed), 9 docs
  files, deployment runbook with "never expose port 8000" rule.
- G5: constraints.txt + Dockerfile `-c constraints.txt` + guard test.
finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the workStars: 323kUpdated Claude CodeCodexVerifiedInstall
systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixesStars: 323kUpdated Claude CodeCodexVerifiedInstall
test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation codeStars: 323kUpdated Claude CodeCodexVerifiedInstall
skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy.Stars: 198kUpdated Claude CodeCodexVerifiedInstall