Skip to content

moonlight-lupin/agent-skills / plugins/dev-pipeline/skills/review-commit

review-commit

Verified

Use when the user says 'review loop N times', 'build then review', 'fix and re-review', 'review loop until clean', 'have cursor build, codex review', or wants the dev-pipeline review stage: a two-axis single pass (Standards + Spec, parallel, never merged) FIRST, then a budgeted confirm-round loop on the fix diffs until no BLOCKING/MAJOR is open, then the commit/deploy gate — three-reviewer gate before live deploy, release hygiene before tagging. Also triggers: 'two-axis review', 'confirm rounds', 'review diff until SHIP', 'N confirm rounds', ship gate.

Review-Commit

Stage 5 of the dev-pipeline: everything after the build, through commit and deploy. This file and its references/ hold the PROCESS. Lessons from past loops (SQLite, MCP, REST, sync, mobile, test-quality traps, CLI quirks) live in the separate review-lessons skill — load a lesson file only when its case comes up, never at stage start.

Before you start: tier, lanes, budget

  1. Tier — risk-derived review tier from orchestrator/references/risk-routing.md (compatibility table: size-tiers.md). It sets how many reviewers run and how many confirm rounds the loop may spend. Say it: "T2: two reviewers, R1 + up to 2 confirm rounds."
  2. Lanes — which model builds and which review: orchestrator/references/lanes.md (the only place model names live).
  3. User overrides — "review loop 3 times", "all three reviewers" — set the budget or reviewer set for this task.

The review sequence

A runs once; B loops within budget; C is the gate at the end.

Step A — Two-axis single pass (cheap, first)

references/two-axis-single-pass.md: two parallel sub-agents review the diff along two separate axes — Standards (repo conventions + the 12 Fowler smells + the Overbuilt and Drive-by Change checks) and Spec (faithfulness to the spec/issue). Never merged or re-ranked. Fail fast first: the base ref must resolve and the diff must be non-empty. Label every finding BLOCKING / MAJOR / MINOR / NIT; they enter Step B as named findings. Skipped at T0.

Step B — R1 review, then confirm rounds

All loop rules live in references/confirm-round-protocol.md. Read it before R1. The short version:

  • R1 reviews the change's diff with the tier's reviewer lanes.
  • Only BLOCKING/MAJOR keep the loop open. MINOR/NIT go to the deferred list and never trigger a round.
  • Confirm rounds review the FIX diff, with full acceptance suite and new adversarial regression checks rerun after each fix. Anything outside the fix lines is OUT-OF-SCOPE-N → deferred (unless a reproduced BLOCKING).
  • Only reviewers with open findings are re-dispatched.
  • Hard budget per tier (T1 = 1, T2 = 2, T3 = 3 confirm rounds). When it's spent, stop and give the user redesign / another round / explicit risk acceptance; open BLOCKING/MAJOR or failing acceptance tests are NOT SHIP.
  • Stop early on the second same-class finding (redesign the class), on no progress, or when most findings are fix-induced (tighten the briefs).
  • Reproduce before fixing; verify each fix landed and its test fails without it.

Mechanics:

  • Step-by-step bodies (brief, build, verify, commit, review, synthesize, fix, push, CI): references/workflow-steps.md.
  • Dispatching the CLIs (cwd, sandbox, timing, outages, bot mode): references/reviewer-dispatch.md.
  • Fix briefs: references/fix-brief-template.md; new-capability briefs against pre-written tests: references/feature-build-brief.md.
  • Spec/design documents instead of code: references/spec-convergence.md.
  • Multi-session or multi-batch loops: references/persistent-loop-plan.md (scripts/loop_plan_check.py, scripts/attest_file.py); dispatch capture: references/dispatch-result-contract.md (scripts/capture_dispatch_result.py); polling: references/background-build-polling.md.

Step C — Commit/deploy gate

  • Never push without a review pass (R1 at least, no open BLOCKING/MAJOR). T0 changes with no behavior change may push directly at the user's instruction.
  • Never deploy live without the three-reviewer gate — all three reviewer lanes SHIP on the net diff, run once after the loop converges (confirm-round-protocol.md § Three-reviewer deployment gate). This is the user's standing instruction and applies at every tier.
  • Before tagging or releasing: references/release-hygiene.md.

Who writes the code during the loop

  • The builder lane implements and fixes. The orchestrator verifies independently and does not hand-code non-trivial fixes.
  • Trivial fixes (≤ ~10 lines, mechanical, no design choice — a typo, a missing import, a pinned off-by-one) the orchestrator may make directly, and must say so. If unsure whether it's trivial, delegate.
  • Reviewers run read-only. The builder never commits; the orchestrator commits after its own verification.

Quick reference — user says

User saysDo
"review loop N times"R1 + up to N−1 confirm rounds (N reviews total); stop early on SHIP
"build then review with codex" / "have cursor build, codex review"build (builder lane) → R1 (reviewer A) → fix → one confirm round if anything BLOCKING/MAJOR
"fix and re-review"fix round → confirm round on the fix diff
"review loop until clean"until no open BLOCKING/MAJOR, within the tier budget — then ask
"ship it" / "deploy"Step C; live deploy needs the three-reviewer gate

Convergence check

Each round should have fewer open BLOCKING/MAJOR than the last. The ledger line per round (confirm-round-protocol.md § Ledger) records the counts the stop conditions read. If the count doesn't fall, stop — another round won't fix a fix that made things worse.

Lessons (load on demand)

review-lessons is the index. Common ones:

CaseLesson file (in review-lessons/references/)
Reviewer BLOCKING contradicts the brief or a contract testreview-findings-adjudication.md
A test that passes but checks nothing; property testssecurity-property-tests.md, confirm-loop-lessons.md
Feature wired but dead in productionproduction-reachability-review.md
Data integrity, migrations, idempotencydata-integrity-principles.md
CLI flags, git mechanics, push hygienetool-mechanics-pitfalls.md
Fix rounds at the wrong layer, two-sided fixespitfalls-fix-round-verification.md
writing-skillsobra/superpowersUse when creating new skills, editing existing skills, or verifying skills work before deploymentStars: 319kUpdated Claude CodeCodexVerifiedInstall
xlsxanthropics/skillsUse this skill any time a spreadsheet file is the primary input or output. This means any task where the user wants to: open, read, edit, or fix an existing .xlsx, .xlsm, .xltx, .csv, or .tsv file (e.g., adding columns, computing formulas, formatting, charting, cleaning messy data); create a new spreadsheet from scratch or from other data sources; or convert between tabular file formats. Trigger especially when the user references a spreadsheet file by name or path — even casually (like "the xlsx in my downloads") — and wants something done to it or produced from it. Also trigger for cleaning or restructuring messy tabular data files (malformed rows, misplaced headers, junk data) into proper spreadsheets. The deliverable must be a spreadsheet file. Do NOT trigger when the primary deliverable is a Word document, HTML report, standalone Python script, database pipeline, or Google Sheets API integration, even if tabular data is involved.Stars: 196kUpdated Claude CodeCodexVerifiedInstall
shipping-and-launchaddyosmani/agent-skillsPrepares production launches. Use when preparing to deploy to production, or when asking what needs to be in place before shipping. Use when you need a pre-launch checklist, when setting up monitoring, when planning a staged rollout, or when you need a rollback strategy.Stars: 118kUpdated Claude CodeCodexVerifiedInstall
childhoodthedotmack/claude-memBabysit a shipped release after merge, publication, or deployment. Verify published packages, production behavior, installed plugins, and late CI or user reports until the observation window is clean; use babysit for PR readiness before release.Stars: 118kUpdated Claude CodeCodexVerifiedInstall