Skip to content

kunitoki/sonic-skills / skills/audio-numerics-review

audio-numerics-review

Verified

Reviews audio DSP code for numerical correctness. Use when the user asks to review, audit, or check DSP code for correctness issues — filters, feedback loops, fixed-point arithmetic, accumulation loops, or any numeric computation in audio code. Trigger on "check this filter for NaN", "why does my reverb blow up?", "is this numerically stable?", "why do I hear DC in my output?". Pairs with audio-dsp-review (realtime safety); this skill covers numeric correctness. Flag issues proactively.

Audio Numerics Review

Floating-point is not real math. IEEE 754 edge cases — denormals, NaN propagation, catastrophic cancellation, precision loss — silently produce wrong audio output without crashing. You won't find them with a debugger; you find them by knowing where to look.

Step 1 — Find numeric-critical paths

Locate every function doing floating-point or integer DSP: filter state loops, feedback delay lines, envelope followers, RMS/energy accumulators, pitch detectors, fixed-point paths (CMSIS-DSP, SIMD int16/int32), any division whose denominator may be zero.

Step 2 — Scan for violations

ViolationWhere to lookSymptom
Denormal floatsIIR state vars, reverb tanks, delay feedbackSudden 100× CPU spike when signal decays
NaN / InfDivisions, sqrt, acos/asin, peak normalizersSilence or noise that can't be traced
Catastrophic cancellationDC-blocking filters, near-Nyquist biquads, first-order diffNoise floor jumps, loss of precision
Fixed-point overflowQ15/Q31 multiply, CMSIS paths, SIMD int16Audible distortion / wrapping
Precision lossRMS/energy sums, mixing buses, long loopsAccumulated DC offset, incorrect levels
FTZ/DAZ absentprepareToPlay/stream-open — no mode setupDenormals hit on some hosts but not others

For code examples and platform-specific notes see references/numerics-pitfalls.md.

Step 3 — Write the review

## Audio Numerics Review: `[file / function]`

### Verdict
[Safe | Has critical violations | Warnings only] — one sentence summary

### Critical Violations
**[Category]: [description]**
`file:line` — `offending code`
Why: one sentence on the numeric risk
Fix: concrete suggestion

### Warnings
[same format]

### What's Done Well
[guarded divisions, double accumulators, FTZ setup, etc.]

### Recommended Fixes (priority order)
1. ...

Quick fix table

ViolationSafe alternative
Denormal in feedbackScopedNoDenormals; FTZ+DAZ in prepareToPlay; DC-offset clamp
Division by zero(denom > 1e-6f) ? num/denom : fallback
sqrt/acos/asin unclampedstd::sqrt(std::max(0.f, x)), std::clamp inputs
NaN propagating silentlyassert(!std::isnan(y)) in debug; validate at entry points
Cancellation in coefficientsCompute coefficients in double; use numerically stable forms
Fixed-point overflowPromote to wider type before multiply; __SSAT, CMSIS saturating ops
Precision loss in long sumdouble accumulator or Kahan compensated summation
FTZ/DAZ absentSet explicitly in prepareToPlay; use ScopedNoDenormals per-block
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall