gpsaggese/helpers / .claude/skills/testing.fix_mock_tests
testing.fix_mock_tests
VerifiedRemove mocking approach from unit tests
Goal
- When the user passes a test file, apply these transformations to remove mocking without changing behavior
- Mocking often signals a design that could be more modular
- Avoid mocking by designing code so dependencies are easy to control, not intercepted artificially
Workflow
- Avoid mocking using the strategies below
Prefer Pure Functions
- Functions that depend only on inputs and return outputs are trivial to test
- Example:
def add(a: int, b: int) -> int: return a + b
- Example:
- No mocking needed: there are no external dependencies
Design for Dependency Injection (DI)
- Instead of hard coding dependencies inside functions or classes, pass them in
- Bad (hardcodes the dependency, forcing a mock to test it)
from typing import Any import requests def get_user(user_id: int) -> Any: return requests.get(f"https://api.com/users/{user_id}").json() - Good (injects the dependency, so a fake can be substituted in tests)
from typing import Any, Protocol class HttpClient(Protocol): def get(self, url: str) -> Any: ... def get_user(user_id: int, http_client: HttpClient) -> Any: return http_client.get(f"https://api.com/users/{user_id}").json() - Bad (creates its own dependency inside
__init__)class Database: pass class UserService: def __init__(self) -> None: self.db: Database = Database() - Good (accepts the dependency, so a fake can be passed in)
class Database: pass class UserService: def __init__(self, db: Database) -> None: self.db: Database = db
Create Lightweight Fakes Instead of Mocks
- A fake is a real implementation with simplified behavior
- More maintainable and less brittle than mocks
- Example:
from typing import Any class FakeDatabase: def __init__(self) -> None: self.data: dict[str, Any] = {} def save(self, key: str, value: Any) -> None: self.data[key] = value def get(self, key: str) -> Any: return self.data.get(key)
Separate Side Effects From Logic
- Keep core logic independent from I/O
- Bad (mixes I/O and logic, forcing mocks for the database and email)
from typing import Any def process_user(user_id: int) -> None: user: Any = db.get(user_id) send_email(user) - Good (logic is separated from I/O, so no mocking is needed)
from typing import Any, Callable def process_user(user: Any, send_email_fn: Callable[[Any], None]) -> None: send_email_fn(user) - Test the logic without mocking the database or email system
Test Behavior Via Public Interfaces
- Avoid testing internal calls, which often leads to mocking
- Focus on outputs and state changes
- Verify the final result or state, not that a method was called
Use Real Collaborators When Cheap
- If a dependency is fast and deterministic, just use it
- JSON parsing
- Simple utility classes
- Pure transformations
- Mocking these adds unnecessary complexity
Use Integration Tests Strategically
- Sometimes the best way to avoid mocking is to test a small system working together, not to unit test in isolation
Important
- All invariants and conventions for unit tests are documented in
.claude/skills/testing.rules.md - For all code you must follow the instructions in
.claude/skills/coding.rules.md
Verification
- Run the tests and confirm they still pass
- Confirm no mocking constructs (
Mock,patch,MagicMock) remain unless truly unavoidable
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the work | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixes | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation code | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy. | Stars: 196k | Updated | Claude CodeCodex | Verified | Install |