existential-birds/beagle / plugins/beagle-ios/skills/ios-animation-code-review
ios-animation-code-review
VerifiedReviews iOS animation code for correctness, performance, accessibility, and Apple API best practices. Use when reviewing .swift files containing animation code — withAnimation, .animation(), PhaseAnimator, KeyframeAnimator, matchedGeometryEffect, navigationTransition, CABasicAnimation, CASpringAnimation, UIViewPropertyAnimator, UIDynamicAnimator, symbolEffect, scrollTransition, contentTransition, or custom Transition conformances.
iOS Animation Code Review
Quick Reference
| Issue Type | Reference |
|---|---|
| Spring parameters, withAnimation misuse, phase/keyframe bugs | references/swiftui-animation-patterns.md |
| Frame drops, offscreen rendering, main thread blocking | references/performance.md |
| Reduce Motion, VoiceOver, motion sensitivity | references/accessibility.md |
| Transition protocol, matchedGeometryEffect, navigation transitions | references/transitions.md |
Hard gates (sequence)
Complete in order for the files in scope. If a step fails, omit the finding, re-anchor, or downgrade to a question—do not ship accusations without meeting the pass condition.
| Step | What you do | Pass condition (objective) |
|---|---|---|
| 1. Inventory | List each file under review and where animation APIs appear (line ranges or symbol names: withAnimation, .animation, matchedGeometryEffect, PhaseAnimator, UIKit/CA animators, etc.). | A written list exists; files with no animation APIs are explicitly marked out of scope. |
| 2. Anchor | Re-read the cited region in the current file or diff hunk before naming an issue. | Each [FILE:LINE] still shows the behavior; stale line numbers are fixed or the finding is dropped. |
| 3. Evidence | For framework-specific claims (spring curves, Transition conformance, Reduce Motion), cross-check the matching row in Quick Reference against references/*.md. | The finding’s detail names the reference file used, or states inline-only (structural/readability with no framework rule). |
| 4. Report | Emit findings using Output Format. | Headers match [FILE:LINE] ISSUE_TITLE; checklist items below are applied only where gates 1–2 covered that code. |
Output Format
Report each finding as:
[FILE:LINE] ISSUE_TITLE
Example: [AnimatedCard.swift:42] Missing Reduce Motion fallback for spring animation
All details, code suggestions, and rationale follow after the header line.
Review Checklist
-
@Environment(\.accessibilityReduceMotion)checked — animations have Reduce Motion fallback - Animation is not the sole feedback channel — important state changes pair with haptics (
.sensoryFeedback) or audio - Custom animation isn't duplicating system-provided motion (standard nav transitions, sheet presentation, SF Symbol effects)
- Animations on frequent interactions are brief and unobtrusive — or absent (system handles it)
- All animations are interruptible — user is never forced to wait for completion before interacting
- Spring animations use
duration/bounceparameters (not raw mass/stiffness/damping unless UIKit/CA) - No deprecated
.animation()withoutvalue:parameter -
withAnimationwraps state changes, not view declarations -
matchedGeometryEffectIDs are stable and unique within the namespace -
geometryGroup()used when parent geometry animates with child views appearing - Looping animations (
PhaseAnimator,symbolEffect) have finite phases or appropriate trigger - No
CATransaction.setAnimationDuration()in UIView-backed layers (use UIView.animate instead) - Interactive animations handle interruption (re-trigger mid-flight doesn't break state)
- Shadow animations provide explicit
shadowPath(avoids per-frame recalculation) - Gesture-driven animations preserve velocity on release for natural completion
- Gesture-driven feedback follows spatial expectations (dismiss direction matches reveal direction)
- No animation of
.id()modifier (destroys view identity — usetransitionormatchedGeometryEffectinstead)
When to Load References
- Incorrect spring setup or
withAnimationscope issues → swiftui-animation-patterns.md - Hitches, dropped frames, or expensive animations in scroll views → performance.md
- Missing Reduce Motion handling or motion accessibility → accessibility.md
matchedGeometryEffectglitches or customTransitionbugs → transitions.md
Review Questions
- Does every animation have a Reduce Motion fallback that preserves the information conveyed? Is animation the only feedback channel, or are haptics/audio supplementing it?
- Is this custom animation necessary, or does the system already provide it (standard transitions, SF Symbol effects, Liquid Glass)?
- Could this animation cause frame drops — is it animating expensive properties (blur, shadow without path, mask) in a list or scroll view?
- Are all animations interruptible? Can the user act without waiting for completion? Does gesture-driven feedback follow spatial expectations?
- Is
withAnimationscoped to the minimal state change needed, or is it wrapping unrelated mutations? - For
matchedGeometryEffect— are source and destination using the same ID and namespace, and is only one visible at a time?
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| brainstormingobra/superpowersYou MUST use this before any creative work - creating features, building components, adding functionality, modifying behavior, or planning anything new, in software or out of it (a talk, a business, a renovation). | Stars: 318k | Updated | Claude CodeCodex | Verified | Install |
| brand-guidelinesanthropics/skillsApplies Anthropic's official brand colors and typography to any sort of artifact that may benefit from having Anthropic's look-and-feel. Use it when brand colors or style guidelines, visual formatting, or company design standards apply. | Stars: 196k | Updated | Claude CodeCodex | Verified | Install |
| frontend-designanthropics/skillsGuidance for distinctive, intentional visual design when building new UI or reshaping an existing one. Helps with aesthetic direction, typography, and making choices that don't read as templated defaults. | Stars: 196k | Updated | Claude CodeCodex | Verified | Install |
| mcp-builderanthropics/skillsGuide for creating high-quality MCP (Model Context Protocol) servers that enable LLMs to interact with external services through well-designed tools. Use when building MCP servers to integrate external APIs or services, whether in Python (FastMCP) or Node/TypeScript (MCP SDK). | Stars: 196k | Updated | Claude CodeCodex | Verified | Install |