encero-systems/incan / .agents/skills/review-test-style
review-test-style
VerifiedReview touched tests and test-adjacent code for style, Result-returning patterns, panic helpers, unwrap/expect use, and obvious coverage gaps. Use when a broad review needs a dedicated test pass or when the user asks for test-review specifically.
Review Test Style — Incan Compiler
Purpose
/review-test-style is a narrow report-only reviewer for touched tests and code changes that imply missing test coverage.
Own:
- panic helpers and panic-style control flow in touched tests
- unwrap/expect in tests
- fallible tests not returning
Result - obvious missing targeted coverage for new behavior
Do not own:
- rustdoc prose
- docs truthfulness
- architecture
- final branch-clean judgment
Output artifact
Write a slice report at:
.agents/state/review-report.test-style.md
Do not write to the canonical .agents/state/review-report.md.
Workflow
- Review the touched tests and the code changes that should have tests.
- Flag:
.unwrap()/.expect()in testspanic!-driven helper/control flow whereResult+ assertions would be clearer- missing targeted tests for new CLI, lifecycle, or semantic behavior
- stale snapshots or missing integration coverage when behavior changed end-to-end
- Only flag a coverage gap when the new behavior or branch is not exercised anywhere in the touched tests. If integration coverage already exercises the behavior, do not demand redundant parser/unit duplication without a concrete reason.
- Keep this pass focused on test quality and coverage, not general code quality.
Slice report shape
Keep slice reports findings-first. Only list clean surfaces when they are materially useful to the orchestrator.
# Review Slice Report
- role: test-style
- worker: <agent-id or stable label>
- status: in_progress | clean | blocked
## Scope
- assigned files:
- loaves/toolchain/incan-cli/tests/integration_tests.rs
## Findings
- [ ] warning | test-gap | panic helper | loaves/toolchain/incan-cli/src/lib.rs:84
Test helper uses panic-oriented control flow instead of `Result` + assertions.
## Reviewed Clean Surfaces
- loaves/toolchain/incan-cli/tests/integration_tests.rs — touched lifecycle coverage reviewed; no additional findings
If there are no findings, say so explicitly.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the work | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixes | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation code | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy. | Stars: 198k | Updated | Claude CodeCodex | Verified | Install |