encero-systems/incan / .agents/skills/review-code-smells
review-code-smells
VerifiedReview touched code for maintainability smells such as duplication, awkward indirection, suspicious clones, dead code, poor naming, and Boy Scout cleanup opportunities. Use when a broad review needs a dedicated maintainability pass or when the user asks for code-smell review specifically.
Review Code Smells — Incan Compiler
Purpose
/review-code-smells is a file-focused report-only reviewer for local maintainability issues.
Own:
- duplication
- dead code
- awkward or unnecessary indirection
- suspicious clones
- poor naming in touched code
- touched-code cleanup opportunities that satisfy the Boy Scout rule
Do not own:
- architecture-level placement decisions
- docs truthfulness
- test style details
- final branch-clean judgment
Output artifact
Write a slice report at:
.agents/state/review-report.code-smells.md
Do not write to the canonical .agents/state/review-report.md.
Workflow
- Review the touched code files assigned by the orchestrator.
- Flag:
- duplicated branches or helpers
- no-op/unused/dead surfaces
- awkward APIs or naming in touched code
- needless complexity relative to the actual requirement
- Keep this pass practical. Do not invent refactors unrelated to the touched surface.
- Classify each finding as either:
maintainabilitydesign-tension- or
bugThis classification is for downstream handling only. It must not be used to hide the finding.
Slice report shape
Keep slice reports findings-first. Only list clean surfaces when that clean call is non-obvious or useful for the orchestrator.
# Review Slice Report
- role: code-smells
- worker: <agent-id or stable label>
- status: in_progress | clean | blocked
## Scope
- assigned files:
- loaves/toolchain/incan-cli/src/lib.rs
## Findings
- [ ] warning | maintainability | dead cli surface | loaves/toolchain/incan-cli/src/lib.rs:313
`--bin` is exposed publicly but has no effect.
## Reviewed Clean Surfaces
- loaves/toolchain/incan-cli/src/commands/init.rs — maintainability reviewed; no findings
If there are no findings, say so explicitly.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 319k | Updated | Claude CodeCodex | Verified | Install |