Skip to content

doncheli/don-cheli-sdd / .agent/skills/doncheli-review

doncheli-review

Verified

Perform strict 7-dimension peer review analyzing correctness, tests, performance, architecture, security, style, and diff cleanliness. Activate when user mentions "review", "revisar", "peer review", "code review", "check my code".

Don Cheli: 7-Dimension Peer Review

Dimensions

  1. Functional Correctness — All Gherkin P1/P2 scenarios implemented
  2. Tests & Coverage — Unit, integration, BDD tests pass; coverage >= 85%
  3. Performance — No N+1 queries, no unbounded queries, no O(n^2) where avoidable
  4. Architecture & Design — SOLID principles, separation of concerns, DI
  5. Security — Input validation, parameterized queries, no hardcoded secrets, auth on all protected endpoints
  6. Style & Conventions — Consistent naming, no unused imports/vars, no console.log
  7. Clean Diff — Only changes related to the feature

Adversarial Rule

You MUST find at least 1 concrete issue in every review. Zero findings triggers a mandatory second pass focused on: N+1 queries, race conditions, untested edge cases, sensitive data in logs, naming inconsistencies.

Output Format

For each finding: ID, severity (Critical/High/Medium/Low), file:line, description, suggested fix.

rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall