Skip to content

doncheli/don-cheli-sdd / .agent/skills/doncheli-pr-review

doncheli-pr-review

Verified

Perform a structured code review of a pull request aligned with SDD principles. Activate when user mentions "PR review", "pull request", "review PR", "code review", "review this diff".

Don Cheli: PR Review

Instructions

  1. Accept a PR number, URL, or diff as input
  2. Fetch the diff using gh pr diff <number> or read the provided diff
  3. Review in this sequence:
    • Spec alignment: does the code implement what the spec says? Flag any drift
    • Tests: are new behaviors covered? Is coverage maintained above 85%?
    • Code quality: complexity, duplication, naming, error handling
    • Security: OWASP Top 10 surface, secrets in code, input validation
    • Breaking changes: API contract changes, schema migrations, deprecations
  4. Categorize each finding: [blocker | warning | suggestion | nitpick]
  5. Blockers must be resolved before merge β€” list them prominently
  6. Never approve a PR with unresolved blockers
  7. Generate a structured review comment ready to post with gh pr review
  8. If spec docs are missing for a non-trivial feature, flag as a warning

Output Format

## PR Review β€” #142 "feat: add voice mode integration"

### Spec Alignment βœ…
All scenarios in specs/voice.feature are covered by the implementation.

### Blockers πŸ”΄
1. src/voice/transcriber.ts:34 β€” API key hardcoded. Must use env var VOICE_API_KEY.

### Warnings 🟑
1. src/voice/transcriber.ts β€” coverage 72%, below 85% threshold.
2. No migration doc for the new voice_sessions table.

### Suggestions 🟒
1. Consider extracting the cleanup logic at line 88 into a private method.

### Nitpicks
1. Line 12: typo "recieve" β†’ "receive"

### Verdict: CHANGES REQUESTED
Resolve 1 blocker before merging.
receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementationStars: 322kUpdated Claude CodeCodexVerifiedInstall
requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirementsStars: 322kUpdated Claude CodeCodexVerifiedInstall
using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallbackStars: 322kUpdated Claude CodeCodexVerifiedInstall
verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions alwaysStars: 322kUpdated Claude CodeCodexVerifiedInstall