Skip to content

ash1794/vibe-engineering / plugins/vibe-engineering/skills/vibe-concurrent-test-safety

vibe-concurrent-test-safety

Verified

Audits tests for concurrency safety — race conditions, shared mock state, cleanup ordering. Use when writing tests that involve goroutines, async operations, or shared mutable state.

vibe-concurrent-test-safety

Flaky tests are almost always concurrency bugs in the test, not the code.

When to Use This Skill

  • Writing tests that launch goroutines or async operations
  • Tests use shared mock objects accessed by multiple goroutines
  • Tests that fail intermittently ("flaky")
  • After adding -race flag and getting failures
  • Tests that involve daemon/server startup and shutdown

When NOT to Use This Skill

  • Purely synchronous tests with no concurrency
  • Tests that are already race-free (verified with -race flag)
  • Simple mock-based tests with single-threaded access

Common Concurrency Bugs in Tests

1. Direct Mock State Access

// BAD: Race condition -- mock.Requests accessed while goroutine writes
go daemon.Run(ctx)
time.Sleep(100 * time.Millisecond)
assert.Equal(t, 3, len(mock.Requests)) // RACE!

// GOOD: Thread-safe accessor
go daemon.Run(ctx)
time.Sleep(100 * time.Millisecond)
assert.Equal(t, 3, mock.RequestCount()) // Safe

2. Missing Context Cancellation Before Cleanup

// BAD: Close bus while daemon goroutine still using it
go daemon.Run(ctx)
defer bus.Close() // daemon may still be writing!

// GOOD: Cancel context first, wait, then cleanup
go daemon.Run(ctx)
defer func() {
    cancel()          // Signal daemon to stop
    <-daemon.Done()   // Wait for it
    bus.Close()        // Now safe
}()

3. Assertions on Timing

// BAD: Relies on timing
go startServer()
time.Sleep(50 * time.Millisecond) // May not be enough
resp := callServer()

// GOOD: Wait for readiness
go startServer()
waitForReady(server) // Poll or use channel
resp := callServer()

Audit Checklist

  • No direct access to shared mock fields (use accessors)
  • Context cancelled before resource cleanup
  • Goroutines joined before test ends (<-done or wg.Wait())
  • No time.Sleep for synchronization (use channels, waitgroups, or polling)
  • Assertions use Eventually or polling for async results
  • Test passes with -race flag
  • Test passes when run 100 times (-count=100)

Output Format

Concurrent Test Safety Audit: [Test File]

Issues Found: X

#IssueLineFix
1Direct mock access:42Use mock.RequestCount()
2Missing cancel before Close:15Add cancel() before defer

Suggested Fixes

[Code snippets for each fix]

rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall