xiduzo/wtf / skills/wtf.pr-review
wtf.pr-review
VerifiedThis skill should be used when a developer or tech lead wants to review a pull request for correctness, spec adherence, and code quality — for example "review PR
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 9.3 KB |
| evals/evals.json | config | 3.7 KB |
| evals/fixtures/missing-test-coverage.json | config | 6.4 KB |
| evals/fixtures/schema-drift.json | config | 4.6 KB |
| evals/fixtures/scope-creep.json | config | 6.6 KB |
evals/fixtures/schema-drift.json
View on GitHub{
"_note": "Fixture for eval 2 — diff implements the settlement status endpoint but returns wrong field names (id/value/state instead of settlementId/amount/status) and omits the required currency field. The Trace carries the Scenario Claim; the canonical scenario text lives in the Feature body.",
"trace": {
"number": 20,
"title": "☄️ Trace: Expose settlement status on payments API",
"labels": [{ "name": "trace" }, { "name": "designed" }],
"body": "## Story\n\n- As an **API Consumer**, I want **to fetch the settlement status for a payment** so that **I can show the payout state in my own system**\n\n## Scenario Claim\n\n- Scenario: Consumer fetches settlement status for a payment\n\n<details>\n<summary>Claimed scenarios — synced from Feature #18 — edit there, not here</summary>\n\n```gherkin\nScenario: Consumer fetches settlement status for a payment\n Given a payment with an associated settlement exists\n When the consumer calls GET /payments/:id/settlement\n Then the response contains the settlement details with status\n And the response shape matches the contract\n```\n\n</details>\n\n## Spine Position\n\n- Position: Skeleton\n- Builds on: —\n\n## Contracts & Interfaces\n\nGET /payments/:id/settlement response body:\n\n```typescript\n{\n settlementId: string;\n amount: number;\n currency: string;\n status: string;\n}\n```\n\n## Definition of Done\n\n- [ ] Endpoint returns correct shape as specified in Contracts\n- [ ] 404 returned when payment has no settlement\n- [ ] Integration test covers the happy path response shape\n- [ ] System releasable after merge"
},
"feature": {
"number": 18,
"title": "🚀 Feature: Payments API settlement visibility",
"body": "## User Stories\n\n### As an API Consumer, I want to fetch the settlement status for a payment so that I can show the payout state in my own system\n\n```gherkin\nScenario: Consumer fetches settlement status for a payment\n Given a payment with an associated settlement exists\n When the consumer calls GET /payments/:id/settlement\n Then the response contains the settlement details with status\n And the response shape matches the contract\n```\n\n## Trace Plan\n\n1. [ ] ☄️ Skeleton — Expose settlement status on payments API (claims: \"Consumer fetches settlement status for a payment\") — Trace #20\n"
},
"diff_stat": "2 files changed, 42 insertions(+), 1 deletion(-)",
"diff": "diff --git a/src/api/routes/payments.ts b/src/api/routes/payments.ts\nindex c1d2e3f..a4b5c6d 100644\n--- a/src/api/routes/payments.ts\n+++ b/src/api/routes/payments.ts\n@@ -1,6 +1,8 @@\n import { Router } from 'express';\n import { SettlementRepository } from '../../repositories/settlement';\n+import { PaymentRepository } from '../../repositories/payment';\n \n const router = Router();\n+const settlementRepo = new SettlementRepository();\n+const paymentRepo = new PaymentRepository();\n \n@@ -12,3 +14,22 @@ router.get('/:id', async (req, res) => {\n res.json(payment);\n });\n+\n+router.get('/:id/settlement', async (req, res) => {\n+ const payment = await paymentRepo.findById(req.params.id);\n+ if (!payment) {\n+ return res.status(404).json({ error: 'Payment not found' });\n+ }\n+\n+ const settlement = await settlementRepo.findByPaymentId(req.params.id);\n+ if (!settlement) {\n+ return res.status(404).json({ error: 'No settlement for this payment' });\n+ }\n+\n+ res.json({\n+ id: settlement.id,\n+ value: settlement.amount,\n+ state: settlement.status,\n+ // currency omitted\n+ });\n+});\n+\n export default router;\ndiff --git a/src/api/routes/payments.test.ts b/src/api/routes/payments.test.ts\nindex d2e3f4a..b5c6d7e 100644\n--- a/src/api/routes/payments.test.ts\n+++ b/src/api/routes/payments.test.ts\n@@ -1,5 +1,25 @@\n import request from 'supertest';\n import app from '../../app';\n+import { seedPaymentWithSettlement, clearDb } from '../../test-utils/db';\n \n describe('GET /payments/:id/settlement', () => {\n+ beforeEach(clearDb);\n+\n+ it('returns 404 when payment has no settlement', async () => {\n+ const res = await request(app)\n+ .get('/payments/unknown-id/settlement');\n+ expect(res.status).toBe(404);\n+ });\n+\n+ it('returns settlement details for a known payment', async () => {\n+ const { paymentId } = await seedPaymentWithSettlement({\n+ amount: 5000,\n+ currency: 'EUR',\n+ status: 'completed',\n+ });\n+\n+ const res = await request(app)\n+ .get(`/payments/${paymentId}/settlement`);\n+\n+ expect(res.status).toBe(200);\n+ expect(res.body.id).toBeDefined();\n+ expect(res.body.state).toBe('completed');\n+ });\n });\n"
}
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness. | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependencies | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is available | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |