Skip to content

tanviet12/vbsec / skills/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. Auto-delegates to sub-agents for large scans (>20 main-language files OR >30 total OR >14 days). Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md36.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review.mdmarkdown10.5 KB
workflows/small-review.mdmarkdown10.1 KB

rules/languages/dart/10-path-traversal.md

View on GitHub
---
id: PATH-TRAVERSAL
severity_max: HIGH
applies_to: dart
overrides: generic/10-path-traversal.md
---

# Path Traversal — Dart / Flutter (đường dẫn điều hướng và đường dẫn file)

> Override cho `rules/generic/10-path-traversal.md` khi `primary_language: dart`. Backend Dart (`shelf`, `shelf_static`, `dart_frog`) đọc file theo tham số request → áp nguyên logic generic (`File(p.join(base, req.params['f']))` thiếu kiểm prefix sau `p.canonicalize`).

## Intent (Flutter-specific)

Ở app Flutter có hai loại "đường dẫn" nhận dữ liệu ngoài:

1. **Đường dẫn điều hướng**: giá trị từ payload push (`message.data['transaction_id']`) hay deep link ghép thẳng vào `context.go('/transaction/$id')`, `GoRouter.go`, `Navigator.pushNamed('/x/$id')`. Giá trị chứa `/`, `?`, `#`, `..` đổi luôn route đích: mở màn khác, chèn query, nhảy vào route debug. Nguồn push là server của mình, nhưng ai có FCM server key / backend bị lạm dụng cũng gửi được; nguồn deep link thì app hay trang web bất kỳ gửi được.
2. **Đường dẫn file**: tên file lấy từ dữ liệu ngoài ghép vào `File('${dir.path}/$name')`: entry trong zip người dùng chọn (ZipSlip), tên file trong payload / response, file chia sẻ từ app khác (`receive_sharing_intent`). `../` ghi đè file của app (cấu hình, database, token fallback).

## Khi nào HIGH

- ZipSlip: giải nén archive từ nguồn ngoài (file người dùng chọn, tải từ URL ngoài) bằng `package:archive`, ghi `File('${out}/${file.name}')` mà không kiểm đường dẫn sau chuẩn hoá nằm trong thư mục đích. `archive` < 3.3.8 còn có CVE path traversal riêng (xem OUTDATED-DEPENDENCY).
- Tên file từ deep link / file chia sẻ / clipboard ghép vào đường dẫn ghi hoặc xoá file.

## Khi nào MEDIUM

- Tham số deep link (`state.pathParameters`, `state.uri.queryParameters`, `uriLinkStream`) ghép vào đường dẫn điều hướng khác mà không lọc định dạng.
- Tên file từ response API ghép vào đường dẫn ghi file.

## Khi nào LOW

- Giá trị từ **payload push** ghép vào đường dẫn điều hướng mà không lọc định dạng (nguồn là server của mình, cần lạm dụng quyền gửi). Vẫn là finding: thiếu kiểm định dạng ở cửa vào.

## Khi nào KHÔNG tạo finding

- Giá trị đã lọc theo **đúng định dạng id trong tài liệu API** trước khi ghép: `RegExp(r'^[0-9a-f-]{36}$')`, `int.tryParse` (khi id là số), `Uri.encodeComponent`. Chú ý lọc phải khớp định dạng thật: đoán "chỉ số" trong khi API dùng UUID làm hỏng tính năng, gợi ý sửa phải dẫn tài liệu API.
- Truyền qua `extra:` / `pathParameters:` của `goNamed` (go_router tự encode) thay vì nối chuỗi.
- Tên file do app đặt (hằng số, `DateTime.now()`, `Uuid().v4()`).
- Check viết sai (`contains('..')` trước khi decode, `startsWith(base)` không có `/` cuối) **vẫn là finding**, hạ severity, nêu cách bypass.

## Cách reasoning

1. Grep sink điều hướng (`context.go(`, `context.push(`, `.go('/`, `pushNamed(`) có nội suy `$` / `+`; grep sink file (`File(`, `Directory(`, `p.join(`, `writeAsBytes`, `extractArchiveToDisk`, `ZipDecoder`).
2. Lần ngược biến về nguồn: `RemoteMessage.data`, `getInitialMessage`, `onMessageOpenedApp`, `NotificationResponse.payload`, `GoRouterState`, `app_links`, `receive_sharing_intent`, `FilePicker`, `ArchiveFile.name`.
3. Có lọc định dạng / chuẩn hoá ở **mọi** đường vào không (thường có 2-3 đường: app đang mở, app ở nền, app mở từ noti lúc tắt)? Một đường lọc, đường khác không → finding ở đường thiếu.
4. ZipSlip: có `p.normalize(p.join(out, name))` rồi `p.isWithin(out, dest)` không?

## Search patterns (gợi ý — dùng Grep tool)

```
context\.(go|push|replace|pushReplacement)\s*\(\s*['"][^'"]*\$
\.go\s*\(\s*['"]/[^'"]*\$\{?\w*(id|Id|data)
pushNamed\s*\(\s*['"][^'"]*\$
message\.data\[\s*['"]\w+['"]\s*\]
(getInitialMessage|onMessageOpenedApp|onDidReceiveNotificationResponse)
state\.(pathParameters|uri\.queryParameters|queryParameters)
File\s*\(\s*['"]\$\{?\w+(\.path)?\}?/\$
ZipDecoder\(\)\.decode|extractArchiveToDisk|extractFileToDisk|ArchiveFile
```

## Examples

### HIGH — flag

```dart
// ZipSlip: entry "../../shared_prefs/FlutterSharedPreferences.xml" ghi đè dữ liệu app
final archive = ZipDecoder().decodeBytes(await picked.readAsBytes());
for (final f in archive.files) {
  final out = File('${dir.path}/${f.name}');
  await out.create(recursive: true);
  await out.writeAsBytes(f.content as List<int>);
}
```

### LOW — flag

```dart
// transaction_id từ push ghép thẳng vào route
FirebaseMessaging.onMessageOpenedApp.listen((m) {
  router.go('/transaction/${m.data['transaction_id']}');
});
```

### NOT flag

```dart
// Lọc theo định dạng id của API (UUID hoặc số cũ), sai thì không mở màn nào
String? safeTransactionId(Object? raw) =>
    raw is String && RegExp(r'^[A-Za-z0-9-]{1,64}$').hasMatch(raw) ? raw : null;

final id = safeTransactionId(message.data['transaction_id']);
if (id != null && mounted) context.go('/transaction/$id');
```

```dart
final dest = p.normalize(p.join(dir.path, f.name));
if (!p.isWithin(dir.path, dest)) continue;   // bỏ entry thoát khỏi thư mục đích
```

## Fix recommendation

1. Một hàm lọc dùng chung cho mọi đường vào (push lúc mở, lúc nền, lúc tắt; deep link), lọc theo định dạng id **trong tài liệu API**; không khớp thì bỏ, không điều hướng.
2. Dùng `goNamed(..., pathParameters: {'id': id})` thay vì nối chuỗi.
3. Listener mở màn từ noti (`eventBus.on<...>().listen`, `onMessageOpenedApp.listen`) giữ `StreamSubscription`, `cancel()` ở `dispose()`, kiểm `mounted` sau `await`.
4. Giải nén: `p.isWithin` sau `p.normalize`, bỏ entry symlink, nâng `archive` ≥ 3.3.8.
5. Tên file ngoài: chỉ giữ `[A-Za-z0-9._-]`, hoặc tự đặt tên.

## Cross-references

- `12-broken-access-control` (Dart): deep link exported không dùng.
- `03-xss` (Dart): giá trị push / deep link dùng làm URL mở WebView / trình duyệt.
- `20-outdated-dependency` (Dart): `archive` < 3.3.8.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall