Skip to content

tanviet12/vbsec / skills/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. Auto-delegates to sub-agents for large scans (>20 main-language files OR >30 total OR >14 days). Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md36.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review.mdmarkdown10.5 KB
workflows/small-review.mdmarkdown10.1 KB

rules/languages/dart/03-xss.md

View on GitHub
---
id: XSS
severity_max: HIGH
applies_to: dart
overrides: generic/03-xss.md
---

# XSS / Mở URL không tin cậy — Dart / Flutter

> Override cho `rules/generic/03-xss.md` khi `primary_language: dart`.

## Intent (Flutter-specific)

Widget Flutter (`Text`, `RichText`) không thông dịch HTML, nên XSS kiểu web chỉ xuất hiện ở ba chỗ:

1. **WebView** (`webview_flutter`, `flutter_inappwebview`): nạp URL hoặc HTML lấy từ dữ liệu ngoài. Trang lạ chạy JavaScript trong WebView của app; nếu app mở `JavaScriptChannel` / `addJavaScriptHandler`, tiêm token vào header / cookie / `runJavaScript`, trang đó gọi được hàm native hoặc lấy token.
2. **Mở URL** (`url_launcher` `launchUrl` / `launch`, `Navigator` sang màn WebView) với URL từ payload push, deep link, response API, nội dung người dùng khác nhập: mở trang lừa đảo trong ngữ cảnh "app ngân hàng gửi", hoặc scheme nguy hiểm (`javascript:`, `intent:`, `file:`, `tel:`/`sms:` tự quay số).
3. **Flutter Web**: `dart:html` / `package:web` `innerHtml`, `setInnerHtml(..., treeSanitizer: NodeTreeSanitizer.trusted)`, `HtmlElementView`. Áp như XSS DOM của generic.

Render HTML bằng `flutter_html` / `flutter_widget_from_html` không chạy script, nhưng `onLinkTap` → `launchUrl(url)` quay về loại 2.

## Khi nào HIGH

- WebView nạp URL / HTML từ L1 (push, deep link, clipboard, nội dung người dùng khác) với `JavaScriptMode.unrestricted` và có `addJavaScriptChannel` / `addJavaScriptHandler` / tiêm token.
- `loadHtmlString` / `loadData` với HTML ghép từ dữ liệu ngoài, JS bật.
- Flutter Web: `innerHtml =` / `NodeTreeSanitizer.trusted` với dữ liệu L1.

## Khi nào MEDIUM

- `launchUrl(Uri.parse(x))` với `x` từ payload push / deep link / response API mà không whitelist scheme + host.
- WebView nạp URL ngoài không whitelist, JS bật, không có channel / token (rủi ro lừa đảo trong khung app).
- `onNavigationRequest` luôn trả `NavigationDecision.navigate` cho WebView đang có channel.

## Khi nào KHÔNG tạo finding

- URL là hằng số trong code (trang điều khoản, hỗ trợ, `app-settings:`).
- Đã whitelist: `uri.scheme == 'https' && allowedHosts.contains(uri.host)` trước khi mở / nạp.
- Mở bằng trình duyệt ngoài (`LaunchMode.externalApplication`) với URL https đã whitelist host.
- Màn quên mật khẩu mở `SFSafariViewController` / Custom Tabs (`LaunchMode.inAppBrowserView`) thay vì WebView: app không đọc được mật khẩu người dùng gõ. Đây là cách đúng.

## Cách reasoning

1. Grep `WebViewController`, `InAppWebView`, `loadRequest`, `loadHtmlString`, `launchUrl`, `launch(`, `canLaunchUrl`, `innerHtml`.
2. Lần URL / HTML về nguồn (xem `data-flow-classification.md` mục "App di động"). Response API của chính backend là L2: chỉ thành L1 khi field đó do người dùng khác nhập (mô tả, ghi chú, link người dùng dán).
3. Kiểm whitelist scheme + host **sau** `Uri.parse` (không kiểm bằng `startsWith('https://shop.vn')`: `https://shop.vn.evil.com` vẫn qua; check viết sai vẫn là finding).
4. WebView: liệt kê channel / handler và thứ chúng làm (đọc token? gọi API? mở camera?).

## Search patterns (gợi ý — dùng Grep tool)

```
(launchUrl|launchUrlString|launch)\s*\(\s*Uri\.parse\s*\(\s*(?!['"])
loadRequest\s*\(\s*Uri\.parse\s*\(\s*(?!['"])
loadHtmlString\s*\(|loadData\s*\(
setJavaScriptMode\s*\(\s*JavaScriptMode\.unrestricted
addJavaScriptChannel|addJavaScriptHandler|evaluateJavascript|runJavaScript
NavigationDecision\.navigate
startsWith\s*\(\s*['"]https?://           # whitelist viết sai
\.innerHtml\s*=|setInnerHtml|NodeTreeSanitizer\.trusted
```

## Examples

### HIGH — flag

```dart
// URL từ deep link /help?u=... nạp vào WebView có channel trả token
final controller = WebViewController()
  ..setJavaScriptMode(JavaScriptMode.unrestricted)
  ..addJavaScriptChannel('App', onMessageReceived: (m) {
    controller.runJavaScript('onToken("${session.token}")');
  })
  ..loadRequest(Uri.parse(widget.url));
```

### MEDIUM — flag

```dart
// Link trong payload push mở thẳng
FirebaseMessaging.onMessageOpenedApp.listen((m) {
  final link = m.data['link'];
  if (link != null) launchUrl(Uri.parse(link));
});
```

### NOT flag

```dart
const _allowed = {'example.com', 'help.example.com'};
final uri = Uri.tryParse(link ?? '');
if (uri != null && uri.scheme == 'https' && _allowed.contains(uri.host)) {
  await launchUrl(uri, mode: LaunchMode.externalApplication);
}
```

## Fix recommendation

1. Whitelist scheme `https` + host cố định sau `Uri.tryParse`; không khớp thì bỏ.
2. WebView chỉ nạp host của mình; `onNavigationRequest` chặn host lạ (mở ra trình duyệt ngoài); không tiêm token vào trang, không mở channel trả dữ liệu nhạy cảm.
3. Trang đăng nhập / quên mật khẩu bên thứ ba: `LaunchMode.inAppBrowserView` hoặc trình duyệt ngoài, không WebView.
4. Flutter Web: dùng `Text` hoặc sanitize trước khi gán HTML.

## Cross-references

- `10-path-traversal` (Dart): cùng nguồn push / deep link ghép vào route.
- `12-broken-access-control` (Dart): deep link exported là cửa vào của chuỗi lỗi này.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall