Skip to content

tanviet12/vbsec / skills/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. Auto-delegates to sub-agents for large scans (>20 main-language files OR >30 total OR >14 days). Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md36.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review.mdmarkdown10.5 KB
workflows/small-review.mdmarkdown10.1 KB

rules/generic/16-unrestricted-file-upload.md

View on GitHub
---
id: UNRESTRICTED-FILE-UPLOAD
severity_max: CRITICAL
applies_to: all
---

# Unrestricted File Upload

## Intent

Endpoint upload không validate → hacker upload `shell.php` vào thư mục webroot, sau đó browse `https://yourapp.com/uploads/shell.php?cmd=cat+/etc/passwd` → **RCE (remote code execution)** chiếm server. Hoặc upload `evil.svg` chứa JavaScript → XSS khi user khác xem. Hoặc upload file siêu lớn → out-of-disk DoS.

Vibe coder dùng `multer` / `formidable` / `move_uploaded_file` mà không check extension, content-type, magic bytes, và lưu thẳng vào public folder.

## Khi nào CRITICAL

- Upload endpoint **không validate** extension HOẶC content-type
- File lưu trong webroot (thư mục được serve trực tiếp như `/public`, `/static`, `/uploads`) **và** server execute được code (PHP, JSP, etc.)
- Filename giữ nguyên từ client → path traversal (`../../etc/passwd`)
- Không giới hạn size → DoS

## Khi nào HIGH (giảm cấp)

- Có check extension nhưng dựa vào client-supplied `filename` (dễ bypass)
- File lưu trong static folder nhưng server không execute (Node serving static, không có handler PHP) — vẫn risk XSS qua SVG/HTML
- Có content-type check nhưng dùng client-supplied header (giả mạo dễ)

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** tìm upload handler theo framework
2. **Read** handler:
   - Có whitelist extension không? List nào? (PHP, JSP, ASPX phải block)
   - Có check magic bytes (file signature) không?
   - Filename: dùng client-supplied hay generate random?
   - Lưu vào đâu? Webroot? Static-served folder?
3. **Trace**:
   - L1: `req.file`, `request.FILES`, `$_FILES`
   - File đi đâu? Có serve lại public không?
4. **Server execution context**: PHP/Apache execute mọi file `.php`. Nginx serve tĩnh đa số an toàn (nhưng SVG vẫn XSS được).

## Search patterns (gợi ý — KHÔNG chạy literal, dùng Grep tool)

### Node.js

```
require\s*\(\s*["']multer["']
multer\s*\(\s*\{
formidable
fs\.(writeFile|writeFileSync|createWriteStream)\s*\(.*req\.
```

### Python

```
# Django
forms\.FileField|FileField\(
request\.FILES\[
# Flask
request\.files\[
# secure_filename — nếu KHÔNG dùng → flag
secure_filename
```

### PHP

```
\$_FILES\[
move_uploaded_file\s*\(
file_put_contents\s*\(.*\$_(FILES|POST)
```

### Generic

```
upload|Upload|UPLOAD
saveAs|save_as|writeFile
multipart/form-data
```

## Examples

### CRITICAL — flag

```javascript
// Express + multer — không filter
const multer = require('multer');
const upload = multer({ dest: 'public/uploads/' });  // webroot!
app.post('/upload', upload.single('file'), (req, res) => {
  res.json({ url: '/uploads/' + req.file.filename });
});
// User upload shell.php → GET /uploads/shell.php execute trên Apache/Nginx+PHP
```

```php
// PHP — giữ nguyên filename, không check
<?php
$target = "uploads/" . basename($_FILES["file"]["name"]);
move_uploaded_file($_FILES["file"]["tmp_name"], $target);
// upload evil.php → uploads/evil.php execute
?>
```

```python
# Flask — dùng filename từ client
@app.route('/upload', methods=['POST'])
def upload():
    f = request.files['file']
    f.save(os.path.join('static/uploads', f.filename))   # path traversal + no extension check
    return 'OK'
```

```python
# Django form không validate
class UploadForm(forms.Form):
    file = forms.FileField()   # accept tất cả
# view: f = form.cleaned_data['file']; save_to('public/', f.name)
```

### NOT critical — không flag

```javascript
// multer với fileFilter + random filename + storage ngoài webroot
const upload = multer({
  dest: '/var/app/uploads/',   // KHÔNG trong public
  limits: { fileSize: 5 * 1024 * 1024 },
  fileFilter: (req, file, cb) => {
    const allowed = ['image/jpeg', 'image/png'];
    cb(null, allowed.includes(file.mimetype));
  },
  filename: (req, file, cb) => {
    cb(null, crypto.randomUUID() + path.extname(file.originalname));
  }
});
// + Đọc magic bytes sau khi upload để confirm thật là image
```

```python
# Django — kiểm tra extension + content-type + magic
from django.core.exceptions import ValidationError
def validate_image(f):
    if f.content_type not in ['image/jpeg', 'image/png']:
        raise ValidationError('Invalid type')
    if f.size > 5_000_000:
        raise ValidationError('Too big')
    # check magic
    head = f.read(8); f.seek(0)
    if not (head.startswith(b'\xff\xd8') or head.startswith(b'\x89PNG')):
        raise ValidationError('Magic mismatch')
```

## Fix recommendation

1. **Whitelist extension** (allow list, không deny list):
   ```javascript
   const ALLOWED = new Set(['.jpg', '.jpeg', '.png', '.webp']);
   const ext = path.extname(file.originalname).toLowerCase();
   if (!ALLOWED.has(ext)) throw new Error('extension not allowed');
   ```
2. **Verify magic bytes** (file signature) — đừng tin extension/content-type:
   ```python
   import magic
   mime = magic.from_buffer(f.read(2048), mime=True); f.seek(0)
   if mime not in ALLOWED_MIME: raise
   ```
3. **Random filename**, không giữ filename client:
   ```javascript
   const safeName = crypto.randomUUID() + ext;
   ```
4. **Lưu ngoài webroot**, serve qua signed URL hoặc proxy controller:
   ```
   /var/app/uploads/  (filesystem)
   → GET /files/:id  → controller check auth → stream file
   ```
5. **Giới hạn size** ở middleware (`limits`, `client_max_body_size`)
6. **Object storage** (S3, GCS, R2): upload thẳng lên bucket, không qua server. Set bucket non-public.
7. **Scan virus** với ClamAV nếu user public (tải về xem được).
8. **Disable execution** trong upload folder: `.htaccess` `RemoveHandler .php` hoặc Nginx `location ~ \.php$ { return 403; }`

## Cross-references

- Cross-check với `04-path-traversal` (nếu có): filename `../../etc/passwd`
- Cross-check với `12-broken-access-control`: ai cũng upload được, hay chỉ user?
- Cross-check với `18-missing-rate-limit`: upload spam = DoS disk
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall