Skip to content

tanviet12/vbsec / skills/codex/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.8 KB
VERSIONother6 B
agents/openai.yamlconfig313 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.9 KB
workflows/small-review.mdmarkdown10.1 KB

rules/languages/go/08-insecure-deserialization.md

View on GitHub
---
id: INSECURE-DESERIALIZATION
severity_max: HIGH
applies_to: go
---

# Insecure Deserialization (Go)

## Intent

Go không có "magic method RCE" như PHP/Python pickle, nhưng vẫn có những sink nguy hiểm khi deserialize **data từ L1 (request body, file upload, cookie)**:

- `encoding/gob.NewDecoder().Decode()` — cho phép tạo bất kỳ struct nào registered. Nếu attacker control nguồn → có thể trigger `init()`-style side effects qua type assertions, hoặc tạo struct gây panic / DoS.
- `gopkg.in/yaml.v2 / v3` — historical CVE (yaml.v2 < 2.2.4 có DoS qua billion laughs / deeply nested). `Unmarshal` interface{} là vector ưa thích.
- `encoding/json.Unmarshal` vào `interface{}` rồi type assert — không phải RCE nhưng dễ panic / logic bypass.
- Custom binary protocol decode (msgpack, protobuf vào interface{}) — rủi ro tương tự gob.

## Khi nào HIGH

- `gob.NewDecoder(req.Body).Decode(&x)` nơi `x` là `interface{}` hoặc struct chứa `interface{}`
- `yaml.Unmarshal(userBytes, &cfg)` với userBytes từ request hoặc file upload, dùng yaml.v2 cũ
- `json.Unmarshal(body, &map[string]interface{}{})` rồi access field qua type assertion không check ok pattern → panic-able

## Khi nào MEDIUM (giảm cấp)

- Decode vào struct cụ thể (`type Req struct {...}`) với field cố định — Go ép schema, attacker chỉ control giá trị, không tạo type mới
- yaml.v3 (≥ 3.0.0) đã fix billion laughs
- Có size limit (`http.MaxBytesReader`) trước decode

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** sinks: `gob.NewDecoder`, `yaml.Unmarshal`, `yaml.NewDecoder`, `json.NewDecoder`, `msgpack.Unmarshal`, `proto.Unmarshal`
2. **Read** call site: target type là struct cụ thể hay `interface{}`?
3. **Trace L1**:
   - `r.Body`, `c.Request.Body` (gin), `c.BodyParser` (fiber), `multipart.File` (upload) → L1
   - File từ disk được upload trước đó → L1 dù gián tiếp
   - File từ embedded FS / config local → L3, safe
4. **Verify**: có `io.LimitReader` / `http.MaxBytesReader` bao quanh không? Có catch panic không?
5. Check **dependency version**: `go.mod` có yaml.v2 < 2.2.4 → HIGH.

## Search patterns (Go-specific)

```
# encoding/gob
gob\.NewDecoder\s*\(
\.Decode\s*\(\s*&?\s*\w+\s*\)

# yaml
yaml\.Unmarshal\s*\(
yaml\.NewDecoder\s*\(
gopkg\.in/yaml\.v2                    # check go.mod

# json into interface{}
json\.Unmarshal\s*\([^,]+,\s*&\w*[Mm]ap\w*\)
json\.Unmarshal\s*\([^,]+,\s*&interface\{\}
json\.NewDecoder\s*\(.+\)\.Decode\s*\(\s*&\w*interface

# msgpack / proto / cbor
msgpack\.Unmarshal\s*\(
proto\.Unmarshal\s*\(
cbor\.Unmarshal\s*\(
```

## Examples

### HIGH — flag

```go
// gob từ request body — attacker control type
func handler(w http.ResponseWriter, r *http.Request) {
    var payload interface{}
    gob.NewDecoder(r.Body).Decode(&payload)  // BAD: interface{} + L1
}
```

```go
// yaml.v2 cũ + L1
import "gopkg.in/yaml.v2"  // check go.mod version
func upload(c *gin.Context) {
    file, _ := c.FormFile("config")
    f, _ := file.Open()
    data, _ := io.ReadAll(f)
    var cfg map[string]interface{}
    yaml.Unmarshal(data, &cfg)  // BAD: yaml.v2 + interface{} map
}
```

```go
// json interface{} + type assertion không check
var m map[string]interface{}
json.NewDecoder(r.Body).Decode(&m)
name := m["name"].(string)  // panic nếu attacker gửi name là số → DoS
```

### NOT critical — safer

```go
// Struct cụ thể — Go ép schema
type CreateUserReq struct {
    Name  string `json:"name"`
    Email string `json:"email"`
}
var req CreateUserReq
if err := json.NewDecoder(http.MaxBytesReader(w, r.Body, 1<<20)).Decode(&req); err != nil {
    http.Error(w, "bad", 400)
    return
}
// req fields chỉ là string, attacker không tạo type mới được
```

```go
// yaml.v3 + size limit
import "gopkg.in/yaml.v3"
data, _ := io.ReadAll(io.LimitReader(r.Body, 64<<10))
var cfg Config  // struct cụ thể
yaml.Unmarshal(data, &cfg)  // OK
```

## Fix recommendation

1. **Tránh `gob` với input từ L1.** Gob được thiết kế cho IPC giữa Go service tin cậy, KHÔNG cho input untrusted.
2. **Decode vào struct cụ thể**, không dùng `interface{}` / `map[string]interface{}` trừ khi thực sự cần (vd: webhook generic).
3. **Upgrade yaml.v2 → yaml.v3** (`go get gopkg.in/yaml.v3`). Update import.
4. **Wrap input với `http.MaxBytesReader` hoặc `io.LimitReader`** để chống DoS.
5. **Recover panic** trong handler (middleware `recover.New()` của fiber, hoặc tự viết) — nhưng đây chỉ là band-aid, sửa gốc bằng type assertion `v, ok := x.(string)`.
6. **Không decode vào unexported field** từ untrusted source.

## Cross-references

- Rule `20-outdated-dependency`: check go.mod cho `yaml.v2 < 2.2.4`, `protobuf < 1.3.2` (CVE)
- Rule `17-verbose-error-debug-mode`: panic stack trace leak qua response nếu chưa recover
- Rule `07-mass-assignment`: cùng họ "decode L1 vào struct" nhưng nhắm field-level (Role, IsAdmin)
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall