Skip to content

tanviet12/vbsec / skills/codex/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.8 KB
VERSIONother6 B
agents/openai.yamlconfig313 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.9 KB
workflows/small-review.mdmarkdown10.1 KB

rules/generic/13-weak-password-hashing.md

View on GitHub
---
id: WEAK-PASSWORD-HASHING
severity_max: CRITICAL
applies_to: all
---

# Weak Password Hashing

## Intent

Lưu password dưới dạng plain text, MD5, SHA1, hoặc SHA256 không salt. Khi DB bị leak (mà DB **luôn luôn bị leak** sớm muộn), hacker dùng **rainbow table** crack MD5/SHA1 trong vài giây — toàn bộ password user bị lộ. User thường dùng cùng password cho nhiều site, nên leak DB của bạn = leak Gmail/bank của họ.

Password phải hash bằng **bcrypt / argon2 / scrypt** với cost factor đủ cao (chậm có chủ đích để chống brute-force GPU).

## Khi nào CRITICAL

- Password lưu plain text (so sánh `==` không qua hash)
- Hash bằng MD5 / SHA1 / SHA256 / SHA512 thô (không salt, không slow KDF)
- Custom hash `sha256(salt + password)` — vẫn nhanh, GPU crack được
- Salt hardcoded chung cho mọi user (`salt = "mysalt"`)
- bcrypt cost factor quá thấp (`bcrypt.hashSync(pwd, 4)` — nên ≥ 10)

## Khi nào HIGH (giảm cấp)

- bcrypt cost 8-9 (chấp nhận được nhưng nên tăng)
- Hash bằng PBKDF2 với iteration count < 100k (nên ≥ 600k theo OWASP 2023)
- Dùng SHA256 nhưng có HMAC + per-user salt (vẫn yếu hơn argon2 nhưng đỡ)

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** tìm pattern hash crypto liên quan đến password
2. **Read** đoạn signup/login để xác nhận:
   - Variable name có chứa `password`, `pwd`, `pass` không?
   - Function được gọi để **hash khi register** và **verify khi login**?
3. **Trace**:
   - L1: password user nhập (plain)
   - Phải qua hashing function → L4 (lưu vào DB)
   - Nếu compare `password == user.password` (plain) → CRITICAL
4. **Đặc biệt**: kiểm tra password reset flow — nhiều khi register dùng bcrypt nhưng reset password lại lưu plain

## Search patterns (gợi ý — KHÔNG chạy literal, dùng Grep tool)

### Hash functions yếu

```
# Node.js
crypto\.createHash\s*\(\s*["'](md5|sha1|sha256|sha512)["']
require\s*\(\s*["']md5["']\s*\)

# Python
hashlib\.(md5|sha1|sha256|sha512)\s*\(
import\s+md5

# PHP
\bmd5\s*\(|\bsha1\s*\(|hash\s*\(\s*["'](md5|sha1|sha256)["']

# Go
md5\.Sum|sha1\.Sum|sha256\.Sum

# Ruby
Digest::(MD5|SHA1|SHA256)\.hexdigest
```

### Password-specific

```
password\s*==\s*       # so sánh plain text
\.password\s*=\s*req\.body\.password   # lưu plain
```

### Hash KDF tốt (KHÔNG flag)

```
bcrypt\.(hash|compare|hashSync|compareSync)
argon2\.(hash|verify)
scrypt\.|crypto\.scrypt
PasswordHasher|werkzeug\.security\.(generate_password_hash|check_password_hash)
Devise|BCrypt::Password
password_hash\s*\(\s*\$?\w+,\s*PASSWORD_(DEFAULT|BCRYPT|ARGON2)
```

## Examples

### CRITICAL — flag

```javascript
// Express signup — MD5
const crypto = require('crypto');
const hash = crypto.createHash('md5').update(req.body.password).digest('hex');
await db.users.insert({ email, password: hash });
```

```python
# Django custom user — SHA256 thô
import hashlib
def set_password(self, raw):
    self.password = hashlib.sha256(raw.encode()).hexdigest()
```

```php
// Login — plain text compare
$user = $db->query("SELECT * FROM users WHERE email='$email'")->fetch();
if ($user['password'] === $_POST['password']) {  // plain text
    $_SESSION['user'] = $user;
}
```

```python
# Salt hardcoded chung cho mọi user
SALT = "myapp_salt_2024"
hash = hashlib.sha256((SALT + password).encode()).hexdigest()
```

### NOT critical — không flag

```javascript
// bcrypt với cost mặc định 10
const bcrypt = require('bcrypt');
const hash = await bcrypt.hash(password, 12);
// login:
const ok = await bcrypt.compare(req.body.password, user.password);
```

```python
# Django dùng built-in (PBKDF2 với iteration cao)
from django.contrib.auth.hashers import make_password, check_password
user.password = make_password(raw_password)
```

```python
# argon2 — recommended
from argon2 import PasswordHasher
ph = PasswordHasher()
hash = ph.hash(password)
ph.verify(hash, password)
```

## Fix recommendation

1. **Chuyển sang bcrypt / argon2 / scrypt** với cost phù hợp:
   ```javascript
   // Node.js
   const bcrypt = require('bcrypt');
   const hash = await bcrypt.hash(password, 12);  // cost 12, ~250ms
   ```
   ```python
   # Python
   from argon2 import PasswordHasher
   ph = PasswordHasher(time_cost=3, memory_cost=65536, parallelism=4)
   ```
   ```php
   // PHP — built-in
   $hash = password_hash($pwd, PASSWORD_ARGON2ID);
   password_verify($pwd, $hash);
   ```
2. **Migration cho user cũ**: lúc user login lần kế tiếp, re-hash với algorithm mới và update DB. Không cần force reset password.
3. **Per-user random salt** — các thư viện trên tự sinh và lưu kèm hash (không cần tự làm).
4. **Cost calibration**: chọn cost sao cho hash mất ~250ms trên server production (cân bằng UX vs anti-brute-force).
5. **Pepper** (tùy chọn): thêm secret server-side ngoài salt — leak DB không đủ crack, cần leak cả config.

## Cross-references

- Cross-check với `01-hardcoded-secret`: pepper / encryption key cho password store
- Cross-check với `12-broken-access-control`: leak password list qua admin endpoint không có auth
- Cross-check với `06-brute-force-login` (nếu có rule): rate-limit login endpoint
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall