Skip to content

tanviet12/vbsec / skills/codex/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.8 KB
VERSIONother6 B
agents/openai.yamlconfig313 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.9 KB
workflows/small-review.mdmarkdown10.1 KB

rules/generic/08-insecure-deserialization.md

View on GitHub
---
id: INSECURE-DESERIALIZATION
severity_max: CRITICAL
applies_to: all
---

# Insecure Deserialization

## Intent

Code dùng `pickle.loads`, `yaml.load`, `eval`, `unserialize`, `ObjectInputStream`, `BinaryFormatter` trên dữ liệu user-controlled (L1). Các API này có thể **chạy code tùy ý khi deserialize** — attacker gửi payload đặc chế là **RCE ngay trên server**, lấy shell, đọc env, chiếm DB.

Đây không phải "lỗi nhỏ" — là **Remote Code Execution thẳng**, không cần leo thang. Vibe code dính khi AI sinh code "tiện nhanh" với `pickle` hoặc `yaml.load` mặc định (không safe loader).

## Khi nào CRITICAL

- L1 input (request body, cookie, query, file upload, message queue payload) đi vào: `pickle.loads`, `pickle.load`, `cPickle.loads`, `yaml.load` (không có `Loader=SafeLoader`), `marshal.loads`, `eval`, `exec`, `unserialize` (PHP), `ObjectInputStream` (Java), `BinaryFormatter.Deserialize` / `SoapFormatter` / `NetDataContractSerializer` (.NET), `Node vm.runInNewContext` với user input
- Không có signature/HMAC check trước khi deserialize

## Khi nào HIGH (giảm cấp)

- Input là L2 (DB) mà DB đó user có thể ghi gián tiếp — vẫn rất nguy hiểm
- Dùng `pickle` cho data internal (Redis cache giữa các service) và Redis không expose public — vẫn rủi ro nếu Redis compromise

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** các API nguy hiểm (xem dưới)
2. **Read** function chứa call: input đến từ đâu?
3. **Trace** L1-L4:
   - `pickle.loads(request.cookies["session"])` → L1 → CRITICAL ngay
   - `pickle.loads(redis.get("user_cache"))` → L2 → cần xem ai ghi vào Redis
   - `pickle.loads(open("./trusted.pkl").read())` → L3 nếu file là static
4. **Verify safe variant**:
   - YAML: phải có `yaml.safe_load` hoặc `Loader=yaml.SafeLoader`
   - JSON: `json.loads` an toàn (không thực thi code) — không flag
   - `ast.literal_eval` an toàn — không flag
5. **Eval / exec** trên L1 ALMOST ALWAYS critical — không có lý do hợp lệ trừ khi sandbox kỹ.

## Search patterns (gợi ý — KHÔNG chạy literal, dùng Grep tool)

### Python

```
pickle\.loads?\s*\(
cPickle\.loads?\s*\(
marshal\.loads?\s*\(
yaml\.load\s*\(                              # KHÔNG có safe_
shelve\.open\s*\(
^eval\s*\(                                   # KHÔNG phải .eval của framework
^exec\s*\(
```

### PHP

```
unserialize\s*\(
phar://                                      # phar deserialization
```

### Java

```
ObjectInputStream
readObject\s*\(
XMLDecoder
```

### .NET

```
BinaryFormatter
SoapFormatter
NetDataContractSerializer
LosFormatter
JavaScriptSerializer.*TypeNameHandling
```

### Node.js

```
node-serialize
vm\.runInNewContext\s*\(
vm\.runInThisContext\s*\(
Function\s*\(\s*req\.                        # new Function(userCode)
```

## Examples

### CRITICAL — flag

```python
# Flask — pickle từ cookie là RCE
import pickle, base64
@app.route("/restore", methods=["POST"])
def restore():
    data = base64.b64decode(request.cookies["session"])
    state = pickle.loads(data)   # L1 → RCE
    return jsonify(state)
```

```python
# yaml.load mặc định = FullLoader, vẫn có thể RCE qua !!python/object/apply
import yaml
config = yaml.load(request.data)   # KHÔNG safe_load
```

```php
<?php
// Cookie chứa serialized object — gadget chain → RCE
$user = unserialize($_COOKIE['user_data']);
```

```python
# eval trên input — game over
result = eval(request.args.get("formula"))   # ?formula=__import__('os').system('rm -rf /')
```

```javascript
// Node — new Function với input
app.post("/calc", (req, res) => {
  const fn = new Function("return " + req.body.expr);
  res.json({ result: fn() });
});
```

```csharp
// .NET
var formatter = new BinaryFormatter();
var obj = formatter.Deserialize(Request.InputStream);   // RCE
```

### NOT critical — không flag (hoặc downgrade)

```python
# JSON — an toàn (không thực thi code)
import json
data = json.loads(request.data)
```

```python
# yaml safe_load — an toàn
import yaml
config = yaml.safe_load(request.data)
# hoặc
config = yaml.load(request.data, Loader=yaml.SafeLoader)
```

```python
# ast.literal_eval — chỉ parse literal, không exec
import ast
data = ast.literal_eval(request.form["data"])
```

```python
# pickle chỉ dùng cho file static trong repo
import pickle
with open("./model.pkl", "rb") as f:
    model = pickle.load(f)   # L3 — file controlled, OK nếu file commit
```

## Fix recommendation

1. **KHÔNG deserialize untrusted data** với pickle/yaml.load/unserialize. Đổi sang JSON cho mọi data từ client:
   ```python
   # Trước (BAD)
   data = pickle.loads(request.data)
   # Sau (GOOD)
   import json
   data = json.loads(request.data)
   ```
2. **YAML**: luôn dùng `yaml.safe_load`:
   ```python
   import yaml
   config = yaml.safe_load(f)
   ```
3. **PHP**: chuyển từ `unserialize` sang `json_decode($data, true)`. Nếu phải `unserialize`, dùng option `["allowed_classes" => false]`.
4. **Java**: tránh `ObjectInputStream`. Dùng JSON (Jackson/Gson) hoặc Protobuf. Nếu phải, set `ObjectInputFilter`.
5. **.NET**: KHÔNG dùng `BinaryFormatter` (Microsoft đã deprecated). Dùng `System.Text.Json` / `Newtonsoft.Json` với `TypeNameHandling.None`.
6. **Nếu BẮT BUỘC dùng pickle/serialize**: ký HMAC trước:
   ```python
   import hmac, hashlib, pickle
   secret = os.environ["PICKLE_SECRET"].encode()
   def sign(data: bytes) -> bytes:
       sig = hmac.new(secret, data, hashlib.sha256).digest()
       return sig + data
   def verify_and_load(blob: bytes):
       sig, data = blob[:32], blob[32:]
       expected = hmac.new(secret, data, hashlib.sha256).digest()
       if not hmac.compare_digest(sig, expected):
           raise ValueError("Bad signature")
       return pickle.loads(data)
   ```
7. **eval/exec**: gần như không bao giờ có lý do hợp lệ. Nếu cần parse expression (math), dùng `ast.literal_eval` hoặc lib như `simpleeval`, `asteval` (sandbox).

## Cross-references

- Rule `02-sql-injection`: cùng họ injection — pickle/eval là "code injection"
- Rule `17-verbose-error-debug-mode`: traceback của pickle lộ class internal → giúp build gadget chain
- Rule `20-outdated-dependency`: lib cũ có gadget chain công khai → exploit dễ hơn
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall