Skip to content

tanviet12/vbsec / skills/antigravity/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.8 KB
workflows/small-review.mdmarkdown10.1 KB

rules/languages/python/15-cors-misconfig.md

View on GitHub
---
id: CORS-MISCONFIG
severity_max: HIGH
applies_to: python
---

# CORS Misconfiguration — Python Specialization

> Override cho rule chung `rules/generic/15-cors-misconfig.md`. Áp dụng khi `primary_language: python`.

## Intent (Python-specific)

Vibe code Python thường vẽ CORS theo kiểu "cho qua hết để frontend chạy được": `CORS(app)` không argument trên Flask, `CORS_ALLOW_ALL_ORIGINS = True` trên Django, `allow_origins=["*"]` trên FastAPI. Sai lầm chết người là **kết hợp `allow_credentials=True` với origin wildcard** — trình duyệt sẽ gửi cookie sang bất kỳ origin nào server echo lại → attacker host trang evil.com đọc API có cookie auth của user.

Lỗi tinh tế hơn: dùng regex pattern không anchor cuối (`r".*\.example\.com"`) → khớp `evil.com.example.attacker.com` (subdomain takeover) hoặc `evil-example.com`.

## Khi nào HIGH

- `flask_cors.CORS(app)` không argument → default `origins='*'`
- Flask `CORS(app, supports_credentials=True, origins='*')` — CRITICAL combo
- Django `CORS_ALLOW_ALL_ORIGINS = True` + `CORS_ALLOW_CREDENTIALS = True`
- Django `CORS_ALLOWED_ORIGIN_REGEXES = [r".*\.example\.com"]` không có `$` anchor → bypass
- Django `CORS_ALLOWED_ORIGIN_REGEXES = [r"^https?://.*"]` quá rộng
- FastAPI `CORSMiddleware(allow_origins=["*"], allow_credentials=True)` — browser sẽ reject nhưng vibe code thường reflect origin từ request header → bypass
- Reflect origin từ header (echo) không validate: `response.headers['Access-Control-Allow-Origin'] = request.headers['Origin']`
- Set thủ công wildcard: `response.headers['Access-Control-Allow-Origin'] = '*'` + cookie auth

## Khi nào MEDIUM (giảm cấp)

- `allow_origins=["*"]` NHƯNG `allow_credentials=False` — vẫn lộ data public nhưng không đánh cắp được cookie
- Whitelist origin cụ thể: `allow_origins=["https://app.example.com"]` — SAFE
- Endpoint không trả data nhạy cảm (public API key info, healthcheck) — không flag

## Cách reasoning

1. **Grep**:
   - Flask: `flask_cors`, `CORS\(`, `CORS_ORIGINS`, `supports_credentials`
   - Django: `CORS_ALLOW_ALL_ORIGINS`, `CORS_ALLOWED_ORIGINS`, `CORS_ALLOWED_ORIGIN_REGEXES`, `CORS_ALLOW_CREDENTIALS`
   - FastAPI: `CORSMiddleware`, `allow_origins`, `allow_credentials`
2. **Identify combos nguy hiểm**:
   - `allow_origins=["*"]` + `allow_credentials=True` → HIGH
   - Reflect origin từ request → HIGH
   - Regex thiếu anchor `^...$` → HIGH
3. **Check endpoint sensitivity**:
   - Có cookie/session auth không? Có Bearer JWT không?
   - API trả data người dùng (PII, balance, history)?
4. **Verify**: production config khác dev không? `if settings.DEBUG: allow=*` chấp nhận nếu DEBUG=False prod.

## Search patterns

```
# Flask-CORS
from\s+flask_cors\s+import\s+CORS
CORS\s*\(\s*app\s*\)  # no args = all origins
CORS\s*\([^)]*supports_credentials\s*=\s*True[^)]*origins\s*=\s*['"]?\*
CORS\s*\([^)]*origins\s*=\s*['"]?\*[^)]*supports_credentials
CORS\s*\([^)]*resources\s*=\s*\{[^}]*origins['"]\s*:\s*['"]?\*

# Django
CORS_ALLOW_ALL_ORIGINS\s*=\s*True
CORS_ORIGIN_ALLOW_ALL\s*=\s*True   # legacy package
CORS_ALLOW_CREDENTIALS\s*=\s*True
CORS_ALLOWED_ORIGIN_REGEXES\s*=\s*\[[^\]]*r?["'][^"']*[^$]["']\s*[\],]  # regex không $
CORS_ALLOWED_ORIGINS\s*=\s*\[[^\]]*\*

# FastAPI / Starlette
from\s+fastapi\.middleware\.cors\s+import\s+CORSMiddleware
CORSMiddleware[^)]*allow_origins\s*=\s*\[\s*["']\*["']\s*\][^)]*allow_credentials\s*=\s*True
add_middleware\s*\(\s*CORSMiddleware

# Manual set wildcard
response\.headers\[['"]Access-Control-Allow-Origin['"]\]\s*=\s*['"]?\*
.*Access-Control-Allow-Origin.*request\.headers\[['"]?Origin
```

## Examples

### HIGH — flag

```python
# Flask-CORS no-arg = allow all
from flask_cors import CORS
app = Flask(__name__)
CORS(app)  # default: origins='*' + supports_credentials=False
# Vẫn lộ data API public nhưng không lấy được cookie

# Worse: bật credentials
CORS(app, supports_credentials=True, origins='*')  # CRITICAL combo
```

```python
# Django settings combo nguy
# settings.py
CORS_ALLOW_ALL_ORIGINS = True
CORS_ALLOW_CREDENTIALS = True
# Attacker host evil.com → fetch /api/me với cookie auth → đọc PII
```

```python
# Django regex thiếu $ anchor
CORS_ALLOWED_ORIGIN_REGEXES = [
    r"^https://.*\.example\.com",  # thiếu $ → khớp evil.example.com.attacker.com
]
CORS_ALLOW_CREDENTIALS = True
```

```python
# FastAPI wildcard + credentials
from fastapi.middleware.cors import CORSMiddleware

app.add_middleware(
    CORSMiddleware,
    allow_origins=["*"],
    allow_credentials=True,  # browser sẽ reject combo này
    allow_methods=["*"],
    allow_headers=["*"],
)
# Nhưng nếu kèm reflect origin thủ công → bypass
```

```python
# Reflect origin (echo) — bypass browser check
@app.after_request
def add_cors(response):
    origin = request.headers.get('Origin')
    response.headers['Access-Control-Allow-Origin'] = origin  # echo blindly
    response.headers['Access-Control-Allow-Credentials'] = 'true'
    return response
```

```python
# FastAPI middleware tự viết phản chiếu
@app.middleware("http")
async def cors_handler(request, call_next):
    response = await call_next(request)
    response.headers['Access-Control-Allow-Origin'] = request.headers.get('origin', '*')
    response.headers['Access-Control-Allow-Credentials'] = 'true'
    return response
```

### NOT critical — không flag

```python
# Whitelist origin cụ thể
from fastapi.middleware.cors import CORSMiddleware
app.add_middleware(
    CORSMiddleware,
    allow_origins=["https://app.example.com", "https://admin.example.com"],
    allow_credentials=True,
    allow_methods=["GET", "POST", "PUT", "DELETE"],
    allow_headers=["Authorization", "Content-Type"],
)
```

```python
# Flask whitelist
CORS(app, resources={
    r"/api/*": {
        "origins": ["https://app.example.com"],
        "supports_credentials": True,
    }
})
```

```python
# Django regex chuẩn anchor đầu cuối
CORS_ALLOWED_ORIGIN_REGEXES = [
    r"^https://[\w-]+\.example\.com$",  # có cả ^ và $
]
```

```python
# Wildcard origin nhưng KHÔNG credentials — public API
CORS(app, origins='*', supports_credentials=False)
# Vẫn lộ data public nhưng không token theft → acceptable cho public API
```

## Fix recommendation

1. **Whitelist tuyệt đối**, KHÔNG wildcard nếu có credentials:
   ```python
   # FastAPI
   app.add_middleware(
       CORSMiddleware,
       allow_origins=[
           "https://app.example.com",
           "https://admin.example.com",
       ],
       allow_credentials=True,
       allow_methods=["GET", "POST", "PUT", "DELETE", "OPTIONS"],
       allow_headers=["Authorization", "Content-Type"],
   )
   ```
2. **Regex phải anchor cả 2 đầu**:
   ```python
   # Django
   CORS_ALLOWED_ORIGIN_REGEXES = [
       r"^https://[\w-]+\.example\.com$",
   ]
   ```
3. **Reflect origin có validate**:
   ```python
   ALLOWED = {"https://app.example.com", "https://admin.example.com"}
   origin = request.headers.get('Origin')
   if origin in ALLOWED:
       response.headers['Access-Control-Allow-Origin'] = origin
       response.headers['Vary'] = 'Origin'  # quan trọng cho cache
   ```
4. **Env-based origin** — config riêng dev/prod:
   ```python
   CORS_ALLOWED_ORIGINS = os.environ['CORS_ALLOWED_ORIGINS'].split(',')
   # .env prod: CORS_ALLOWED_ORIGINS=https://app.example.com
   # .env dev: CORS_ALLOWED_ORIGINS=http://localhost:3000
   ```
5. **Methods/Headers cũng whitelist** — không `allow_methods=["*"]` + credentials.
6. **Vary: Origin** trong response để CDN cache không nhầm lẫn origin.
7. **Tách public vs private endpoints**: `/api/public/*` có thể `*`, `/api/me/*` whitelist.
8. **Test bằng curl** với header `Origin: https://evil.com` xem có lọt không.

## Cross-references

- Python `11-csrf`: CORS sai + cookie auth = chain với CSRF
- Python `14-jwt-none-algorithm`: JWT trong cookie + CORS misconfig = token theft cross-origin
- Generic `12-broken-access-control`: CORS chỉ là transport layer, auth thực sự ở permission model
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall