Skip to content

tanviet12/vbsec / skills/antigravity/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.8 KB
workflows/small-review.mdmarkdown10.1 KB

rules/languages/dotnet/08-insecure-deserialization.md

View on GitHub
---
id: INSECURE-DESERIALIZATION
severity_max: CRITICAL
applies_to: dotnet
overrides: generic/08-insecure-deserialization.md
---

# Insecure Deserialization — .NET 10 Specialization

> Override cho rule chung `rules/generic/08-insecure-deserialization.md`. Áp dụng khi `primary_language: dotnet`.

## Intent (.NET-specific)

`System.Text.Json` mặc định tương đối an toàn, nhưng .NET codebase vẫn hay có Newtonsoft.Json legacy, BinaryFormatter/LosFormatter/NetDataContractSerializer, hoặc custom polymorphic converter. Nguy hiểm nhất là deserialize untrusted data với type metadata (`TypeNameHandling`) hoặc formatter có khả năng materialize arbitrary type/gadget chain. Trong ASP.NET Core, source thường là request body, uploaded file, cookie, cache, queue message hoặc webhook.

## Khi nào CRITICAL

- `JsonConvert.DeserializeObject` với `TypeNameHandling.Auto/All/Objects/Arrays` trên dữ liệu L1/L2.
- `JsonSerializerSettings.TypeNameHandling != None` mà không có strict `SerializationBinder`.
- `BinaryFormatter.Deserialize`, `LosFormatter.Deserialize`, `NetDataContractSerializer.ReadObject`, `SoapFormatter.Deserialize`.
- `DataContractSerializer` / `XmlSerializer` deserialize type do user chọn hoặc XML untrusted kèm unsafe resolver.
- Custom `JsonConverter` / polymorphism map cho phép type discriminator từ request map tự do sang runtime type.
- Deserialize từ cookie/session/cache/queue mà attacker có thể ghi hoặc ký không được verify.

## Khi nào HIGH (giảm cấp)

- Deserialize internal trusted file/config build-time.
- `System.Text.Json.JsonSerializer.Deserialize<TKnownDto>` vào DTO cố định, không polymorphic arbitrary type.
- Newtonsoft có `TypeNameHandling.None` hoặc binder allowlist chặt.
- Payload có HMAC/signature verify trước khi deserialize unsafe format.

## Cách reasoning

1. Grep deserialization sink: `JsonConvert.DeserializeObject`, `TypeNameHandling`, `BinaryFormatter`, `LosFormatter`, `NetDataContractSerializer`, `ReadObject`.
2. Read callsite và settings.
3. Trace payload source:
   - `Request.Body`, uploaded file, header/cookie, SignalR/WebSocket, queue/webhook → L1/L2.
   - local trusted config/sealed resource → L3/L4.
4. Verify:
   - Target type generic is DTO? `DeserializeObject<MyDto>(json)` safe hơn `object`.
   - `TypeNameHandling` có `None` không?
   - Có binder allowlist (`ISerializationBinder`) không?
   - XML resolver disabled?
5. Flag CRITICAL khi untrusted bytes/string đi vào unsafe deserializer/config.

## Search patterns

```
# Newtonsoft.Json type name handling
TypeNameHandling\s*=\s*TypeNameHandling\.(All|Auto|Objects|Arrays)
JsonConvert\.DeserializeObject\s*<\s*object\s*>
JsonConvert\.DeserializeObject\s*\([^)]*JsonSerializerSettings

# Legacy unsafe formatters
BinaryFormatter\s*\(
\.Deserialize\s*\(
LosFormatter\s*\(
NetDataContractSerializer\s*\(
SoapFormatter\s*\(

# Data/XML deserialization
DataContractSerializer\s*\(
XmlSerializer\s*\(
\.ReadObject\s*\(

# ASP.NET request sources near deserialize
Request\.Body
ReadAsStringAsync\s*\(
Request\.Form\.Files
Request\.Cookies
```

## Examples

### CRITICAL — flag

```csharp
// Newtonsoft TypeNameHandling.All from request body
[HttpPost("/import")]
public async Task<IActionResult> Import()
{
    using var reader = new StreamReader(Request.Body);
    var json = await reader.ReadToEndAsync();
    var obj = JsonConvert.DeserializeObject<object>(json, new JsonSerializerSettings
    {
        TypeNameHandling = TypeNameHandling.All
    });
    return Ok(obj);
}
```

```csharp
// BinaryFormatter from uploaded file
using var stream = formFile.OpenReadStream();
var formatter = new BinaryFormatter();
var state = formatter.Deserialize(stream);
```

```csharp
// NetDataContractSerializer materializes CLR types
var serializer = new NetDataContractSerializer();
var obj = serializer.ReadObject(Request.Body);
```

```csharp
// Polymorphic discriminator from request maps directly to Type
var typeName = doc.RootElement.GetProperty("$type").GetString();
var type = Type.GetType(typeName!);
return JsonSerializer.Deserialize(json, type!);
```

### NOT critical — không flag

```csharp
// System.Text.Json into known DTO
var req = await JsonSerializer.DeserializeAsync<ImportRequest>(Request.Body);
```

```csharp
// Newtonsoft fixed DTO and no type names
var req = JsonConvert.DeserializeObject<ImportRequest>(json, new JsonSerializerSettings
{
    TypeNameHandling = TypeNameHandling.None
});
```

```csharp
// Newtonsoft with binder allowlist
var settings = new JsonSerializerSettings
{
    TypeNameHandling = TypeNameHandling.Objects,
    SerializationBinder = new KnownTypesBinder(new[] { typeof(SafeMessage) })
};
```

```csharp
// Signed payload before legacy load (acceptable with strong key)
if (!hmacValidator.IsValid(payload, signature)) return Unauthorized();
var obj = formatter.Deserialize(new MemoryStream(payload));
```

## Fix recommendation

1. Prefer `System.Text.Json` into known DTO/record types.
2. Do not enable Newtonsoft `TypeNameHandling` for untrusted payloads. If unavoidable, use strict `ISerializationBinder` allowlist.
3. Remove `BinaryFormatter`, `LosFormatter`, `NetDataContractSerializer`, `SoapFormatter` from request/cookie/upload paths.
4. For polymorphism, use explicit discriminator enum/map to known DTO types, never `Type.GetType(userInput)`.
5. Verify HMAC/signature before deserializing data from cache/queue/cookie if legacy format cannot be removed.

## Cross-references

- `21-command-injection`: unsafe deserialization often reaches RCE sinks.
- `01-hardcoded-secret`: HMAC/signing keys must not be hardcoded.
- `20-outdated-dependency`: old Newtonsoft/gadget-compatible libraries increase exploitability.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall