Skip to content

tanviet12/vbsec / skills/antigravity/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.8 KB
workflows/small-review.mdmarkdown10.1 KB

rules/generic/07-mass-assignment.md

View on GitHub
---
id: MASS-ASSIGNMENT
severity_max: CRITICAL
applies_to: all
---

# Mass Assignment

## Intent

Endpoint nhận `req.body` rồi **spread/merge toàn bộ vào model/DB** không lọc field. Attacker thêm field `is_admin: true`, `role: "admin"`, `balance: 999999`, `email_verified: true`, `user_id: 1` vào JSON request — **tự nâng quyền lên admin, đổi tiền, đổi owner, bypass verify email**.

Vibe code cực dính vì AI hay viết `Object.assign(user, req.body)` / `User.create(**request.json)` cho "ngắn gọn". Đây là một dạng của Broken Access Control trong OWASP Top 10.

## Khi nào CRITICAL

- Endpoint dùng `Object.assign(model, req.body)`, `{...model, ...req.body}`, `new Model(req.body)`, `Model.create(**request.json)` mà KHÔNG có whitelist
- Model chứa field nhạy cảm: `is_admin`, `role`, `permissions`, `user_id`, `owner_id`, `balance`, `verified`, `is_staff`, `is_superuser`
- Endpoint accessible cho user thường (không phải admin-only)

## Khi nào HIGH (giảm cấp)

- Endpoint admin-only (có check role) — vẫn rủi ro nếu admin nhập nhầm hoặc bị compromise
- Model không có field nguy hiểm (chỉ có `name`, `bio`, `avatar`...) — nhưng vẫn nên whitelist

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** các pattern spread/merge body (xem dưới)
2. **Read** function: model được tạo/update là gì? Có những field nào?
3. **Trace** field model: schema có field nào nguy hiểm? (xem migration, schema.prisma, models.py)
4. **Verify whitelist**:
   - Express/Mongoose: có dùng `pick(req.body, [...])` (lodash) không?
   - Rails: có dùng `params.require(:user).permit(:name, :email)` không?
   - Laravel: model có `$fillable` hoặc `$guarded` không?
   - Django: có dùng `ModelForm` / serializer `fields = [...]` không?
5. Endpoint PATCH/PUT thường nguy hiểm hơn POST vì update existing record.

## Search patterns (gợi ý — KHÔNG chạy literal, dùng Grep tool)

### Express / Node

```
Object\.assign\s*\(\s*[a-zA-Z_]+\s*,\s*req\.body
\.\.\.req\.body                                      # spread trong object
new\s+\w+\s*\(\s*req\.body\s*\)                      # mongoose new Model(req.body)
\.create\s*\(\s*req\.body\s*\)                       # Sequelize / Prisma / Mongoose
\.update\s*\(\s*req\.body\s*\)
\.findByIdAndUpdate\s*\([^,]+,\s*req\.body
```

### Python (Django / Flask / FastAPI)

```
Model\(\*\*request\.(json|form|data)\)
\.objects\.create\s*\(\s*\*\*request\.
setattr\s*\(\s*\w+\s*,\s*key\s*,\s*value\s*\)        # iterate qua request.json
for\s+k\s*,\s*v\s+in\s+request\.json\.items
```

### Ruby on Rails

```
\.update\s*\(\s*params\[:\w+\]\s*\)\s*$              # KHÔNG có .permit
\.new\s*\(\s*params\[:\w+\]\s*\)\s*$
\.create\s*\(\s*params\[:\w+\]\s*\)\s*$
```

### PHP / Laravel

```
->fill\s*\(\s*\$request->all\(\)\s*\)
::create\s*\(\s*\$request->all\(\)\s*\)
::update\s*\(\s*\$request->all\(\)\s*\)
```

## Examples

### CRITICAL — flag

```javascript
// Express + Mongoose — bất kỳ ai cũng tự thành admin
app.patch("/api/users/me", requireAuth, async (req, res) => {
  const user = await User.findById(req.user.id);
  Object.assign(user, req.body);   // L1 → toàn bộ field, kể cả isAdmin
  await user.save();
  res.json(user);
});
// Attacker: PATCH /api/users/me { "isAdmin": true }
```

```python
# Flask — tạo user kèm role
@app.route("/api/users", methods=["POST"])
def create_user():
    user = User(**request.json)   # L1 spread vào model
    db.session.add(user)
    db.session.commit()
    return jsonify(user.to_dict())
# Attacker: POST {"username":"x","password":"x","role":"admin"}
```

```ruby
# Rails — KHÔNG có strong params
def update
  @user = User.find(params[:id])
  @user.update(params[:user])   # mass assign — admin field lọt
end
```

```php
<?php
// Laravel — không có $fillable
class User extends Model {}
// Controller
public function store(Request $request) {
    User::create($request->all());   // is_admin lọt qua
}
```

```javascript
// Prisma
await prisma.user.update({
  where: { id: req.user.id },
  data: req.body,   // ! toàn bộ body
});
```

### NOT critical — không flag (hoặc downgrade)

```javascript
// Express — whitelist với lodash.pick
import { pick } from "lodash";
app.patch("/api/users/me", requireAuth, async (req, res) => {
  const updates = pick(req.body, ["name", "bio", "avatar"]);
  const user = await User.findByIdAndUpdate(req.user.id, updates, { new: true });
  res.json(user);
});
```

```python
# FastAPI Pydantic — schema lọc tự động
class UserUpdate(BaseModel):
    name: str | None = None
    bio: str | None = None
    # KHÔNG khai báo role / is_admin — bị reject

@app.patch("/api/users/me")
def update_me(data: UserUpdate, user: User = Depends(current_user)):
    for k, v in data.dict(exclude_unset=True).items():
        setattr(user, k, v)
```

```ruby
# Rails strong params
def update
  @user.update(user_params)
end
private
def user_params
  params.require(:user).permit(:name, :bio, :avatar)
end
```

```php
<?php
// Laravel với $fillable
class User extends Model {
    protected $fillable = ['name', 'email', 'bio'];   // role KHÔNG trong list
}
```

## Fix recommendation

1. **Whitelist field rõ ràng** (allow-list, không phải deny-list):
   ```javascript
   import { pick } from "lodash";
   const ALLOWED = ["name", "bio", "avatar"];
   const updates = pick(req.body, ALLOWED);
   ```
2. **Dùng DTO / schema validation**:
   - FastAPI: Pydantic model
   - NestJS: class-validator + `whitelist: true, forbidNonWhitelisted: true`
   - Joi / Zod / Yup ở Express
   - Marshmallow ở Flask
3. **Framework convention**:
   - Rails: `params.require(:x).permit(:a, :b)` luôn luôn
   - Laravel: `$fillable` array ở mọi model
   - Django: `ModelForm` / serializer `fields = [...]`
4. **Tách endpoint update profile vs update role**:
   - `PATCH /api/users/me` — chỉ field user tự sửa
   - `PATCH /api/admin/users/:id/role` — admin-only endpoint
5. **Audit log**: ghi lại request body khi update field nhạy cảm (role, balance) để detect.

## Cross-references

- Rule `04-idor`: mass assignment + IDOR = đổi owner của resource người khác
- Rule `02-sql-injection`: cùng họ "trust input", khác sink
- Rule `17-verbose-error-debug-mode`: validation error lộ tên field hidden
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall