Skip to content

tanviet12/vbsec / skills/antigravity/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.8 KB
workflows/small-review.mdmarkdown10.1 KB

rules/generic/06-brute-force.md

View on GitHub
---
id: BRUTE-FORCE
severity_max: HIGH
applies_to: all
---

# Missing Rate Limit (Brute Force)

## Intent

Endpoint **login / signup / password-reset / OTP-verify / API** không có rate limit. Attacker chạy script gửi 1 triệu request thử mật khẩu hoặc OTP 6 chữ số (chỉ 1M tổ hợp = 100% trúng), **chiếm tài khoản, bypass 2FA, spam đăng ký tạo user rác, brute-force coupon code, vét cạn email hợp lệ qua signup error**.

Vibe code thường quên rate limit vì frontend chỉ cho user click 1 lần — nhưng API gọi trực tiếp được vô hạn.

## Khi nào HIGH

Chỉ HIGH khi thiếu rate limit **cộng thêm** một yếu tố làm vét cạn chắc chắn thành công hoặc hậu quả lớn:

- OTP / verify code 4-6 chữ số mà KHÔNG có lockout sau N lần fail (không gian nhỏ, vét cạn trong vài phút)
- Endpoint coupon / promo / invite code không gian nhỏ, không rate limit (vét cạn 100k mã)
- Login của **admin panel** hoặc endpoint auth mà đăng nhập xong là có quyền ghi tiền / đổi role
- Login không rate limit **và** không có MFA **và** mật khẩu lưu bằng hash yếu hoặc không có chính sách độ dài (credential stuffing thành công cao)

## Khi nào MEDIUM (mặc định)

- `/login`, `/signup`, `/forgot-password`, `/api/auth/*` của app thường KHÔNG có rate limit / lockout, không có yếu tố ở mục HIGH → **MEDIUM là mức mặc định** cho lỗi này
- Có rate limit nhưng quá lỏng (vd: 1000 req/phút cho `/login`)
- Có CAPTCHA sau N lần fail (chậm bot nhưng không chặn)

## Khi nào LOW

- Endpoint nội bộ chỉ accessible qua VPN / IP allowlist
- Có lockout theo tài khoản nhưng thiếu lockout theo IP (hoặc ngược lại)

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** route handler chứa keyword `login`, `signup`, `register`, `reset`, `forgot`, `verify`, `otp`, `auth`
2. **Read** đầy đủ file + middleware stack: có dùng `express-rate-limit`, `flask-limiter`, `django-ratelimit`, `@fastify/rate-limit`, `Throttle` (NestJS), `RateLimiter` (Laravel) không?
3. **Check OTP flow**:
   - Code có bao nhiêu ký tự / digit? 4-6 digit + không lockout = đỏ
   - Có biến `attempts_count` / `failed_attempts` trong DB / Redis không?
   - Code có TTL không (vd: 5 phút)? Code sống lâu = brute dễ hơn
4. **Check global middleware**: rate limit có thể set global ở app level (vd: `app.use(rateLimiter)`) → cần đọc cả file entry
5. Reverse proxy (nginx, Cloudflare) có rate limit không? Nếu có thì OK ở mức infra.

## Search patterns (gợi ý — KHÔNG chạy literal, dùng Grep tool)

### Tìm endpoint nhạy cảm

```
(login|signin|signup|register|password-reset|forgot-password|verify-otp|verify-email|2fa)
@app\.route.*(login|signup|reset|verify)
router\.(post|put)\s*\(\s*["'].*(login|signup|reset|verify)
```

### Tìm rate-limit middleware (vắng = nghi vấn)

```
express-rate-limit|rateLimit\s*\(
flask-limiter|@limiter\.limit
django-ratelimit|@ratelimit
@fastify/rate-limit
@Throttle\s*\(                              # NestJS
RateLimiter::for\s*\(                       # Laravel
```

### Tìm OTP verification

```
(otp|code|verification_code)\s*==\s*
\.compare\s*\(\s*(otp|code|verificationCode)
verifyOTP|verify_otp|verifyCode|checkOTP
```

## Examples

### HIGH — flag

```javascript
// Express — login không rate limit
app.post("/login", async (req, res) => {
  const { username, password } = req.body;
  const user = await User.findOne({ username });
  if (await bcrypt.compare(password, user.passwordHash)) {
    return res.json({ token: sign(user) });
  }
  res.status(401).send("Wrong password");
});
```

```python
# Flask — verify OTP 6 digit không lockout, không TTL check
@app.route("/verify-otp", methods=["POST"])
def verify_otp():
    user_id = request.json["user_id"]
    code = request.json["code"]
    record = OTP.query.filter_by(user_id=user_id).first()
    if record.code == code:
        return {"verified": True}
    return {"verified": False}, 401
# Attacker brute force 000000 → 999999 trong vài phút
```

```php
<?php
// Laravel — không có throttle
Route::post('/forgot-password', [AuthController::class, 'forgot']);
```

```javascript
// Coupon brute force — không rate limit
app.get("/api/coupon/:code", async (req, res) => {
  const coupon = await Coupon.findOne({ code: req.params.code });
  if (coupon) return res.json(coupon);
  res.status(404).end();
});
```

### NOT high — không flag (hoặc downgrade)

```javascript
// Có rate limit cụ thể cho login
import rateLimit from "express-rate-limit";
const loginLimiter = rateLimit({ windowMs: 15 * 60 * 1000, max: 5 });
app.post("/login", loginLimiter, async (req, res) => { /* ... */ });
```

```python
# Flask-Limiter
from flask_limiter import Limiter
limiter = Limiter(app, key_func=get_remote_address)

@app.route("/verify-otp", methods=["POST"])
@limiter.limit("5 per minute")
def verify_otp(): ...
```

```python
# OTP có attempt count + lockout
def verify_otp(user_id, code):
    record = OTP.get(user_id)
    if record.attempts >= 5:
        raise Locked("Too many attempts")
    if record.code != code:
        record.attempts += 1
        record.save()
        raise Unauthorized()
    record.delete()
    return True
```

```php
<?php
// Laravel throttle middleware
Route::post('/forgot-password', [AuthController::class, 'forgot'])
    ->middleware('throttle:5,15');   // 5 req / 15 phút
```

## Fix recommendation

1. **Thêm rate limit middleware cho endpoint nhạy cảm**:
   ```javascript
   // Express
   import rateLimit from "express-rate-limit";
   const authLimiter = rateLimit({
     windowMs: 15 * 60 * 1000,   // 15 phút
     max: 5,                      // 5 lần / IP
     standardHeaders: true,
     message: "Quá nhiều lần thử, vui lòng đợi 15 phút",
   });
   app.use("/login", authLimiter);
   app.use("/forgot-password", authLimiter);
   ```
2. **OTP flow chuẩn**:
   - Code random 6 digit
   - TTL ngắn (5-10 phút)
   - Lockout sau 5 lần fail (Redis counter)
   - Mỗi user có **1 mã active** tại một thời điểm
   - Sau verify success → delete mã ngay
3. **Tier rate limit**:
   - Per IP: 5 req / 15 phút cho login
   - Per account: 3 req / 15 phút cho password-reset (theo email/user_id)
4. **CAPTCHA sau N fail** (Cloudflare Turnstile, hCaptcha, reCAPTCHA v3)
5. **Account lockout** (cẩn thận tránh DOS nạn nhân) — chỉ lock IP, không lock account vĩnh viễn
6. **Layer tầng infra**: Cloudflare / AWS WAF / nginx `limit_req_zone` — phòng thủ trước khi đến app

## Cross-references

- Rule `12-no-mfa-on-admin` (nếu có): admin không MFA + brute force = chiếm root
- Rule `17-verbose-error-debug-mode`: `/login` trả về "user not found" vs "wrong password" → enum user
- Rule `04-idor`: brute force ID (numeric) — cùng họ "không giới hạn"
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall