Skip to content

tanviet12/vbsec / skills/antigravity/vbs-scan-security

vbs-scan-security

Flagged

Use when scanning code for security vulnerabilities. Use when user says "scan security", "kiểm tra bảo mật", "security audit", "review security", or invokes `/vbs-scan-security`. For large scans (>20 main-language files OR >30 total OR >14 days) processes chunks sequentially. Outputs bilingual reports (vi/en). Optional `--auto-fix` (agentic patch + verify loop) and `--sca` (live CVE lookup via OSV.dev).

FileKindSize
SKILL.mdskill md28.2 KB
VERSIONother6 B
references/chunking-strategy.mdmarkdown7.2 KB
references/data-flow-classification.mdmarkdown9.5 KB
references/dependency-scan.mdmarkdown9.7 KB
references/i18n/en.mdmarkdown8.7 KB
references/i18n/vi.mdmarkdown9.4 KB
references/language-detection.mdmarkdown7.5 KB
references/load-rules.shexecutablescript5.2 KB
references/output-format.mdmarkdown26.1 KB
references/project-context.mdmarkdown2.7 KB
references/sub-agent-prompts.mdmarkdown16.5 KB
references/validate-report.pyexecutablescript8.7 KB
rules/generic/01-hardcoded-secret.mdmarkdown5.4 KB
rules/generic/02-sql-injection.mdmarkdown5.2 KB
rules/generic/03-xss.mdmarkdown4.9 KB
rules/generic/04-idor.mdmarkdown5.7 KB
rules/generic/05-slopsquatting.mdmarkdown6.1 KB
rules/generic/06-brute-force.mdmarkdown6.9 KB
rules/generic/07-mass-assignment.mdmarkdown6.3 KB
rules/generic/08-insecure-deserialization.mdmarkdown6.3 KB
rules/generic/09-ssrf.mdmarkdown6.7 KB
rules/generic/10-path-traversal.mdmarkdown6.3 KB
rules/generic/11-csrf.mdmarkdown7.8 KB
rules/generic/12-broken-access-control.mdmarkdown7.9 KB
rules/generic/13-weak-password-hashing.mdmarkdown5.2 KB
rules/generic/14-jwt-none-algorithm.mdmarkdown5.3 KB
rules/generic/15-cors-misconfig.mdmarkdown5.3 KB
rules/generic/16-unrestricted-file-upload.mdmarkdown5.9 KB
rules/generic/17-verbose-error-debug-mode.mdmarkdown5.8 KB
rules/generic/18-missing-rate-limit.mdmarkdown10.7 KB
rules/generic/19-race-condition.mdmarkdown11.5 KB
rules/generic/20-outdated-dependency.mdmarkdown7.2 KB
rules/generic/21-command-injection.mdmarkdown6.6 KB
rules/generic/22-vulnerable-dependency.mdmarkdown5.3 KB
rules/generic/23-llm-prompt-injection.mdmarkdown9.7 KB
rules/generic/24-excessive-agency.mdmarkdown10.1 KB
rules/generic/25-tenant-isolation.mdmarkdown10.1 KB
rules/generic/26-authz-path-parity.mdmarkdown10.9 KB
rules/generic/27-excessive-data-exposure.mdmarkdown10.4 KB
rules/generic/28-business-state-integrity.mdmarkdown9.5 KB
rules/generic/29-sensitive-data-in-logs.mdmarkdown9.1 KB
rules/generic/30-auth-session-lifecycle.mdmarkdown9.4 KB
rules/generic/31-resource-exhaustion.mdmarkdown9.0 KB
rules/languages/README.mdmarkdown8.5 KB
rules/languages/dart/01-hardcoded-secret.mdmarkdown7.9 KB
rules/languages/dart/03-xss.mdmarkdown5.2 KB
rules/languages/dart/05-slopsquatting.mdmarkdown4.6 KB
rules/languages/dart/10-path-traversal.mdmarkdown6.3 KB
rules/languages/dart/12-broken-access-control.mdmarkdown8.3 KB
rules/languages/dart/17-verbose-error-debug-mode.mdmarkdown6.7 KB
rules/languages/dart/20-outdated-dependency.mdmarkdown4.7 KB
rules/languages/dart/README.mdmarkdown3.7 KB
rules/languages/dotnet/02-sql-injection.mdmarkdown5.7 KB
rules/languages/dotnet/07-mass-assignment.mdmarkdown6.0 KB
rules/languages/dotnet/08-insecure-deserialization.mdmarkdown5.7 KB
rules/languages/dotnet/17-verbose-error-debug-mode.mdmarkdown5.0 KB
rules/languages/dotnet/21-command-injection.mdmarkdown5.3 KB
rules/languages/dotnet/README.mdmarkdown1.7 KB
rules/languages/go/02-sql-injection.mdmarkdown5.2 KB
rules/languages/go/08-insecure-deserialization.mdmarkdown5.0 KB
rules/languages/go/09-ssrf.mdmarkdown5.8 KB
rules/languages/go/17-verbose-error-debug-mode.mdmarkdown6.1 KB
rules/languages/go/21-command-injection.mdmarkdown5.2 KB
rules/languages/go/README.mdmarkdown2.7 KB
rules/languages/php/02-sql-injection.mdmarkdown5.8 KB
rules/languages/php/08-insecure-deserialization.mdmarkdown6.2 KB
rules/languages/php/11-csrf.mdmarkdown6.2 KB
rules/languages/php/17-verbose-error-debug-mode.mdmarkdown6.5 KB
rules/languages/php/21-command-injection.mdmarkdown6.7 KB
rules/languages/php/README.mdmarkdown2.9 KB
rules/languages/python/02-sql-injection.mdmarkdown7.2 KB
rules/languages/python/07-mass-assignment.mdmarkdown7.3 KB
rules/languages/python/08-insecure-deserialization.mdmarkdown7.3 KB
rules/languages/python/09-ssrf.mdmarkdown7.5 KB
rules/languages/python/11-csrf.mdmarkdown7.6 KB
rules/languages/python/14-jwt-none-algorithm.mdmarkdown7.5 KB
rules/languages/python/15-cors-misconfig.mdmarkdown8.0 KB
rules/languages/python/17-verbose-error-debug-mode.mdmarkdown8.4 KB
rules/languages/python/21-command-injection.mdmarkdown8.5 KB
rules/languages/python/README.mdmarkdown3.4 KB
rules/languages/typescript/02-sql-injection.mdmarkdown7.5 KB
rules/languages/typescript/03-xss.mdmarkdown6.7 KB
rules/languages/typescript/07-mass-assignment.mdmarkdown7.4 KB
rules/languages/typescript/08-insecure-deserialization.mdmarkdown7.0 KB
rules/languages/typescript/09-ssrf.mdmarkdown7.5 KB
rules/languages/typescript/11-csrf.mdmarkdown7.3 KB
rules/languages/typescript/14-jwt-none-algorithm.mdmarkdown7.0 KB
rules/languages/typescript/15-cors-misconfig.mdmarkdown7.2 KB
rules/languages/typescript/17-verbose-error-debug-mode.mdmarkdown7.2 KB
rules/languages/typescript/21-command-injection.mdmarkdown6.7 KB
rules/languages/typescript/README.mdmarkdown3.3 KB
workflows/auto-fix.mdmarkdown18.9 KB
workflows/large-review-sequential.mdmarkdown14.8 KB
workflows/small-review.mdmarkdown10.1 KB

rules/generic/02-sql-injection.md

View on GitHub
---
id: SQL-INJECTION
severity_max: CRITICAL
applies_to: all
---

# SQL Injection

## Intent

Input từ user (L1) được ghép thẳng vào câu SQL bằng string concat hoặc f-string. Attacker gửi `' OR 1=1--` hoặc `'; DROP TABLE users;--` để **dump toàn bộ DB, xóa table, leo thang admin, đọc file hệ thống** (qua `LOAD_FILE` MySQL hoặc `pg_read_file` Postgres).

Đây là lỗ hổng kinh điển nhưng vibe code rất hay dính vì AI sinh code "cho nhanh" bằng f-string thay vì dùng parameterized query.

## Khi nào CRITICAL

- L1 input (req.body, req.query, req.params, $_GET, $_POST, request.args, msg.text) ghép vào câu SQL bằng `+`, `%s % `, f-string, template string, `.format()`
- Endpoint không có auth hoặc ai cũng gọi được
- Dùng raw query qua `db.execute()`, `cursor.execute()`, `mysqli_query`, `mysql_query`, `db.query()` mà KHÔNG truyền params riêng

## Khi nào HIGH (giảm cấp)

- Input có thể trace về L3/L4 (hardcoded list, enum, env var) — không phải L1 trực tiếp
- Có whitelist/regex kiểm tra trước (vd: chỉ cho phép `[a-z]+`)
- Endpoint chỉ admin gọi được (có middleware check role) — vẫn nguy hiểm vì insider/escalation, nhưng impact thấp hơn

## Cách reasoning (KHÔNG pattern-match thuần)

1. **Grep** tìm các call site đến `execute`, `query`, `raw`, `exec` (xem patterns dưới)
2. **Read** đầy đủ function chứa call: xem biến truyền vào câu SQL đến từ đâu
3. **Trace** ngược lên L1-L4 (xem `references/data-flow-classification.md`):
   - Biến đó là param của route handler? → L1
   - Đọc từ DB rồi nhét lại vào query khác? → L2 (vẫn rủi ro stored SQLi)
   - Hardcoded constant? → L3, safe
4. **Verify sanitization**: có `escape()`, có parameterized (`?`, `$1`, `:name`) không?
5. Chỉ flag khi L1 → SQL sink WITHOUT params/escape

## Search patterns (gợi ý — KHÔNG chạy literal, dùng Grep tool)

### Python

```
# String building
(execute|executemany|raw)\s*\(\s*f["'].*\{
(execute|executemany|raw)\s*\(\s*["'].*%\s*[a-zA-Z_]
(execute|executemany|raw)\s*\(\s*["'].*\+\s*[a-zA-Z_]
\.format\s*\(.*\)\s*\)?\s*$         # near .execute()
# ORM raw
\.raw\s*\(\s*f["']
text\s*\(\s*f["']                   # SQLAlchemy text()
```

### Node.js

```
\.query\s*\(\s*`[^`]*\$\{           # template literal trong .query()
\.query\s*\(\s*["'][^"']*\+
db\.run\s*\(\s*`.*\$\{
sequelize\.query\s*\(\s*`.*\$\{
```

### PHP

```
mysql_query\s*\(\s*["'][^"']*\$
mysqli_query\s*\(.*\$_(GET|POST|REQUEST)
->query\s*\(\s*["'][^"']*\$
->exec\s*\(\s*["'][^"']*\$
```

### Go

```
db\.(Query|Exec|QueryRow)\s*\(\s*fmt\.Sprintf
db\.(Query|Exec|QueryRow)\s*\(\s*".*"\s*\+
```

## Examples

### CRITICAL — flag

```python
# Flask handler — username là L1
@app.route("/login", methods=["POST"])
def login():
    username = request.form["username"]   # L1
    password = request.form["password"]   # L1
    cursor.execute(f"SELECT * FROM users WHERE username='{username}' AND password='{password}'")
```

```javascript
// Express — req.params.id là L1
app.get("/user/:id", (req, res) => {
  db.query(`SELECT * FROM users WHERE id = ${req.params.id}`, (err, rows) => {
    res.json(rows);
  });
});
```

```php
<?php
// $_GET['q'] là L1
$q = $_GET['q'];
$result = mysqli_query($conn, "SELECT * FROM products WHERE name LIKE '%$q%'");
```

```go
// chi router — name là L1
name := chi.URLParam(r, "name")
rows, _ := db.Query(fmt.Sprintf("SELECT * FROM accounts WHERE name='%s'", name))
```

### NOT critical — không flag (hoặc downgrade)

```python
# Parameterized — an toàn
cursor.execute("SELECT * FROM users WHERE username=%s AND password=%s", (username, password))
```

```javascript
// Tham số riêng — an toàn
db.query("SELECT * FROM users WHERE id = ?", [req.params.id]);
// Prisma / ORM với binding cũng an toàn
const user = await prisma.user.findUnique({ where: { id: Number(req.params.id) } });
```

```python
# Whitelist enum trước khi nhét vào ORDER BY (cột không tham số hóa được)
ALLOWED = {"name", "created_at", "price"}
sort = request.args.get("sort")
if sort not in ALLOWED:
    abort(400)
cursor.execute(f"SELECT * FROM products ORDER BY {sort}")  # safe vì whitelist
```

## Fix recommendation

1. **Dùng parameterized query / prepared statement**:
   ```python
   # Trước (BAD)
   cursor.execute(f"SELECT * FROM users WHERE id={user_id}")
   # Sau (GOOD)
   cursor.execute("SELECT * FROM users WHERE id=%s", (user_id,))
   ```
2. **Dùng ORM cho query thường**: SQLAlchemy, Prisma, GORM, Eloquent, Django ORM — chúng tự bind tham số.
3. **Tham số không bind được (table name, column name, ORDER BY direction)**: dùng whitelist enum, KHÔNG nhận trực tiếp từ L1.
4. **Tránh dynamic SQL builder** kiểu f-string. Nếu phải build dynamic, dùng query builder của ORM (knex, sqlx).
5. **Defense in depth**: principle of least privilege cho DB user (read-only nếu chỉ select), bật log, dùng WAF.

## Cross-references

- Rule `17-verbose-error-debug-mode`: error SQL trả về full query → giúp attacker exploit nhanh hơn
- Rule `04-idor`: SQLi + thiếu auth ownership = nuke toàn DB
- Rule `07-mass-assignment`: cùng họ "input ghép thẳng" nhưng nhắm vào ORM model
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall