Skip to content

sb-dev/openquant / .agents/skills/rust-review

rust-review

Verified

Review Rust crates, services, or libraries for safe/unsafe boundary issues, memory safety, concurrency hazards, panic-induced denial of service, FFI safety, and async runtime mistakes. Use for a Rust security audit, especially unsafe, FFI, or concurrent code.

FileKindSize
SKILL.mdskill md5.4 KB
upstream/.claude-plugin/plugin.jsonconfig530 B
upstream/README.mdmarkdown8.2 KB
upstream/agents/rust-review-dedup-judge.mdmarkdown20.4 KB
upstream/agents/rust-review-fp-judge.mdmarkdown23.1 KB
upstream/agents/rust-review-worker.mdmarkdown31.8 KB
upstream/prompts/clusters/async-runtime.mdmarkdown855 B
upstream/prompts/clusters/concurrency-data-race.mdmarkdown2.6 KB
upstream/prompts/clusters/concurrency-locking.mdmarkdown6.9 KB
upstream/prompts/clusters/error-handling.mdmarkdown1.6 KB
upstream/prompts/clusters/ffi-cross-language.mdmarkdown3.3 KB
upstream/prompts/clusters/info-disclosure.mdmarkdown562 B
upstream/prompts/clusters/input-os-safety.mdmarkdown1.1 KB
upstream/prompts/clusters/layout-safety.mdmarkdown572 B
upstream/prompts/clusters/logic-correctness.mdmarkdown3.8 KB
upstream/prompts/clusters/manifest.jsonconfig10.9 KB
upstream/prompts/clusters/memory-safety.mdmarkdown4.6 KB
upstream/prompts/clusters/panic-dos.mdmarkdown6.0 KB
upstream/prompts/clusters/recursion-dos.mdmarkdown5.3 KB
upstream/prompts/clusters/resource-handling.mdmarkdown1.5 KB
upstream/prompts/clusters/static-hygiene.mdmarkdown746 B
upstream/prompts/clusters/unsafe-boundary.mdmarkdown15.6 KB
upstream/prompts/general/abi-mismatch-finder.mdmarkdown705 B
upstream/prompts/general/adversarial-trait-finder.mdmarkdown1.5 KB
upstream/prompts/general/arithmetic-overflow-finder.mdmarkdown2.1 KB
upstream/prompts/general/assertion-reachable-finder.mdmarkdown879 B
upstream/prompts/general/async-blocking-finder.mdmarkdown1.2 KB
upstream/prompts/general/atomic-race-finder.mdmarkdown1.3 KB
upstream/prompts/general/buffer-overflow-unsafe-finder.mdmarkdown2.6 KB
upstream/prompts/general/bufwriter-unflushed-finder.mdmarkdown995 B
upstream/prompts/general/cancel-safety-finder.mdmarkdown1.2 KB
upstream/prompts/general/cargo-lint-config-finder.mdmarkdown2.4 KB
upstream/prompts/general/closure-ffi-finder.mdmarkdown3.9 KB
upstream/prompts/general/closure-panic-finder.mdmarkdown1.1 KB
upstream/prompts/general/collection-key-mutation-finder.mdmarkdown1.9 KB
upstream/prompts/general/cstring-dangling-finder.mdmarkdown1.3 KB
upstream/prompts/general/deprecated-api-finder.mdmarkdown1.9 KB
upstream/prompts/general/destructor-skip-finder.mdmarkdown1.4 KB
upstream/prompts/general/double-free-finder.mdmarkdown1.6 KB
upstream/prompts/general/drop-panic-finder.mdmarkdown973 B
upstream/prompts/general/dyn-trait-ffi-finder.mdmarkdown2.8 KB
upstream/prompts/general/float-edge-finder.mdmarkdown798 B
upstream/prompts/general/foreign-drop-finder.mdmarkdown2.7 KB
upstream/prompts/general/invalid-free-finder.mdmarkdown1.2 KB
upstream/prompts/general/lossy-from-into-finder.mdmarkdown603 B
upstream/prompts/general/lossy-str-conversion-finder.mdmarkdown1.2 KB
upstream/prompts/general/msrv-mismatch-finder.mdmarkdown401 B
upstream/prompts/general/nondeterminism-finder.mdmarkdown1.6 KB
upstream/prompts/general/opaque-pointer-finder.mdmarkdown1.9 KB
upstream/prompts/general/ord-eq-hash-finder.mdmarkdown754 B
upstream/prompts/general/out-of-bounds-index-finder.mdmarkdown727 B
upstream/prompts/general/packed-field-ref-finder.mdmarkdown3.7 KB
upstream/prompts/general/panic-unwind-unsafe-finder.mdmarkdown3.0 KB
upstream/prompts/general/path-traversal-join-finder.mdmarkdown1.7 KB
upstream/prompts/general/pointer-exposure-finder.mdmarkdown1.8 KB
upstream/prompts/general/raw-fd-lifecycle-finder.mdmarkdown2.0 KB
upstream/prompts/general/recursive-deserialize-stack-overflow-finder.mdmarkdown4.8 KB
upstream/prompts/general/recursive-drop-stack-overflow-finder.mdmarkdown2.7 KB
upstream/prompts/general/recursive-format-stack-overflow-finder.mdmarkdown4.1 KB
upstream/prompts/general/refcell-borrow-panic-finder.mdmarkdown1.2 KB
upstream/prompts/general/repr-c-padding-finder.mdmarkdown2.2 KB
upstream/prompts/general/resource-exhaustion-finder.mdmarkdown2.4 KB
upstream/prompts/general/result-discarded-finder.mdmarkdown1.6 KB
upstream/prompts/general/select-bias-finder.mdmarkdown1.2 KB
upstream/prompts/general/send-sync-bounds-finder.mdmarkdown2.6 KB
upstream/prompts/general/serialize-struct-mismatch-finder.mdmarkdown2.3 KB
upstream/prompts/general/shared-memory-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/static-mut-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/str-slice-boundary-finder.mdmarkdown1.0 KB
upstream/prompts/general/string-comparison-finder.mdmarkdown1.4 KB
upstream/prompts/general/toctou-finder.mdmarkdown1.3 KB
upstream/prompts/general/uninitialized-read-finder.mdmarkdown1.8 KB
upstream/prompts/general/union-ub-finder.mdmarkdown3.5 KB
upstream/prompts/general/unsafe-sync-impl-finder.mdmarkdown3.7 KB
upstream/prompts/general/unwrap-on-untrusted-finder.mdmarkdown1.3 KB
upstream/prompts/general/use-after-free-finder.mdmarkdown2.9 KB
upstream/prompts/general/vec-set-len-uninit-finder.mdmarkdown2.5 KB
upstream/scripts/build_run_plan.pyscript24.0 KB
upstream/scripts/generate_sarif.pyexecutablescript22.9 KB
upstream/scripts/pyproject.tomlmanifest220 B
upstream/scripts/test_gating.pyscript12.6 KB
upstream/scripts/test_generate_sarif.pyscript19.5 KB
upstream/scripts/test_prompt_regexes.pyscript4.3 KB
upstream/scripts/test_split.pyscript10.2 KB
upstream/scripts/test_validate_artifacts.pyscript10.3 KB
upstream/scripts/validate_artifacts.pyscript11.4 KB
upstream/skills/rust-review/SKILL.upstream.mdmarkdown43.5 KB

upstream/prompts/general/unsafe-sync-impl-finder.md

View on GitHub
---
name: unsafe-sync-impl-finder
description: Audits unsafe impl Send/Sync over types with interior mutability
---

**Finding ID Prefix:** `UNSAFESYNC`.

**Bug shape:** a manual `unsafe impl Send`/`Sync for MyStruct {}` overrides the auto-derived `!Send`/`!Sync` of a payload that is not actually thread-safe — a raw pointer, `UnsafeCell`, or a handle to non-thread-safe foreign state. The unsoundness can come from **either** unsynchronized interior mutation through `&self`, **or** simply making a non-thread-safe payload transferable (`Send`) / shareable (`Sync`) across threads with **no Rust-side mutation at all** (e.g. `struct W(*mut CHandle); unsafe impl Send for W {}` over a single-threaded C handle).

**Gates:**

1. `unsafe impl (Send | Sync) for T` exists.
2. `T` contains at least one field that is **not** auto-`Send`/`Sync`: a raw pointer (`*mut`/`*const`), `NonNull`, `UnsafeCell`/`Cell`/`RefCell`, `Rc`, a `MutexGuard`, or any other `!Send`/`!Sync` type (e.g. an FFI handle). It need not be a literal raw pointer — `struct W(NonNull<CHandle>)` / `struct W(Rc<u32>)` are the common real shapes.
3. At least **one** of: (a) `T`'s `&self` methods mutate the interior without internal synchronization; **or** (b) `T` holds a raw pointer / non-`Send` / non-`Sync` field and the manual impl lets that payload be transferred (`Send`) or shared (`Sync`) across threads without the wrapped resource being thread-safe — **no `&self` mutation required**. Treat the test as "the auto-derived `!Send`/`!Sync` was overridden without a justifying invariant", not strictly "mutation through `&self`".

**FPs:**

- Interior mutation goes through `Atomic*`.
- The payload is genuinely thread-safe for the trait being impl'd (every field is itself `Send`/`Sync`, or interior mutation goes through an atomic/`Mutex`/`RwLock`), making the manual impl redundant rather than unsound. (Note: confining mutation to `&mut self` does **not** by itself make a manual `unsafe impl Send`/`Sync` sound — `Sync` concerns shared `&self` access to a possibly non-thread-safe payload and `Send` concerns transfer, neither of which requires `&self` mutation.)
- `T`'s manual impl is justified by an invariant that is **actually enforced for all safe uses** — not merely documented. `unsafe impl Send`/`Sync` grants the capability to *all* safe code, so a `// SAFETY:`/doc comment alone does **not** make it sound: a bare `*mut CHandle` wrapper that safe code can freely construct and move across threads is still unsound *even with* a "caller must use one thread" comment (that is the bug shape above, not an FP). The invariant counts only when the type's API upholds it — e.g. the sole constructor is `unsafe` (shifting the obligation to callers), or every access is gated behind a `Mutex`/`RwLock`/atomic the wrapper owns. Verify enforcement, not the mere presence of a comment.

**Search patterns:**

```
unsafe\s+impl\b.*\b(Send|Sync)\b\s+for
UnsafeCell|\bCell\b|\bRefCell\b|\bNonNull\b|\bRc<|\bMutexGuard\b
\*mut\s|\*const\s
```

The first pattern uses `impl\b.*\b(Send|Sync)\b` (not `impl\s+(Send|Sync)`) so it also matches the dominant generic forms `unsafe impl<T> Send for Wrapper<T>` and `unsafe impl<T: ?Sized> Sync for Box<T>`, where `<...>` sits between `impl` and the trait. The second/third lines seed Gate 2's raw-pointer / interior-mutable fields (`*mut`/`*const`, `Cell`/`RefCell`), not just `UnsafeCell`.

**Recommendation:** remove the manual `unsafe impl` and let the type stay `!Send`/`!Sync`; or make the payload genuinely thread-safe (wrap mutation in `Mutex`/`RwLock`/atomics, or replace the raw pointer with a `Send`/`Sync` type); or, if the impl is truly required, document the exact synchronization invariant the caller must uphold and why it justifies overriding the auto trait.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall