Skip to content

sb-dev/openquant / .agents/skills/rust-review

rust-review

Verified

Review Rust crates, services, or libraries for safe/unsafe boundary issues, memory safety, concurrency hazards, panic-induced denial of service, FFI safety, and async runtime mistakes. Use for a Rust security audit, especially unsafe, FFI, or concurrent code.

FileKindSize
SKILL.mdskill md5.4 KB
upstream/.claude-plugin/plugin.jsonconfig530 B
upstream/README.mdmarkdown8.2 KB
upstream/agents/rust-review-dedup-judge.mdmarkdown20.4 KB
upstream/agents/rust-review-fp-judge.mdmarkdown23.1 KB
upstream/agents/rust-review-worker.mdmarkdown31.8 KB
upstream/prompts/clusters/async-runtime.mdmarkdown855 B
upstream/prompts/clusters/concurrency-data-race.mdmarkdown2.6 KB
upstream/prompts/clusters/concurrency-locking.mdmarkdown6.9 KB
upstream/prompts/clusters/error-handling.mdmarkdown1.6 KB
upstream/prompts/clusters/ffi-cross-language.mdmarkdown3.3 KB
upstream/prompts/clusters/info-disclosure.mdmarkdown562 B
upstream/prompts/clusters/input-os-safety.mdmarkdown1.1 KB
upstream/prompts/clusters/layout-safety.mdmarkdown572 B
upstream/prompts/clusters/logic-correctness.mdmarkdown3.8 KB
upstream/prompts/clusters/manifest.jsonconfig10.9 KB
upstream/prompts/clusters/memory-safety.mdmarkdown4.6 KB
upstream/prompts/clusters/panic-dos.mdmarkdown6.0 KB
upstream/prompts/clusters/recursion-dos.mdmarkdown5.3 KB
upstream/prompts/clusters/resource-handling.mdmarkdown1.5 KB
upstream/prompts/clusters/static-hygiene.mdmarkdown746 B
upstream/prompts/clusters/unsafe-boundary.mdmarkdown15.6 KB
upstream/prompts/general/abi-mismatch-finder.mdmarkdown705 B
upstream/prompts/general/adversarial-trait-finder.mdmarkdown1.5 KB
upstream/prompts/general/arithmetic-overflow-finder.mdmarkdown2.1 KB
upstream/prompts/general/assertion-reachable-finder.mdmarkdown879 B
upstream/prompts/general/async-blocking-finder.mdmarkdown1.2 KB
upstream/prompts/general/atomic-race-finder.mdmarkdown1.3 KB
upstream/prompts/general/buffer-overflow-unsafe-finder.mdmarkdown2.6 KB
upstream/prompts/general/bufwriter-unflushed-finder.mdmarkdown995 B
upstream/prompts/general/cancel-safety-finder.mdmarkdown1.2 KB
upstream/prompts/general/cargo-lint-config-finder.mdmarkdown2.4 KB
upstream/prompts/general/closure-ffi-finder.mdmarkdown3.9 KB
upstream/prompts/general/closure-panic-finder.mdmarkdown1.1 KB
upstream/prompts/general/collection-key-mutation-finder.mdmarkdown1.9 KB
upstream/prompts/general/cstring-dangling-finder.mdmarkdown1.3 KB
upstream/prompts/general/deprecated-api-finder.mdmarkdown1.9 KB
upstream/prompts/general/destructor-skip-finder.mdmarkdown1.4 KB
upstream/prompts/general/double-free-finder.mdmarkdown1.6 KB
upstream/prompts/general/drop-panic-finder.mdmarkdown973 B
upstream/prompts/general/dyn-trait-ffi-finder.mdmarkdown2.8 KB
upstream/prompts/general/float-edge-finder.mdmarkdown798 B
upstream/prompts/general/foreign-drop-finder.mdmarkdown2.7 KB
upstream/prompts/general/invalid-free-finder.mdmarkdown1.2 KB
upstream/prompts/general/lossy-from-into-finder.mdmarkdown603 B
upstream/prompts/general/lossy-str-conversion-finder.mdmarkdown1.2 KB
upstream/prompts/general/msrv-mismatch-finder.mdmarkdown401 B
upstream/prompts/general/nondeterminism-finder.mdmarkdown1.6 KB
upstream/prompts/general/opaque-pointer-finder.mdmarkdown1.9 KB
upstream/prompts/general/ord-eq-hash-finder.mdmarkdown754 B
upstream/prompts/general/out-of-bounds-index-finder.mdmarkdown727 B
upstream/prompts/general/packed-field-ref-finder.mdmarkdown3.7 KB
upstream/prompts/general/panic-unwind-unsafe-finder.mdmarkdown3.0 KB
upstream/prompts/general/path-traversal-join-finder.mdmarkdown1.7 KB
upstream/prompts/general/pointer-exposure-finder.mdmarkdown1.8 KB
upstream/prompts/general/raw-fd-lifecycle-finder.mdmarkdown2.0 KB
upstream/prompts/general/recursive-deserialize-stack-overflow-finder.mdmarkdown4.8 KB
upstream/prompts/general/recursive-drop-stack-overflow-finder.mdmarkdown2.7 KB
upstream/prompts/general/recursive-format-stack-overflow-finder.mdmarkdown4.1 KB
upstream/prompts/general/refcell-borrow-panic-finder.mdmarkdown1.2 KB
upstream/prompts/general/repr-c-padding-finder.mdmarkdown2.2 KB
upstream/prompts/general/resource-exhaustion-finder.mdmarkdown2.4 KB
upstream/prompts/general/result-discarded-finder.mdmarkdown1.6 KB
upstream/prompts/general/select-bias-finder.mdmarkdown1.2 KB
upstream/prompts/general/send-sync-bounds-finder.mdmarkdown2.6 KB
upstream/prompts/general/serialize-struct-mismatch-finder.mdmarkdown2.3 KB
upstream/prompts/general/shared-memory-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/static-mut-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/str-slice-boundary-finder.mdmarkdown1.0 KB
upstream/prompts/general/string-comparison-finder.mdmarkdown1.4 KB
upstream/prompts/general/toctou-finder.mdmarkdown1.3 KB
upstream/prompts/general/uninitialized-read-finder.mdmarkdown1.8 KB
upstream/prompts/general/union-ub-finder.mdmarkdown3.5 KB
upstream/prompts/general/unsafe-sync-impl-finder.mdmarkdown3.7 KB
upstream/prompts/general/unwrap-on-untrusted-finder.mdmarkdown1.3 KB
upstream/prompts/general/use-after-free-finder.mdmarkdown2.9 KB
upstream/prompts/general/vec-set-len-uninit-finder.mdmarkdown2.5 KB
upstream/scripts/build_run_plan.pyscript24.0 KB
upstream/scripts/generate_sarif.pyexecutablescript22.9 KB
upstream/scripts/pyproject.tomlmanifest220 B
upstream/scripts/test_gating.pyscript12.6 KB
upstream/scripts/test_generate_sarif.pyscript19.5 KB
upstream/scripts/test_prompt_regexes.pyscript4.3 KB
upstream/scripts/test_split.pyscript10.2 KB
upstream/scripts/test_validate_artifacts.pyscript10.3 KB
upstream/scripts/validate_artifacts.pyscript11.4 KB
upstream/skills/rust-review/SKILL.upstream.mdmarkdown43.5 KB

upstream/prompts/general/recursive-format-stack-overflow-finder.md

View on GitHub
---
name: recursive-format-stack-overflow-finder
description: Detects format/Display/Debug/Serialize/log macros applied to recursive types reachable from untrusted input, where depth-proportional stack growth causes an uncatchable abort
---

**Finding ID Prefix:** `RECURSEFMT`.

**Gates:**

1. A formatting/serializing/logging sink applied to a value `v`:
   - `format!`, `print!`/`println!`, `eprint!`/`eprintln!`, `write!`/`writeln!`, `dbg!`
   - `v.to_string()`, `format!("{}", v)`, `format!("{:?}", v)`, `format!("{:#?}", v)`
   - `tracing::{trace,debug,info,warn,error}!` / `log::{...}!` with `{}`/`{:?}` of `v`
   - `serde_json::{to_string,to_vec,to_writer}` (and `_pretty` variants), `serde_yaml::to_string`, `toml::to_string`, `ron::to_string`, `bincode::serialize`, `ciborium::ser::into_writer`
   - `anyhow!`/`bail!`/`thiserror`-derived `Display` chains that embed `v` via `{:?}`/`{}`
2. The static type of `v` (or a field of `v` reached during formatting) is in `rec_map` from Phase A — i.e., recursive directly or via `serde_json::Value` / `serde_yaml::Value` / `toml::Value` / `syn::*` / `proc_macro2::TokenStream` / similar.
3. `v` is reachable from an untrusted source identified in Phase B, OR `v` is constructed via repeated `clone`/`push`/append loops on untrusted data so that depth can grow with input size.
4. Neither the type's `Display`/`Debug`/`Serialize` impl nor a wrapper at the call site bounds depth. Specifically:
   - No `Formatter::precision()` / max-depth check in a hand-written `impl Debug`/`impl Display`.
   - No truncating wrapper (`pretty_assertions::Comparison`, custom `Truncated<&T>`, `tracing` field redaction, etc.).
   - No `serde_stacker` deserializer/serializer wrapping the codec.

**Why it matters:** stack overflow is uncatchable — `catch_unwind` does **not** trap it. The **entire process** aborts (a stack overflow in any thread aborts the whole process via the runtime's SIGSEGV handler — never just the offending thread), regardless of `panic` strategy. `serde_json` enforces a 128-deep recursion limit on **parse**, but **no** symmetric limit exists on `Serialize`/`Debug`/`Display`. A deep value therefore reaches a formatting sink only when a parse cap did **not** bound it: a value decoded by a codec with no default limit (`bincode`, `postcard`), a value decoded by a codec whose default recursion limit was raised/disabled (`serde_json::Deserializer::disable_recursion_limit()`, `ron::Options::without_recursion_limit`, `toml`'s `unbounded` feature — note `serde_json`/`serde_yaml`/`toml`/`ron`/`ciborium` all default-cap at ~128/128/~80/128/256), or a value built programmatically (repeated `push`/`clone`). A value parsed by *default* `serde_json` is ≤128 deep — too shallow to overflow on re-emit — so the format-side hazard does **not** apply to it (see `RECURSEDES` for the parse-side cap). Error chains (`anyhow`, `eyre`, `thiserror` with `#[source]`) compound the risk: a Display of one error transitively formats every wrapped cause.

**FPs (reject):**

- The type is recursive in definition but the codebase provably bounds depth at construction (e.g., a parser that rejects depth > N before insertion, *and* the same type is not constructed by any other path).
- The formatting site is statically unreachable from untrusted input (constants, build-script-time values, `#[cfg(test)]`).
- A hand-written `impl Debug`/`impl Display` already implements depth limiting (read the body — recursion guarded by an explicit counter or `f.precision()`).
- The recursive field is behind a `Lazy`/`OnceCell` populated only from trusted config.

**Patch:**

- Wrap the sink in a truncating display: implement `Debug` manually with a depth counter that bails to `…` past a threshold, or pass through a `Truncated<&T, N>` newtype that does the same.
- For `serde_json`/etc. re-emission of untrusted values, route through `serde_stacker::Serializer` (grows heap-allocated stack frames) or precompute a depth check and refuse > N.
- For log lines, drop `{:?}` of recursive values and emit shape summaries (`len`, `kind`, top-level keys) instead of the full structure.
- For error chains, render with `anyhow::Chain` / explicit iteration rather than nested `Display` recursion.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 470kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall