sb-dev/openquant / .agents/skills/rust-review
rust-review
VerifiedReview Rust crates, services, or libraries for safe/unsafe boundary issues, memory safety, concurrency hazards, panic-induced denial of service, FFI safety, and async runtime mistakes. Use for a Rust security audit, especially unsafe, FFI, or concurrent code.
upstream/prompts/general/ord-eq-hash-finder.md
View on GitHub---
name: ord-eq-hash-finder
description: Detects manual Ord/PartialOrd/Eq/PartialEq/Hash impls that violate required invariants
---
**Finding ID Prefix:** `ORDEQHASH`.
**Gates:**
1. Manual (non-derived) `impl Ord` / `impl PartialOrd` / `impl Eq` / `impl PartialEq` / `impl Hash` exists.
2. At least one invariant is checkable as violated by reading the impl: (a) `a == b ⟹ hash(a) == hash(b)`, (b) `Ord::cmp` total order consistency with `PartialOrd::partial_cmp`, (c) `Eq` reflexivity/symmetry/transitivity, (d) NaN handling for floats.
**Why:** violations corrupt `HashMap`/`BTreeMap` (collisions, missing keys, infinite loops in some std internals).
**Patch:** derive when possible; otherwise document invariant proofs and add property tests.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |