sb-dev/openquant / .agents/skills/rust-review
rust-review
VerifiedReview Rust crates, services, or libraries for safe/unsafe boundary issues, memory safety, concurrency hazards, panic-induced denial of service, FFI safety, and async runtime mistakes. Use for a Rust security audit, especially unsafe, FFI, or concurrent code.
upstream/prompts/general/drop-panic-finder.md
View on GitHub---
name: drop-panic-finder
description: Detects panic possibility inside Drop impls (double-panic abort) or Mutex poisoning paths
---
**Finding ID Prefix:** `DROPPANIC`.
**Gates:**
1. `impl Drop for T` exists.
2. The `drop` method body contains an operation that can panic: `.unwrap()`, `.expect()`, arithmetic, indexing, `assert!`, or any `panic!`. (Allocation is **not** a panic source under `std` + the default allocator — allocation *failure* calls `handle_alloc_error`, which aborts without unwinding; only `no_std` or a custom panicking alloc-error hook makes it unwind.)
3. The type is constructed in user-reachable code paths (not test-only).
**Why it matters:** if `Drop` panics during stack unwinding from another panic, the process aborts. If `Drop` panics holding a `Mutex` guard, the mutex is poisoned and downstream `.lock().unwrap()` calls panic too — a propagating DoS.
**Patch:** log-and-swallow inside `Drop`; never `.unwrap()` in a destructor.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |