sb-dev/openquant / .agents/skills/rust-review
rust-review
VerifiedReview Rust crates, services, or libraries for safe/unsafe boundary issues, memory safety, concurrency hazards, panic-induced denial of service, FFI safety, and async runtime mistakes. Use for a Rust security audit, especially unsafe, FFI, or concurrent code.
upstream/prompts/general/assertion-reachable-finder.md
View on GitHub---
name: assertion-reachable-finder
description: Detects reachable unreachable!()/unimplemented!()/todo!()/assert!() in non-test code
---
**Finding ID Prefix:** `ASSERTREACH`.
**Gates:**
1. Macro: `unreachable!`, `unimplemented!`, `todo!`, `assert!`, `assert_eq!`, `assert_ne!`, `panic!`, or `debug_assert!` in `release` builds (note: `debug_assert!` is no-op in release; OOS unless `debug-assertions = true`).
2. Not gated by `#[cfg(test)]` / `#[cfg(debug_assertions)]`.
3. Has at least one reachable control-flow path from a `pub fn` or trait-impl method, OR the condition can be falsified by untrusted input.
**FPs:**
- Exhaustiveness markers where the compiler-checked match makes the branch genuinely unreachable (verify by reading the match's arms).
- Asserts inside `#[cfg(test)]` modules.
**Patch:** replace `unreachable!`/`assert!` with structured error returns.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |