Skip to content

sb-dev/openquant / .agents/skills/rust-review

rust-review

Verified

Review Rust crates, services, or libraries for safe/unsafe boundary issues, memory safety, concurrency hazards, panic-induced denial of service, FFI safety, and async runtime mistakes. Use for a Rust security audit, especially unsafe, FFI, or concurrent code.

FileKindSize
SKILL.mdskill md5.4 KB
upstream/.claude-plugin/plugin.jsonconfig530 B
upstream/README.mdmarkdown8.2 KB
upstream/agents/rust-review-dedup-judge.mdmarkdown20.4 KB
upstream/agents/rust-review-fp-judge.mdmarkdown23.1 KB
upstream/agents/rust-review-worker.mdmarkdown31.8 KB
upstream/prompts/clusters/async-runtime.mdmarkdown855 B
upstream/prompts/clusters/concurrency-data-race.mdmarkdown2.6 KB
upstream/prompts/clusters/concurrency-locking.mdmarkdown6.9 KB
upstream/prompts/clusters/error-handling.mdmarkdown1.6 KB
upstream/prompts/clusters/ffi-cross-language.mdmarkdown3.3 KB
upstream/prompts/clusters/info-disclosure.mdmarkdown562 B
upstream/prompts/clusters/input-os-safety.mdmarkdown1.1 KB
upstream/prompts/clusters/layout-safety.mdmarkdown572 B
upstream/prompts/clusters/logic-correctness.mdmarkdown3.8 KB
upstream/prompts/clusters/manifest.jsonconfig10.9 KB
upstream/prompts/clusters/memory-safety.mdmarkdown4.6 KB
upstream/prompts/clusters/panic-dos.mdmarkdown6.0 KB
upstream/prompts/clusters/recursion-dos.mdmarkdown5.3 KB
upstream/prompts/clusters/resource-handling.mdmarkdown1.5 KB
upstream/prompts/clusters/static-hygiene.mdmarkdown746 B
upstream/prompts/clusters/unsafe-boundary.mdmarkdown15.6 KB
upstream/prompts/general/abi-mismatch-finder.mdmarkdown705 B
upstream/prompts/general/adversarial-trait-finder.mdmarkdown1.5 KB
upstream/prompts/general/arithmetic-overflow-finder.mdmarkdown2.1 KB
upstream/prompts/general/assertion-reachable-finder.mdmarkdown879 B
upstream/prompts/general/async-blocking-finder.mdmarkdown1.2 KB
upstream/prompts/general/atomic-race-finder.mdmarkdown1.3 KB
upstream/prompts/general/buffer-overflow-unsafe-finder.mdmarkdown2.6 KB
upstream/prompts/general/bufwriter-unflushed-finder.mdmarkdown995 B
upstream/prompts/general/cancel-safety-finder.mdmarkdown1.2 KB
upstream/prompts/general/cargo-lint-config-finder.mdmarkdown2.4 KB
upstream/prompts/general/closure-ffi-finder.mdmarkdown3.9 KB
upstream/prompts/general/closure-panic-finder.mdmarkdown1.1 KB
upstream/prompts/general/collection-key-mutation-finder.mdmarkdown1.9 KB
upstream/prompts/general/cstring-dangling-finder.mdmarkdown1.3 KB
upstream/prompts/general/deprecated-api-finder.mdmarkdown1.9 KB
upstream/prompts/general/destructor-skip-finder.mdmarkdown1.4 KB
upstream/prompts/general/double-free-finder.mdmarkdown1.6 KB
upstream/prompts/general/drop-panic-finder.mdmarkdown973 B
upstream/prompts/general/dyn-trait-ffi-finder.mdmarkdown2.8 KB
upstream/prompts/general/float-edge-finder.mdmarkdown798 B
upstream/prompts/general/foreign-drop-finder.mdmarkdown2.7 KB
upstream/prompts/general/invalid-free-finder.mdmarkdown1.2 KB
upstream/prompts/general/lossy-from-into-finder.mdmarkdown603 B
upstream/prompts/general/lossy-str-conversion-finder.mdmarkdown1.2 KB
upstream/prompts/general/msrv-mismatch-finder.mdmarkdown401 B
upstream/prompts/general/nondeterminism-finder.mdmarkdown1.6 KB
upstream/prompts/general/opaque-pointer-finder.mdmarkdown1.9 KB
upstream/prompts/general/ord-eq-hash-finder.mdmarkdown754 B
upstream/prompts/general/out-of-bounds-index-finder.mdmarkdown727 B
upstream/prompts/general/packed-field-ref-finder.mdmarkdown3.7 KB
upstream/prompts/general/panic-unwind-unsafe-finder.mdmarkdown3.0 KB
upstream/prompts/general/path-traversal-join-finder.mdmarkdown1.7 KB
upstream/prompts/general/pointer-exposure-finder.mdmarkdown1.8 KB
upstream/prompts/general/raw-fd-lifecycle-finder.mdmarkdown2.0 KB
upstream/prompts/general/recursive-deserialize-stack-overflow-finder.mdmarkdown4.8 KB
upstream/prompts/general/recursive-drop-stack-overflow-finder.mdmarkdown2.7 KB
upstream/prompts/general/recursive-format-stack-overflow-finder.mdmarkdown4.1 KB
upstream/prompts/general/refcell-borrow-panic-finder.mdmarkdown1.2 KB
upstream/prompts/general/repr-c-padding-finder.mdmarkdown2.2 KB
upstream/prompts/general/resource-exhaustion-finder.mdmarkdown2.4 KB
upstream/prompts/general/result-discarded-finder.mdmarkdown1.6 KB
upstream/prompts/general/select-bias-finder.mdmarkdown1.2 KB
upstream/prompts/general/send-sync-bounds-finder.mdmarkdown2.6 KB
upstream/prompts/general/serialize-struct-mismatch-finder.mdmarkdown2.3 KB
upstream/prompts/general/shared-memory-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/static-mut-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/str-slice-boundary-finder.mdmarkdown1.0 KB
upstream/prompts/general/string-comparison-finder.mdmarkdown1.4 KB
upstream/prompts/general/toctou-finder.mdmarkdown1.3 KB
upstream/prompts/general/uninitialized-read-finder.mdmarkdown1.8 KB
upstream/prompts/general/union-ub-finder.mdmarkdown3.5 KB
upstream/prompts/general/unsafe-sync-impl-finder.mdmarkdown3.7 KB
upstream/prompts/general/unwrap-on-untrusted-finder.mdmarkdown1.3 KB
upstream/prompts/general/use-after-free-finder.mdmarkdown2.9 KB
upstream/prompts/general/vec-set-len-uninit-finder.mdmarkdown2.5 KB
upstream/scripts/build_run_plan.pyscript24.0 KB
upstream/scripts/generate_sarif.pyexecutablescript22.9 KB
upstream/scripts/pyproject.tomlmanifest220 B
upstream/scripts/test_gating.pyscript12.6 KB
upstream/scripts/test_generate_sarif.pyscript19.5 KB
upstream/scripts/test_prompt_regexes.pyscript4.3 KB
upstream/scripts/test_split.pyscript10.2 KB
upstream/scripts/test_validate_artifacts.pyscript10.3 KB
upstream/scripts/validate_artifacts.pyscript11.4 KB
upstream/skills/rust-review/SKILL.upstream.mdmarkdown43.5 KB

upstream/prompts/clusters/logic-correctness.md

View on GitHub
---
name: cluster-logic-correctness
kind: cluster
consolidated: false
covers:
  - ord-eq-hash                # ORDEQHASH
  - adversarial-trait          # TRAITADV
  - closure-panic              # CLOSUREPANIC
  - float-edge                 # FLOATEDGE
  - string-comparison          # STRCMP
  - serialize-struct-mismatch  # SERFIELDS
  - nondeterminism             # NONDET
  - collection-key-mutation    # KEYMUT
---

# Cluster: Logic correctness

ID prefixes: `ORDEQHASH`, `TRAITADV`, `CLOSUREPANIC`, `FLOATEDGE`, `STRCMP`, `SERFIELDS`, `NONDET`, `KEYMUT`.

## Phase A

```
rg seed: "impl\b[^{]*?\b(Ord|PartialOrd|Eq|PartialEq|Hash)\b[^{]*\bfor\b"  # hand impls incl. generic `impl<T> Ord for W<T>` and `impl PartialOrd<Other> for Foo`
rg seed: "#\[derive\([^)]*\b(Ord|PartialOrd|Eq|PartialEq|Hash)\b"          # derived — a hand/derive split across these traits is a common inconsistency source
rg seed: "\b(f32|f64)\b"
rg seed: "<\s*\w+\s*:\s*[A-Z]"  # generic trait bounds
rg seed: "\bcatch_unwind\b"
rg seed: "\bFn(Once|Mut)?\b|\bptr::(read|write)\b|\bdrop_in_place\b"  # closure-accepting bounds + pointer ops → CLOSUREPANIC unsafe windows
rg seed: "\b(starts_with|ends_with|contains)\b"
rg seed: "eq_ignore_ascii_case|to_lowercase|to_uppercase|to_ascii_lowercase|to_ascii_uppercase"  # case-folding → STRCMP case-mixing
rg seed: "serialize_(struct|tuple|seq|map)\("
rg seed: "\bHashMap\b|\bHashSet\b"
rg seed: "peek_mut|RefCell\b|Cell\b"
```

## Phase B — Run finders in order

Apply each pass against the Phase-A inventory; detailed detection + FP guidance live in the per-class finder files (do not re-derive them here).

1. **`ORDEQHASH` — ord-eq-hash** — hand `Ord`/`PartialOrd`/`Eq`/`PartialEq`/`Hash` impls that violate the consistency contracts (incl. a hand/derive split across them). Seed: the `impl … for` and `#[derive(…)]` greps.
2. **`TRAITADV` — adversarial-trait** *(requires `has_unsafe`)* — a hostile generic trait impl breaks an invariant an `unsafe` block relies on. Seed: generic trait bounds.
3. **`CLOSUREPANIC` — closure-panic** *(requires `has_unsafe`)* — a user closure invoked between two pointer ops panics and leaves an `unsafe` scaffold inconsistent. Seed: `Fn`/`FnMut`/`FnOnce` bounds + `ptr::read`/`ptr::write`/`drop_in_place` windows, `catch_unwind`.
4. **`FLOATEDGE` — float-edge** — NaN/Inf comparison or ordering edge cases (e.g. saturating `f64 as usize`). Seed: `f32` / `f64`.
5. **`STRCMP` — string-comparison** — partial / case-insensitive comparison bypasses a check. Seed: `starts_with`/`ends_with`/`contains` + case-folding (`eq_ignore_ascii_case`, `to_lowercase`, …).
6. **`SERFIELDS` — serialize-struct-mismatch** — `serialize_struct(len)` (or `serialize_tuple`/`serialize_seq(Some(N))`/`serialize_map(Some(N))`) field-count disagreement corrupts output. Seed: `serialize_struct(`/`serialize_tuple(`/`serialize_seq(`/`serialize_map(`.
7. **`NONDET` — nondeterminism** — `HashMap`/`HashSet` iteration or hashing introduces nondeterminism in replicated/consensus state. Seed: `HashMap` / `HashSet`.
8. **`KEYMUT` — collection-key-mutation** — mutating a key or heap element already stored in a map/set/heap breaks its ordering/hash invariant. Seed: `peek_mut` / `RefCell` / `Cell`.

## Deconfliction

- `ORDEQHASH` vs `KEYMUT`: a *broken* `Ord`/`Hash` impl is `ORDEQHASH`; mutating an otherwise-correct key already inside a collection is `KEYMUT`.
- `FLOATEDGE` vs `ORDEQHASH`: a NaN-induced `PartialOrd` surprise at a use site is `FLOATEDGE`; a hand `Ord` impl that is internally inconsistent is `ORDEQHASH`.
- `NONDET` vs `KEYMUT`: nondeterministic *iteration order* is `NONDET`; in-place *key mutation* breaking lookup is `KEYMUT`.
- `CLOSUREPANIC` (here) vs `PANICUNWIND` (memory-safety): a user `Fn` panicking between two pointer ops vs container metadata left stale across unwind.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall