Skip to content

sb-dev/openquant / .agents/skills/rust-review

rust-review

Verified

Review Rust crates, services, or libraries for safe/unsafe boundary issues, memory safety, concurrency hazards, panic-induced denial of service, FFI safety, and async runtime mistakes. Use for a Rust security audit, especially unsafe, FFI, or concurrent code.

FileKindSize
SKILL.mdskill md5.4 KB
upstream/.claude-plugin/plugin.jsonconfig530 B
upstream/README.mdmarkdown8.2 KB
upstream/agents/rust-review-dedup-judge.mdmarkdown20.4 KB
upstream/agents/rust-review-fp-judge.mdmarkdown23.1 KB
upstream/agents/rust-review-worker.mdmarkdown31.8 KB
upstream/prompts/clusters/async-runtime.mdmarkdown855 B
upstream/prompts/clusters/concurrency-data-race.mdmarkdown2.6 KB
upstream/prompts/clusters/concurrency-locking.mdmarkdown6.9 KB
upstream/prompts/clusters/error-handling.mdmarkdown1.6 KB
upstream/prompts/clusters/ffi-cross-language.mdmarkdown3.3 KB
upstream/prompts/clusters/info-disclosure.mdmarkdown562 B
upstream/prompts/clusters/input-os-safety.mdmarkdown1.1 KB
upstream/prompts/clusters/layout-safety.mdmarkdown572 B
upstream/prompts/clusters/logic-correctness.mdmarkdown3.8 KB
upstream/prompts/clusters/manifest.jsonconfig10.9 KB
upstream/prompts/clusters/memory-safety.mdmarkdown4.6 KB
upstream/prompts/clusters/panic-dos.mdmarkdown6.0 KB
upstream/prompts/clusters/recursion-dos.mdmarkdown5.3 KB
upstream/prompts/clusters/resource-handling.mdmarkdown1.5 KB
upstream/prompts/clusters/static-hygiene.mdmarkdown746 B
upstream/prompts/clusters/unsafe-boundary.mdmarkdown15.6 KB
upstream/prompts/general/abi-mismatch-finder.mdmarkdown705 B
upstream/prompts/general/adversarial-trait-finder.mdmarkdown1.5 KB
upstream/prompts/general/arithmetic-overflow-finder.mdmarkdown2.1 KB
upstream/prompts/general/assertion-reachable-finder.mdmarkdown879 B
upstream/prompts/general/async-blocking-finder.mdmarkdown1.2 KB
upstream/prompts/general/atomic-race-finder.mdmarkdown1.3 KB
upstream/prompts/general/buffer-overflow-unsafe-finder.mdmarkdown2.6 KB
upstream/prompts/general/bufwriter-unflushed-finder.mdmarkdown995 B
upstream/prompts/general/cancel-safety-finder.mdmarkdown1.2 KB
upstream/prompts/general/cargo-lint-config-finder.mdmarkdown2.4 KB
upstream/prompts/general/closure-ffi-finder.mdmarkdown3.9 KB
upstream/prompts/general/closure-panic-finder.mdmarkdown1.1 KB
upstream/prompts/general/collection-key-mutation-finder.mdmarkdown1.9 KB
upstream/prompts/general/cstring-dangling-finder.mdmarkdown1.3 KB
upstream/prompts/general/deprecated-api-finder.mdmarkdown1.9 KB
upstream/prompts/general/destructor-skip-finder.mdmarkdown1.4 KB
upstream/prompts/general/double-free-finder.mdmarkdown1.6 KB
upstream/prompts/general/drop-panic-finder.mdmarkdown973 B
upstream/prompts/general/dyn-trait-ffi-finder.mdmarkdown2.8 KB
upstream/prompts/general/float-edge-finder.mdmarkdown798 B
upstream/prompts/general/foreign-drop-finder.mdmarkdown2.7 KB
upstream/prompts/general/invalid-free-finder.mdmarkdown1.2 KB
upstream/prompts/general/lossy-from-into-finder.mdmarkdown603 B
upstream/prompts/general/lossy-str-conversion-finder.mdmarkdown1.2 KB
upstream/prompts/general/msrv-mismatch-finder.mdmarkdown401 B
upstream/prompts/general/nondeterminism-finder.mdmarkdown1.6 KB
upstream/prompts/general/opaque-pointer-finder.mdmarkdown1.9 KB
upstream/prompts/general/ord-eq-hash-finder.mdmarkdown754 B
upstream/prompts/general/out-of-bounds-index-finder.mdmarkdown727 B
upstream/prompts/general/packed-field-ref-finder.mdmarkdown3.7 KB
upstream/prompts/general/panic-unwind-unsafe-finder.mdmarkdown3.0 KB
upstream/prompts/general/path-traversal-join-finder.mdmarkdown1.7 KB
upstream/prompts/general/pointer-exposure-finder.mdmarkdown1.8 KB
upstream/prompts/general/raw-fd-lifecycle-finder.mdmarkdown2.0 KB
upstream/prompts/general/recursive-deserialize-stack-overflow-finder.mdmarkdown4.8 KB
upstream/prompts/general/recursive-drop-stack-overflow-finder.mdmarkdown2.7 KB
upstream/prompts/general/recursive-format-stack-overflow-finder.mdmarkdown4.1 KB
upstream/prompts/general/refcell-borrow-panic-finder.mdmarkdown1.2 KB
upstream/prompts/general/repr-c-padding-finder.mdmarkdown2.2 KB
upstream/prompts/general/resource-exhaustion-finder.mdmarkdown2.4 KB
upstream/prompts/general/result-discarded-finder.mdmarkdown1.6 KB
upstream/prompts/general/select-bias-finder.mdmarkdown1.2 KB
upstream/prompts/general/send-sync-bounds-finder.mdmarkdown2.6 KB
upstream/prompts/general/serialize-struct-mismatch-finder.mdmarkdown2.3 KB
upstream/prompts/general/shared-memory-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/static-mut-race-finder.mdmarkdown2.8 KB
upstream/prompts/general/str-slice-boundary-finder.mdmarkdown1.0 KB
upstream/prompts/general/string-comparison-finder.mdmarkdown1.4 KB
upstream/prompts/general/toctou-finder.mdmarkdown1.3 KB
upstream/prompts/general/uninitialized-read-finder.mdmarkdown1.8 KB
upstream/prompts/general/union-ub-finder.mdmarkdown3.5 KB
upstream/prompts/general/unsafe-sync-impl-finder.mdmarkdown3.7 KB
upstream/prompts/general/unwrap-on-untrusted-finder.mdmarkdown1.3 KB
upstream/prompts/general/use-after-free-finder.mdmarkdown2.9 KB
upstream/prompts/general/vec-set-len-uninit-finder.mdmarkdown2.5 KB
upstream/scripts/build_run_plan.pyscript24.0 KB
upstream/scripts/generate_sarif.pyexecutablescript22.9 KB
upstream/scripts/pyproject.tomlmanifest220 B
upstream/scripts/test_gating.pyscript12.6 KB
upstream/scripts/test_generate_sarif.pyscript19.5 KB
upstream/scripts/test_prompt_regexes.pyscript4.3 KB
upstream/scripts/test_split.pyscript10.2 KB
upstream/scripts/test_validate_artifacts.pyscript10.3 KB
upstream/scripts/validate_artifacts.pyscript11.4 KB
upstream/skills/rust-review/SKILL.upstream.mdmarkdown43.5 KB

upstream/prompts/clusters/ffi-cross-language.md

View on GitHub
---
name: cluster-ffi-cross-language
kind: cluster
consolidated: false
covers:
  - cstring-dangling # CSTRDANGLE
  - abi-mismatch     # ABIMISMATCH
  - repr-c-padding   # REPRCPAD
  - opaque-pointer   # OPAQUEPTR
  - foreign-drop     # FOREIGNDROP
  - closure-ffi      # CLOSUREFFI
  - dyn-trait-ffi    # DYNFFI
---

# Cluster: FFI cross-language

ID prefixes: `CSTRDANGLE`, `ABIMISMATCH`, `REPRCPAD`, `OPAQUEPTR`, `FOREIGNDROP`, `CLOSUREFFI`, `DYNFFI`.

## Phase A

```
rg seed: "extern\s+\"(C|system|stdcall|cdecl|win64|sysv64|aapcs|fastcall|thiscall|vectorcall|efiapi)(-unwind)?\"|extern\s+\{|\bextern\s+fn\b"
rg seed: "CString::|CStr::|CString::new"
rg seed: "#\[repr\((C|transparent)"
rg seed: "bindgen|cbindgen"
rg seed: "\bimpl\b[^{]*?\bDrop\s+for\s+\w+"
rg seed: "libc::(malloc|free)|CoTaskMem|g_malloc|CFAllocator|LocalAlloc"
rg seed: "\bdyn\s+Fn(Once|Mut)?\b|\bextern\s+\"(C|C-unwind|system)\"\s*fn\b|catch_unwind"
rg seed: "\bdyn\s+\w|\bBox<\s*dyn\s+\w"
rg seed: "\bc_void\b"                                                                  # OPAQUEPTR seed: *mut/*const c_void opaque handles
```

## Phase B — Run finders in order

Apply each pass against the Phase-A inventory; detailed detection + FP guidance live in the per-class finder files (do not re-derive them here).

1. **`CSTRDANGLE` — cstring-dangling** — `CString::as_ptr()` used after the owning `CString` (often a temporary dropped at end of statement) is gone. Seed: `CString::` / `CStr::`.
2. **`ABIMISMATCH` — abi-mismatch** — `extern` fn signature, calling convention, or type widths disagree with the foreign declaration. Seed: `extern "C"`, `bindgen`.
3. **`REPRCPAD` — repr-c-padding** — uninitialized `#[repr(C)]` padding bytes cross the FFI boundary (info leak). Seed: `#[repr(C|transparent)]`.
4. **`OPAQUEPTR` — opaque-pointer** — ownership/validity confusion over an opaque handle passed across FFI. Seed: `*mut c_void`, opaque handle types.
5. **`FOREIGNDROP` — foreign-drop** — Rust `Drop` frees memory the foreign side owns (or vice-versa): mismatched allocator/free. Seed: `impl Drop`, `libc::free` / `CoTaskMem` / `g_malloc`.
6. **`CLOSUREFFI` — closure-ffi** — Rust closure registered as a C callback without `catch_unwind` (panic across `extern "C"`) or with unbounded capture lifetimes. Seed: `dyn Fn*`, `extern "C" fn`, `catch_unwind`.
7. **`DYNFFI` — dyn-trait-ffi** — `dyn Trait` fat pointer (vtable + data) truncated to a thin pointer crossing the boundary. Seed: `Box<dyn ...>`, `dyn ...`.

## Deconfliction

- `REPRCPAD` (this cluster) vs `REPRC` (unsafe-boundary): `REPRCPAD` owns *uninitialized padding bytes leaking across FFI*; `REPRC` owns *general layout / `#[repr]` soundness*. File `REPRCPAD` when the defect is padding disclosure at the boundary.
- `OPAQUEPTR` vs `FOREIGNDROP`: handle *identity/validity* confusion vs *who calls free*. An opaque handle whose `Drop` frees foreign-owned memory is `FOREIGNDROP`; mere use-after-invalidate of the handle is `OPAQUEPTR`.
- `CLOSUREFFI` vs `DYNFFI`: closure *trampoline / panic-unwind* hazard vs a `dyn Trait` *fat-pointer / vtable* crossing the boundary. A `Box<dyn Fn>` passed as a callback is `CLOSUREFFI`; a `dyn Trait` object whose vtable crosses FFI is `DYNFFI`.
- `CSTRDANGLE` vs `FOREIGNDROP`: a Rust-owned `CStr` whose lifetime ends too early vs the foreign side freeing a buffer Rust still references.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall