Skip to content

richfrem/agent-plugins-skills / plugins/agent-agentic-os/.apm/skills/running-control-plane

running-control-plane

Flagged

CRITICAL INTAKE GATEWAY: use at the start of any non-trivial engineering task, feature, refactor, multi-file bugfix, work package or new idea, including requests to explore, brainstorm, build, fix or change something, before planning or code changes. Enforces read-only discovery, 1-3 structured questions with defaults, control-plane registration and the immutable four-pillar TASK_SPEC.md. Also runs the rest of the control plane: health ("run health check", "check os metrics", "system monitor", event bus, locks, memory, "is my signing identity ready" status check), transition simulation ("dry run transition", "simulate transition", "check edge X -> Y"), worktree selection, and gating on/off ("disable the control plane", "turn off the push guard", "stop gating my commits"). Not for project setup or key creation (use setting-up-agentic-os) or improving skills (use improving-skills-in-lab).

FileKindSize
SKILL.mdskill md5.4 KB
evals/evals.jsonconfig8.3 KB
references/acceptance-criteria.mdmarkdown4.0 KB
references/agentic-os-skill-map.mdmarkdown2.3 KB
references/architecture/architecture.mdmarkdown2.4 KB
references/architecture/context-folder-patterns.mdmarkdown3.3 KB
references/architecture/vision.mdmarkdown56.6 KB
references/cheap-agent-transition-simulation.mdmarkdown6.1 KB
references/control-plane-architecture.mdmarkdown9.0 KB
references/control-plane-rebuild-recovery.mdmarkdown6.2 KB
references/control-plane-simulation-protocol.mdmarkdown5.7 KB
references/diagrams/agentic-os-memory-subsystem.mmdother1.4 KB
references/diagrams/architecture-overview.mmdother3.1 KB
references/diagrams/control-plane-architecture.mermaidother6.3 KB
references/diagrams/control-plane-lifecycle-hardened-with-ciba-rar.mermaidother4.5 KB
references/diagrams/control-plane-pipeline-happy-path.mermaidother5.0 KB
references/diagrams/control-plane-pipeline.mermaidother9.3 KB
references/diagrams/event-bus-architecture.mmdother2.4 KB
references/diagrams/increment-b-human-only-transition-ssh-signing.mermaidother5.3 KB
references/edge-matrix.mdmarkdown13.3 KB
references/fallback-tree.mdmarkdown2.9 KB
references/health-detailed-reference.mdmarkdown7.1 KB
references/healthy-transcript.mdmarkdown3.8 KB
references/implementation-ledger-contract.mdmarkdown851 B
references/intake-detailed-reference.mdmarkdown3.1 KB
references/modes/health.mdmarkdown3.4 KB
references/modes/intake.mdmarkdown3.8 KB
references/modes/mode.mdmarkdown5.8 KB
references/modes/simulator.mdmarkdown6.2 KB
references/modes/worktree.mdmarkdown2.9 KB
references/multi-round-external-review-protocol.mdmarkdown2.6 KB
references/worktree-reconciliation-and-multi-worktree-practices.mdmarkdown5.8 KB
requirements-dev.inother741 B
requirements-dev.txtmarkdown603 B
requirements.inother196 B
requirements.txtmanifest202 B
scripts/agent_control.pyscript97.7 KB
scripts/audit_map_debt.pyscript6.1 KB
scripts/capability_probe.pyscript6.4 KB
scripts/check_plan_links.pyscript1.8 KB
scripts/control_plane/__init__.pyscript842 B
scripts/control_plane/adapters.pyscript144.9 KB
scripts/control_plane/approver_policy.pyscript20.0 KB
scripts/control_plane/baseline_transition_report.pyscript4.0 KB
scripts/control_plane/constants.pyscript13.5 KB
scripts/control_plane/coordinator.pyscript57.3 KB
scripts/control_plane/edge_matrix.pyscript3.1 KB
scripts/control_plane/gate1_approval.pyscript10.7 KB
scripts/control_plane/gate_evidence.pyscript9.9 KB
scripts/control_plane/identity_layout.pyscript2.9 KB
scripts/control_plane/identity_setup.pyscript11.0 KB
scripts/control_plane/implementation.pyscript3.7 KB
scripts/control_plane/implementation_loop.pyscript11.3 KB
scripts/control_plane/inspection.pyscript3.9 KB
scripts/control_plane/installation_probe.pyscript5.7 KB
scripts/control_plane/isolation_check.pyscript14.0 KB
scripts/control_plane/measurement.pyscript39.1 KB
scripts/control_plane/pipeline_simulator.pyscript30.0 KB
scripts/control_plane/policy.pyscript32.5 KB
scripts/control_plane/ports.pyscript20.3 KB
scripts/control_plane/proof_edges.pyscript4.6 KB
scripts/control_plane/proof_policy.pyscript2.2 KB
scripts/control_plane/receipt_provenance.pyscript4.7 KB
scripts/control_plane/registry.pyscript32.9 KB
scripts/control_plane/review_options.pyscript8.2 KB
scripts/control_plane/review_selection.pyscript3.2 KB
scripts/control_plane/run_transition_simulation.pyscript12.0 KB
scripts/control_plane/signing_selftest.pyscript6.8 KB
scripts/control_plane/simulation_identity.pyscript10.4 KB
scripts/control_plane/snapshot.pyscript10.8 KB
scripts/control_plane/ssh_signing.pyscript21.8 KB
scripts/control_plane/state_machine.pyscript5.8 KB
scripts/control_plane/transition_request.pyscript19.5 KB
scripts/control_plane/transition_simulation_cases.pyscript24.6 KB
scripts/control_plane/transition_templates.yamlconfig159.1 KB
scripts/control_plane/tty_signer.pyscript3.0 KB
scripts/control_plane/wrappers/__init__.pyscript24 B
scripts/control_plane/wrappers/record_interview_question.pyscript8.0 KB
scripts/control_plane/wrappers/record_retrospective.pyscript2.3 KB
scripts/control_plane/wrappers/run_exit_verification.pyscript6.4 KB
scripts/control_plane/wrappers/run_verify_exit_bundle.pyscript5.4 KB
scripts/control_plane/wrappers/write_plan_document.pyscript9.6 KB
scripts/control_plane_hooks.pyscript10.5 KB
scripts/control_plane_mode.pyscript12.0 KB
scripts/distill_playbook.pyexecutablescript9.9 KB
scripts/evolution_state.pyscript29.4 KB
scripts/export_upstream_pr.pyscript4.4 KB
scripts/interview_spec_engine.pyscript9.1 KB
scripts/kernel.pyscript14.6 KB
scripts/pre-commit-evolution-guardexecutablescript3.7 KB
scripts/pre-commit-pipeline-guardexecutablescript13.6 KB
scripts/pre-push-review-guardexecutablescript10.5 KB
scripts/record_trace.pyscript7.2 KB
scripts/smoke_test.pyexecutablescript22.6 KB
scripts/test_capability_probe.pyscript3.9 KB
scripts/test_worktree_manager.pyscript2.8 KB
scripts/verify_evolution_receipt.pyscript7.5 KB
scripts/verify_gate_evidence.pyscript1.6 KB
scripts/worktree_manager.pyscript3.0 KB
tests/conftest.pyscript7.7 KB
tests/helpers/__init__.pyscript0 B
tests/helpers/control_plane_fixtures.pyscript2.6 KB
tests/helpers/control_plane_repo.pyscript4.0 KB
tests/helpers/gate1_fixtures.pyscript5.8 KB
tests/helpers/human_signer.pyscript7.3 KB
tests/helpers/implementation_ledger.pyscript1.1 KB
tests/interview_helpers.pyscript5.2 KB
tests/test_actionable_rollback.pyscript2.2 KB
tests/test_agent_control.pyscript190.6 KB
tests/test_agent_control_gate_characterization.pyscript14.7 KB
tests/test_approve_transition.pyscript10.5 KB
tests/test_approver_identity_guidance.pyscript3.4 KB
tests/test_approver_isolation.pyscript12.3 KB
tests/test_audit_map_debt.pyscript4.7 KB
tests/test_authorized_actor_enforcement.pyscript22.9 KB
tests/test_background_document_priority.pyscript924 B
tests/test_check_plan_links.pyscript1.1 KB
tests/test_content_snapshot.pyscript11.8 KB
tests/test_control_plane_architecture_diagram_contract.pyscript9.0 KB
tests/test_control_plane_architecture_overview_contract.pyscript2.1 KB
tests/test_control_plane_critic_review.pyscript3.1 KB
tests/test_control_plane_crypto_adapter.pyscript5.0 KB
tests/test_control_plane_delegation_contract.pyscript5.7 KB
tests/test_control_plane_facade_composition.pyscript15.9 KB
tests/test_control_plane_filesystem_adapter.pyscript4.9 KB
tests/test_control_plane_hooks.pyscript7.3 KB
tests/test_control_plane_interview_guidance.pyscript3.8 KB
tests/test_control_plane_measurement_contract.pyscript28.0 KB
tests/test_control_plane_mode.pyscript7.5 KB
tests/test_control_plane_mode_guards.pyscript3.5 KB
tests/test_control_plane_model_catalog_adapter.pyscript9.2 KB
tests/test_control_plane_pipeline_diagram_contract.pyscript2.3 KB
tests/test_control_plane_pipeline_simulator.pyscript7.5 KB
tests/test_control_plane_policy.pyscript13.0 KB
tests/test_control_plane_ports.pyscript3.2 KB
tests/test_control_plane_reset_transition.pyscript13.6 KB
tests/test_control_plane_schema_rebuild_atomicity.pyscript20.0 KB
tests/test_control_plane_simulation_protocol_contract.pyscript959 B
tests/test_control_plane_sqlite_persistence_adapter.pyscript5.5 KB
tests/test_control_plane_state_machine.pyscript15.2 KB
tests/test_control_plane_trigger_enforcement.pyscript14.6 KB
tests/test_control_plane_worktree_sharing.pyscript4.5 KB
tests/test_domain_namespaces.pyscript6.7 KB
tests/test_done_closure_proof.pyscript6.9 KB
tests/test_draft_plan_interactive_outline_gap.pyscript2.2 KB
tests/test_dual_identity_onboarding.pyscript7.3 KB
tests/test_edge_matrix.pyscript3.2 KB
tests/test_ensure_schema_fastpath.pyscript4.4 KB
tests/test_evolution_guards.pyscript14.9 KB
tests/test_evolution_scripts.pyscript55.3 KB
tests/test_gate1_guidance.pyscript1.8 KB
tests/test_gate3_code_acceptance.pyscript13.5 KB
tests/test_graph_state_machine.pyscript16.0 KB
tests/test_guidance_readiness.pyscript2.2 KB
tests/test_health_check_signing_status.pyscript3.5 KB
tests/test_human_decision_trigger_enforcement.pyscript37.3 KB
tests/test_human_only_wiring.pyscript22.3 KB
tests/test_human_signer_isolation.pyscript4.0 KB
tests/test_identity_verification_readiness.pyscript5.8 KB
tests/test_implementation_ledger.pyscript3.4 KB
tests/test_implementation_loop.pyscript6.9 KB
tests/test_implementation_runtime_bridge.pyscript2.6 KB
tests/test_init_agentic_os_scaffolding.pyscript10.0 KB
tests/test_init_respects_control_plane_mode.pyscript4.3 KB
tests/test_inspect_verbs.pyscript3.6 KB
tests/test_installation_probe.pyscript3.1 KB
tests/test_intake_scenarios.pyscript7.2 KB
tests/test_interview_plan_outline.pyscript2.8 KB
tests/test_isolation_check.pyscript12.5 KB
tests/test_isolation_setup_docs.pyscript2.7 KB
tests/test_kernel_security.pyscript4.0 KB
tests/test_legacy_input_fallback.pyscript6.0 KB
tests/test_list_review_options.pyscript3.1 KB
tests/test_multi_agent_bundle_gate.pyscript5.5 KB
tests/test_one_approver_per_pipeline.pyscript15.8 KB
tests/test_os_init_dual_identity.pyscript3.9 KB
tests/test_os_init_identity_bootstrap.pyscript8.8 KB
tests/test_os_init_identity_status.pyscript3.9 KB
tests/test_os_init_single_instruction_file.pyscript7.3 KB
tests/test_p00_live_baseline.pyscript10.2 KB
tests/test_p01_intake_persistence.pyscript6.7 KB
tests/test_post_run_metrics_protocol.pyscript3.3 KB
tests/test_pre_commit_pipeline_guard.pyscript29.1 KB
tests/test_pre_push_review_guard.pyscript5.7 KB
tests/test_receipt_provenance.pyscript6.6 KB
tests/test_retrospective_pipeline.pyscript5.3 KB
tests/test_review_option_menus.pyscript6.6 KB
tests/test_review_selection.pyscript8.2 KB
tests/test_round3_fixes.pyscript8.3 KB
tests/test_rules_compliance.pyscript1.3 KB
tests/test_run_transition_simulation_formatting.pyscript1.7 KB
tests/test_run_verify_exit_bundle.pyscript10.2 KB
tests/test_setup_ciba_identity.pyscript11.2 KB
tests/test_signed_approval_human_receipt.pyscript3.9 KB
tests/test_signing_mechanics_selftest.pyscript6.9 KB
tests/test_signing_skill_selfcontained.pyscript3.4 KB
tests/test_skip_receipt_guidance.pyscript2.7 KB
tests/test_ssh_signing.pyscript23.9 KB
tests/test_strategy_artifacts.pyscript21.8 KB
tests/test_transition_answer_normalization.pyscript1.1 KB

tests/test_round3_fixes.py

View on GitHub
"""
tests/test_round3_fixes.py
==========================

Purpose:
    Failing-first tests for the confirmed round-3 review findings (auth-ciba-increment-b, #639):
    A1 `invalidate-receipt` and `record-review-skip` must be routed and refuse (not silently exit 0) without a
    terminal; S2 Gate 1 rejections raised as signing/request/snapshot errors must leave a `transition_violations`
    audit row; S1 the human-only receipt verbs refuse to run as the agent account; S4 verification tries every
    matching principal, not just the first. Real SQLite, real ssh-keygen; the terminal/identity is injected.

Key Input Dependencies:
    - agent_control.py (_dispatch_command, _build_parser), control_plane/receipt_provenance.py,
      control_plane/adapters.py, control_plane/ssh_signing.py; tests/test_approve_transition.py (Gate fixture)

Key Functions (test cases):
    - test_invalidate_receipt_is_routed_and_refuses_without_a_terminal
    - test_record_review_skip_is_routed_and_refuses_without_a_terminal
    - test_a_bad_gate1_signature_leaves_a_violation_row
    - test_human_only_receipt_verbs_refuse_the_agent_account
    - test_verification_tries_every_matching_principal
"""

import os
import sqlite3
import shutil
import subprocess
import sys
from pathlib import Path

import pytest

_scripts_dir = str(Path(__file__).resolve().parent.parent / "scripts")
if _scripts_dir not in sys.path:
    sys.path.insert(0, _scripts_dir)

import agent_control
from control_plane.receipt_provenance import ReceiptError, invalidate_receipt, record_human_skip
from control_plane.ssh_signing import SIGN_NAMESPACE, verify_signature
from test_approve_transition import TASK as GATE_TASK, Gate, GateApprovalError
from helpers.gate1_fixtures import reach_awaiting_approval

_FOUND = shutil.which("ssh-keygen")
SSH_KEYGEN = _FOUND or "ssh-keygen"
pytestmark = pytest.mark.skipif(_FOUND is None, reason="ssh-keygen not installed")


@pytest.fixture
def cp(tmp_path):
    return reach_awaiting_approval(tmp_path, "round3-task-001").control_plane


def _run_verb(cp, *argv):
    args = agent_control._build_parser().parse_args(list(argv))
    agent_control._dispatch_command(cp, args)


def test_invalidate_receipt_is_routed_and_refuses_without_a_terminal(cp):
    cp.record_review_skip("round3-task-001", "multi_agent_review", "agent", "x")
    with pytest.raises(SystemExit) as excinfo:  # stdin is not a terminal under pytest
        _run_verb(cp, "invalidate-receipt", "--receipt-id", "1", "--reason", "forged")
    assert "REFUSED" in str(excinfo.value) and "terminal" in str(excinfo.value).lower()
    assert cp._persistence.has_receipt("round3-task-001", "multi_agent_review_skipped")


def test_record_review_skip_is_routed_and_refuses_without_a_terminal(cp):
    with pytest.raises(SystemExit) as excinfo:
        _run_verb(cp, "record-review-skip", "--task-id", "round3-task-001", "--phase", "multi_agent_review", "--reason", "x", "--interactive")
    assert "REFUSED" in str(excinfo.value)
    assert not cp._persistence.has_receipt("round3-task-001", "multi_agent_review_skipped")


def test_a_bad_gate1_signature_leaves_a_violation_row(tmp_path):
    gate = Gate(tmp_path)
    attacker = tmp_path / "attacker"
    attacker.mkdir()
    Gate._keygen(attacker / "id")
    path, _ = gate.show()
    gate.sign(path, key=attacker / "id")
    with pytest.raises(GateApprovalError):
        gate.approve()
    rows = gate.db().execute(
        "SELECT attempted_from_state, attempted_to_state, detail FROM transition_violations WHERE task_id = ?", (GATE_TASK,)
    ).fetchall()
    assert rows and rows[-1][0] == "AWAITING_APPROVAL" and rows[-1][1] == "APPROVED"
    assert gate.state() == "AWAITING_APPROVAL"


def test_human_only_receipt_verbs_refuse_the_agent_account(cp):
    kwargs = dict(tty_fn=lambda: True, input_fn=lambda _p: "multi_agent_review", out=lambda *_: None, agent_uid=os.geteuid())
    with pytest.raises(ReceiptError) as excinfo:
        record_human_skip(cp, "round3-task-001", "multi_agent_review", "x", **kwargs)
    assert "agent" in str(excinfo.value).lower()
    with pytest.raises(ReceiptError):
        invalidate_receipt(cp, 1, "x", **kwargs)
    assert not cp._persistence.has_receipt("round3-task-001", "multi_agent_review_skipped")


def test_verification_tries_every_matching_principal(tmp_path):
    key = tmp_path / "id"
    subprocess.run([SSH_KEYGEN, "-q", "-t", "ed25519", "-N", "", "-C", "t", "-f", str(key)], check=True, capture_output=True)
    pub = (tmp_path / "id.pub").read_text().split()
    allowed = tmp_path / "allowed_signers"
    allowed.write_text(
        f'alpha@x namespaces="other-app@example.org" {pub[0]} {pub[1]}\n'
        f'op@local namespaces="{SIGN_NAMESPACE}" {pub[0]} {pub[1]}\n'
    )
    os.chmod(allowed, 0o600)
    data = tmp_path / "challenge"
    data.write_bytes(b"challenge bytes")
    subprocess.run([SSH_KEYGEN, "-Y", "sign", "-f", str(key), "-n", SIGN_NAMESPACE, str(data)], check=True, capture_output=True)
    verified = verify_signature(b"challenge bytes", Path(str(data) + ".sig").read_bytes(), allowed_signers=allowed)
    assert verified.principal == "op@local"


# ---- Round 4 findings (N1, N2) --------------------------------------------------------------------------
def test_a_rejected_attempt_does_not_block_a_later_valid_commit_check(tmp_path):
    """N1: a failed Gate 1 attempt is kept for audit but must not poison pipeline-history validation."""
    gate = Gate(tmp_path)
    attacker = tmp_path / "attacker"
    attacker.mkdir()
    Gate._keygen(attacker / "id")
    path, _ = gate.show()
    gate.sign(path, key=attacker / "id")
    with pytest.raises(GateApprovalError):
        gate.approve()
    kinds = [r[0] for r in gate.db().execute("SELECT kind FROM transition_violations WHERE task_id = ?", (GATE_TASK,))]
    assert kinds == ["REJECTED_ATTEMPT"]  # history is kept
    Path(str(path) + ".sig").unlink()  # ssh-keygen will not overwrite the earlier signature file
    gate.sign(path)  # the human retries with the right key
    gate.approve()
    verdict = gate.cp._persistence.validate_task_pipeline_history(GATE_TASK, "APPROVED")
    assert verdict is None or "violation" not in verdict.lower(), verdict


def test_a_trigger_recorded_illegal_transition_still_blocks(tmp_path):
    """N1: rows written by the enforce_valid_transition trigger keep blocking commit validation."""
    from test_review_selection import TASK, _plan_review_task

    sim = _plan_review_task(tmp_path)
    with pytest.raises(Exception):
        sim.control_plane.transition(TASK, "MULTI_AGENT_REVIEW", "tester", "no decisions")  # trigger rejects
    kinds = [r[0] for r in sqlite3.connect(sim.control_plane.db_path).execute("SELECT kind FROM transition_violations WHERE task_id = ?", (TASK,))]
    assert kinds == ["ILLEGAL_TRANSITION"]
    assert "violation" in (sim.control_plane._persistence.validate_task_pipeline_history(TASK, "PLAN_REVIEW") or "").lower()


def test_principal_lists_are_split_into_individual_identities(tmp_path):
    """N2: `alice@x,bob@x` in allowed_signers must be tried as alice@x and bob@x, not as one identity."""
    key = tmp_path / "id"
    subprocess.run([SSH_KEYGEN, "-q", "-t", "ed25519", "-N", "", "-C", "t", "-f", str(key)], check=True, capture_output=True)
    pub = (tmp_path / "id.pub").read_text().split()
    allowed = tmp_path / "allowed_signers"
    allowed.write_text(
        f'other@x namespaces="other-app@example.org" {pub[0]} {pub[1]}\n'
        f'alice@x,bob@x namespaces="{SIGN_NAMESPACE}" {pub[0]} {pub[1]}\n'
    )
    os.chmod(allowed, 0o600)
    data = tmp_path / "challenge"
    data.write_bytes(b"challenge bytes")
    subprocess.run([SSH_KEYGEN, "-Y", "sign", "-f", str(key), "-n", SIGN_NAMESPACE, str(data)], check=True, capture_output=True)
    verified = verify_signature(b"challenge bytes", Path(str(data) + ".sig").read_bytes(), allowed_signers=allowed)
    assert verified.principal in ("alice@x", "bob@x")


def test_a_refused_signature_tells_the_human_to_delete_the_old_signature_file(tmp_path):
    """After a failed approval ssh-keygen will not overwrite the earlier .sig; the refusal must say how to retry."""
    gate = Gate(tmp_path)
    attacker = tmp_path / "attacker"
    attacker.mkdir()
    Gate._keygen(attacker / "id")
    path, _ = gate.show()
    gate.sign(path, key=attacker / "id")
    with pytest.raises(GateApprovalError) as excinfo:
        gate.approve()
    assert "delete" in str(excinfo.value).lower() and ".sig" in str(excinfo.value)
reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.Stars: 322kUpdated Claude CodeCodexVerifiedInstall
dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependenciesStars: 322kUpdated Claude CodeCodexVerifiedInstall
executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is availableStars: 322kUpdated Claude CodeCodexVerifiedInstall