Skip to content

richfrem/agent-plugins-skills / plugins/agent-agentic-os/.apm/skills/running-control-plane

running-control-plane

Flagged

CRITICAL INTAKE GATEWAY: use at the start of any non-trivial engineering task, feature, refactor, multi-file bugfix, work package or new idea, including requests to explore, brainstorm, build, fix or change something, before planning or code changes. Enforces read-only discovery, 1-3 structured questions with defaults, control-plane registration and the immutable four-pillar TASK_SPEC.md. Also runs the rest of the control plane: health ("run health check", "check os metrics", "system monitor", event bus, locks, memory, "is my signing identity ready" status check), transition simulation ("dry run transition", "simulate transition", "check edge X -> Y"), worktree selection, and gating on/off ("disable the control plane", "turn off the push guard", "stop gating my commits"). Not for project setup or key creation (use setting-up-agentic-os) or improving skills (use improving-skills-in-lab).

FileKindSize
SKILL.mdskill md5.4 KB
evals/evals.jsonconfig8.3 KB
references/acceptance-criteria.mdmarkdown4.0 KB
references/agentic-os-skill-map.mdmarkdown2.3 KB
references/architecture/architecture.mdmarkdown2.4 KB
references/architecture/context-folder-patterns.mdmarkdown3.3 KB
references/architecture/vision.mdmarkdown56.6 KB
references/cheap-agent-transition-simulation.mdmarkdown6.1 KB
references/control-plane-architecture.mdmarkdown9.0 KB
references/control-plane-rebuild-recovery.mdmarkdown6.2 KB
references/control-plane-simulation-protocol.mdmarkdown5.7 KB
references/diagrams/agentic-os-memory-subsystem.mmdother1.4 KB
references/diagrams/architecture-overview.mmdother3.1 KB
references/diagrams/control-plane-architecture.mermaidother6.3 KB
references/diagrams/control-plane-lifecycle-hardened-with-ciba-rar.mermaidother4.5 KB
references/diagrams/control-plane-pipeline-happy-path.mermaidother5.0 KB
references/diagrams/control-plane-pipeline.mermaidother9.3 KB
references/diagrams/event-bus-architecture.mmdother2.4 KB
references/diagrams/increment-b-human-only-transition-ssh-signing.mermaidother5.3 KB
references/edge-matrix.mdmarkdown13.3 KB
references/fallback-tree.mdmarkdown2.9 KB
references/health-detailed-reference.mdmarkdown7.1 KB
references/healthy-transcript.mdmarkdown3.8 KB
references/implementation-ledger-contract.mdmarkdown851 B
references/intake-detailed-reference.mdmarkdown3.1 KB
references/modes/health.mdmarkdown3.4 KB
references/modes/intake.mdmarkdown3.8 KB
references/modes/mode.mdmarkdown5.8 KB
references/modes/simulator.mdmarkdown6.2 KB
references/modes/worktree.mdmarkdown2.9 KB
references/multi-round-external-review-protocol.mdmarkdown2.6 KB
references/worktree-reconciliation-and-multi-worktree-practices.mdmarkdown5.8 KB
requirements-dev.inother741 B
requirements-dev.txtmarkdown603 B
requirements.inother196 B
requirements.txtmanifest202 B
scripts/agent_control.pyscript97.7 KB
scripts/audit_map_debt.pyscript6.1 KB
scripts/capability_probe.pyscript6.4 KB
scripts/check_plan_links.pyscript1.8 KB
scripts/control_plane/__init__.pyscript842 B
scripts/control_plane/adapters.pyscript144.9 KB
scripts/control_plane/approver_policy.pyscript20.0 KB
scripts/control_plane/baseline_transition_report.pyscript4.0 KB
scripts/control_plane/constants.pyscript13.5 KB
scripts/control_plane/coordinator.pyscript57.3 KB
scripts/control_plane/edge_matrix.pyscript3.1 KB
scripts/control_plane/gate1_approval.pyscript10.7 KB
scripts/control_plane/gate_evidence.pyscript9.9 KB
scripts/control_plane/identity_layout.pyscript2.9 KB
scripts/control_plane/identity_setup.pyscript11.0 KB
scripts/control_plane/implementation.pyscript3.7 KB
scripts/control_plane/implementation_loop.pyscript11.3 KB
scripts/control_plane/inspection.pyscript3.9 KB
scripts/control_plane/installation_probe.pyscript5.7 KB
scripts/control_plane/isolation_check.pyscript14.0 KB
scripts/control_plane/measurement.pyscript39.1 KB
scripts/control_plane/pipeline_simulator.pyscript30.0 KB
scripts/control_plane/policy.pyscript32.5 KB
scripts/control_plane/ports.pyscript20.3 KB
scripts/control_plane/proof_edges.pyscript4.6 KB
scripts/control_plane/proof_policy.pyscript2.2 KB
scripts/control_plane/receipt_provenance.pyscript4.7 KB
scripts/control_plane/registry.pyscript32.9 KB
scripts/control_plane/review_options.pyscript8.2 KB
scripts/control_plane/review_selection.pyscript3.2 KB
scripts/control_plane/run_transition_simulation.pyscript12.0 KB
scripts/control_plane/signing_selftest.pyscript6.8 KB
scripts/control_plane/simulation_identity.pyscript10.4 KB
scripts/control_plane/snapshot.pyscript10.8 KB
scripts/control_plane/ssh_signing.pyscript21.8 KB
scripts/control_plane/state_machine.pyscript5.8 KB
scripts/control_plane/transition_request.pyscript19.5 KB
scripts/control_plane/transition_simulation_cases.pyscript24.6 KB
scripts/control_plane/transition_templates.yamlconfig159.1 KB
scripts/control_plane/tty_signer.pyscript3.0 KB
scripts/control_plane/wrappers/__init__.pyscript24 B
scripts/control_plane/wrappers/record_interview_question.pyscript8.0 KB
scripts/control_plane/wrappers/record_retrospective.pyscript2.3 KB
scripts/control_plane/wrappers/run_exit_verification.pyscript6.4 KB
scripts/control_plane/wrappers/run_verify_exit_bundle.pyscript5.4 KB
scripts/control_plane/wrappers/write_plan_document.pyscript9.6 KB
scripts/control_plane_hooks.pyscript10.5 KB
scripts/control_plane_mode.pyscript12.0 KB
scripts/distill_playbook.pyexecutablescript9.9 KB
scripts/evolution_state.pyscript29.4 KB
scripts/export_upstream_pr.pyscript4.4 KB
scripts/interview_spec_engine.pyscript9.1 KB
scripts/kernel.pyscript14.6 KB
scripts/pre-commit-evolution-guardexecutablescript3.7 KB
scripts/pre-commit-pipeline-guardexecutablescript13.6 KB
scripts/pre-push-review-guardexecutablescript10.5 KB
scripts/record_trace.pyscript7.2 KB
scripts/smoke_test.pyexecutablescript22.6 KB
scripts/test_capability_probe.pyscript3.9 KB
scripts/test_worktree_manager.pyscript2.8 KB
scripts/verify_evolution_receipt.pyscript7.5 KB
scripts/verify_gate_evidence.pyscript1.6 KB
scripts/worktree_manager.pyscript3.0 KB
tests/conftest.pyscript7.7 KB
tests/helpers/__init__.pyscript0 B
tests/helpers/control_plane_fixtures.pyscript2.6 KB
tests/helpers/control_plane_repo.pyscript4.0 KB
tests/helpers/gate1_fixtures.pyscript5.8 KB
tests/helpers/human_signer.pyscript7.3 KB
tests/helpers/implementation_ledger.pyscript1.1 KB
tests/interview_helpers.pyscript5.2 KB
tests/test_actionable_rollback.pyscript2.2 KB
tests/test_agent_control.pyscript190.6 KB
tests/test_agent_control_gate_characterization.pyscript14.7 KB
tests/test_approve_transition.pyscript10.5 KB
tests/test_approver_identity_guidance.pyscript3.4 KB
tests/test_approver_isolation.pyscript12.3 KB
tests/test_audit_map_debt.pyscript4.7 KB
tests/test_authorized_actor_enforcement.pyscript22.9 KB
tests/test_background_document_priority.pyscript924 B
tests/test_check_plan_links.pyscript1.1 KB
tests/test_content_snapshot.pyscript11.8 KB
tests/test_control_plane_architecture_diagram_contract.pyscript9.0 KB
tests/test_control_plane_architecture_overview_contract.pyscript2.1 KB
tests/test_control_plane_critic_review.pyscript3.1 KB
tests/test_control_plane_crypto_adapter.pyscript5.0 KB
tests/test_control_plane_delegation_contract.pyscript5.7 KB
tests/test_control_plane_facade_composition.pyscript15.9 KB
tests/test_control_plane_filesystem_adapter.pyscript4.9 KB
tests/test_control_plane_hooks.pyscript7.3 KB
tests/test_control_plane_interview_guidance.pyscript3.8 KB
tests/test_control_plane_measurement_contract.pyscript28.0 KB
tests/test_control_plane_mode.pyscript7.5 KB
tests/test_control_plane_mode_guards.pyscript3.5 KB
tests/test_control_plane_model_catalog_adapter.pyscript9.2 KB
tests/test_control_plane_pipeline_diagram_contract.pyscript2.3 KB
tests/test_control_plane_pipeline_simulator.pyscript7.5 KB
tests/test_control_plane_policy.pyscript13.0 KB
tests/test_control_plane_ports.pyscript3.2 KB
tests/test_control_plane_reset_transition.pyscript13.6 KB
tests/test_control_plane_schema_rebuild_atomicity.pyscript20.0 KB
tests/test_control_plane_simulation_protocol_contract.pyscript959 B
tests/test_control_plane_sqlite_persistence_adapter.pyscript5.5 KB
tests/test_control_plane_state_machine.pyscript15.2 KB
tests/test_control_plane_trigger_enforcement.pyscript14.6 KB
tests/test_control_plane_worktree_sharing.pyscript4.5 KB
tests/test_domain_namespaces.pyscript6.7 KB
tests/test_done_closure_proof.pyscript6.9 KB
tests/test_draft_plan_interactive_outline_gap.pyscript2.2 KB
tests/test_dual_identity_onboarding.pyscript7.3 KB
tests/test_edge_matrix.pyscript3.2 KB
tests/test_ensure_schema_fastpath.pyscript4.4 KB
tests/test_evolution_guards.pyscript14.9 KB
tests/test_evolution_scripts.pyscript55.3 KB
tests/test_gate1_guidance.pyscript1.8 KB
tests/test_gate3_code_acceptance.pyscript13.5 KB
tests/test_graph_state_machine.pyscript16.0 KB
tests/test_guidance_readiness.pyscript2.2 KB
tests/test_health_check_signing_status.pyscript3.5 KB
tests/test_human_decision_trigger_enforcement.pyscript37.3 KB
tests/test_human_only_wiring.pyscript22.3 KB
tests/test_human_signer_isolation.pyscript4.0 KB
tests/test_identity_verification_readiness.pyscript5.8 KB
tests/test_implementation_ledger.pyscript3.4 KB
tests/test_implementation_loop.pyscript6.9 KB
tests/test_implementation_runtime_bridge.pyscript2.6 KB
tests/test_init_agentic_os_scaffolding.pyscript10.0 KB
tests/test_init_respects_control_plane_mode.pyscript4.3 KB
tests/test_inspect_verbs.pyscript3.6 KB
tests/test_installation_probe.pyscript3.1 KB
tests/test_intake_scenarios.pyscript7.2 KB
tests/test_interview_plan_outline.pyscript2.8 KB
tests/test_isolation_check.pyscript12.5 KB
tests/test_isolation_setup_docs.pyscript2.7 KB
tests/test_kernel_security.pyscript4.0 KB
tests/test_legacy_input_fallback.pyscript6.0 KB
tests/test_list_review_options.pyscript3.1 KB
tests/test_multi_agent_bundle_gate.pyscript5.5 KB
tests/test_one_approver_per_pipeline.pyscript15.8 KB
tests/test_os_init_dual_identity.pyscript3.9 KB
tests/test_os_init_identity_bootstrap.pyscript8.8 KB
tests/test_os_init_identity_status.pyscript3.9 KB
tests/test_os_init_single_instruction_file.pyscript7.3 KB
tests/test_p00_live_baseline.pyscript10.2 KB
tests/test_p01_intake_persistence.pyscript6.7 KB
tests/test_post_run_metrics_protocol.pyscript3.3 KB
tests/test_pre_commit_pipeline_guard.pyscript29.1 KB
tests/test_pre_push_review_guard.pyscript5.7 KB
tests/test_receipt_provenance.pyscript6.6 KB
tests/test_retrospective_pipeline.pyscript5.3 KB
tests/test_review_option_menus.pyscript6.6 KB
tests/test_review_selection.pyscript8.2 KB
tests/test_round3_fixes.pyscript8.3 KB
tests/test_rules_compliance.pyscript1.3 KB
tests/test_run_transition_simulation_formatting.pyscript1.7 KB
tests/test_run_verify_exit_bundle.pyscript10.2 KB
tests/test_setup_ciba_identity.pyscript11.2 KB
tests/test_signed_approval_human_receipt.pyscript3.9 KB
tests/test_signing_mechanics_selftest.pyscript6.9 KB
tests/test_signing_skill_selfcontained.pyscript3.4 KB
tests/test_skip_receipt_guidance.pyscript2.7 KB
tests/test_ssh_signing.pyscript23.9 KB
tests/test_strategy_artifacts.pyscript21.8 KB
tests/test_transition_answer_normalization.pyscript1.1 KB

tests/test_review_selection.py

View on GitHub
"""
tests/test_review_selection.py
==============================

Purpose:
    Failing-first contract tests for T17 (auth-ciba-increment-b, issue #639): the review-selection-v1
    sequence on BOTH review edges (PLAN_REVIEW -> MULTI_AGENT_REVIEW and WORKTREE_REVIEW ->
    MULTI_AGENT_CODE_REVIEW): review needed -> method -> (internal only) runtime -> model -> effort.
    The three internal-review selections are conditional human questions declared in the YAML
    (`asked_when`), asked one at a time, human-typed only (never `provided_answers`), never defaulted,
    and a reviewer outcome cannot be recorded for an internal review without them.
    Real coordinator, real SQLite; expectations come from the live registry, not retyped literals.

Key Input Dependencies:
    - control_plane/transition_templates.yaml (asked_when questions), registry.py, coordinator.py
    - control_plane/review_selection.py (conditional_questions, review_selection_gaps)
    - agent_control.py (ControlPlane.record_critic_review)
    - tests/helpers/gate1_fixtures.py

Key Functions (test cases):
    - test_both_edges_declare_the_three_internal_selections_conditionally
    - test_conditional_questions_are_not_dbrequired
    - test_internal_method_asks_runtime_model_effort_in_order_and_records_human_decisions
    - test_external_method_asks_nothing_more
    - test_provided_answers_cannot_satisfy_an_internal_selection
    - test_empty_selection_is_rejected
    - test_critic_outcome_is_refused_without_the_selections
    - test_review_selection_gaps_reports_missing_ids
"""

import io
import sqlite3
import sys
from pathlib import Path

import pytest

_scripts_dir = str(Path(__file__).resolve().parent.parent / "scripts")
if _scripts_dir not in sys.path:
    sys.path.insert(0, _scripts_dir)

from control_plane.coordinator import TransitionCoordinator, TransitionCoordinatorError
from control_plane.pipeline_simulator import PipelineSimulator
from control_plane.registry import TransitionRegistry
from control_plane.review_selection import REVIEW_EDGES, conditional_questions, review_selection_gaps

TASK = "review-sel-001"
INTERNAL = "Multi-agent review — internal [Recommended]"
EXTERNAL = "Multi-agent review — external bundle (agent generates bundle, waits for you to upload to an independent model and report back)"
YES = "Yes — continue to review method selection [Recommended]"


def _plan_review_task(tmp_path):
    registry = TransitionRegistry.load_default()
    sim = PipelineSimulator(tmp_path / "control_plane.db", registry=registry)
    sim.create_task(TASK, "review selection")
    sim.control_plane.repo_root = tmp_path / "repo"
    sim.control_plane.repo_root.mkdir(parents=True, exist_ok=True)
    sim.enter_interview(TASK)
    sim.stage_interview_answers(TASK, classification="STANDARD", to_state="DRAFT_PLAN")
    sim.control_plane.record_plan_mode_entry(TASK, "simulator")
    sim.transition_from_interview(TASK, "DRAFT_PLAN", classification="STANDARD", expect_success=True)
    plans = sim.control_plane.repo_root / "docs" / "plans"
    plans.mkdir(parents=True, exist_ok=True)
    (plans / f"{TASK}-spec.md").write_text("# spec", encoding="utf-8")
    (plans / f"{TASK}-implementation-plan.md").write_text("# plan", encoding="utf-8")
    feed = iter(["1", "YES"])
    TransitionCoordinator(
        sim.control_plane, registry=registry, input_fn=lambda _p: next(feed), output_stream=io.StringIO(),
    ).coordinate_transition(task_id=TASK, to_state="PLAN_REVIEW", actor="human", reason="setup", interactive=True)
    return sim


def _go(sim, answers, **kw):
    feed = iter(answers)
    prompts = []

    def ask(p):
        prompts.append(p)
        return next(feed)

    coordinator = TransitionCoordinator(sim.control_plane, registry=sim.registry, input_fn=ask, output_stream=io.StringIO())
    kwargs = dict(task_id=TASK, to_state="MULTI_AGENT_REVIEW", actor="human", reason="review", interactive=True)
    kwargs.update(kw)
    return coordinator.coordinate_transition(**kwargs), prompts


def _decisions(sim):
    conn = sqlite3.connect(sim.control_plane.db_path)
    return conn.execute(
        "SELECT question_id, answer, actor FROM transition_decisions WHERE task_id = ? AND to_state = 'MULTI_AGENT_REVIEW' ORDER BY decision_id",
        (TASK,),
    ).fetchall()


def test_both_edges_declare_the_three_internal_selections_conditionally():
    registry = TransitionRegistry.load_default()
    for from_state, to_state in REVIEW_EDGES:
        questions = conditional_questions(registry.get_template(from_state, to_state))
        assert len(questions) == 3
        assert [q["asked_when"]["question_id"] for q in questions] == [questions[0]["asked_when"]["question_id"]] * 3


def test_conditional_questions_are_not_dbrequired(tmp_path):
    sim = _plan_review_task(tmp_path)
    conn = sqlite3.connect(sim.control_plane.db_path)
    required = {r[0] for r in conn.execute(
        "SELECT question_id FROM required_transition_questions WHERE from_state = 'PLAN_REVIEW' AND to_state = 'MULTI_AGENT_REVIEW'")}
    conditional = {q["question_id"] for q in conditional_questions(sim.registry.get_template("PLAN_REVIEW", "MULTI_AGENT_REVIEW"))}
    assert conditional and not (required & conditional)


def test_internal_method_asks_runtime_model_effort_in_order_and_records_human_decisions(tmp_path):
    sim = _plan_review_task(tmp_path)
    _, prompts = _go(sim, [YES, INTERNAL, "claude-cli", "opus-5", "medium", "YES"])
    ids = [p.split(":")[0] for p in prompts]
    conditional = [q["question_id"] for q in conditional_questions(sim.registry.get_template("PLAN_REVIEW", "MULTI_AGENT_REVIEW"))]
    assert ids[2:5] == conditional
    rows = {r[0]: (r[1], r[2]) for r in _decisions(sim)}
    assert [rows[c] for c in conditional] == [("claude-cli", "human"), ("opus-5", "human"), ("medium", "human")]


def test_external_method_asks_nothing_more(tmp_path):
    sim = _plan_review_task(tmp_path)
    _, prompts = _go(sim, [YES, EXTERNAL, "YES"])
    conditional = {q["question_id"] for q in conditional_questions(sim.registry.get_template("PLAN_REVIEW", "MULTI_AGENT_REVIEW"))}
    assert not ({p.split(":")[0] for p in prompts} & conditional)
    assert not ({r[0] for r in _decisions(sim)} & conditional)


def test_provided_answers_cannot_satisfy_an_internal_selection(tmp_path):
    sim = _plan_review_task(tmp_path)
    conditional = conditional_questions(sim.registry.get_template("PLAN_REVIEW", "MULTI_AGENT_REVIEW"))
    answers = {"plan_review_agent_review_decision": YES, "plan_review_method": INTERNAL}
    answers.update({q["question_id"]: "x" for q in conditional})
    with pytest.raises(TransitionCoordinatorError):
        _go(sim, [], interactive=False, provided_answers=answers)
    assert sim.control_plane._persistence.read_current_state(TASK) == "PLAN_REVIEW"


def test_empty_selection_is_rejected(tmp_path):
    sim = _plan_review_task(tmp_path)
    with pytest.raises(TransitionCoordinatorError):
        _go(sim, [YES, INTERNAL, "", "opus-5", "medium", "YES"])
    assert sim.control_plane._persistence.read_current_state(TASK) == "PLAN_REVIEW"


def test_critic_outcome_is_refused_without_the_selections(tmp_path):
    sim = _plan_review_task(tmp_path)
    _go(sim, [YES, INTERNAL, "claude-cli", "opus-5", "medium", "YES"])
    conn = sqlite3.connect(sim.control_plane.db_path)
    conn.execute("DELETE FROM transition_decisions WHERE task_id = ? AND question_id LIKE '%internal_model'", (TASK,))
    conn.commit()
    with pytest.raises(Exception) as excinfo:
        sim.control_plane.record_critic_review(TASK, 1, "opus-5", "PASS", "no selection recorded")
    assert "selection" in str(excinfo.value).lower()


def test_review_selection_gaps_reports_missing_ids(tmp_path):
    sim = _plan_review_task(tmp_path)
    conn = sqlite3.connect(sim.control_plane.db_path)
    assert review_selection_gaps(conn, sim.registry, TASK, "PLAN_REVIEW", "MULTI_AGENT_REVIEW") == []
    _go(sim, [YES, INTERNAL, "claude-cli", "opus-5", "medium", "YES"])
    assert review_selection_gaps(conn, sim.registry, TASK, "PLAN_REVIEW", "MULTI_AGENT_REVIEW") == []
    conn.execute("DELETE FROM transition_decisions WHERE task_id = ? AND question_id LIKE '%internal_effort'", (TASK,))
    conn.commit()
    gaps = review_selection_gaps(conn, sim.registry, TASK, "PLAN_REVIEW", "MULTI_AGENT_REVIEW")
    assert len(gaps) == 1 and gaps[0].endswith("internal_effort")
reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.Stars: 322kUpdated Claude CodeCodexVerifiedInstall
dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependenciesStars: 322kUpdated Claude CodeCodexVerifiedInstall
executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is availableStars: 322kUpdated Claude CodeCodexVerifiedInstall