Skip to content

richfrem/agent-plugins-skills / plugins/agent-agentic-os/.apm/skills/running-control-plane

running-control-plane

Flagged

CRITICAL INTAKE GATEWAY: use at the start of any non-trivial engineering task, feature, refactor, multi-file bugfix, work package or new idea, including requests to explore, brainstorm, build, fix or change something, before planning or code changes. Enforces read-only discovery, 1-3 structured questions with defaults, control-plane registration and the immutable four-pillar TASK_SPEC.md. Also runs the rest of the control plane: health ("run health check", "check os metrics", "system monitor", event bus, locks, memory, "is my signing identity ready" status check), transition simulation ("dry run transition", "simulate transition", "check edge X -> Y"), worktree selection, and gating on/off ("disable the control plane", "turn off the push guard", "stop gating my commits"). Not for project setup or key creation (use setting-up-agentic-os) or improving skills (use improving-skills-in-lab).

FileKindSize
SKILL.mdskill md5.4 KB
evals/evals.jsonconfig8.3 KB
references/acceptance-criteria.mdmarkdown4.0 KB
references/agentic-os-skill-map.mdmarkdown2.3 KB
references/architecture/architecture.mdmarkdown2.4 KB
references/architecture/context-folder-patterns.mdmarkdown3.3 KB
references/architecture/vision.mdmarkdown56.6 KB
references/cheap-agent-transition-simulation.mdmarkdown6.1 KB
references/control-plane-architecture.mdmarkdown9.0 KB
references/control-plane-rebuild-recovery.mdmarkdown6.2 KB
references/control-plane-simulation-protocol.mdmarkdown5.7 KB
references/diagrams/agentic-os-memory-subsystem.mmdother1.4 KB
references/diagrams/architecture-overview.mmdother3.1 KB
references/diagrams/control-plane-architecture.mermaidother6.3 KB
references/diagrams/control-plane-lifecycle-hardened-with-ciba-rar.mermaidother4.5 KB
references/diagrams/control-plane-pipeline-happy-path.mermaidother5.0 KB
references/diagrams/control-plane-pipeline.mermaidother9.3 KB
references/diagrams/event-bus-architecture.mmdother2.4 KB
references/diagrams/increment-b-human-only-transition-ssh-signing.mermaidother5.3 KB
references/edge-matrix.mdmarkdown13.3 KB
references/fallback-tree.mdmarkdown2.9 KB
references/health-detailed-reference.mdmarkdown7.1 KB
references/healthy-transcript.mdmarkdown3.8 KB
references/implementation-ledger-contract.mdmarkdown851 B
references/intake-detailed-reference.mdmarkdown3.1 KB
references/modes/health.mdmarkdown3.4 KB
references/modes/intake.mdmarkdown3.8 KB
references/modes/mode.mdmarkdown5.8 KB
references/modes/simulator.mdmarkdown6.2 KB
references/modes/worktree.mdmarkdown2.9 KB
references/multi-round-external-review-protocol.mdmarkdown2.6 KB
references/worktree-reconciliation-and-multi-worktree-practices.mdmarkdown5.8 KB
requirements-dev.inother741 B
requirements-dev.txtmarkdown603 B
requirements.inother196 B
requirements.txtmanifest202 B
scripts/agent_control.pyscript97.7 KB
scripts/audit_map_debt.pyscript6.1 KB
scripts/capability_probe.pyscript6.4 KB
scripts/check_plan_links.pyscript1.8 KB
scripts/control_plane/__init__.pyscript842 B
scripts/control_plane/adapters.pyscript144.9 KB
scripts/control_plane/approver_policy.pyscript20.0 KB
scripts/control_plane/baseline_transition_report.pyscript4.0 KB
scripts/control_plane/constants.pyscript13.5 KB
scripts/control_plane/coordinator.pyscript57.3 KB
scripts/control_plane/edge_matrix.pyscript3.1 KB
scripts/control_plane/gate1_approval.pyscript10.7 KB
scripts/control_plane/gate_evidence.pyscript9.9 KB
scripts/control_plane/identity_layout.pyscript2.9 KB
scripts/control_plane/identity_setup.pyscript11.0 KB
scripts/control_plane/implementation.pyscript3.7 KB
scripts/control_plane/implementation_loop.pyscript11.3 KB
scripts/control_plane/inspection.pyscript3.9 KB
scripts/control_plane/installation_probe.pyscript5.7 KB
scripts/control_plane/isolation_check.pyscript14.0 KB
scripts/control_plane/measurement.pyscript39.1 KB
scripts/control_plane/pipeline_simulator.pyscript30.0 KB
scripts/control_plane/policy.pyscript32.5 KB
scripts/control_plane/ports.pyscript20.3 KB
scripts/control_plane/proof_edges.pyscript4.6 KB
scripts/control_plane/proof_policy.pyscript2.2 KB
scripts/control_plane/receipt_provenance.pyscript4.7 KB
scripts/control_plane/registry.pyscript32.9 KB
scripts/control_plane/review_options.pyscript8.2 KB
scripts/control_plane/review_selection.pyscript3.2 KB
scripts/control_plane/run_transition_simulation.pyscript12.0 KB
scripts/control_plane/signing_selftest.pyscript6.8 KB
scripts/control_plane/simulation_identity.pyscript10.4 KB
scripts/control_plane/snapshot.pyscript10.8 KB
scripts/control_plane/ssh_signing.pyscript21.8 KB
scripts/control_plane/state_machine.pyscript5.8 KB
scripts/control_plane/transition_request.pyscript19.5 KB
scripts/control_plane/transition_simulation_cases.pyscript24.6 KB
scripts/control_plane/transition_templates.yamlconfig159.1 KB
scripts/control_plane/tty_signer.pyscript3.0 KB
scripts/control_plane/wrappers/__init__.pyscript24 B
scripts/control_plane/wrappers/record_interview_question.pyscript8.0 KB
scripts/control_plane/wrappers/record_retrospective.pyscript2.3 KB
scripts/control_plane/wrappers/run_exit_verification.pyscript6.4 KB
scripts/control_plane/wrappers/run_verify_exit_bundle.pyscript5.4 KB
scripts/control_plane/wrappers/write_plan_document.pyscript9.6 KB
scripts/control_plane_hooks.pyscript10.5 KB
scripts/control_plane_mode.pyscript12.0 KB
scripts/distill_playbook.pyexecutablescript9.9 KB
scripts/evolution_state.pyscript29.4 KB
scripts/export_upstream_pr.pyscript4.4 KB
scripts/interview_spec_engine.pyscript9.1 KB
scripts/kernel.pyscript14.6 KB
scripts/pre-commit-evolution-guardexecutablescript3.7 KB
scripts/pre-commit-pipeline-guardexecutablescript13.6 KB
scripts/pre-push-review-guardexecutablescript10.5 KB
scripts/record_trace.pyscript7.2 KB
scripts/smoke_test.pyexecutablescript22.6 KB
scripts/test_capability_probe.pyscript3.9 KB
scripts/test_worktree_manager.pyscript2.8 KB
scripts/verify_evolution_receipt.pyscript7.5 KB
scripts/verify_gate_evidence.pyscript1.6 KB
scripts/worktree_manager.pyscript3.0 KB
tests/conftest.pyscript7.7 KB
tests/helpers/__init__.pyscript0 B
tests/helpers/control_plane_fixtures.pyscript2.6 KB
tests/helpers/control_plane_repo.pyscript4.0 KB
tests/helpers/gate1_fixtures.pyscript5.8 KB
tests/helpers/human_signer.pyscript7.3 KB
tests/helpers/implementation_ledger.pyscript1.1 KB
tests/interview_helpers.pyscript5.2 KB
tests/test_actionable_rollback.pyscript2.2 KB
tests/test_agent_control.pyscript190.6 KB
tests/test_agent_control_gate_characterization.pyscript14.7 KB
tests/test_approve_transition.pyscript10.5 KB
tests/test_approver_identity_guidance.pyscript3.4 KB
tests/test_approver_isolation.pyscript12.3 KB
tests/test_audit_map_debt.pyscript4.7 KB
tests/test_authorized_actor_enforcement.pyscript22.9 KB
tests/test_background_document_priority.pyscript924 B
tests/test_check_plan_links.pyscript1.1 KB
tests/test_content_snapshot.pyscript11.8 KB
tests/test_control_plane_architecture_diagram_contract.pyscript9.0 KB
tests/test_control_plane_architecture_overview_contract.pyscript2.1 KB
tests/test_control_plane_critic_review.pyscript3.1 KB
tests/test_control_plane_crypto_adapter.pyscript5.0 KB
tests/test_control_plane_delegation_contract.pyscript5.7 KB
tests/test_control_plane_facade_composition.pyscript15.9 KB
tests/test_control_plane_filesystem_adapter.pyscript4.9 KB
tests/test_control_plane_hooks.pyscript7.3 KB
tests/test_control_plane_interview_guidance.pyscript3.8 KB
tests/test_control_plane_measurement_contract.pyscript28.0 KB
tests/test_control_plane_mode.pyscript7.5 KB
tests/test_control_plane_mode_guards.pyscript3.5 KB
tests/test_control_plane_model_catalog_adapter.pyscript9.2 KB
tests/test_control_plane_pipeline_diagram_contract.pyscript2.3 KB
tests/test_control_plane_pipeline_simulator.pyscript7.5 KB
tests/test_control_plane_policy.pyscript13.0 KB
tests/test_control_plane_ports.pyscript3.2 KB
tests/test_control_plane_reset_transition.pyscript13.6 KB
tests/test_control_plane_schema_rebuild_atomicity.pyscript20.0 KB
tests/test_control_plane_simulation_protocol_contract.pyscript959 B
tests/test_control_plane_sqlite_persistence_adapter.pyscript5.5 KB
tests/test_control_plane_state_machine.pyscript15.2 KB
tests/test_control_plane_trigger_enforcement.pyscript14.6 KB
tests/test_control_plane_worktree_sharing.pyscript4.5 KB
tests/test_domain_namespaces.pyscript6.7 KB
tests/test_done_closure_proof.pyscript6.9 KB
tests/test_draft_plan_interactive_outline_gap.pyscript2.2 KB
tests/test_dual_identity_onboarding.pyscript7.3 KB
tests/test_edge_matrix.pyscript3.2 KB
tests/test_ensure_schema_fastpath.pyscript4.4 KB
tests/test_evolution_guards.pyscript14.9 KB
tests/test_evolution_scripts.pyscript55.3 KB
tests/test_gate1_guidance.pyscript1.8 KB
tests/test_gate3_code_acceptance.pyscript13.5 KB
tests/test_graph_state_machine.pyscript16.0 KB
tests/test_guidance_readiness.pyscript2.2 KB
tests/test_health_check_signing_status.pyscript3.5 KB
tests/test_human_decision_trigger_enforcement.pyscript37.3 KB
tests/test_human_only_wiring.pyscript22.3 KB
tests/test_human_signer_isolation.pyscript4.0 KB
tests/test_identity_verification_readiness.pyscript5.8 KB
tests/test_implementation_ledger.pyscript3.4 KB
tests/test_implementation_loop.pyscript6.9 KB
tests/test_implementation_runtime_bridge.pyscript2.6 KB
tests/test_init_agentic_os_scaffolding.pyscript10.0 KB
tests/test_init_respects_control_plane_mode.pyscript4.3 KB
tests/test_inspect_verbs.pyscript3.6 KB
tests/test_installation_probe.pyscript3.1 KB
tests/test_intake_scenarios.pyscript7.2 KB
tests/test_interview_plan_outline.pyscript2.8 KB
tests/test_isolation_check.pyscript12.5 KB
tests/test_isolation_setup_docs.pyscript2.7 KB
tests/test_kernel_security.pyscript4.0 KB
tests/test_legacy_input_fallback.pyscript6.0 KB
tests/test_list_review_options.pyscript3.1 KB
tests/test_multi_agent_bundle_gate.pyscript5.5 KB
tests/test_one_approver_per_pipeline.pyscript15.8 KB
tests/test_os_init_dual_identity.pyscript3.9 KB
tests/test_os_init_identity_bootstrap.pyscript8.8 KB
tests/test_os_init_identity_status.pyscript3.9 KB
tests/test_os_init_single_instruction_file.pyscript7.3 KB
tests/test_p00_live_baseline.pyscript10.2 KB
tests/test_p01_intake_persistence.pyscript6.7 KB
tests/test_post_run_metrics_protocol.pyscript3.3 KB
tests/test_pre_commit_pipeline_guard.pyscript29.1 KB
tests/test_pre_push_review_guard.pyscript5.7 KB
tests/test_receipt_provenance.pyscript6.6 KB
tests/test_retrospective_pipeline.pyscript5.3 KB
tests/test_review_option_menus.pyscript6.6 KB
tests/test_review_selection.pyscript8.2 KB
tests/test_round3_fixes.pyscript8.3 KB
tests/test_rules_compliance.pyscript1.3 KB
tests/test_run_transition_simulation_formatting.pyscript1.7 KB
tests/test_run_verify_exit_bundle.pyscript10.2 KB
tests/test_setup_ciba_identity.pyscript11.2 KB
tests/test_signed_approval_human_receipt.pyscript3.9 KB
tests/test_signing_mechanics_selftest.pyscript6.9 KB
tests/test_signing_skill_selfcontained.pyscript3.4 KB
tests/test_skip_receipt_guidance.pyscript2.7 KB
tests/test_ssh_signing.pyscript23.9 KB
tests/test_strategy_artifacts.pyscript21.8 KB
tests/test_transition_answer_normalization.pyscript1.1 KB

tests/test_one_approver_per_pipeline.py

View on GitHub
#!/usr/bin/env python
"""
test_one_approver_per_pipeline.py
=================================

Purpose:
    Contract tests for one approver per pipeline (control_plane/approver_policy.py) in the
    two-database design: real work lives in control_plane.db (only human keys approve) and
    simulations in a separate simulation_control_plane.db (only the agent key approves). The
    context is a property of the database file, never of a row. Includes a regression for each
    applicable finding of the round-1 and round-2 adversarial reviews
    (temp/_prompt_requests/review-one-approver-per-pipeline-*response.md). Real ssh-keygen keys
    and signatures throughout; nothing is mocked except which key the stand-in human picks in
    the two negative end-to-end tests.

Key Input Dependencies:
    plugins/agent-agentic-os/skills/running-control-plane/scripts/control_plane/approver_policy.py — rules under test
    plugins/agent-agentic-os/skills/running-control-plane/scripts/control_plane/pipeline_simulator.py — end-to-end pipelines
    plugins/agent-agentic-os/skills/running-control-plane/tests/helpers/human_signer.py — stand-in human (operator + agent keys)
    ssh-keygen

Layer: Development / Testing

Functions:
    - test_context_is_decided_by_database_file_name
    - test_real_work_binds_first_human_key
    - test_second_human_key_refused_on_bound_pipeline
    - test_agent_key_refused_in_real_work_database
    - test_agent_key_under_alias_is_still_the_agent
    - test_principal_patterns_fail_closed
    - test_key_enrolled_as_both_agent_and_human_fails_closed
    - test_repository_database_requires_canonical_trust_anchor
    - test_binding_survives_receipt_deletion
    - test_rollout_binds_to_the_key_that_signed_earlier_gates
    - test_foreign_binding_row_fails_closed
    - test_simulation_database_refuses_human_key
    - test_simulation_database_keeps_one_agent_key
    - test_semicolon_principal_keeps_key_continuity
    - test_full_simulation_pipeline_only_agent_approves
    - test_full_real_work_pipeline_only_human_approves
    - test_agent_signature_refused_through_real_commit
    - test_human_signature_refused_through_real_commit_in_simulation

Usage:
    python -m pytest plugins/agent-agentic-os/skills/running-control-plane/tests/test_one_approver_per_pipeline.py
"""

import sqlite3
import subprocess
from pathlib import Path

import pytest

from agent_control import ControlPlane
from control_plane import approver_policy as ap
from control_plane.ssh_signing import SIGN_NAMESPACE

HUMAN = "operator@control-plane"


def _keygen(path: Path) -> str:
    subprocess.run(["ssh-keygen", "-q", "-t", "ed25519", "-N", "", "-f", str(path)], check=True)
    kt, kb = Path(str(path) + ".pub").read_text().split()[:2]
    return f"{kt} {kb}"


def _fp(path: Path) -> str:
    return ap.key_fingerprint(Path(str(path) + ".pub").read_text().split()[1])


@pytest.fixture
def keys(tmp_path):
    """Real human, second human, agent and second agent keys."""
    k = {name: tmp_path / f"{name}_key" for name in ("human", "human2", "agent", "agent2")}
    pubs = {name: _keygen(path) for name, path in k.items()}
    k["pubs"] = pubs
    k["lines"] = {
        "human": f'{HUMAN} namespaces="{SIGN_NAMESPACE}" {pubs["human"]}',
        "human2": f'second@control-plane namespaces="{SIGN_NAMESPACE}" {pubs["human2"]}',
        "agent": f'{ap.AGENT_SIMULATION_PRINCIPAL} namespaces="{SIGN_NAMESPACE}" {pubs["agent"]}',
        "agent2": f'{ap.AGENT_SIMULATION_PRINCIPAL} namespaces="{SIGN_NAMESPACE}" {pubs["agent2"]}',
    }
    return k


def _repo(root: Path, lines: list, db_name: str = ap.REPOSITORY_DB_NAME) -> tuple:
    """<root>/context/<db_name> with its allowed_signers at <root>/context/identity/allowed_signers."""
    (root / "context" / "identity" / "challenges").mkdir(parents=True)
    allowed = root / "context" / "identity" / "allowed_signers"
    allowed.write_text("\n".join(lines) + "\n")
    cp = ControlPlane(db_path=root / "context" / db_name)
    cp.init_db()
    cp.create_task("t1", "demo", "claude-code")
    return cp, allowed


def _enforce(cp, key, allowed, principal=HUMAN, request_id=None):
    with sqlite3.connect(cp.db_path) as conn:
        ap.enforce_pipeline_approver(conn, "t1", _fp(key), principal, allowed, cp.db_path, request_id)


def test_context_is_decided_by_database_file_name(tmp_path):
    assert ap.pipeline_context(tmp_path / "context" / "control_plane.db") == ap.CONTEXT_REAL
    assert ap.pipeline_context(tmp_path / "anything-else.db") == ap.CONTEXT_REAL  # unknown names fail safe
    assert ap.pipeline_context(tmp_path / "context" / "simulation" / ap.SIMULATION_DB_NAME) == ap.CONTEXT_SIMULATION


def test_real_work_binds_first_human_key(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["agent"]])
    _enforce(cp, keys["human"], allowed)
    with sqlite3.connect(cp.db_path) as conn:
        b = ap.get_binding(conn, "t1")
    assert (b["context"], b["approver_fingerprint"], b["source"]) == (ap.CONTEXT_REAL, _fp(keys["human"]), "first_gate")
    _enforce(cp, keys["human"], allowed)  # same key: later gates pass


def test_second_human_key_refused_on_bound_pipeline(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["human2"]])
    _enforce(cp, keys["human"], allowed)
    with pytest.raises(ap.ApproverPolicyError, match="One approver per pipeline"):
        _enforce(cp, keys["human2"], allowed, principal="second@control-plane")


def test_agent_key_refused_in_real_work_database(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["agent"]])
    with pytest.raises(ap.ApproverPolicyError, match="cannot approve real work"):
        _enforce(cp, keys["agent"], allowed, principal=ap.AGENT_SIMULATION_PRINCIPAL)


def test_agent_key_under_alias_is_still_the_agent(tmp_path, keys):
    alias = f'alias,{ap.AGENT_SIMULATION_PRINCIPAL} namespaces="{SIGN_NAMESPACE}" {keys["pubs"]["agent"]}'
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], alias])
    assert ap.key_role(_fp(keys["agent"]), allowed) == "agent"
    with pytest.raises(ap.ApproverPolicyError, match="cannot approve real work"):
        _enforce(cp, keys["agent"], allowed, principal="alias")


@pytest.mark.parametrize("principals", ["test-*@local", "test-hum?n@local", "*", "!someone@x,test-human@local"])
def test_principal_patterns_fail_closed(tmp_path, keys, principals):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], f'{principals} namespaces="{SIGN_NAMESPACE}" {keys["pubs"]["agent"]}'])
    with pytest.raises(ap.ApproverPolicyError, match="principal pattern"):
        _enforce(cp, keys["human"], allowed)


def test_key_enrolled_as_both_agent_and_human_fails_closed(tmp_path, keys):
    both = f'sneaky@control-plane namespaces="{SIGN_NAMESPACE}" {keys["pubs"]["agent"]}'
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["agent"], both])
    with pytest.raises(ap.ApproverPolicyError, match="both as the agent"):
        _enforce(cp, keys["agent"], allowed, principal="sneaky@control-plane")


def test_repository_database_requires_canonical_trust_anchor(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"]])
    stray = tmp_path / "stray_allowed_signers"
    stray.write_text(f'{HUMAN} namespaces="{SIGN_NAMESPACE}" {keys["pubs"]["agent"]}\n')  # agent key labelled human
    with pytest.raises(ap.ApproverPolicyError, match="must be verified against"):
        _enforce(cp, keys["agent"], stray)
    assert ap.canonical_anchor(cp.db_path) == allowed.resolve()
    _enforce(cp, keys["human"], allowed)


def test_binding_survives_receipt_deletion(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["human2"]])
    _enforce(cp, keys["human"], allowed)
    with sqlite3.connect(cp.db_path) as conn:  # what invalidation and an INTAKE reset do to evidence
        conn.execute("UPDATE verification_receipts SET invalidated_at = 1 WHERE task_id = 't1'")
        conn.execute("DELETE FROM verification_receipts WHERE task_id = 't1'")
    with pytest.raises(ap.ApproverPolicyError, match="One approver per pipeline"):
        _enforce(cp, keys["human2"], allowed, principal="second@control-plane")


def _consumed_request(cp, fingerprint: str, request_id: int) -> None:
    """A signed gate committed before this policy existed: a consumed request, no binding row."""
    with sqlite3.connect(cp.db_path) as conn:
        cols = [r[1] for r in conn.execute("PRAGMA table_info(transition_request)")]
        conn.execute("PRAGMA foreign_keys = OFF")
        values = {c: None for c in cols}
        values.update(request_id=request_id, task_id="t1", status="CONSUMED", jti=f"sshsig:{fingerprint}")
        notnull = {r[1]: r[3] for r in conn.execute("PRAGMA table_info(transition_request)")}
        for c in cols:
            if values[c] is None and notnull[c]:
                values[c] = 0
        conn.execute(f"INSERT INTO transition_request ({','.join(cols)}) VALUES ({','.join('?' * len(cols))})", tuple(values[c] for c in cols))


def test_rollout_binds_to_the_key_that_signed_earlier_gates(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["human2"]])
    _consumed_request(cp, _fp(keys["human"]), request_id=1)
    with pytest.raises(ap.ApproverPolicyError, match="earlier signed gate"):
        _enforce(cp, keys["human2"], allowed, principal="second@control-plane", request_id=2)
    _enforce(cp, keys["human"], allowed, request_id=2)
    with sqlite3.connect(cp.db_path) as conn:
        assert ap.get_binding(conn, "t1")["source"] == "history"


def test_foreign_binding_row_fails_closed(tmp_path, keys):
    """A binding row that does not match this task and database (copied, stale, or forged) grants nothing."""
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["agent"]])
    with sqlite3.connect(cp.db_path) as conn:
        ap.ensure_binding_table(conn)
        conn.execute(
            "INSERT INTO task_approver_binding VALUES ('t1', (SELECT created_at FROM tasks WHERE task_id='t1'), 'simulation', ?, 'x', 'first_gate', 0)",
            (_fp(keys["agent"]),),
        )
    with pytest.raises(ap.ApproverPolicyError, match="cannot approve real work"):
        _enforce(cp, keys["agent"], allowed, principal=ap.AGENT_SIMULATION_PRINCIPAL)
    with pytest.raises(ap.ApproverPolicyError, match="does not belong"):
        _enforce(cp, keys["human"], allowed)


def test_simulation_database_refuses_human_key(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["agent"]], db_name=ap.SIMULATION_DB_NAME)
    with pytest.raises(ap.ApproverPolicyError, match="a human key cannot"):
        _enforce(cp, keys["human"], allowed)
    _enforce(cp, keys["agent"], allowed, principal=ap.AGENT_SIMULATION_PRINCIPAL)


def test_simulation_database_keeps_one_agent_key(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["agent"], keys["lines"]["agent2"]], db_name=ap.SIMULATION_DB_NAME)
    _enforce(cp, keys["agent"], allowed, principal=ap.AGENT_SIMULATION_PRINCIPAL)
    with pytest.raises(ap.ApproverPolicyError, match="One approver per pipeline"):
        _enforce(cp, keys["agent2"], allowed, principal=ap.AGENT_SIMULATION_PRINCIPAL)


def test_semicolon_principal_keeps_key_continuity(tmp_path, keys):
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"]])
    _enforce(cp, keys["human"], allowed, principal="odd;name@x")
    _enforce(cp, keys["human"], allowed, principal="odd;name@x")
    with sqlite3.connect(cp.db_path) as conn:
        assert ap.get_binding(conn, "t1")["approver_principal"] == "odd;name@x"


# ---- complete pipelines through the real signed commit path ----

def _state_and_binding(sim, task):
    with sqlite3.connect(sim.db_path) as conn:
        state = conn.execute("SELECT state FROM tasks WHERE task_id = ?", (task,)).fetchone()[0]
        return state, ap.get_binding(conn, task)


def test_full_simulation_pipeline_only_agent_approves(tmp_path):
    from control_plane.pipeline_simulator import PipelineSimulator
    from helpers.human_signer import get_test_human

    from control_plane.simulation_identity import ensure_identity_at

    sim = PipelineSimulator(tmp_path / ap.SIMULATION_DB_NAME)  # signs with its own simulation key by default
    sim.create_task("t-sim", "simulation")
    sim.run_standard_happy_path("t-sim")
    state, b = _state_and_binding(sim, "t-sim")
    assert state == "DONE"
    sim_key = ensure_identity_at(tmp_path / "identity")["fingerprint"]
    assert (b["context"], b["approver_fingerprint"]) == (ap.CONTEXT_SIMULATION, sim_key)
    assert sim_key != _fp(get_test_human().key)  # its own generated key, not the suite's


def test_full_real_work_pipeline_only_human_approves(tmp_path):
    from control_plane.pipeline_simulator import PipelineSimulator
    from helpers.human_signer import get_test_human

    sim = PipelineSimulator(tmp_path / "control_plane.db")
    sim.create_task("t-real", "real work")
    sim.run_standard_happy_path("t-real")
    state, b = _state_and_binding(sim, "t-real")
    assert state == "DONE"
    assert (b["context"], b["approver_fingerprint"]) == (ap.CONTEXT_REAL, _fp(get_test_human().operator_key))


def test_agent_signature_refused_through_real_commit(tmp_path, monkeypatch):
    from control_plane.gate1_approval import GateApprovalError
    from control_plane.pipeline_simulator import PipelineSimulator
    from helpers.human_signer import TestHuman, get_test_human

    human = get_test_human()
    monkeypatch.setattr(TestHuman, "signer_for", lambda self, cp, rid: (human.key, ap.AGENT_SIMULATION_PRINCIPAL))
    sim = PipelineSimulator(tmp_path / "control_plane.db")
    sim.create_task("t-real", "real work")
    with pytest.raises((ap.ApproverPolicyError, GateApprovalError), match="cannot approve real work"):
        sim.run_standard_happy_path("t-real")
    state, b = _state_and_binding(sim, "t-real")
    assert state == "AWAITING_APPROVAL" and b is None


def test_human_signature_refused_through_real_commit_in_simulation(tmp_path, monkeypatch):
    from control_plane.gate1_approval import GateApprovalError
    from control_plane.pipeline_simulator import PipelineSimulator
    from helpers.human_signer import OPERATOR_PRINCIPAL, TestHuman, get_test_human

    human = get_test_human()
    monkeypatch.setattr(TestHuman, "signer_for", lambda self, cp, rid: (human.operator_key, OPERATOR_PRINCIPAL))
    sim = PipelineSimulator(tmp_path / ap.SIMULATION_DB_NAME, human_signer=human.sign_request)
    sim.create_task("t-sim", "simulation")
    with pytest.raises((ap.ApproverPolicyError, GateApprovalError), match="a human key cannot"):
        sim.run_standard_happy_path("t-sim")
    state, b = _state_and_binding(sim, "t-sim")
    assert state == "AWAITING_APPROVAL" and b is None


def test_simulation_name_pointing_at_real_database_is_refused(tmp_path, keys):
    """A symlink or hard link NAMED simulation_control_plane.db that reaches the real database is
    ambiguous: refused for every key, never treated as a simulation (and never reassigned)."""
    cp, allowed = _repo(tmp_path / "r", [keys["lines"]["human"], keys["lines"]["agent"]])
    real = Path(cp.db_path)
    symlinked = real.parent / "sym" / ap.SIMULATION_DB_NAME
    symlinked.parent.mkdir()
    symlinked.symlink_to(real)
    hardlinked = real.parent / "hard" / ap.SIMULATION_DB_NAME
    hardlinked.parent.mkdir()
    import os
    os.link(real, hardlinked)
    for alias in (symlinked, hardlinked):
        assert ap.pipeline_context(alias) == ap.CONTEXT_AMBIGUOUS, alias
        for key, principal in ((keys["agent"], ap.AGENT_SIMULATION_PRINCIPAL), (keys["human"], HUMAN)):
            with sqlite3.connect(alias) as conn, pytest.raises(ap.ApproverPolicyError, match="ambiguous"):
                ap.enforce_pipeline_approver(conn, "t1", _fp(key), principal, allowed, alias)


def test_simulation_name_case_variant_is_ambiguous(tmp_path):
    assert ap.pipeline_context(tmp_path / "Simulation_Control_Plane.db") == ap.CONTEXT_AMBIGUOUS
reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.Stars: 322kUpdated Claude CodeCodexVerifiedInstall
dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependenciesStars: 322kUpdated Claude CodeCodexVerifiedInstall
executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is availableStars: 322kUpdated Claude CodeCodexVerifiedInstall