Skip to content

richfrem/agent-plugins-skills / plugins/agent-agentic-os/.apm/skills/running-control-plane

running-control-plane

Flagged

CRITICAL INTAKE GATEWAY: use at the start of any non-trivial engineering task, feature, refactor, multi-file bugfix, work package or new idea, including requests to explore, brainstorm, build, fix or change something, before planning or code changes. Enforces read-only discovery, 1-3 structured questions with defaults, control-plane registration and the immutable four-pillar TASK_SPEC.md. Also runs the rest of the control plane: health ("run health check", "check os metrics", "system monitor", event bus, locks, memory, "is my signing identity ready" status check), transition simulation ("dry run transition", "simulate transition", "check edge X -> Y"), worktree selection, and gating on/off ("disable the control plane", "turn off the push guard", "stop gating my commits"). Not for project setup or key creation (use setting-up-agentic-os) or improving skills (use improving-skills-in-lab).

FileKindSize
SKILL.mdskill md5.4 KB
evals/evals.jsonconfig8.3 KB
references/acceptance-criteria.mdmarkdown4.0 KB
references/agentic-os-skill-map.mdmarkdown2.3 KB
references/architecture/architecture.mdmarkdown2.4 KB
references/architecture/context-folder-patterns.mdmarkdown3.3 KB
references/architecture/vision.mdmarkdown56.6 KB
references/cheap-agent-transition-simulation.mdmarkdown6.1 KB
references/control-plane-architecture.mdmarkdown9.0 KB
references/control-plane-rebuild-recovery.mdmarkdown6.2 KB
references/control-plane-simulation-protocol.mdmarkdown5.7 KB
references/diagrams/agentic-os-memory-subsystem.mmdother1.4 KB
references/diagrams/architecture-overview.mmdother3.1 KB
references/diagrams/control-plane-architecture.mermaidother6.3 KB
references/diagrams/control-plane-lifecycle-hardened-with-ciba-rar.mermaidother4.5 KB
references/diagrams/control-plane-pipeline-happy-path.mermaidother5.0 KB
references/diagrams/control-plane-pipeline.mermaidother9.3 KB
references/diagrams/event-bus-architecture.mmdother2.4 KB
references/diagrams/increment-b-human-only-transition-ssh-signing.mermaidother5.3 KB
references/edge-matrix.mdmarkdown13.3 KB
references/fallback-tree.mdmarkdown2.9 KB
references/health-detailed-reference.mdmarkdown7.1 KB
references/healthy-transcript.mdmarkdown3.8 KB
references/implementation-ledger-contract.mdmarkdown851 B
references/intake-detailed-reference.mdmarkdown3.1 KB
references/modes/health.mdmarkdown3.4 KB
references/modes/intake.mdmarkdown3.8 KB
references/modes/mode.mdmarkdown5.8 KB
references/modes/simulator.mdmarkdown6.2 KB
references/modes/worktree.mdmarkdown2.9 KB
references/multi-round-external-review-protocol.mdmarkdown2.6 KB
references/worktree-reconciliation-and-multi-worktree-practices.mdmarkdown5.8 KB
requirements-dev.inother741 B
requirements-dev.txtmarkdown603 B
requirements.inother196 B
requirements.txtmanifest202 B
scripts/agent_control.pyscript97.7 KB
scripts/audit_map_debt.pyscript6.1 KB
scripts/capability_probe.pyscript6.4 KB
scripts/check_plan_links.pyscript1.8 KB
scripts/control_plane/__init__.pyscript842 B
scripts/control_plane/adapters.pyscript144.9 KB
scripts/control_plane/approver_policy.pyscript20.0 KB
scripts/control_plane/baseline_transition_report.pyscript4.0 KB
scripts/control_plane/constants.pyscript13.5 KB
scripts/control_plane/coordinator.pyscript57.3 KB
scripts/control_plane/edge_matrix.pyscript3.1 KB
scripts/control_plane/gate1_approval.pyscript10.7 KB
scripts/control_plane/gate_evidence.pyscript9.9 KB
scripts/control_plane/identity_layout.pyscript2.9 KB
scripts/control_plane/identity_setup.pyscript11.0 KB
scripts/control_plane/implementation.pyscript3.7 KB
scripts/control_plane/implementation_loop.pyscript11.3 KB
scripts/control_plane/inspection.pyscript3.9 KB
scripts/control_plane/installation_probe.pyscript5.7 KB
scripts/control_plane/isolation_check.pyscript14.0 KB
scripts/control_plane/measurement.pyscript39.1 KB
scripts/control_plane/pipeline_simulator.pyscript30.0 KB
scripts/control_plane/policy.pyscript32.5 KB
scripts/control_plane/ports.pyscript20.3 KB
scripts/control_plane/proof_edges.pyscript4.6 KB
scripts/control_plane/proof_policy.pyscript2.2 KB
scripts/control_plane/receipt_provenance.pyscript4.7 KB
scripts/control_plane/registry.pyscript32.9 KB
scripts/control_plane/review_options.pyscript8.2 KB
scripts/control_plane/review_selection.pyscript3.2 KB
scripts/control_plane/run_transition_simulation.pyscript12.0 KB
scripts/control_plane/signing_selftest.pyscript6.8 KB
scripts/control_plane/simulation_identity.pyscript10.4 KB
scripts/control_plane/snapshot.pyscript10.8 KB
scripts/control_plane/ssh_signing.pyscript21.8 KB
scripts/control_plane/state_machine.pyscript5.8 KB
scripts/control_plane/transition_request.pyscript19.5 KB
scripts/control_plane/transition_simulation_cases.pyscript24.6 KB
scripts/control_plane/transition_templates.yamlconfig159.1 KB
scripts/control_plane/tty_signer.pyscript3.0 KB
scripts/control_plane/wrappers/__init__.pyscript24 B
scripts/control_plane/wrappers/record_interview_question.pyscript8.0 KB
scripts/control_plane/wrappers/record_retrospective.pyscript2.3 KB
scripts/control_plane/wrappers/run_exit_verification.pyscript6.4 KB
scripts/control_plane/wrappers/run_verify_exit_bundle.pyscript5.4 KB
scripts/control_plane/wrappers/write_plan_document.pyscript9.6 KB
scripts/control_plane_hooks.pyscript10.5 KB
scripts/control_plane_mode.pyscript12.0 KB
scripts/distill_playbook.pyexecutablescript9.9 KB
scripts/evolution_state.pyscript29.4 KB
scripts/export_upstream_pr.pyscript4.4 KB
scripts/interview_spec_engine.pyscript9.1 KB
scripts/kernel.pyscript14.6 KB
scripts/pre-commit-evolution-guardexecutablescript3.7 KB
scripts/pre-commit-pipeline-guardexecutablescript13.6 KB
scripts/pre-push-review-guardexecutablescript10.5 KB
scripts/record_trace.pyscript7.2 KB
scripts/smoke_test.pyexecutablescript22.6 KB
scripts/test_capability_probe.pyscript3.9 KB
scripts/test_worktree_manager.pyscript2.8 KB
scripts/verify_evolution_receipt.pyscript7.5 KB
scripts/verify_gate_evidence.pyscript1.6 KB
scripts/worktree_manager.pyscript3.0 KB
tests/conftest.pyscript7.7 KB
tests/helpers/__init__.pyscript0 B
tests/helpers/control_plane_fixtures.pyscript2.6 KB
tests/helpers/control_plane_repo.pyscript4.0 KB
tests/helpers/gate1_fixtures.pyscript5.8 KB
tests/helpers/human_signer.pyscript7.3 KB
tests/helpers/implementation_ledger.pyscript1.1 KB
tests/interview_helpers.pyscript5.2 KB
tests/test_actionable_rollback.pyscript2.2 KB
tests/test_agent_control.pyscript190.6 KB
tests/test_agent_control_gate_characterization.pyscript14.7 KB
tests/test_approve_transition.pyscript10.5 KB
tests/test_approver_identity_guidance.pyscript3.4 KB
tests/test_approver_isolation.pyscript12.3 KB
tests/test_audit_map_debt.pyscript4.7 KB
tests/test_authorized_actor_enforcement.pyscript22.9 KB
tests/test_background_document_priority.pyscript924 B
tests/test_check_plan_links.pyscript1.1 KB
tests/test_content_snapshot.pyscript11.8 KB
tests/test_control_plane_architecture_diagram_contract.pyscript9.0 KB
tests/test_control_plane_architecture_overview_contract.pyscript2.1 KB
tests/test_control_plane_critic_review.pyscript3.1 KB
tests/test_control_plane_crypto_adapter.pyscript5.0 KB
tests/test_control_plane_delegation_contract.pyscript5.7 KB
tests/test_control_plane_facade_composition.pyscript15.9 KB
tests/test_control_plane_filesystem_adapter.pyscript4.9 KB
tests/test_control_plane_hooks.pyscript7.3 KB
tests/test_control_plane_interview_guidance.pyscript3.8 KB
tests/test_control_plane_measurement_contract.pyscript28.0 KB
tests/test_control_plane_mode.pyscript7.5 KB
tests/test_control_plane_mode_guards.pyscript3.5 KB
tests/test_control_plane_model_catalog_adapter.pyscript9.2 KB
tests/test_control_plane_pipeline_diagram_contract.pyscript2.3 KB
tests/test_control_plane_pipeline_simulator.pyscript7.5 KB
tests/test_control_plane_policy.pyscript13.0 KB
tests/test_control_plane_ports.pyscript3.2 KB
tests/test_control_plane_reset_transition.pyscript13.6 KB
tests/test_control_plane_schema_rebuild_atomicity.pyscript20.0 KB
tests/test_control_plane_simulation_protocol_contract.pyscript959 B
tests/test_control_plane_sqlite_persistence_adapter.pyscript5.5 KB
tests/test_control_plane_state_machine.pyscript15.2 KB
tests/test_control_plane_trigger_enforcement.pyscript14.6 KB
tests/test_control_plane_worktree_sharing.pyscript4.5 KB
tests/test_domain_namespaces.pyscript6.7 KB
tests/test_done_closure_proof.pyscript6.9 KB
tests/test_draft_plan_interactive_outline_gap.pyscript2.2 KB
tests/test_dual_identity_onboarding.pyscript7.3 KB
tests/test_edge_matrix.pyscript3.2 KB
tests/test_ensure_schema_fastpath.pyscript4.4 KB
tests/test_evolution_guards.pyscript14.9 KB
tests/test_evolution_scripts.pyscript55.3 KB
tests/test_gate1_guidance.pyscript1.8 KB
tests/test_gate3_code_acceptance.pyscript13.5 KB
tests/test_graph_state_machine.pyscript16.0 KB
tests/test_guidance_readiness.pyscript2.2 KB
tests/test_health_check_signing_status.pyscript3.5 KB
tests/test_human_decision_trigger_enforcement.pyscript37.3 KB
tests/test_human_only_wiring.pyscript22.3 KB
tests/test_human_signer_isolation.pyscript4.0 KB
tests/test_identity_verification_readiness.pyscript5.8 KB
tests/test_implementation_ledger.pyscript3.4 KB
tests/test_implementation_loop.pyscript6.9 KB
tests/test_implementation_runtime_bridge.pyscript2.6 KB
tests/test_init_agentic_os_scaffolding.pyscript10.0 KB
tests/test_init_respects_control_plane_mode.pyscript4.3 KB
tests/test_inspect_verbs.pyscript3.6 KB
tests/test_installation_probe.pyscript3.1 KB
tests/test_intake_scenarios.pyscript7.2 KB
tests/test_interview_plan_outline.pyscript2.8 KB
tests/test_isolation_check.pyscript12.5 KB
tests/test_isolation_setup_docs.pyscript2.7 KB
tests/test_kernel_security.pyscript4.0 KB
tests/test_legacy_input_fallback.pyscript6.0 KB
tests/test_list_review_options.pyscript3.1 KB
tests/test_multi_agent_bundle_gate.pyscript5.5 KB
tests/test_one_approver_per_pipeline.pyscript15.8 KB
tests/test_os_init_dual_identity.pyscript3.9 KB
tests/test_os_init_identity_bootstrap.pyscript8.8 KB
tests/test_os_init_identity_status.pyscript3.9 KB
tests/test_os_init_single_instruction_file.pyscript7.3 KB
tests/test_p00_live_baseline.pyscript10.2 KB
tests/test_p01_intake_persistence.pyscript6.7 KB
tests/test_post_run_metrics_protocol.pyscript3.3 KB
tests/test_pre_commit_pipeline_guard.pyscript29.1 KB
tests/test_pre_push_review_guard.pyscript5.7 KB
tests/test_receipt_provenance.pyscript6.6 KB
tests/test_retrospective_pipeline.pyscript5.3 KB
tests/test_review_option_menus.pyscript6.6 KB
tests/test_review_selection.pyscript8.2 KB
tests/test_round3_fixes.pyscript8.3 KB
tests/test_rules_compliance.pyscript1.3 KB
tests/test_run_transition_simulation_formatting.pyscript1.7 KB
tests/test_run_verify_exit_bundle.pyscript10.2 KB
tests/test_setup_ciba_identity.pyscript11.2 KB
tests/test_signed_approval_human_receipt.pyscript3.9 KB
tests/test_signing_mechanics_selftest.pyscript6.9 KB
tests/test_signing_skill_selfcontained.pyscript3.4 KB
tests/test_skip_receipt_guidance.pyscript2.7 KB
tests/test_ssh_signing.pyscript23.9 KB
tests/test_strategy_artifacts.pyscript21.8 KB
tests/test_transition_answer_normalization.pyscript1.1 KB

tests/test_gate3_code_acceptance.py

View on GitHub
"""
tests/test_gate3_code_acceptance.py
===================================

Purpose:
    Failing-first acceptance tests for the hardening of Gate 3 (auth-ciba-increment-b, human decision 2026-09-20):
    BOTH edges into VERIFY_EXIT -- WORKTREE_REVIEW -> VERIFY_EXIT (direct code acceptance) and
    MULTI_AGENT_CODE_REVIEW -> VERIFY_EXIT (post-review code acceptance) -- are the moment human authority
    accepts the agent's code into the release pipeline, so they need the same cryptographic proof as Gate 1: the
    coordinator halts with HUMAN_PROOF_REQUIRED and a request_id, the challenge binds the task, the edge, the
    commit SHA, the diff hash and the untracked-file hash (a plain `git diff` would miss new files), and only a
    verified `ssh-keygen -Y sign` signature consumed in the commit transaction advances the state. The soft
    `--skip-review` / `--skip-reason` flags are gone. Real git repository, real SQLite, real ssh-keygen; the
    identity is injected, nothing is mocked.

Key Input Dependencies:
    - control_plane/proof_edges.py, snapshot.py (code_acceptance_snapshot), ssh_signing.py (EDGE_ASSERTIONS),
      coordinator.py (HumanProofRequired), adapters.py, gate1_approval.py, transition_templates.yaml, agent_control.py
    - tests/helpers/gate1_fixtures.py, tests/test_approve_transition.py (key helpers)

Key Functions (test cases):
    - test_both_edges_halt_for_a_signature_and_change_nothing
    - test_challenge_binds_head_diff_and_untracked
    - test_a_valid_signature_commits_verify_exit (both edges)
    - test_a_changed_tracked_file_or_new_untracked_file_refuses_and_audits
    - test_a_forged_signature_refuses_and_audits
    - test_staged_human_decisions_are_refused_without_a_proof
    - test_skip_flags_are_gone_and_skip_is_refused_on_proof_edges
    - test_registry_has_no_skip_semantics_on_the_gate3_edges
"""

import io
import os
import pwd
import shutil
import sqlite3
import subprocess
import sys
from pathlib import Path

import pytest

_scripts_dir = str(Path(__file__).resolve().parent.parent / "scripts")
if _scripts_dir not in sys.path:
    sys.path.insert(0, _scripts_dir)

import agent_control
from helpers.human_signer import OPERATOR_PRINCIPAL, get_test_human
from control_plane.coordinator import HumanProofRequired, TransitionCoordinator, TransitionCoordinatorError
from control_plane.gate1_approval import GateApprovalError, approve_transition, show_challenge
from control_plane.identity_layout import default_layout
from control_plane.ports import PersistenceInvariantViolation, TransitionCommitRequest, TransitionDecision
from control_plane.registry import TransitionRegistry
from control_plane.ssh_signing import SIGN_NAMESPACE
from helpers.gate1_fixtures import init_git_worktree, reach_multi_agent_code_review, reach_worktree_review

TASK = "gate3-task-001"
DIRECT = ("WORKTREE_REVIEW", "VERIFY_EXIT")
POST_REVIEW = ("MULTI_AGENT_CODE_REVIEW", "VERIFY_EXIT")
_FOUND = shutil.which("ssh-keygen")
SSH_KEYGEN = _FOUND or "ssh-keygen"
pytestmark = [pytest.mark.no_auto_signer, pytest.mark.skipif(_FOUND is None or shutil.which("git") is None, reason="ssh-keygen and git are required")]


def _other_uid() -> int:
    for name in ("nobody", "daemon"):
        try:
            uid = pwd.getpwnam(name).pw_uid
            if uid != os.geteuid():
                return uid
        except KeyError:
            continue
    return os.geteuid() + 4242


class CodeGate:
    """A task sitting at WORKTREE_REVIEW (or MULTI_AGENT_CODE_REVIEW) with a real git worktree and a real key."""

    def __init__(self, tmp_path: Path, edge):
        self.tmp = tmp_path.resolve()
        self.edge = edge
        self.worktree = init_git_worktree(self.tmp / "worktree")
        self.sim = reach_worktree_review(self.tmp, TASK, self.worktree)
        if edge == POST_REVIEW:
            reach_multi_agent_code_review(self.sim, TASK)
        self.cp = self.sim.control_plane
        self.repo = Path(self.cp.repo_root)
        (self.worktree / "module.py").write_text("VALUE = 2\n")  # the agent's uncommitted work
        (self.worktree / "new_file.py").write_text("NEW = 1\n")  # and a brand-new untracked file
        self.layout = default_layout(self.repo)
        for d in (self.layout.root, self.layout.challenge_dir):
            d.mkdir(parents=True, exist_ok=True)
            os.chmod(d, 0o700)
        # One approver per pipeline: this regular task's Gate 1 was signed with the stand-in human's operator key,
        # so Gate 3 must be signed with that same key (key continuity, not just a matching principal name).
        human = get_test_human()
        human.ensure_identity(self.repo)
        self.key = human.operator_key
        self.principal = OPERATOR_PRINCIPAL
        self.identity = {"agent_name": "agentic-os-local-agent", "agent_uid": _other_uid(), "agent_gids": set()}

    @staticmethod
    def keygen(path: Path) -> None:
        subprocess.run([SSH_KEYGEN, "-q", "-t", "ed25519", "-N", "", "-C", "op", "-f", str(path)], check=True, capture_output=True)

    def coordinator(self):
        return TransitionCoordinator(
            self.cp, registry=self.sim.registry, output_stream=io.StringIO(),
        )

    def request(self) -> int:
        with pytest.raises(HumanProofRequired) as excinfo:
            self.coordinator().coordinate_transition(task_id=TASK, to_state="VERIFY_EXIT", actor="agent", reason="request", interactive=False)
        self.request_id = excinfo.value.remediation["request_id"]
        return self.request_id

    def show(self):
        out = io.StringIO()
        path = show_challenge(self.cp, self.request_id, layout=self.layout, key_hint=str(self.key), agent_identity=self.identity, out=out)
        return path, out.getvalue()

    def sign(self, path: Path, key: Path = None) -> None:
        sig = Path(str(path) + ".sig")
        if sig.exists():
            sig.unlink()
        subprocess.run([SSH_KEYGEN, "-Y", "sign", "-f", str(key or self.key), "-n", SIGN_NAMESPACE, str(path)], check=True, capture_output=True)

    def approve(self):
        return approve_transition(self.cp, self.request_id, layout=self.layout, principal=self.principal, agent_identity=self.identity, out=io.StringIO())

    def db(self):
        return sqlite3.connect(self.cp.db_path)

    def state(self):
        return self.db().execute("SELECT state FROM tasks WHERE task_id = ?", (TASK,)).fetchone()[0]

    def violations(self):
        return self.db().execute("SELECT kind, detail FROM transition_violations WHERE task_id = ?", (TASK,)).fetchall()


@pytest.fixture(params=[DIRECT, POST_REVIEW], ids=["direct", "post-review"])
def gate(request, tmp_path):
    return CodeGate(tmp_path, request.param)


def test_both_edges_halt_for_a_signature_and_change_nothing(gate):
    with pytest.raises(HumanProofRequired) as excinfo:
        gate.coordinator().coordinate_transition(task_id=TASK, to_state="VERIFY_EXIT", actor="agent", reason="try", interactive=False)
    assert excinfo.value.remediation["request_id"]
    assert "HUMAN_PROOF_REQUIRED" in str(excinfo.value)
    assert gate.state() == gate.edge[0]
    assert gate.db().execute("SELECT COUNT(*) FROM transition_decisions WHERE task_id = ? AND to_state = 'VERIFY_EXIT'", (TASK,)).fetchone()[0] == 0


def test_challenge_binds_head_diff_and_untracked(gate):
    gate.request()
    path, printed = gate.show()
    head = subprocess.run(["git", "-C", str(gate.worktree), "rev-parse", "HEAD"], capture_output=True, text=True).stdout.strip()
    assert head in printed and "tracked_diff:" in printed and "untracked:" in printed
    assert f"transition: {gate.edge[0]} -> VERIFY_EXIT" in printed and f"task: {TASK}" in printed
    assert "nonce:" in printed and "expires:" in printed


def test_a_valid_signature_commits_verify_exit(gate):
    gate.request()
    path, _ = gate.show()
    gate.sign(path)
    record = gate.approve()
    assert record.to_state == "VERIFY_EXIT" and gate.state() == "VERIFY_EXIT"
    assert gate.db().execute("SELECT status FROM transition_request WHERE request_id = ?", (gate.request_id,)).fetchone()[0] == "CONSUMED"
    # no decision rows, no actor strings: the consumed, signature-verified request is the authority
    assert gate.db().execute("SELECT COUNT(*) FROM transition_decisions WHERE task_id = ? AND to_state = 'VERIFY_EXIT'", (TASK,)).fetchone()[0] == 0


@pytest.mark.parametrize("tamper", ["tracked", "untracked-new", "untracked-edit"])
def test_a_changed_tracked_file_or_new_untracked_file_refuses_and_audits(gate, tamper):
    gate.request()
    path, _ = gate.show()
    gate.sign(path)
    if tamper == "tracked":
        (gate.worktree / "module.py").write_text("VALUE = 3\n")
    elif tamper == "untracked-new":
        (gate.worktree / "sneaky.py").write_text("import os\n")
    else:
        (gate.worktree / "new_file.py").write_text("NEW = 999\n")
    with pytest.raises(GateApprovalError):
        gate.approve()
    assert gate.state() == gate.edge[0]
    assert gate.violations(), "the refused attempt must leave an audit row"
    assert {v[0] for v in gate.violations()} == {"REJECTED_ATTEMPT"}


def test_a_forged_signature_refuses_and_audits(gate, tmp_path):
    attacker = tmp_path / "attacker"
    attacker.mkdir()
    CodeGate.keygen(attacker / "id")
    gate.request()
    path, _ = gate.show()
    gate.sign(path, key=attacker / "id")
    with pytest.raises(GateApprovalError):
        gate.approve()
    assert gate.state() == gate.edge[0] and gate.violations()


def test_staged_human_decisions_are_refused_without_a_proof(gate):
    """No soft `actor='human'` decision rows: the commit path itself refuses them on a proof edge."""
    conn = gate.db()
    occupancy = conn.execute("SELECT MAX(transition_id) FROM task_transitions WHERE task_id = ?", (TASK,)).fetchone()[0]
    template = gate.sim.registry.get_template(*gate.edge[:1], "VERIFY_EXIT")
    decisions = [
        TransitionDecision(
            task_id=TASK, source_occupancy_transition_id=occupancy, from_state=gate.edge[0], to_state="VERIFY_EXIT",
            question_id=q["question_id"], answer=q["accepted_answers"][0], decision_type="ANSWER", actor="human", recorded_at=1.0,
        )
        for q in template.human_questions
    ]
    request = TransitionCommitRequest(
        task_id=TASK, expected_from_state=gate.edge[0], to_state="VERIFY_EXIT", source_occupancy_transition_id=occupancy,
        template_id=template.transition_id, actor="human", reason="soft", staged_decisions=decisions, staged_receipts=[],
    )
    with pytest.raises(PersistenceInvariantViolation):
        gate.cp._persistence.apply_transition_with_receipts(request)
    assert gate.state() == gate.edge[0]


def test_skip_flags_are_gone_and_skip_is_refused_on_proof_edges(gate):
    parser = agent_control._build_parser()
    for verb in ("coordinate-transition", "transition"):
        with pytest.raises(SystemExit):
            parser.parse_args([verb, "--task-id", TASK, "--to", "VERIFY_EXIT", "--skip-review", "--skip-reason", "x", "--human-confirmed", "HUMAN-CONFIRMED: x"])
    with pytest.raises((TransitionCoordinatorError, HumanProofRequired)):
        gate.coordinator().coordinate_transition(
            task_id=TASK, to_state="VERIFY_EXIT", actor="human", reason="skip", interactive=True, skip_review=True, skip_reason="x",
        )
    assert gate.state() == gate.edge[0]


def test_registry_has_no_skip_semantics_on_the_gate3_edges():
    registry = TransitionRegistry.load_default()
    for edge in (DIRECT, POST_REVIEW):
        template = registry.get_template(*edge)
        assert template.requires_cryptographic_proof is True
        assert template.skip.get("allowed") is False
        assert "code_review_or_skip" not in template.deterministic_checks
        assert template.human_questions == []
        assert "skip" not in template.next_steps_hint.lower(), edge


def _write_lock_is_free(db_path) -> bool:
    """True if another connection can take the write lock right now (0.3s budget)."""
    probe = sqlite3.connect(db_path, timeout=0.3, isolation_level=None)
    try:
        probe.execute("BEGIN IMMEDIATE;")
        probe.execute("ROLLBACK;")
        return True
    except sqlite3.OperationalError:
        return False
    finally:
        probe.close()


def test_no_write_lock_is_held_during_snapshot_or_signature_verification(gate, monkeypatch):
    """The commit's BEGIN IMMEDIATE must not span external work (git snapshot hashing, the
    `ssh-keygen -Y verify` subprocess): both run BEFORE the write lock is taken, or a concurrent
    writer gets `database is locked` for the full duration of the subprocess."""
    from control_plane import gate1_approval, transition_request

    observed = {"snapshot": [], "verify": []}
    real_snapshot, real_verify = gate1_approval.snapshot_for_edge, transition_request.verify_signature

    def snapshot_probe(*args, **kwargs):
        observed["snapshot"].append(_write_lock_is_free(gate.cp.db_path))
        return real_snapshot(*args, **kwargs)

    def verify_probe(*args, **kwargs):
        observed["verify"].append(_write_lock_is_free(gate.cp.db_path))
        return real_verify(*args, **kwargs)

    monkeypatch.setattr(gate1_approval, "snapshot_for_edge", snapshot_probe)
    monkeypatch.setattr(transition_request, "verify_signature", verify_probe)

    gate.request()
    path, _ = gate.show()
    gate.sign(path)
    observed["snapshot"].clear()  # show/challenge-time snapshots are not under test
    gate.approve()

    assert gate.state() == "VERIFY_EXIT"
    assert observed["verify"] and all(observed["verify"]), f"write lock held during ssh-keygen verify: {observed['verify']}"
    assert observed["snapshot"] and all(observed["snapshot"]), f"write lock held during live snapshot: {observed['snapshot']}"
reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis.Stars: 471kUpdated Claude CodeCodexUnverifiedInstall
diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.Stars: 322kUpdated Claude CodeCodexVerifiedInstall
dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependenciesStars: 322kUpdated Claude CodeCodexVerifiedInstall
executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is availableStars: 322kUpdated Claude CodeCodexVerifiedInstall