Skip to content

richfrem/agent-plugins-skills / plugins/agent-agentic-os/.apm/skills/running-control-plane

running-control-plane

Flagged

CRITICAL INTAKE GATEWAY: use at the start of any non-trivial engineering task, feature, refactor, multi-file bugfix, work package or new idea, including requests to explore, brainstorm, build, fix or change something, before planning or code changes. Enforces read-only discovery, 1-3 structured questions with defaults, control-plane registration and the immutable four-pillar TASK_SPEC.md. Also runs the rest of the control plane: health ("run health check", "check os metrics", "system monitor", event bus, locks, memory, "is my signing identity ready" status check), transition simulation ("dry run transition", "simulate transition", "check edge X -> Y"), worktree selection, and gating on/off ("disable the control plane", "turn off the push guard", "stop gating my commits"). Not for project setup or key creation (use setting-up-agentic-os) or improving skills (use improving-skills-in-lab).

FileKindSize
SKILL.mdskill md5.4 KB
evals/evals.jsonconfig8.3 KB
references/acceptance-criteria.mdmarkdown4.0 KB
references/agentic-os-skill-map.mdmarkdown2.3 KB
references/architecture/architecture.mdmarkdown2.4 KB
references/architecture/context-folder-patterns.mdmarkdown3.3 KB
references/architecture/vision.mdmarkdown56.6 KB
references/cheap-agent-transition-simulation.mdmarkdown6.1 KB
references/control-plane-architecture.mdmarkdown9.0 KB
references/control-plane-rebuild-recovery.mdmarkdown6.2 KB
references/control-plane-simulation-protocol.mdmarkdown5.7 KB
references/diagrams/agentic-os-memory-subsystem.mmdother1.4 KB
references/diagrams/architecture-overview.mmdother3.1 KB
references/diagrams/control-plane-architecture.mermaidother6.3 KB
references/diagrams/control-plane-lifecycle-hardened-with-ciba-rar.mermaidother4.5 KB
references/diagrams/control-plane-pipeline-happy-path.mermaidother5.0 KB
references/diagrams/control-plane-pipeline.mermaidother9.3 KB
references/diagrams/event-bus-architecture.mmdother2.4 KB
references/diagrams/increment-b-human-only-transition-ssh-signing.mermaidother5.3 KB
references/edge-matrix.mdmarkdown13.3 KB
references/fallback-tree.mdmarkdown2.9 KB
references/health-detailed-reference.mdmarkdown7.1 KB
references/healthy-transcript.mdmarkdown3.8 KB
references/implementation-ledger-contract.mdmarkdown851 B
references/intake-detailed-reference.mdmarkdown3.1 KB
references/modes/health.mdmarkdown3.4 KB
references/modes/intake.mdmarkdown3.8 KB
references/modes/mode.mdmarkdown5.8 KB
references/modes/simulator.mdmarkdown6.2 KB
references/modes/worktree.mdmarkdown2.9 KB
references/multi-round-external-review-protocol.mdmarkdown2.6 KB
references/worktree-reconciliation-and-multi-worktree-practices.mdmarkdown5.8 KB
requirements-dev.inother741 B
requirements-dev.txtmarkdown603 B
requirements.inother196 B
requirements.txtmanifest202 B
scripts/agent_control.pyscript97.7 KB
scripts/audit_map_debt.pyscript6.1 KB
scripts/capability_probe.pyscript6.4 KB
scripts/check_plan_links.pyscript1.8 KB
scripts/control_plane/__init__.pyscript842 B
scripts/control_plane/adapters.pyscript144.9 KB
scripts/control_plane/approver_policy.pyscript20.0 KB
scripts/control_plane/baseline_transition_report.pyscript4.0 KB
scripts/control_plane/constants.pyscript13.5 KB
scripts/control_plane/coordinator.pyscript57.3 KB
scripts/control_plane/edge_matrix.pyscript3.1 KB
scripts/control_plane/gate1_approval.pyscript10.7 KB
scripts/control_plane/gate_evidence.pyscript9.9 KB
scripts/control_plane/identity_layout.pyscript2.9 KB
scripts/control_plane/identity_setup.pyscript11.0 KB
scripts/control_plane/implementation.pyscript3.7 KB
scripts/control_plane/implementation_loop.pyscript11.3 KB
scripts/control_plane/inspection.pyscript3.9 KB
scripts/control_plane/installation_probe.pyscript5.7 KB
scripts/control_plane/isolation_check.pyscript14.0 KB
scripts/control_plane/measurement.pyscript39.1 KB
scripts/control_plane/pipeline_simulator.pyscript30.0 KB
scripts/control_plane/policy.pyscript32.5 KB
scripts/control_plane/ports.pyscript20.3 KB
scripts/control_plane/proof_edges.pyscript4.6 KB
scripts/control_plane/proof_policy.pyscript2.2 KB
scripts/control_plane/receipt_provenance.pyscript4.7 KB
scripts/control_plane/registry.pyscript32.9 KB
scripts/control_plane/review_options.pyscript8.2 KB
scripts/control_plane/review_selection.pyscript3.2 KB
scripts/control_plane/run_transition_simulation.pyscript12.0 KB
scripts/control_plane/signing_selftest.pyscript6.8 KB
scripts/control_plane/simulation_identity.pyscript10.4 KB
scripts/control_plane/snapshot.pyscript10.8 KB
scripts/control_plane/ssh_signing.pyscript21.8 KB
scripts/control_plane/state_machine.pyscript5.8 KB
scripts/control_plane/transition_request.pyscript19.5 KB
scripts/control_plane/transition_simulation_cases.pyscript24.6 KB
scripts/control_plane/transition_templates.yamlconfig159.1 KB
scripts/control_plane/tty_signer.pyscript3.0 KB
scripts/control_plane/wrappers/__init__.pyscript24 B
scripts/control_plane/wrappers/record_interview_question.pyscript8.0 KB
scripts/control_plane/wrappers/record_retrospective.pyscript2.3 KB
scripts/control_plane/wrappers/run_exit_verification.pyscript6.4 KB
scripts/control_plane/wrappers/run_verify_exit_bundle.pyscript5.4 KB
scripts/control_plane/wrappers/write_plan_document.pyscript9.6 KB
scripts/control_plane_hooks.pyscript10.5 KB
scripts/control_plane_mode.pyscript12.0 KB
scripts/distill_playbook.pyexecutablescript9.9 KB
scripts/evolution_state.pyscript29.4 KB
scripts/export_upstream_pr.pyscript4.4 KB
scripts/interview_spec_engine.pyscript9.1 KB
scripts/kernel.pyscript14.6 KB
scripts/pre-commit-evolution-guardexecutablescript3.7 KB
scripts/pre-commit-pipeline-guardexecutablescript13.6 KB
scripts/pre-push-review-guardexecutablescript10.5 KB
scripts/record_trace.pyscript7.2 KB
scripts/smoke_test.pyexecutablescript22.6 KB
scripts/test_capability_probe.pyscript3.9 KB
scripts/test_worktree_manager.pyscript2.8 KB
scripts/verify_evolution_receipt.pyscript7.5 KB
scripts/verify_gate_evidence.pyscript1.6 KB
scripts/worktree_manager.pyscript3.0 KB
tests/conftest.pyscript7.7 KB
tests/helpers/__init__.pyscript0 B
tests/helpers/control_plane_fixtures.pyscript2.6 KB
tests/helpers/control_plane_repo.pyscript4.0 KB
tests/helpers/gate1_fixtures.pyscript5.8 KB
tests/helpers/human_signer.pyscript7.3 KB
tests/helpers/implementation_ledger.pyscript1.1 KB
tests/interview_helpers.pyscript5.2 KB
tests/test_actionable_rollback.pyscript2.2 KB
tests/test_agent_control.pyscript190.6 KB
tests/test_agent_control_gate_characterization.pyscript14.7 KB
tests/test_approve_transition.pyscript10.5 KB
tests/test_approver_identity_guidance.pyscript3.4 KB
tests/test_approver_isolation.pyscript12.3 KB
tests/test_audit_map_debt.pyscript4.7 KB
tests/test_authorized_actor_enforcement.pyscript22.9 KB
tests/test_background_document_priority.pyscript924 B
tests/test_check_plan_links.pyscript1.1 KB
tests/test_content_snapshot.pyscript11.8 KB
tests/test_control_plane_architecture_diagram_contract.pyscript9.0 KB
tests/test_control_plane_architecture_overview_contract.pyscript2.1 KB
tests/test_control_plane_critic_review.pyscript3.1 KB
tests/test_control_plane_crypto_adapter.pyscript5.0 KB
tests/test_control_plane_delegation_contract.pyscript5.7 KB
tests/test_control_plane_facade_composition.pyscript15.9 KB
tests/test_control_plane_filesystem_adapter.pyscript4.9 KB
tests/test_control_plane_hooks.pyscript7.3 KB
tests/test_control_plane_interview_guidance.pyscript3.8 KB
tests/test_control_plane_measurement_contract.pyscript28.0 KB
tests/test_control_plane_mode.pyscript7.5 KB
tests/test_control_plane_mode_guards.pyscript3.5 KB
tests/test_control_plane_model_catalog_adapter.pyscript9.2 KB
tests/test_control_plane_pipeline_diagram_contract.pyscript2.3 KB
tests/test_control_plane_pipeline_simulator.pyscript7.5 KB
tests/test_control_plane_policy.pyscript13.0 KB
tests/test_control_plane_ports.pyscript3.2 KB
tests/test_control_plane_reset_transition.pyscript13.6 KB
tests/test_control_plane_schema_rebuild_atomicity.pyscript20.0 KB
tests/test_control_plane_simulation_protocol_contract.pyscript959 B
tests/test_control_plane_sqlite_persistence_adapter.pyscript5.5 KB
tests/test_control_plane_state_machine.pyscript15.2 KB
tests/test_control_plane_trigger_enforcement.pyscript14.6 KB
tests/test_control_plane_worktree_sharing.pyscript4.5 KB
tests/test_domain_namespaces.pyscript6.7 KB
tests/test_done_closure_proof.pyscript6.9 KB
tests/test_draft_plan_interactive_outline_gap.pyscript2.2 KB
tests/test_dual_identity_onboarding.pyscript7.3 KB
tests/test_edge_matrix.pyscript3.2 KB
tests/test_ensure_schema_fastpath.pyscript4.4 KB
tests/test_evolution_guards.pyscript14.9 KB
tests/test_evolution_scripts.pyscript55.3 KB
tests/test_gate1_guidance.pyscript1.8 KB
tests/test_gate3_code_acceptance.pyscript13.5 KB
tests/test_graph_state_machine.pyscript16.0 KB
tests/test_guidance_readiness.pyscript2.2 KB
tests/test_health_check_signing_status.pyscript3.5 KB
tests/test_human_decision_trigger_enforcement.pyscript37.3 KB
tests/test_human_only_wiring.pyscript22.3 KB
tests/test_human_signer_isolation.pyscript4.0 KB
tests/test_identity_verification_readiness.pyscript5.8 KB
tests/test_implementation_ledger.pyscript3.4 KB
tests/test_implementation_loop.pyscript6.9 KB
tests/test_implementation_runtime_bridge.pyscript2.6 KB
tests/test_init_agentic_os_scaffolding.pyscript10.0 KB
tests/test_init_respects_control_plane_mode.pyscript4.3 KB
tests/test_inspect_verbs.pyscript3.6 KB
tests/test_installation_probe.pyscript3.1 KB
tests/test_intake_scenarios.pyscript7.2 KB
tests/test_interview_plan_outline.pyscript2.8 KB
tests/test_isolation_check.pyscript12.5 KB
tests/test_isolation_setup_docs.pyscript2.7 KB
tests/test_kernel_security.pyscript4.0 KB
tests/test_legacy_input_fallback.pyscript6.0 KB
tests/test_list_review_options.pyscript3.1 KB
tests/test_multi_agent_bundle_gate.pyscript5.5 KB
tests/test_one_approver_per_pipeline.pyscript15.8 KB
tests/test_os_init_dual_identity.pyscript3.9 KB
tests/test_os_init_identity_bootstrap.pyscript8.8 KB
tests/test_os_init_identity_status.pyscript3.9 KB
tests/test_os_init_single_instruction_file.pyscript7.3 KB
tests/test_p00_live_baseline.pyscript10.2 KB
tests/test_p01_intake_persistence.pyscript6.7 KB
tests/test_post_run_metrics_protocol.pyscript3.3 KB
tests/test_pre_commit_pipeline_guard.pyscript29.1 KB
tests/test_pre_push_review_guard.pyscript5.7 KB
tests/test_receipt_provenance.pyscript6.6 KB
tests/test_retrospective_pipeline.pyscript5.3 KB
tests/test_review_option_menus.pyscript6.6 KB
tests/test_review_selection.pyscript8.2 KB
tests/test_round3_fixes.pyscript8.3 KB
tests/test_rules_compliance.pyscript1.3 KB
tests/test_run_transition_simulation_formatting.pyscript1.7 KB
tests/test_run_verify_exit_bundle.pyscript10.2 KB
tests/test_setup_ciba_identity.pyscript11.2 KB
tests/test_signed_approval_human_receipt.pyscript3.9 KB
tests/test_signing_mechanics_selftest.pyscript6.9 KB
tests/test_signing_skill_selfcontained.pyscript3.4 KB
tests/test_skip_receipt_guidance.pyscript2.7 KB
tests/test_ssh_signing.pyscript23.9 KB
tests/test_strategy_artifacts.pyscript21.8 KB
tests/test_transition_answer_normalization.pyscript1.1 KB

tests/test_control_plane_state_machine.py

View on GitHub
"""
test_control_plane_state_machine.py — State-Machine Domain Extraction (issue-524)
=====================================================================================

Purpose:
    Unit tests for control_plane/state_machine.py's StateMachine in complete isolation — no
    SQLite, no ControlPlane — proving state-machine validation (known-state check + adjacency
    legality) is genuinely independently testable domain logic. Added after external
    post-implementation review (round 2) found this validation still embedded directly in
    ControlPlane.transition(), contradicting the plan's declared "state-machine validation"
    separation. Also includes an integration test proving ControlPlane.transition() actually
    delegates to self._state_machine rather than reimplementing the checks inline.

Key Input Dependencies:
    None — pure in-memory StateMachine instance.

Key Functions:
    - test_validate_known_state_rejects_unknown_state()
    - test_validate_known_state_accepts_every_canonical_state()
    - test_validate_adjacency_rejects_illegal_edge()
    - test_validate_adjacency_accepts_every_legal_edge()
    - test_control_plane_transition_delegates_to_state_machine()
"""

import io
import sys
from pathlib import Path

import pytest

SCRIPTS_DIR = Path(__file__).resolve().parent.parent / "scripts"
if str(SCRIPTS_DIR) not in sys.path:
    sys.path.insert(0, str(SCRIPTS_DIR))

from control_plane.state_machine import StateMachine, CANONICAL_STATES, ALLOWED_TRANSITIONS, InvalidStateTransition
from control_plane.registry import TransitionRegistry
from control_plane.constants import (
    STATE_INTAKE, STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_MULTI_AGENT_REVIEW, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL, STATE_APPROVED, STATE_IN_WORKTREE, STATE_WORKTREE_REVIEW, STATE_MULTI_AGENT_CODE_REVIEW, STATE_VERIFY_EXIT, STATE_RETROSPECTIVE, STATE_DONE, STATE_ROLLED_BACK, STATE_ESCALATED,
)


def test_validate_known_state_rejects_unknown_state():
    sm = StateMachine()
    with pytest.raises(InvalidStateTransition, match="Unknown state: NOT_A_REAL_STATE"):
        sm.validate_known_state("NOT_A_REAL_STATE")


def test_validate_known_state_accepts_every_canonical_state():
    sm = StateMachine()
    for state in CANONICAL_STATES:
        sm.validate_known_state(state)  # must not raise


def test_validate_adjacency_rejects_illegal_edge():
    # DONE -> INTAKE is now the deliberate reset_to_intake recovery edge (added
    # for control-plane-reset-transition) — no longer illegal, so it can't be
    # used as the illegal-edge example here. DONE -> WORKTREE_REVIEW remains
    # illegal (DONE is still terminal except for the one explicit reset edge).
    sm = StateMachine()
    with pytest.raises(InvalidStateTransition, match="Cannot transition task 't1' from 'DONE' to 'WORKTREE_REVIEW'"):
        sm.validate_adjacency("t1", STATE_DONE, STATE_WORKTREE_REVIEW)


def test_validate_adjacency_accepts_every_legal_edge():
    sm = StateMachine()
    for from_state, to_states in ALLOWED_TRANSITIONS.items():
        for to_state in to_states:
            sm.validate_adjacency("t1", from_state, to_state)  # must not raise


def test_human_recovery_target_is_not_limited_by_normal_dag():
    sm = StateMachine()
    sm.validate_recovery_target("t1", STATE_DONE, STATE_IN_WORKTREE)
    with pytest.raises(InvalidStateTransition, match="must differ"):
        sm.validate_recovery_target("t1", STATE_DONE, STATE_DONE)


def test_human_recovery_from_done_to_worktree_requires_and_consumes_approval(tmp_path):
    from agent_control import ControlPlane

    cp = ControlPlane(db_path=tmp_path / "control_plane.db")
    cp.create_task(task_id="recovery-done-1", title="Reopen", runtime_tool="claude")
    cp.coordinate_transition("recovery-done-1", STATE_DONE, "human", "Close fixture", interactive=True)  # signed close

    token = cp.record_recovery_approval(
        "recovery-done-1", STATE_IN_WORKTREE, "human", actor="human",
        reason="Missed implementation fix requires rework",
    )
    record = cp.apply_recovery_transition(
        "recovery-done-1", STATE_IN_WORKTREE, token, "human", "Reopen for bounded rework"
    )

    assert record.from_state == STATE_DONE
    assert record.to_state == STATE_IN_WORKTREE
    assert cp.get_task("recovery-done-1")["state"] == STATE_IN_WORKTREE

def test_every_non_done_state_has_a_signed_closure_edge():
    for state in CANONICAL_STATES:
        if state != STATE_DONE:
            assert STATE_DONE in ALLOWED_TRANSITIONS[state]


@pytest.mark.no_auto_signer
def test_direct_agent_close_is_refused_without_an_openssh_signature(tmp_path):
    """auth-ciba-increment-b: closing a task is a cryptographic gate. An agent (or anyone) calling the facade
    without a signed transition_request fails closed: the state does not move."""
    from agent_control import ControlPlane
    from control_plane.coordinator import HumanProofRequired

    cp = ControlPlane(db_path=tmp_path / "control_plane.db")
    cp.create_task(task_id="force-1", title="Close", runtime_tool="claude")
    with pytest.raises((HumanProofRequired, Exception)) as excinfo:
        cp.transition("force-1", STATE_DONE, "agent", "close now")
    assert "signature" in str(excinfo.value).lower() or "HUMAN_PROOF_REQUIRED" in str(excinfo.value)
    assert cp.get_task("force-1")["state"] == STATE_INTAKE


def test_the_force_close_bypass_parameters_no_longer_exist(tmp_path):
    """The force_close / human_authorization keyword bypass was removed; passing it is a TypeError, not a
    quiet fallback, on both the coordinator and the ControlPlane facade."""
    from agent_control import ControlPlane
    from control_plane.coordinator import TransitionCoordinator

    cp = ControlPlane(db_path=tmp_path / "control_plane.db")
    cp.create_task("force-kw", "Close", "claude")
    with pytest.raises(TypeError, match="force_close"):
        TransitionCoordinator(cp).coordinate_transition(
            "force-kw", STATE_DONE, "human", "close", force_close=True, human_authorization="FORCE_CLOSE", interactive=True,
        )
    with pytest.raises(TypeError, match="force_close"):
        cp.coordinate_transition(
            "force-kw", STATE_DONE, "human", "close", force_close=True, human_authorization="FORCE_CLOSE", interactive=True,
        )
    assert cp.get_task("force-kw")["state"] == STATE_INTAKE


@pytest.mark.no_auto_signer
@pytest.mark.parametrize("typed", ["FORCE_CLOSE", "FORCE_DONE", "YES", "1"])
def test_a_typed_word_at_an_interactive_prompt_cannot_close_a_task(tmp_path, typed):
    """Even a real interactive terminal and the old magic words do nothing without a signature: the coordinator
    halts with HUMAN_PROOF_REQUIRED and the task does not move."""
    from agent_control import ControlPlane
    from control_plane.coordinator import HumanProofRequired, TransitionCoordinator

    cp = ControlPlane(db_path=tmp_path / "control_plane.db")
    cp.create_task("force-typed", "Close", "claude")
    prompts = []
    coord = TransitionCoordinator(cp, input_fn=lambda p: prompts.append(p) or typed, output_stream=io.StringIO())
    with pytest.raises(HumanProofRequired):
        coord.coordinate_transition("force-typed", STATE_DONE, "human", "close", interactive=True)
    assert cp.get_task("force-typed")["state"] == STATE_INTAKE
    assert prompts == []  # nothing was offered as an authorizing prompt


@pytest.mark.no_auto_signer
def test_a_noninteractive_human_actor_string_cannot_close_a_task(tmp_path):
    from agent_control import ControlPlane
    from control_plane.coordinator import HumanProofRequired

    cp = ControlPlane(db_path=tmp_path / "control_plane.db")
    cp.create_task("force-spoof", "Close", "claude")
    with pytest.raises(HumanProofRequired):
        cp.coordinate_transition("force-spoof", STATE_DONE, "human", "close", interactive=False)
    assert cp.get_task("force-spoof")["state"] == STATE_INTAKE


def test_a_signed_close_persists_from_any_state(tmp_path):
    """The positive path: with the (test) human signing the real request, closure commits."""
    from agent_control import ControlPlane

    cp = ControlPlane(db_path=tmp_path / "control_plane.db")
    cp.create_task(task_id="force-2", title="Close", runtime_tool="claude")
    record = cp.coordinate_transition("force-2", STATE_DONE, "human", "Emergency close", interactive=True)
    assert record.from_state == STATE_INTAKE
    assert cp.get_task("force-2")["state"] == STATE_DONE
    assert cp._persistence.get_last_transition("force-2").to_state == STATE_DONE


def test_every_non_done_state_exposes_a_proof_gated_closure_edge():
    """Closure is legal from every non-terminal state, and every such edge is cryptographic: it declares
    requires_cryptographic_proof, authority type cryptographic_proof, and no FORCE_* accepted-answer question."""
    registry = TransitionRegistry.load_default()
    proof_edges = registry.proof_required_edges()
    for state in CANONICAL_STATES:
        if state == STATE_DONE:
            continue
        assert STATE_DONE in ALLOWED_TRANSITIONS[state]
        template = registry.get_template(state, STATE_DONE)
        assert template is not None
        assert (state, STATE_DONE) in proof_edges
        assert template.authority.get("type") == "cryptographic_proof"
        for question in template.human_questions:
            assert not {"FORCE_DONE", "FORCE_CLOSE"} & set(question.get("accepted_answers", []))


def test_signed_close_reaches_done_from_every_nonterminal_state(tmp_path):
    """Exercise every closure source edge through the coordinator, real SQLite and the real (test) signer."""
    from agent_control import ControlPlane
    from control_plane.coordinator import TransitionCoordinator
    from helpers.gate1_fixtures import init_git_worktree

    paths = {
        STATE_INTAKE: [],
        STATE_INTERVIEW: [STATE_INTERVIEW],
        STATE_DRAFT_PLAN: [STATE_INTERVIEW, STATE_DRAFT_PLAN],
        STATE_PLAN_REVIEW: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW],
        STATE_MULTI_AGENT_REVIEW: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_MULTI_AGENT_REVIEW],
        STATE_AWAITING_APPROVAL: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL],
        STATE_APPROVED: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL, STATE_APPROVED],
        STATE_IN_WORKTREE: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL, STATE_APPROVED, STATE_IN_WORKTREE],
        STATE_WORKTREE_REVIEW: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL, STATE_APPROVED, STATE_IN_WORKTREE, STATE_WORKTREE_REVIEW],
        STATE_MULTI_AGENT_CODE_REVIEW: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL, STATE_APPROVED, STATE_IN_WORKTREE, STATE_WORKTREE_REVIEW, STATE_MULTI_AGENT_CODE_REVIEW],
        STATE_VERIFY_EXIT: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL, STATE_APPROVED, STATE_IN_WORKTREE, STATE_WORKTREE_REVIEW, STATE_VERIFY_EXIT],
        # RETROSPECTIVE is closed by retrospective_to_done, which adds retrospective_done_guard and the full-suite
        # receipt on top of the signature; those guards are covered by test_transition_guidance / test_agent_control.
        STATE_ROLLED_BACK: [STATE_INTERVIEW, STATE_DRAFT_PLAN, STATE_PLAN_REVIEW, STATE_AWAITING_APPROVAL, STATE_APPROVED, STATE_IN_WORKTREE, STATE_ROLLED_BACK],
        STATE_ESCALATED: [STATE_ESCALATED],
    }
    registry = TransitionRegistry.load_default()

    for state, path in paths.items():
        # <repo>/context/control_plane.db makes tmp the repo root, so the dirty-main check does not inspect the real checkout
        (tmp_path / state.lower() / "context").mkdir(parents=True)
        control_plane = ControlPlane(db_path=tmp_path / state.lower() / "context" / "control_plane.db")
        control_plane.init_db()
        task_id = f"close-{state.lower()}"
        control_plane.create_task(task_id, "Closure simulation", "simulator")
        current = STATE_INTAKE
        for next_state in path:
            template = registry.get_template(current, next_state)
            assert template is not None
            source_transition = control_plane._persistence.get_last_transition(task_id)
            question_ids = list(template.stage_question_ids or [])
            question_ids += [question["question_id"] for question in template.human_questions]
            if template.approval.get("required") and template.approval.get("approver_role", "human") == "human":
                question_ids.append(f"approval_{template.transition_id}")
            for question_id in question_ids:
                control_plane.record_decision(
                    task_id, source_transition.transition_id, current, next_state,
                    question_id, "SIMULATED_HUMAN_CONFIRMATION", actor="human",
                )
            if (current, next_state) in registry.proof_required_edges():
                # a cryptographic gate: setup walks it through the real signed flow, never a direct persistence write
                if next_state == STATE_VERIFY_EXIT:
                    control_plane.update_worktree(task_id, str(init_git_worktree(tmp_path / f"wt-{task_id}")), f"sim/{task_id}", "written_in_worktree")
                control_plane.coordinate_transition(task_id, next_state, "human", f"legal setup for {state}", interactive=True)
            else:
                assert control_plane._persistence.apply_transition(
                    task_id, current, next_state, "simulator", f"legal setup for {state}"
                )
            current = next_state

        record = TransitionCoordinator(control_plane, registry=registry, output_stream=io.StringIO()).coordinate_transition(
            task_id, STATE_DONE, "human", f"Signed close from {state}", interactive=True,
        )
        assert (record.from_state, record.to_state) == (state, STATE_DONE)
        assert control_plane.get_task(task_id)["state"] == STATE_DONE


def test_control_plane_transition_delegates_to_state_machine(tmp_path, monkeypatch):
    """Integration: ControlPlane.transition() calls self._state_machine.validate_known_state()
    and validate_adjacency() rather than checking CANONICAL_STATES/ALLOWED_TRANSITIONS inline —
    proven by monkeypatching StateMachine to record calls and confirm they happened."""
    from agent_control import ControlPlane

    calls = []
    original_validate_known = StateMachine.validate_known_state
    original_validate_adjacency = StateMachine.validate_adjacency

    def recording_validate_known(self, to_state):
        calls.append(("validate_known_state", to_state))
        return original_validate_known(self, to_state)

    def recording_validate_adjacency(self, task_id, current_state, to_state):
        calls.append(("validate_adjacency", task_id, current_state, to_state))
        return original_validate_adjacency(self, task_id, current_state, to_state)

    monkeypatch.setattr(StateMachine, "validate_known_state", recording_validate_known)
    monkeypatch.setattr(StateMachine, "validate_adjacency", recording_validate_adjacency)

    cp = ControlPlane(db_path=tmp_path / "control_plane.db")
    cp.create_task(task_id="t1", title="State Machine Delegation Task", runtime_tool="claude")
    cp.transition(task_id="t1", to_state=STATE_INTERVIEW, actor="user", reason="test")

    assert ("validate_known_state", STATE_INTERVIEW) in calls
    assert ("validate_adjacency", "t1", STATE_INTAKE, STATE_INTERVIEW) in calls
reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.Stars: 322kUpdated Claude CodeCodexVerifiedInstall
dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependenciesStars: 322kUpdated Claude CodeCodexVerifiedInstall
executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is availableStars: 322kUpdated Claude CodeCodexVerifiedInstall