Skip to content

richfrem/agent-plugins-skills / plugins/agent-agentic-os/.apm/skills/running-control-plane

running-control-plane

Flagged

CRITICAL INTAKE GATEWAY: use at the start of any non-trivial engineering task, feature, refactor, multi-file bugfix, work package or new idea, including requests to explore, brainstorm, build, fix or change something, before planning or code changes. Enforces read-only discovery, 1-3 structured questions with defaults, control-plane registration and the immutable four-pillar TASK_SPEC.md. Also runs the rest of the control plane: health ("run health check", "check os metrics", "system monitor", event bus, locks, memory, "is my signing identity ready" status check), transition simulation ("dry run transition", "simulate transition", "check edge X -> Y"), worktree selection, and gating on/off ("disable the control plane", "turn off the push guard", "stop gating my commits"). Not for project setup or key creation (use setting-up-agentic-os) or improving skills (use improving-skills-in-lab).

FileKindSize
SKILL.mdskill md5.4 KB
evals/evals.jsonconfig8.3 KB
references/acceptance-criteria.mdmarkdown4.0 KB
references/agentic-os-skill-map.mdmarkdown2.3 KB
references/architecture/architecture.mdmarkdown2.4 KB
references/architecture/context-folder-patterns.mdmarkdown3.3 KB
references/architecture/vision.mdmarkdown56.6 KB
references/cheap-agent-transition-simulation.mdmarkdown6.1 KB
references/control-plane-architecture.mdmarkdown9.0 KB
references/control-plane-rebuild-recovery.mdmarkdown6.2 KB
references/control-plane-simulation-protocol.mdmarkdown5.7 KB
references/diagrams/agentic-os-memory-subsystem.mmdother1.4 KB
references/diagrams/architecture-overview.mmdother3.1 KB
references/diagrams/control-plane-architecture.mermaidother6.3 KB
references/diagrams/control-plane-lifecycle-hardened-with-ciba-rar.mermaidother4.5 KB
references/diagrams/control-plane-pipeline-happy-path.mermaidother5.0 KB
references/diagrams/control-plane-pipeline.mermaidother9.3 KB
references/diagrams/event-bus-architecture.mmdother2.4 KB
references/diagrams/increment-b-human-only-transition-ssh-signing.mermaidother5.3 KB
references/edge-matrix.mdmarkdown13.3 KB
references/fallback-tree.mdmarkdown2.9 KB
references/health-detailed-reference.mdmarkdown7.1 KB
references/healthy-transcript.mdmarkdown3.8 KB
references/implementation-ledger-contract.mdmarkdown851 B
references/intake-detailed-reference.mdmarkdown3.1 KB
references/modes/health.mdmarkdown3.4 KB
references/modes/intake.mdmarkdown3.8 KB
references/modes/mode.mdmarkdown5.8 KB
references/modes/simulator.mdmarkdown6.2 KB
references/modes/worktree.mdmarkdown2.9 KB
references/multi-round-external-review-protocol.mdmarkdown2.6 KB
references/worktree-reconciliation-and-multi-worktree-practices.mdmarkdown5.8 KB
requirements-dev.inother741 B
requirements-dev.txtmarkdown603 B
requirements.inother196 B
requirements.txtmanifest202 B
scripts/agent_control.pyscript97.7 KB
scripts/audit_map_debt.pyscript6.1 KB
scripts/capability_probe.pyscript6.4 KB
scripts/check_plan_links.pyscript1.8 KB
scripts/control_plane/__init__.pyscript842 B
scripts/control_plane/adapters.pyscript144.9 KB
scripts/control_plane/approver_policy.pyscript20.0 KB
scripts/control_plane/baseline_transition_report.pyscript4.0 KB
scripts/control_plane/constants.pyscript13.5 KB
scripts/control_plane/coordinator.pyscript57.3 KB
scripts/control_plane/edge_matrix.pyscript3.1 KB
scripts/control_plane/gate1_approval.pyscript10.7 KB
scripts/control_plane/gate_evidence.pyscript9.9 KB
scripts/control_plane/identity_layout.pyscript2.9 KB
scripts/control_plane/identity_setup.pyscript11.0 KB
scripts/control_plane/implementation.pyscript3.7 KB
scripts/control_plane/implementation_loop.pyscript11.3 KB
scripts/control_plane/inspection.pyscript3.9 KB
scripts/control_plane/installation_probe.pyscript5.7 KB
scripts/control_plane/isolation_check.pyscript14.0 KB
scripts/control_plane/measurement.pyscript39.1 KB
scripts/control_plane/pipeline_simulator.pyscript30.0 KB
scripts/control_plane/policy.pyscript32.5 KB
scripts/control_plane/ports.pyscript20.3 KB
scripts/control_plane/proof_edges.pyscript4.6 KB
scripts/control_plane/proof_policy.pyscript2.2 KB
scripts/control_plane/receipt_provenance.pyscript4.7 KB
scripts/control_plane/registry.pyscript32.9 KB
scripts/control_plane/review_options.pyscript8.2 KB
scripts/control_plane/review_selection.pyscript3.2 KB
scripts/control_plane/run_transition_simulation.pyscript12.0 KB
scripts/control_plane/signing_selftest.pyscript6.8 KB
scripts/control_plane/simulation_identity.pyscript10.4 KB
scripts/control_plane/snapshot.pyscript10.8 KB
scripts/control_plane/ssh_signing.pyscript21.8 KB
scripts/control_plane/state_machine.pyscript5.8 KB
scripts/control_plane/transition_request.pyscript19.5 KB
scripts/control_plane/transition_simulation_cases.pyscript24.6 KB
scripts/control_plane/transition_templates.yamlconfig159.1 KB
scripts/control_plane/tty_signer.pyscript3.0 KB
scripts/control_plane/wrappers/__init__.pyscript24 B
scripts/control_plane/wrappers/record_interview_question.pyscript8.0 KB
scripts/control_plane/wrappers/record_retrospective.pyscript2.3 KB
scripts/control_plane/wrappers/run_exit_verification.pyscript6.4 KB
scripts/control_plane/wrappers/run_verify_exit_bundle.pyscript5.4 KB
scripts/control_plane/wrappers/write_plan_document.pyscript9.6 KB
scripts/control_plane_hooks.pyscript10.5 KB
scripts/control_plane_mode.pyscript12.0 KB
scripts/distill_playbook.pyexecutablescript9.9 KB
scripts/evolution_state.pyscript29.4 KB
scripts/export_upstream_pr.pyscript4.4 KB
scripts/interview_spec_engine.pyscript9.1 KB
scripts/kernel.pyscript14.6 KB
scripts/pre-commit-evolution-guardexecutablescript3.7 KB
scripts/pre-commit-pipeline-guardexecutablescript13.6 KB
scripts/pre-push-review-guardexecutablescript10.5 KB
scripts/record_trace.pyscript7.2 KB
scripts/smoke_test.pyexecutablescript22.6 KB
scripts/test_capability_probe.pyscript3.9 KB
scripts/test_worktree_manager.pyscript2.8 KB
scripts/verify_evolution_receipt.pyscript7.5 KB
scripts/verify_gate_evidence.pyscript1.6 KB
scripts/worktree_manager.pyscript3.0 KB
tests/conftest.pyscript7.7 KB
tests/helpers/__init__.pyscript0 B
tests/helpers/control_plane_fixtures.pyscript2.6 KB
tests/helpers/control_plane_repo.pyscript4.0 KB
tests/helpers/gate1_fixtures.pyscript5.8 KB
tests/helpers/human_signer.pyscript7.3 KB
tests/helpers/implementation_ledger.pyscript1.1 KB
tests/interview_helpers.pyscript5.2 KB
tests/test_actionable_rollback.pyscript2.2 KB
tests/test_agent_control.pyscript190.6 KB
tests/test_agent_control_gate_characterization.pyscript14.7 KB
tests/test_approve_transition.pyscript10.5 KB
tests/test_approver_identity_guidance.pyscript3.4 KB
tests/test_approver_isolation.pyscript12.3 KB
tests/test_audit_map_debt.pyscript4.7 KB
tests/test_authorized_actor_enforcement.pyscript22.9 KB
tests/test_background_document_priority.pyscript924 B
tests/test_check_plan_links.pyscript1.1 KB
tests/test_content_snapshot.pyscript11.8 KB
tests/test_control_plane_architecture_diagram_contract.pyscript9.0 KB
tests/test_control_plane_architecture_overview_contract.pyscript2.1 KB
tests/test_control_plane_critic_review.pyscript3.1 KB
tests/test_control_plane_crypto_adapter.pyscript5.0 KB
tests/test_control_plane_delegation_contract.pyscript5.7 KB
tests/test_control_plane_facade_composition.pyscript15.9 KB
tests/test_control_plane_filesystem_adapter.pyscript4.9 KB
tests/test_control_plane_hooks.pyscript7.3 KB
tests/test_control_plane_interview_guidance.pyscript3.8 KB
tests/test_control_plane_measurement_contract.pyscript28.0 KB
tests/test_control_plane_mode.pyscript7.5 KB
tests/test_control_plane_mode_guards.pyscript3.5 KB
tests/test_control_plane_model_catalog_adapter.pyscript9.2 KB
tests/test_control_plane_pipeline_diagram_contract.pyscript2.3 KB
tests/test_control_plane_pipeline_simulator.pyscript7.5 KB
tests/test_control_plane_policy.pyscript13.0 KB
tests/test_control_plane_ports.pyscript3.2 KB
tests/test_control_plane_reset_transition.pyscript13.6 KB
tests/test_control_plane_schema_rebuild_atomicity.pyscript20.0 KB
tests/test_control_plane_simulation_protocol_contract.pyscript959 B
tests/test_control_plane_sqlite_persistence_adapter.pyscript5.5 KB
tests/test_control_plane_state_machine.pyscript15.2 KB
tests/test_control_plane_trigger_enforcement.pyscript14.6 KB
tests/test_control_plane_worktree_sharing.pyscript4.5 KB
tests/test_domain_namespaces.pyscript6.7 KB
tests/test_done_closure_proof.pyscript6.9 KB
tests/test_draft_plan_interactive_outline_gap.pyscript2.2 KB
tests/test_dual_identity_onboarding.pyscript7.3 KB
tests/test_edge_matrix.pyscript3.2 KB
tests/test_ensure_schema_fastpath.pyscript4.4 KB
tests/test_evolution_guards.pyscript14.9 KB
tests/test_evolution_scripts.pyscript55.3 KB
tests/test_gate1_guidance.pyscript1.8 KB
tests/test_gate3_code_acceptance.pyscript13.5 KB
tests/test_graph_state_machine.pyscript16.0 KB
tests/test_guidance_readiness.pyscript2.2 KB
tests/test_health_check_signing_status.pyscript3.5 KB
tests/test_human_decision_trigger_enforcement.pyscript37.3 KB
tests/test_human_only_wiring.pyscript22.3 KB
tests/test_human_signer_isolation.pyscript4.0 KB
tests/test_identity_verification_readiness.pyscript5.8 KB
tests/test_implementation_ledger.pyscript3.4 KB
tests/test_implementation_loop.pyscript6.9 KB
tests/test_implementation_runtime_bridge.pyscript2.6 KB
tests/test_init_agentic_os_scaffolding.pyscript10.0 KB
tests/test_init_respects_control_plane_mode.pyscript4.3 KB
tests/test_inspect_verbs.pyscript3.6 KB
tests/test_installation_probe.pyscript3.1 KB
tests/test_intake_scenarios.pyscript7.2 KB
tests/test_interview_plan_outline.pyscript2.8 KB
tests/test_isolation_check.pyscript12.5 KB
tests/test_isolation_setup_docs.pyscript2.7 KB
tests/test_kernel_security.pyscript4.0 KB
tests/test_legacy_input_fallback.pyscript6.0 KB
tests/test_list_review_options.pyscript3.1 KB
tests/test_multi_agent_bundle_gate.pyscript5.5 KB
tests/test_one_approver_per_pipeline.pyscript15.8 KB
tests/test_os_init_dual_identity.pyscript3.9 KB
tests/test_os_init_identity_bootstrap.pyscript8.8 KB
tests/test_os_init_identity_status.pyscript3.9 KB
tests/test_os_init_single_instruction_file.pyscript7.3 KB
tests/test_p00_live_baseline.pyscript10.2 KB
tests/test_p01_intake_persistence.pyscript6.7 KB
tests/test_post_run_metrics_protocol.pyscript3.3 KB
tests/test_pre_commit_pipeline_guard.pyscript29.1 KB
tests/test_pre_push_review_guard.pyscript5.7 KB
tests/test_receipt_provenance.pyscript6.6 KB
tests/test_retrospective_pipeline.pyscript5.3 KB
tests/test_review_option_menus.pyscript6.6 KB
tests/test_review_selection.pyscript8.2 KB
tests/test_round3_fixes.pyscript8.3 KB
tests/test_rules_compliance.pyscript1.3 KB
tests/test_run_transition_simulation_formatting.pyscript1.7 KB
tests/test_run_verify_exit_bundle.pyscript10.2 KB
tests/test_setup_ciba_identity.pyscript11.2 KB
tests/test_signed_approval_human_receipt.pyscript3.9 KB
tests/test_signing_mechanics_selftest.pyscript6.9 KB
tests/test_signing_skill_selfcontained.pyscript3.4 KB
tests/test_skip_receipt_guidance.pyscript2.7 KB
tests/test_ssh_signing.pyscript23.9 KB
tests/test_strategy_artifacts.pyscript21.8 KB
tests/test_transition_answer_normalization.pyscript1.1 KB

tests/test_control_plane_schema_rebuild_atomicity.py

View on GitHub
"""
test_control_plane_schema_rebuild_atomicity.py — atomicity fix for _rebuild_schema_transactional() (issue-552)
================================================================================================================

Purpose:
    Proves _rebuild_schema_transactional()'s BEGIN IMMEDIATE/COMMIT transaction is actually
    atomic — a mid-rebuild failure leaves the DB in its exact pre-rebuild state (true rollback),
    not the half-migrated state the pre-fix code produced (conn.executescript(SCHEMA_SQL)
    silently commits any open transaction, per documented CPython sqlite3 behavior). Also covers
    the fix's necessary side effects: correct statement-splitting of SCHEMA_SQL (which embeds
    two CREATE TRIGGER ... BEGIN ... END; blocks with internal semicolons), no PRAGMA
    journal_mode/foreign_keys/busy_timeout drift, and map-debt.md write ordering (must not write
    on a rolled-back rebuild).

Key Input Dependencies:
    - Temporary SQLite databases via pytest's tmp_path fixture
    - control_plane.adapters.SqlitePersistenceAdapter, SCHEMA_SQL, _split_schema_sql_statements

Key Functions:
    - test_splitter_produces_expected_statement_breakdown()
    - test_splitter_preserves_trigger_bodies_intact()
    - test_rebuild_with_nonempty_data_survives_intact()
    - test_rebuild_failure_mid_copy_loop_rolls_back_completely()
    - test_rebuild_preserves_journal_mode_and_busy_timeout()
    - test_map_debt_not_written_on_rolled_back_rebuild()
"""

import sqlite3
import re
import sys
from pathlib import Path

import pytest

SCRIPTS_DIR = Path(__file__).resolve().parent.parent / "scripts"
if str(SCRIPTS_DIR) not in sys.path:
    sys.path.insert(0, str(SCRIPTS_DIR))

from control_plane.adapters import SqlitePersistenceAdapter, FilesystemAdapter, SCHEMA_SQL
from control_plane.constants import (
    STATE_INTAKE, STATE_INTERVIEW, STATE_RETROSPECTIVE,
)


def _make_adapter(tmp_path):
    db_path = tmp_path / "control_plane.db"
    adapter = SqlitePersistenceAdapter(db_path, FilesystemAdapter())
    adapter.ensure_schema()
    return adapter, db_path


def _seed_realistic_data(conn):
    """Seeds tasks + child rows across multiple states, mirroring real control-plane usage.
    enforce_valid_initial_state only permits NULL->INTAKE inserts (LEGAL_INITIAL_STATES), so
    task-b is inserted at INTAKE and legally transitioned to RETROSPECTIVE via UPDATE, answering
    the human-authorized emergency-close edge's two required questions (reason category, then
    the literal FORCE_RETROSPECTIVE confirmation)."""
    conn.execute(
        "INSERT INTO tasks (task_id, title, state, runtime_tool) VALUES (?, ?, ?, ?)",
        ("task-a", "Task A", STATE_INTAKE, "claude"),
    )
    conn.execute(
        "INSERT INTO tasks (task_id, title, state, runtime_tool) VALUES (?, ?, ?, ?)",
        ("task-b", "Task B", STATE_INTAKE, "claude"),
    )
    conn.execute("UPDATE tasks SET state = 'INTERVIEW' WHERE task_id = 'task-b';")
    conn.execute(
        "INSERT INTO task_transitions (task_id, from_state, to_state, actor) VALUES (?, ?, ?, ?)",
        ("task-b", STATE_INTAKE, STATE_INTERVIEW, "test"),
    )
    interview_answers = {
        "force_retrospective_reason_category": (
            "Task is effectively complete/trivial -- this is a planned early close, not a failure"
        ),
        "force_retrospective_authorization": "FORCE_RETROSPECTIVE",
    }
    for question_id, answer in interview_answers.items():
        conn.execute(
            """
            INSERT INTO transition_decisions (
                task_id, source_occupancy_transition_id, from_state, to_state,
                question_id, answer, decision_type, actor, recorded_at
            ) VALUES ('task-b', 1, 'INTERVIEW', 'RETROSPECTIVE', ?, ?, 'ANSWER', 'human', 12345.0)
            """,
            (question_id, answer),
        )
    conn.execute("UPDATE tasks SET state = 'RETROSPECTIVE' WHERE task_id = 'task-b';")
    conn.execute(
        "INSERT INTO task_transitions (task_id, from_state, to_state, actor) VALUES (?, ?, ?, ?)",
        ("task-b", STATE_INTERVIEW, STATE_RETROSPECTIVE, "test"),
    )
    conn.execute(
        "INSERT INTO critic_reviews (task_id, iteration, model_used, verdict, critique_findings) VALUES (?, ?, ?, ?, ?)",
        ("task-b", 1, "test-model", "PASS", "all good"),
    )
    conn.execute(
        "INSERT INTO verification_receipts (task_id, gate_name, command_executed, exit_code, receipt_token) VALUES (?, ?, ?, ?, ?)",
        ("task-b", "test-gate", "echo test", 0, "token-123"),
    )
    conn.commit()


def test_splitter_produces_expected_statement_breakdown():
    """Splitter must filter out all 3 leading PRAGMAs and produce exactly the DDL statements
    SCHEMA_SQL actually contains: 13 CREATE TABLE, 4 CREATE INDEX, 2 CREATE TRIGGER."""
    from control_plane.adapters import _split_schema_sql_statements

    statements = _split_schema_sql_statements(SCHEMA_SQL)

    assert not any(s.strip().upper().startswith("PRAGMA") for s in statements), (
        "PRAGMA statements must be filtered out of the split — they must not be individually "
        "executed inside the rebuild transaction (finding #2)."
    )

    upper_starts = [s.strip().upper() for s in statements]
    create_table = [s for s in upper_starts if s.startswith("CREATE TABLE")]
    create_index = [s for s in upper_starts if s.startswith("CREATE INDEX")]
    create_trigger = [s for s in upper_starts if s.startswith("CREATE TRIGGER") or "CREATE TRIGGER" in s]

    expected_table = len(re.findall(r"CREATE TABLE IF NOT EXISTS", SCHEMA_SQL, flags=re.IGNORECASE))
    expected_index = len(re.findall(r"CREATE INDEX IF NOT EXISTS", SCHEMA_SQL, flags=re.IGNORECASE))
    expected_trigger = len(re.findall(r"CREATE TRIGGER IF NOT EXISTS", SCHEMA_SQL, flags=re.IGNORECASE))
    assert len(create_table) == expected_table, f"expected {expected_table} CREATE TABLE statements, got {len(create_table)}"
    assert len(create_index) == expected_index, f"expected {expected_index} CREATE INDEX statements, got {len(create_index)}"
    assert len(create_trigger) == expected_trigger, f"expected {expected_trigger} CREATE TRIGGER statements, got {len(create_trigger)}"


def test_splitter_preserves_trigger_bodies_intact():
    """The two CREATE TRIGGER ... BEGIN ... END; blocks must survive as single statements, not
    be fragmented on their embedded semicolons (each trigger body has 2 inner semicolons)."""
    from control_plane.adapters import _split_schema_sql_statements

    statements = _split_schema_sql_statements(SCHEMA_SQL)
    trigger_statements = [s for s in statements if "CREATE TRIGGER" in s.upper() and "TRANSITION_VIOLATIONS" in s.upper()]

    assert len(trigger_statements) == 2
    for stmt in trigger_statements:
        assert "BEGIN" in stmt.upper() and stmt.rstrip().endswith(";") and stmt.rstrip().upper().endswith("END;")
        # Each trigger body has an INSERT + one more statement (UPDATE or DELETE) before END.
        assert stmt.upper().count("INSERT INTO TRANSITION_VIOLATIONS") == 1

    # Verify each is independently valid, executable SQL against a fresh connection with the
    # tables it depends on already present.
    conn = sqlite3.connect(":memory:")
    for stmt in [s for s in statements if s.strip().upper().startswith("CREATE TABLE")]:
        conn.execute(stmt)
    for stmt in trigger_statements:
        conn.execute(stmt)  # must not raise
    conn.close()


def test_rebuild_with_nonempty_data_survives_intact(tmp_path):
    """Happy-path rebuild against realistic non-empty data — the missing test-category gap
    identified during intake. All rows must survive the rebuild unchanged."""
    adapter, db_path = _make_adapter(tmp_path)
    conn = adapter.get_connection()
    try:
        _seed_realistic_data(conn)
        adapter._rebuild_schema_transactional(conn)
    finally:
        conn.close()

    conn = sqlite3.connect(str(db_path))
    try:
        tasks = {r[0]: r[1] for r in conn.execute("SELECT task_id, state FROM tasks")}
        assert tasks == {"task-a": STATE_INTAKE, "task-b": STATE_RETROSPECTIVE}
        transitions = conn.execute("SELECT COUNT(*) FROM task_transitions").fetchone()[0]
        assert transitions == 2
        orphans = conn.execute(
            "SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name LIKE '\\_%\\_migrating' ESCAPE '\\'"
        ).fetchone()[0]
        assert orphans == 0
    finally:
        conn.close()


def test_rebuild_failure_mid_copy_loop_rolls_back_completely(tmp_path, monkeypatch):
    """RED->GREEN: forces an exception partway through the copy loop against a non-empty DB.
    After the fix, the DB must be restored to its exact pre-rebuild state — no orphan
    _*_migrating tables, no data loss, schema_version unchanged. This is the core atomicity
    contract issue #552 exists to establish."""
    adapter, db_path = _make_adapter(tmp_path)
    conn = adapter.get_connection()
    try:
        _seed_realistic_data(conn)
        pre_version = conn.execute("SELECT version FROM schema_version").fetchone()[0]
    finally:
        conn.close()

    call_count = {"n": 0}
    real_copy = SqlitePersistenceAdapter._copy_common_columns

    def failing_copy(self, conn, source_table, dest_table):
        call_count["n"] += 1
        if call_count["n"] == 3:  # fail partway through the 7-table copy loop
            raise sqlite3.OperationalError("simulated mid-rebuild failure")
        return real_copy(self, conn, source_table, dest_table)

    monkeypatch.setattr(SqlitePersistenceAdapter, "_copy_common_columns", failing_copy)

    conn = adapter.get_connection()
    try:
        with pytest.raises(sqlite3.OperationalError):
            adapter._rebuild_schema_transactional(conn)
    finally:
        conn.close()

    # Verify true rollback: no orphan tables, data intact, schema_version unchanged.
    conn = sqlite3.connect(str(db_path))
    try:
        orphans = conn.execute(
            "SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name LIKE '\\_%\\_migrating' ESCAPE '\\'"
        ).fetchone()[0]
        assert orphans == 0, "orphan _*_migrating tables must not survive a rolled-back rebuild"

        tasks = {r[0]: r[1] for r in conn.execute("SELECT task_id, state FROM tasks")}
        assert tasks == {"task-a": STATE_INTAKE, "task-b": STATE_RETROSPECTIVE}, "data must be unchanged after rollback"

        post_version = conn.execute("SELECT version FROM schema_version").fetchone()[0]
        assert post_version == pre_version, "schema_version must be unchanged after rollback"
    finally:
        conn.close()


def test_rebuild_preserves_journal_mode_and_busy_timeout(tmp_path):
    """The 3 leading PRAGMA statements in SCHEMA_SQL must be skipped during the split
    (finding #2) without causing journal_mode/busy_timeout drift — they're already set on the
    connection by ensure_schema() before this method ever runs."""
    adapter, db_path = _make_adapter(tmp_path)
    conn = adapter.get_connection()
    try:
        adapter._rebuild_schema_transactional(conn)
        journal_mode = conn.execute("PRAGMA journal_mode;").fetchone()[0]
        busy_timeout = conn.execute("PRAGMA busy_timeout;").fetchone()[0]
    finally:
        conn.close()

    assert journal_mode.lower() == "wal"
    assert busy_timeout == 5000


class _RecordingFilesystemAdapter(FilesystemAdapter):
    """Wraps the real FilesystemAdapter but records every append_text() call, so the test can
    assert on write occurrence without touching the real repo's references/map-debt.md."""

    def __init__(self):
        self.appended: list = []

    def append_text(self, path, text):  # type: ignore[override]
        self.appended.append((path, text))

    def exists(self, path):  # type: ignore[override]
        # _log_orphan_merge_conflicts() no-ops if the map-debt file doesn't "exist" — report
        # True unconditionally so the write path (or its absence) is what the test observes.
        return True


def test_map_debt_not_written_on_rolled_back_rebuild(tmp_path, monkeypatch):
    """Finding #1 (HIGH): _log_orphan_merge_conflicts()'s map-debt.md write must not happen
    until after COMMIT succeeds. Forces a post-merge-but-pre-commit failure with an active
    orphan-merge path (a dangling _tasks_old from a previously-interrupted migration) and
    asserts zero map-debt writes occurred when the transaction rolls back."""
    db_path = tmp_path / "control_plane.db"
    recording_fs = _RecordingFilesystemAdapter()
    adapter = SqlitePersistenceAdapter(db_path, recording_fs)
    adapter.ensure_schema()

    conn = adapter.get_connection()
    try:
        # Seed a real tasks row, then create a dangling "_tasks_old" with a conflicting
        # task_id/different data, simulating a prior interrupted migration's leftover.
        _seed_realistic_data(conn)
        conn.execute('CREATE TABLE "_tasks_old" AS SELECT * FROM tasks WHERE task_id = "task-a";')
        conn.execute('UPDATE "_tasks_old" SET title = "Stale conflicting title";')
        conn.commit()
    finally:
        conn.close()

    # Let the entire copy loop AND the orphan merge (which calls _log_orphan_merge_conflicts,
    # the write under test) run to completion, then fail on the final schema_version INSERT —
    # i.e. after the write this test cares about has already happened, but before COMMIT. This
    # is the failure window finding #1 identifies: a write with real, observable effect that
    # occurs inside the "atomic" block but isn't covered by the SQL transaction.
    real_merge = SqlitePersistenceAdapter._merge_orphaned_tasks_old

    def failing_merge(self, conn):
        real_merge(self, conn)
        raise sqlite3.OperationalError("simulated post-merge pre-commit failure")

    monkeypatch.setattr(SqlitePersistenceAdapter, "_merge_orphaned_tasks_old", failing_merge)

    conn = adapter.get_connection()
    try:
        with pytest.raises(sqlite3.OperationalError):
            adapter._rebuild_schema_transactional(conn)
    finally:
        conn.close()

    assert recording_fs.appended == [], (
        "map-debt.md must receive no writes when the rebuild transaction rolls back "
        "(finding #1) — the write must be deferred until after a successful COMMIT"
    )


class _RaisingFilesystemAdapter(FilesystemAdapter):
    """Simulates a map-debt.md filesystem write failure (disk full, permissions) on
    append_text(), to prove it doesn't get reported as a schema-rebuild failure."""

    def append_text(self, path, text):  # type: ignore[override]
        raise OSError("simulated disk-full failure writing map-debt.md")

    def exists(self, path):  # type: ignore[override]
        return True


def test_map_debt_write_failure_after_successful_commit_does_not_raise(tmp_path, monkeypatch):
    """Implementation-review finding (MODERATE): if the deferred map-debt.md write itself
    fails after COMMIT has already succeeded, that failure must not propagate as an exception
    out of _rebuild_schema_transactional()/ensure_schema() — the schema rebuild genuinely
    succeeded; only a low-severity logging side effect failed. Every CRUD method calls
    ensure_schema() first, so an unhandled exception here would make a fully successful
    rebuild look like a fatal schema failure to every caller."""
    db_path = tmp_path / "control_plane.db"
    raising_fs = _RaisingFilesystemAdapter()
    adapter = SqlitePersistenceAdapter(db_path, raising_fs)
    adapter.ensure_schema()

    conn = adapter.get_connection()
    try:
        _seed_realistic_data(conn)
        conn.execute('CREATE TABLE "_tasks_old" AS SELECT * FROM tasks WHERE task_id = "task-a";')
        conn.execute('UPDATE "_tasks_old" SET title = "Stale conflicting title";')
        conn.commit()
    finally:
        conn.close()

    conn = adapter.get_connection()
    try:
        with pytest.warns(UserWarning, match="map-debt logging failed"):
            adapter._rebuild_schema_transactional(conn)  # must not raise
    finally:
        conn.close()

    # The rebuild itself must have genuinely succeeded despite the logging failure.
    conn = sqlite3.connect(str(db_path))
    try:
        tasks = {r[0] for r in conn.execute("SELECT task_id FROM tasks")}
        assert "task-a" in tasks and "task-b" in tasks
    finally:
        conn.close()


def test_health_check_fails_loudly_on_orphaned_migration_table(tmp_path):
    """Finding #4: ensure_schema() must detect an orphaned _<table>_migrating table as its
    literal first operation and fail with a clear, actionable error — not a cryptic
    FOREIGN KEY constraint failed surfaced deep inside a retried rebuild."""
    adapter, db_path = _make_adapter(tmp_path)
    conn = adapter.get_connection()
    try:
        conn.execute('CREATE TABLE "_tasks_migrating" (task_id TEXT PRIMARY KEY);')
        conn.commit()
    finally:
        conn.close()

    with pytest.raises(RuntimeError, match="orphaned migration tables"):
        adapter.ensure_schema()


def test_health_check_does_not_misfire_on_concurrent_legitimate_rebuild(tmp_path):
    """Finding #5 (MODERATE): a second connection's health check specifically must not
    false-fire against a first connection's legitimate, uncommitted, in-progress rebuild. WAL
    snapshot isolation should make connection B's read of sqlite_master see the pre-rebuild
    state cleanly while A's BEGIN IMMEDIATE (which has renamed tasks -> _tasks_migrating) is
    still open and uncommitted. Scoped to the health-check read itself, not the rest of
    ensure_schema()'s later writes — those legitimately contend for A's write lock, a separate,
    already-tracked lock-hold-time concern (see spec §6 Out of Scope), not a health-check bug."""
    adapter, db_path = _make_adapter(tmp_path)

    conn_a = sqlite3.connect(str(db_path), timeout=1.0)
    conn_a.execute("PRAGMA foreign_keys = OFF;")
    conn_a.execute("BEGIN IMMEDIATE;")
    conn_a.execute('ALTER TABLE "tasks" RENAME TO "_tasks_migrating";')
    # Deliberately left open and uncommitted — simulates a legitimate in-progress rebuild.

    try:
        adapter_b = SqlitePersistenceAdapter(db_path, FilesystemAdapter())
        conn_b = adapter_b.get_connection()
        try:
            # Must not raise: connection B's read of sqlite_master must see the pre-rebuild
            # snapshot (tasks present, no orphan _tasks_migrating), not A's uncommitted rename.
            adapter_b._check_no_orphaned_migration_tables(conn_b)
        finally:
            conn_b.close()
    finally:
        conn_a.execute("ROLLBACK;")
        conn_a.close()


def test_rebuild_leaves_transition_request_fk_functional(tmp_path):
    """RED->GREEN: transition_request has FOREIGN KEY (task_id) REFERENCES tasks(task_id), but
    is excluded from ALL_REBUILD_TABLES, so it is never itself renamed/rebuilt during
    _rebuild_schema_transactional(). SQLite's ALTER TABLE RENAME auto-repoints the stored FK
    clause of any table referencing the renamed table -- so transition_request's own CREATE
    TABLE SQL in sqlite_master silently gets rewritten to reference "_tasks_migrating" the
    moment tasks is renamed. Because transition_request is never dropped, its subsequent
    `CREATE TABLE IF NOT EXISTS transition_request` in SCHEMA_SQL is a no-op, so the corrupted
    FK text survives the rebuild permanently. The next INSERT INTO transition_request, with
    foreign_keys=ON (the get_connection() default used everywhere in real usage), then fails
    with 'no such table: main._tasks_migrating' -- reproducing the exact crash hit at the
    AWAITING_APPROVAL -> APPROVED gate, the only edge that ever writes this table."""
    adapter, db_path = _make_adapter(tmp_path)
    conn = adapter.get_connection()
    try:
        _seed_realistic_data(conn)
        adapter._rebuild_schema_transactional(conn)
    finally:
        conn.close()

    conn = adapter.get_connection()  # foreign_keys = ON, matching real runtime usage
    try:
        conn.execute(
            "INSERT INTO transition_request "
            "(task_id, from_state, to_state, occupancy_id, nonce, expiration, revision_hash, created_at) "
            "VALUES (?, ?, ?, ?, ?, ?, ?, ?)",
            ("task-a", STATE_INTAKE, STATE_INTERVIEW, 1, "nonce-1", 9999999999.0, "hash-1", 0.0),
        )
        conn.commit()
    finally:
        conn.close()
reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.Stars: 322kUpdated Claude CodeCodexVerifiedInstall
dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependenciesStars: 322kUpdated Claude CodeCodexVerifiedInstall
executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is availableStars: 322kUpdated Claude CodeCodexVerifiedInstall