Skip to content

richfrem/agent-plugins-skills / plugins/agent-agentic-os/.apm/skills/running-control-plane

running-control-plane

Flagged

CRITICAL INTAKE GATEWAY: use at the start of any non-trivial engineering task, feature, refactor, multi-file bugfix, work package or new idea, including requests to explore, brainstorm, build, fix or change something, before planning or code changes. Enforces read-only discovery, 1-3 structured questions with defaults, control-plane registration and the immutable four-pillar TASK_SPEC.md. Also runs the rest of the control plane: health ("run health check", "check os metrics", "system monitor", event bus, locks, memory, "is my signing identity ready" status check), transition simulation ("dry run transition", "simulate transition", "check edge X -> Y"), worktree selection, and gating on/off ("disable the control plane", "turn off the push guard", "stop gating my commits"). Not for project setup or key creation (use setting-up-agentic-os) or improving skills (use improving-skills-in-lab).

FileKindSize
SKILL.mdskill md5.4 KB
evals/evals.jsonconfig8.3 KB
references/acceptance-criteria.mdmarkdown4.0 KB
references/agentic-os-skill-map.mdmarkdown2.3 KB
references/architecture/architecture.mdmarkdown2.4 KB
references/architecture/context-folder-patterns.mdmarkdown3.3 KB
references/architecture/vision.mdmarkdown56.6 KB
references/cheap-agent-transition-simulation.mdmarkdown6.1 KB
references/control-plane-architecture.mdmarkdown9.0 KB
references/control-plane-rebuild-recovery.mdmarkdown6.2 KB
references/control-plane-simulation-protocol.mdmarkdown5.7 KB
references/diagrams/agentic-os-memory-subsystem.mmdother1.4 KB
references/diagrams/architecture-overview.mmdother3.1 KB
references/diagrams/control-plane-architecture.mermaidother6.3 KB
references/diagrams/control-plane-lifecycle-hardened-with-ciba-rar.mermaidother4.5 KB
references/diagrams/control-plane-pipeline-happy-path.mermaidother5.0 KB
references/diagrams/control-plane-pipeline.mermaidother9.3 KB
references/diagrams/event-bus-architecture.mmdother2.4 KB
references/diagrams/increment-b-human-only-transition-ssh-signing.mermaidother5.3 KB
references/edge-matrix.mdmarkdown13.3 KB
references/fallback-tree.mdmarkdown2.9 KB
references/health-detailed-reference.mdmarkdown7.1 KB
references/healthy-transcript.mdmarkdown3.8 KB
references/implementation-ledger-contract.mdmarkdown851 B
references/intake-detailed-reference.mdmarkdown3.1 KB
references/modes/health.mdmarkdown3.4 KB
references/modes/intake.mdmarkdown3.8 KB
references/modes/mode.mdmarkdown5.8 KB
references/modes/simulator.mdmarkdown6.2 KB
references/modes/worktree.mdmarkdown2.9 KB
references/multi-round-external-review-protocol.mdmarkdown2.6 KB
references/worktree-reconciliation-and-multi-worktree-practices.mdmarkdown5.8 KB
requirements-dev.inother741 B
requirements-dev.txtmarkdown603 B
requirements.inother196 B
requirements.txtmanifest202 B
scripts/agent_control.pyscript97.7 KB
scripts/audit_map_debt.pyscript6.1 KB
scripts/capability_probe.pyscript6.4 KB
scripts/check_plan_links.pyscript1.8 KB
scripts/control_plane/__init__.pyscript842 B
scripts/control_plane/adapters.pyscript144.9 KB
scripts/control_plane/approver_policy.pyscript20.0 KB
scripts/control_plane/baseline_transition_report.pyscript4.0 KB
scripts/control_plane/constants.pyscript13.5 KB
scripts/control_plane/coordinator.pyscript57.3 KB
scripts/control_plane/edge_matrix.pyscript3.1 KB
scripts/control_plane/gate1_approval.pyscript10.7 KB
scripts/control_plane/gate_evidence.pyscript9.9 KB
scripts/control_plane/identity_layout.pyscript2.9 KB
scripts/control_plane/identity_setup.pyscript11.0 KB
scripts/control_plane/implementation.pyscript3.7 KB
scripts/control_plane/implementation_loop.pyscript11.3 KB
scripts/control_plane/inspection.pyscript3.9 KB
scripts/control_plane/installation_probe.pyscript5.7 KB
scripts/control_plane/isolation_check.pyscript14.0 KB
scripts/control_plane/measurement.pyscript39.1 KB
scripts/control_plane/pipeline_simulator.pyscript30.0 KB
scripts/control_plane/policy.pyscript32.5 KB
scripts/control_plane/ports.pyscript20.3 KB
scripts/control_plane/proof_edges.pyscript4.6 KB
scripts/control_plane/proof_policy.pyscript2.2 KB
scripts/control_plane/receipt_provenance.pyscript4.7 KB
scripts/control_plane/registry.pyscript32.9 KB
scripts/control_plane/review_options.pyscript8.2 KB
scripts/control_plane/review_selection.pyscript3.2 KB
scripts/control_plane/run_transition_simulation.pyscript12.0 KB
scripts/control_plane/signing_selftest.pyscript6.8 KB
scripts/control_plane/simulation_identity.pyscript10.4 KB
scripts/control_plane/snapshot.pyscript10.8 KB
scripts/control_plane/ssh_signing.pyscript21.8 KB
scripts/control_plane/state_machine.pyscript5.8 KB
scripts/control_plane/transition_request.pyscript19.5 KB
scripts/control_plane/transition_simulation_cases.pyscript24.6 KB
scripts/control_plane/transition_templates.yamlconfig159.1 KB
scripts/control_plane/tty_signer.pyscript3.0 KB
scripts/control_plane/wrappers/__init__.pyscript24 B
scripts/control_plane/wrappers/record_interview_question.pyscript8.0 KB
scripts/control_plane/wrappers/record_retrospective.pyscript2.3 KB
scripts/control_plane/wrappers/run_exit_verification.pyscript6.4 KB
scripts/control_plane/wrappers/run_verify_exit_bundle.pyscript5.4 KB
scripts/control_plane/wrappers/write_plan_document.pyscript9.6 KB
scripts/control_plane_hooks.pyscript10.5 KB
scripts/control_plane_mode.pyscript12.0 KB
scripts/distill_playbook.pyexecutablescript9.9 KB
scripts/evolution_state.pyscript29.4 KB
scripts/export_upstream_pr.pyscript4.4 KB
scripts/interview_spec_engine.pyscript9.1 KB
scripts/kernel.pyscript14.6 KB
scripts/pre-commit-evolution-guardexecutablescript3.7 KB
scripts/pre-commit-pipeline-guardexecutablescript13.6 KB
scripts/pre-push-review-guardexecutablescript10.5 KB
scripts/record_trace.pyscript7.2 KB
scripts/smoke_test.pyexecutablescript22.6 KB
scripts/test_capability_probe.pyscript3.9 KB
scripts/test_worktree_manager.pyscript2.8 KB
scripts/verify_evolution_receipt.pyscript7.5 KB
scripts/verify_gate_evidence.pyscript1.6 KB
scripts/worktree_manager.pyscript3.0 KB
tests/conftest.pyscript7.7 KB
tests/helpers/__init__.pyscript0 B
tests/helpers/control_plane_fixtures.pyscript2.6 KB
tests/helpers/control_plane_repo.pyscript4.0 KB
tests/helpers/gate1_fixtures.pyscript5.8 KB
tests/helpers/human_signer.pyscript7.3 KB
tests/helpers/implementation_ledger.pyscript1.1 KB
tests/interview_helpers.pyscript5.2 KB
tests/test_actionable_rollback.pyscript2.2 KB
tests/test_agent_control.pyscript190.6 KB
tests/test_agent_control_gate_characterization.pyscript14.7 KB
tests/test_approve_transition.pyscript10.5 KB
tests/test_approver_identity_guidance.pyscript3.4 KB
tests/test_approver_isolation.pyscript12.3 KB
tests/test_audit_map_debt.pyscript4.7 KB
tests/test_authorized_actor_enforcement.pyscript22.9 KB
tests/test_background_document_priority.pyscript924 B
tests/test_check_plan_links.pyscript1.1 KB
tests/test_content_snapshot.pyscript11.8 KB
tests/test_control_plane_architecture_diagram_contract.pyscript9.0 KB
tests/test_control_plane_architecture_overview_contract.pyscript2.1 KB
tests/test_control_plane_critic_review.pyscript3.1 KB
tests/test_control_plane_crypto_adapter.pyscript5.0 KB
tests/test_control_plane_delegation_contract.pyscript5.7 KB
tests/test_control_plane_facade_composition.pyscript15.9 KB
tests/test_control_plane_filesystem_adapter.pyscript4.9 KB
tests/test_control_plane_hooks.pyscript7.3 KB
tests/test_control_plane_interview_guidance.pyscript3.8 KB
tests/test_control_plane_measurement_contract.pyscript28.0 KB
tests/test_control_plane_mode.pyscript7.5 KB
tests/test_control_plane_mode_guards.pyscript3.5 KB
tests/test_control_plane_model_catalog_adapter.pyscript9.2 KB
tests/test_control_plane_pipeline_diagram_contract.pyscript2.3 KB
tests/test_control_plane_pipeline_simulator.pyscript7.5 KB
tests/test_control_plane_policy.pyscript13.0 KB
tests/test_control_plane_ports.pyscript3.2 KB
tests/test_control_plane_reset_transition.pyscript13.6 KB
tests/test_control_plane_schema_rebuild_atomicity.pyscript20.0 KB
tests/test_control_plane_simulation_protocol_contract.pyscript959 B
tests/test_control_plane_sqlite_persistence_adapter.pyscript5.5 KB
tests/test_control_plane_state_machine.pyscript15.2 KB
tests/test_control_plane_trigger_enforcement.pyscript14.6 KB
tests/test_control_plane_worktree_sharing.pyscript4.5 KB
tests/test_domain_namespaces.pyscript6.7 KB
tests/test_done_closure_proof.pyscript6.9 KB
tests/test_draft_plan_interactive_outline_gap.pyscript2.2 KB
tests/test_dual_identity_onboarding.pyscript7.3 KB
tests/test_edge_matrix.pyscript3.2 KB
tests/test_ensure_schema_fastpath.pyscript4.4 KB
tests/test_evolution_guards.pyscript14.9 KB
tests/test_evolution_scripts.pyscript55.3 KB
tests/test_gate1_guidance.pyscript1.8 KB
tests/test_gate3_code_acceptance.pyscript13.5 KB
tests/test_graph_state_machine.pyscript16.0 KB
tests/test_guidance_readiness.pyscript2.2 KB
tests/test_health_check_signing_status.pyscript3.5 KB
tests/test_human_decision_trigger_enforcement.pyscript37.3 KB
tests/test_human_only_wiring.pyscript22.3 KB
tests/test_human_signer_isolation.pyscript4.0 KB
tests/test_identity_verification_readiness.pyscript5.8 KB
tests/test_implementation_ledger.pyscript3.4 KB
tests/test_implementation_loop.pyscript6.9 KB
tests/test_implementation_runtime_bridge.pyscript2.6 KB
tests/test_init_agentic_os_scaffolding.pyscript10.0 KB
tests/test_init_respects_control_plane_mode.pyscript4.3 KB
tests/test_inspect_verbs.pyscript3.6 KB
tests/test_installation_probe.pyscript3.1 KB
tests/test_intake_scenarios.pyscript7.2 KB
tests/test_interview_plan_outline.pyscript2.8 KB
tests/test_isolation_check.pyscript12.5 KB
tests/test_isolation_setup_docs.pyscript2.7 KB
tests/test_kernel_security.pyscript4.0 KB
tests/test_legacy_input_fallback.pyscript6.0 KB
tests/test_list_review_options.pyscript3.1 KB
tests/test_multi_agent_bundle_gate.pyscript5.5 KB
tests/test_one_approver_per_pipeline.pyscript15.8 KB
tests/test_os_init_dual_identity.pyscript3.9 KB
tests/test_os_init_identity_bootstrap.pyscript8.8 KB
tests/test_os_init_identity_status.pyscript3.9 KB
tests/test_os_init_single_instruction_file.pyscript7.3 KB
tests/test_p00_live_baseline.pyscript10.2 KB
tests/test_p01_intake_persistence.pyscript6.7 KB
tests/test_post_run_metrics_protocol.pyscript3.3 KB
tests/test_pre_commit_pipeline_guard.pyscript29.1 KB
tests/test_pre_push_review_guard.pyscript5.7 KB
tests/test_receipt_provenance.pyscript6.6 KB
tests/test_retrospective_pipeline.pyscript5.3 KB
tests/test_review_option_menus.pyscript6.6 KB
tests/test_review_selection.pyscript8.2 KB
tests/test_round3_fixes.pyscript8.3 KB
tests/test_rules_compliance.pyscript1.3 KB
tests/test_run_transition_simulation_formatting.pyscript1.7 KB
tests/test_run_verify_exit_bundle.pyscript10.2 KB
tests/test_setup_ciba_identity.pyscript11.2 KB
tests/test_signed_approval_human_receipt.pyscript3.9 KB
tests/test_signing_mechanics_selftest.pyscript6.9 KB
tests/test_signing_skill_selfcontained.pyscript3.4 KB
tests/test_skip_receipt_guidance.pyscript2.7 KB
tests/test_ssh_signing.pyscript23.9 KB
tests/test_strategy_artifacts.pyscript21.8 KB
tests/test_transition_answer_normalization.pyscript1.1 KB

tests/test_control_plane_architecture_diagram_contract.py

View on GitHub
"""
test_control_plane_architecture_diagram_contract.py — Diagram/Code Alignment Contract (issue-524)
======================================================================================================

Purpose:
    references/diagrams/control-plane-architecture.mermaid is a durable architectural contract, not
    decorative documentation — it exists so a future regression (SQL creeping back into
    ControlPlane, policy reading SQLite directly, a declared port losing its adapter) is
    visible as a diagram/code mismatch, not just discoverable by re-reading the whole file.
    This test parses control_plane/ports.py and control_plane/adapters.py via `ast` to get the
    real, current list of Port and Adapter class names, and asserts the diagram names every one
    of them, plus the facade class and the policy module. If a new port/adapter is added to the
    code without updating the diagram, this test fails — forcing the diagram to be kept honest.

Key Input Dependencies:
    - references/diagrams/control-plane-architecture.mermaid (repo root, relative path resolved below)
    - plugins/agent-agentic-os/skills/running-control-plane/scripts/control_plane/ports.py
    - plugins/agent-agentic-os/skills/running-control-plane/scripts/control_plane/adapters.py

Key Functions:
    - test_diagram_names_every_port_class()
    - test_diagram_names_every_adapter_class()
    - test_diagram_names_facade_and_policy_module()
    - test_diagram_names_real_state_machine_component()
    - test_diagram_shows_sqlite_boundary()
    - test_diagram_shows_policy_to_persistence_relationship()
    - test_every_adapter_subclasses_its_corresponding_port()
    - test_diagram_has_plain_renderable_mermaid_syntax()
    - test_agent_control_has_no_sql_matching_the_diagrams_persistence_boundary_claim()
"""

import ast
import sys
from pathlib import Path

SCRIPTS_DIR = Path(__file__).resolve().parent.parent / "scripts"
if str(SCRIPTS_DIR) not in sys.path:
    sys.path.insert(0, str(SCRIPTS_DIR))

from control_plane import ports as _ports_module
from control_plane import adapters as _adapters_module

REPO_ROOT = Path(__file__).resolve().parents[5]
SKILL_DIR = Path(__file__).resolve().parent.parent
DIAGRAM_FILE = SKILL_DIR / "references" / "diagrams" / "control-plane-architecture.mermaid"
PORTS_FILE = SCRIPTS_DIR / "control_plane" / "ports.py"
ADAPTERS_FILE = SCRIPTS_DIR / "control_plane" / "adapters.py"
STATE_MACHINE_FILE = SCRIPTS_DIR / "control_plane" / "state_machine.py"
AGENT_CONTROL_FILE = SCRIPTS_DIR / "agent_control.py"

# Maps each *Adapter class name to the *Port class it must subclass — kept explicit (not
# inferred) so a mismatch (e.g. a new adapter that forgets to subclass its port) is a clear
# diff against this list, not a silent pass.
ADAPTER_TO_PORT = {
    "SqlitePersistenceAdapter": "PersistencePort",
    "CryptoAdapter": "CryptoPort",
    "FilesystemAdapter": "FilesystemPort",
    "ModelCatalogAdapter": "ModelCatalogPort",
    "ClockAdapter": "ClockPort",
}


def _class_names(source_path: Path) -> set:
    tree = ast.parse(source_path.read_text(encoding="utf-8"))
    return {node.name for node in ast.walk(tree) if isinstance(node, ast.ClassDef)}


def test_diagram_names_every_port_class():
    """Every *Port class currently declared in ports.py must be named in the diagram."""
    diagram = DIAGRAM_FILE.read_text(encoding="utf-8")
    port_classes = {c for c in _class_names(PORTS_FILE) if c.endswith("Port")}
    assert port_classes, "sanity check: ports.py should declare at least one *Port class"
    missing = {c for c in port_classes if c not in diagram}
    assert not missing, f"Diagram is missing port class(es): {missing}"


def test_diagram_names_every_adapter_class():
    """Every *Adapter class currently declared in adapters.py must be named in the diagram."""
    diagram = DIAGRAM_FILE.read_text(encoding="utf-8")
    adapter_classes = {c for c in _class_names(ADAPTERS_FILE) if c.endswith("Adapter")}
    assert adapter_classes, "sanity check: adapters.py should declare at least one *Adapter class"
    missing = {c for c in adapter_classes if c not in diagram}
    assert not missing, f"Diagram is missing adapter class(es): {missing}"


def test_diagram_names_facade_and_policy_module():
    """The diagram must name the ControlPlane facade and reference the policy engine."""
    diagram = DIAGRAM_FILE.read_text(encoding="utf-8")
    assert "ControlPlane" in diagram
    assert "policy" in diagram.lower()


def test_diagram_shows_sqlite_boundary():
    """The diagram must show the SQLite database as the terminal node behind
    SqlitePersistenceAdapter, using Mermaid's cylinder shape `[( )]`."""
    diagram = DIAGRAM_FILE.read_text(encoding="utf-8")
    assert "control_plane.db" in diagram
    assert "[(" in diagram, "diagram should use Mermaid cylinder syntax [( )] for the database node"


def test_diagram_names_real_state_machine_component():
    """The diagram's State-machine node must correspond to a real class in
    control_plane/state_machine.py, not just a label with no backing component (round-2
    review finding: the diagram previously showed a State-machine validation node while that
    logic still lived inline in ControlPlane, with no corresponding module/class at all)."""
    diagram = DIAGRAM_FILE.read_text(encoding="utf-8")
    state_machine_classes = {c for c in _class_names(STATE_MACHINE_FILE) if c == "StateMachine"}
    assert state_machine_classes, "control_plane/state_machine.py must declare a StateMachine class"
    assert "StateMachine" in diagram, "diagram must name the real StateMachine class, not just a generic label"


def test_diagram_shows_policy_to_persistence_relationship():
    """The diagram must show the policy engine receiving facts through PersistencePort (a
    dotted edge), not appearing to read SQLite directly."""
    diagram = DIAGRAM_FILE.read_text(encoding="utf-8")
    assert "-.->" in diagram, "diagram should use a dotted edge for the policy-to-persistence relationship"
    # The dotted edge must actually connect something policy-related to PersistencePort —
    # not just exist anywhere in the file.
    dotted_lines = [line for line in diagram.splitlines() if "-.->" in line]
    assert any("PersistencePort" in line for line in dotted_lines), (
        "the dotted edge must target PersistencePort, not an unrelated node"
    )


def test_every_adapter_subclasses_its_corresponding_port():
    """Each concrete adapter must actually subclass its corresponding port at the Python
    level — not just be named similarly. Round-2 review finding: SqlitePersistenceAdapter was
    declared but did not subclass PersistencePort for several commits; this test makes that
    exact class of mismatch a permanent, automatic failure."""
    for adapter_name, port_name in ADAPTER_TO_PORT.items():
        adapter_cls = getattr(_adapters_module, adapter_name)
        port_cls = getattr(_ports_module, port_name)
        assert issubclass(adapter_cls, port_cls), (
            f"{adapter_name} does not subclass {port_name} — diagram implies a port/adapter "
            "relationship that the code does not actually have"
        )


def test_diagram_has_plain_renderable_mermaid_syntax():
    """Lightweight structural sanity check for GitHub-renderable Mermaid syntax — no full
    parser is available in this repo, so this checks the specific failure modes the diagram
    must avoid: starts with a valid diagram-type declaration, no raw HTML tags, no smart/curly
    quotes, and balanced brackets (a common source of 'Mermaid parse error' on GitHub)."""
    diagram = DIAGRAM_FILE.read_text(encoding="utf-8")
    assert diagram.lstrip().startswith("flowchart"), "diagram must start with a 'flowchart' declaration"
    assert "<" not in diagram and ">" not in diagram.replace("-->", "").replace("-.->", ""), (
        "diagram should not contain raw HTML-like tags in labels"
    )
    for smart_quote in ("“", "”", "‘", "’"):
        assert smart_quote not in diagram, f"diagram contains a smart quote ({smart_quote!r}) — use plain ASCII quotes"
    assert diagram.count("[") == diagram.count("]"), "unbalanced [ ] brackets in diagram"
    assert diagram.count("(") == diagram.count(")"), "unbalanced ( ) brackets in diagram"


def test_agent_control_has_no_sql_matching_the_diagrams_persistence_boundary_claim():
    """The diagram claims ControlPlane never executes SQL directly — this test is the
    executable half of that contract (the diagram is the documented half). Duplicates the
    check in test_control_plane_facade_composition.py deliberately: that file protects the
    facade-composition claim; this one protects the diagram-accuracy claim specifically, so
    the two can fail independently with distinct, specific messages."""
    source = AGENT_CONTROL_FILE.read_text(encoding="utf-8")
    for banned in ("sqlite3.connect(", "conn.execute(", "SELECT ", "INSERT INTO", "UPDATE tasks"):
        assert banned not in source, (
            f"agent_control.py contains {banned!r} — this contradicts the architecture diagram's "
            "claim that ControlPlane delegates all persistence to SqlitePersistenceAdapter"
        )
reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.Stars: 322kUpdated Claude CodeCodexVerifiedInstall
dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependenciesStars: 322kUpdated Claude CodeCodexVerifiedInstall
executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is availableStars: 322kUpdated Claude CodeCodexVerifiedInstall