Skip to content

PaloAltoNetworks/shifter / .claude/skills/architecture-review

architecture-review

Verified

Review a change for architectural drift, guardrail weakening, and ADR impact before shipping.

FileKindSize
SKILL.mdskill md1.3 KB
---
name: architecture-review
description: Review a change for architectural drift, guardrail weakening, and ADR impact before shipping.
---

# Architecture Review

This is a repo-specific review checklist for architectural conformance.

## Focus Areas

1. Cross-layer boundaries
   - Are imports still limited to `shared` and explicit service seams?
   - Did any direct cross-layer model import appear?

2. Guardrail integrity
   - Were `.github/workflows/**`, `.pre-commit-config.yaml`, `.claude/**`, `AGENTS.md`, or `scripts/adr_guard/**` changed?
   - If yes, were matching docs updated?
   - Did the change weaken enforcement, broaden skips, or make rules easier to bypass?

3. ADR impact
   - Does the change implement an existing ADR?
   - Does it change the meaning of an existing ADR?
   - Does it need a new ADR or a temporary exception?

4. Shared/public seams
   - Were `shared/**` or `*/services.py` changed?
   - If yes, did tests and docs move with them?

## Commands

```bash
python3 scripts/adr_guard/adr_guard.py --changed --level fast
python3 scripts/adr_guard/adr_guard.py --all --level ci
```

## Findings Format

For each issue, provide:

- severity
- file
- violated rule or drift risk
- why it matters
- exact fix

If no issues are found, say:

`Architecture review: no ADR or guardrail issues found.`
receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementationStars: 323kUpdated Claude CodeCodexVerifiedInstall
requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirementsStars: 323kUpdated Claude CodeCodexVerifiedInstall
using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallbackStars: 323kUpdated Claude CodeCodexVerifiedInstall
verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions alwaysStars: 323kUpdated Claude CodeCodexVerifiedInstall