oliver-kriska/claude-elixir-phoenix / plugins/elixir-phoenix/skills/review
review
VerifiedReview Elixir/Phoenix changes before committing — bugs, security, Ecto, LiveView, and Oban anti-patterns, via parallel specialist agents. Use when asked to review changes, a component, a diff, or a PR.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 8.8 KB |
| references/agent-spawning.md | markdown | 3.9 KB |
| references/blocker-handling.md | markdown | 2.6 KB |
| references/conventions.md | markdown | 1.9 KB |
| references/example-review.md | markdown | 2.5 KB |
| references/requirements-detection.md | markdown | 3.9 KB |
| references/review-template.md | markdown | 3.4 KB |
references/conventions.md
View on GitHub# Review Conventions System
After a review, users can mark findings as accepted patterns (suppress
in future reviews) or new conventions (enforce in future reviews).
This prevents repeat noise and compounds review knowledge.
## Convention File
Location: `.claude/conventions.md` (project root, checked into git)
### Entry Format
```markdown
## Convention C{ID}: {Title}
- **Type**: SUPPRESS | ENFORCE
- **Source**: Review of {feature} on {date}
- **Pattern**: {code pattern or description}
- **Rationale**: {why this is accepted/required}
```
### Example Entries
```markdown
## Convention C001: Fire-and-forget analytics OK
- **Type**: SUPPRESS
- **Pattern**: Task.start(fn -> Analytics.track(...) end) without supervision
- **Rationale**: Analytics loss is acceptable, adding supervision adds complexity
## Convention C002: All context functions validate ownership
- **Type**: ENFORCE
- **Pattern**: Every public context function that modifies data must verify
the caller owns the resource via `authorize_resource/2`
- **Rationale**: Security review found 3 unprotected mutations
```
## How Review Agents Use Conventions
At review start, if `.claude/conventions.md` exists:
1. Read the file
2. **SUPPRESS** entries: Skip findings that match the pattern. Do NOT
report them as issues — they are intentionally accepted.
3. **ENFORCE** entries: Flag violations of enforced patterns as WARNINGS.
These are project-specific rules beyond Iron Laws.
## Interactive Extraction Flow
After presenting review findings (Step 5), offer:
```
Any findings to convert to conventions?
- SUPPRESS: "We do this intentionally, stop flagging it"
- ENFORCE: "This should always be done this way going forward"
- Skip: No conventions to add
```
For each accepted convention:
1. Assign next sequential ID (C001, C002, ...)
2. Write to `.claude/conventions.md`
3. Attribute to the review that surfaced it
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |