oliver-kriska/claude-elixir-phoenix / targets/pi/skills/phx-review
phx-review
VerifiedReview changed Elixir/Phoenix code read-only. Check requirements, cite evidence, deduplicate findings, and return a severity-based verdict.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 4.1 KB |
| references/agent-spawning.md | markdown | 1.4 KB |
| references/blocker-handling.md | markdown | 2.7 KB |
| references/conventions.md | markdown | 1.9 KB |
| references/example-review.md | markdown | 2.6 KB |
| references/requirements-detection.md | markdown | 1.3 KB |
| references/review-template.md | markdown | 3.4 KB |
references/example-review.md
View on GitHub# Example Review Output
```markdown
# Review: Magic Link Authentication
**Date**: 2024-01-15
**Files Reviewed**: 12
**Reviewers**: elixir-reviewer, testing-reviewer, security-analyzer
## Summary
| Severity | Count |
|----------|-------|
| Blockers | 1 |
| Warnings | 2 |
| Suggestions | 3 |
**Verdict**: BLOCKED
## Requirements Coverage (from Linear AUTH-142)
| # | Requirement | Status | Evidence |
|---|-------------|--------|----------|
| 1 | Users can request a magic link by email | MET | `request_magic_link_live.ex:34` submit handler |
| 2 | Clicking the link logs the user in | MET | `session_controller.ex:18` verify flow |
| 3 | Tokens expire after 24 hours | UNMET | `auth.ex:45` — no expiry check (see Blocker #1) |
| 4 | Rate-limit per email to 5 requests / hour | UNMET | no Hammer/PlugAttack usage in diff (see Warning #1) |
| 5 | Failed attempts logged for audit | UNCLEAR | `Logger.warn` calls present, no structured audit trail — manual check |
**Summary**: 2 MET · 0 PARTIAL · 2 UNMET · 1 UNCLEAR
## Blockers (1)
### 1. Magic Token Never Expires
**File**: lib/my_app/auth.ex:45
**Reviewer**: security-analyzer
**Issue**: Magic tokens have no expiration, allowing indefinite reuse.
**Why this matters**: An attacker who obtains a token can use it forever.
**Current code**:
```elixir
def verify_magic_token(token) do
Repo.get_by(MagicToken, token: token)
end
```
**Recommended approach**:
```elixir
def verify_magic_token(token) do
MagicToken
|> where([t], t.token == ^token)
|> where([t], t.inserted_at > ago(24, "hour"))
|> Repo.one()
end
```
## Warnings (2)
### 1. Missing Rate Limiting
**File**: lib/my_app_web/live/request_magic_link_live.ex
**Reviewer**: security-analyzer
**Issue**: No rate limiting on magic link requests
**Recommendation**: Add Hammer rate limiting
### 2. Test Coverage Gap
**File**: test/my_app/auth_test.exs
**Reviewer**: testing-reviewer
**Issue**: No test for expired token scenario
**Recommendation**: Add expiration test case
## At a Glance
| # | Finding | Severity | Reviewer | File | New? |
|---|---------|----------|----------|------|------|
| 1 | Magic token never expires | BLOCKER | security-analyzer | auth.ex:45 | Yes |
| 2 | Missing rate limiting | WARNING | security-analyzer | request_magic_link_live.ex | Yes |
| 3 | No expired token test | WARNING | testing-reviewer | auth_test.exs | Yes |
## Next Steps
How would you like to proceed?
- `/skill:phx-plan` — Replan the fixes (for complex/architectural issues)
- `/skill:phx-work .claude/plans/magic-link-auth/plan.md` — Fix directly
- I'll handle it myself
```
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |