oliver-kriska/claude-elixir-phoenix / targets/pi/skills/phx-review
phx-review
VerifiedReview changed Elixir/Phoenix code read-only. Check requirements, cite evidence, deduplicate findings, and return a severity-based verdict.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 4.1 KB |
| references/agent-spawning.md | markdown | 1.4 KB |
| references/blocker-handling.md | markdown | 2.7 KB |
| references/conventions.md | markdown | 1.9 KB |
| references/example-review.md | markdown | 2.6 KB |
| references/requirements-detection.md | markdown | 1.3 KB |
| references/review-template.md | markdown | 3.4 KB |
references/conventions.md
View on GitHub# Review Conventions System
After a review, users can mark findings as accepted patterns (suppress
in future reviews) or new conventions (enforce in future reviews).
This prevents repeat noise and compounds review knowledge.
## Convention File
Location: `.claude/conventions.md` (project root, checked into git)
### Entry Format
```markdown
## Convention C{ID}: {Title}
- **Type**: SUPPRESS | ENFORCE
- **Source**: Review of {feature} on {date}
- **Pattern**: {code pattern or description}
- **Rationale**: {why this is accepted/required}
```
### Example Entries
```markdown
## Convention C001: Fire-and-forget analytics OK
- **Type**: SUPPRESS
- **Pattern**: Task.start(fn -> Analytics.track(...) end) without supervision
- **Rationale**: Analytics loss is acceptable, adding supervision adds complexity
## Convention C002: All context functions validate ownership
- **Type**: ENFORCE
- **Pattern**: Every public context function that modifies data must verify
the caller owns the resource via `authorize_resource/2`
- **Rationale**: Security review found 3 unprotected mutations
```
## How Review Agents Use Conventions
At review start, if `.claude/conventions.md` exists:
1. Read the file
2. **SUPPRESS** entries: Skip findings that match the pattern. Do NOT
report them as issues — they are intentionally accepted.
3. **ENFORCE** entries: Flag violations of enforced patterns as WARNINGS.
These are project-specific rules beyond Iron Laws.
## Interactive Extraction Flow
After presenting review findings (Step 5), offer:
```
Any findings to convert to conventions?
- SUPPRESS: "We do this intentionally, stop flagging it"
- ENFORCE: "This should always be done this way going forward"
- Skip: No conventions to add
```
For each accepted convention:
1. Assign next sequential ID (C001, C002, ...)
2. Write to `.claude/conventions.md`
3. Attribute to the review that surfaced it
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |