Skip to content

oliver-kriska/claude-elixir-phoenix / targets/dsh/skills/phx-review

phx-review

Verified

Review changed Elixir/Phoenix code read-only. Check requirements, cite evidence, deduplicate findings, and return a severity-based verdict.

references/review-template.md

View on GitHub
# Review Template Format

## Full Review Template

Write to `.claude/plans/{slug}/reviews/{feature}-review.md`:

```markdown
# Review: {Feature or Scope}

**Date**: {date}
**Files Reviewed**: {count}
**Reviewers**: elixir-reviewer, testing-reviewer, security-analyzer

## Summary

| Severity | Count |
|----------|-------|
| Blockers | {n} |
| Warnings | {n} |
| Suggestions | {n} |

**Verdict**: PASS | PASS WITH WARNINGS | REQUIRES CHANGES | BLOCKED

## Requirements Coverage (from {REQUIREMENTS_SOURCE})

| # | Requirement | Status | Evidence |
|---|-------------|--------|----------|
| 1 | {requirement text, ~80 chars} | MET | `lib/foo.ex:42` |
| 2 | {...} | PARTIAL | handler at `foo_live.ex:110`; no test for error branch |
| 3 | {...} | UNMET | not found in diff |
| 4 | {...} | UNCLEAR | UX requirement — manual verification needed |

**Summary**: {n_met} MET · {n_partial} PARTIAL · {n_unmet} UNMET · {n_unclear} UNCLEAR

*Omit this entire section if `--no-requirements` was passed. If detection
failed, replace the table with a single line: `**NOT AVAILABLE** —
{reason}`. Placement is intentional: this block precedes the per-severity
findings because "did we deliver what we promised" is the user's first
question.*

## Blockers ({n})

### 1. {Issue Title}

**File**: {path}:{line}
**Reviewer**: {agent}
**Issue**: {description}
**Why this matters**: {impact explanation}

**Current code**:

```elixir
bad_code()
```

**Recommended approach**:

```elixir
good_code()
```

---

### 2. {Issue Title}

...

## Warnings ({n})

### 1. {Issue Title}

**File**: {path}:{line}
**Reviewer**: {agent}
**Issue**: {description}
**Recommendation**: {what to do}

---

## Suggestions ({n})

### 1. {Suggestion Title}

**File**: {path}
**Suggestion**: {improvement idea}

---

## Next Steps

How would you like to proceed?

- `/phx-plan` — Replan the fixes (for complex/architectural issues)
- `/phx-work` — Fix directly (for simple, clear fixes)
- I'll handle it myself

```

## Verdict Decision Rules

| Verdict | Conditions |
|---------|-----------|
| **PASS** | No blockers, no warnings, suggestions only, all requirements MET |
| **PASS WITH WARNINGS** | No blockers, warnings present but not test-coverage gaps, OR some requirements PARTIAL |
| **REQUIRES CHANGES** | No Iron Law blockers but test coverage gaps detected (see below), OR any requirement UNMET |
| **BLOCKED** | Iron Law violations or critical security/data issues |

### REQUIRES CHANGES Triggers

This verdict catches code that works but lacks adequate test coverage:

- New public functions with zero tests
- Removed tests without replacement coverage
- New `handle_event` callbacks without corresponding tests
- New Oban workers without `perform/1` tests
- New LiveView routes without basic mount/render tests

These are not blockers (code works) but should not merge without tests.

## Mandatory Summary Table

Every review MUST end with this at-a-glance table (even if only 1 finding):

| # | Finding | Severity | Reviewer | File | New? |
|---|---------|----------|----------|------|------|
| 1 | {title} | BLOCKER/WARNING/SUGGESTION | {agent} | {path}:{line} | Yes/Pre-existing |

**New?** column: "Yes" = finding on changed lines (this diff). "Pre-existing" = on unchanged code. Pre-existing issues appear in the report but do NOT affect the verdict.

The review template has no task lists (`- [ ]`), fix phases, or plan
modifications. Review is findings-only; task creation belongs in `/phx-plan`.
receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementationStars: 322kUpdated Claude CodeCodexVerifiedInstall
requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirementsStars: 322kUpdated Claude CodeCodexVerifiedInstall
using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallbackStars: 322kUpdated Claude CodeCodexVerifiedInstall
verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions alwaysStars: 322kUpdated Claude CodeCodexVerifiedInstall